impressionist 1.4.2 → 1.4.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: cac2802f1a96bf95bc358134f43a869aab3ba449
-  data.tar.gz: afab8713bbc4b91bcd84a57a3042cbfce578643e
+  metadata.gz: 21b7ae84d4f69a1461cc94b0683901a5cee02b3c
+  data.tar.gz: a96eef9bfbaf175a8f7594dae7792a23c5f86033
 SHA512:
-  metadata.gz: f92d2ef3618bce991811cb438751bc6e76497bcae951a8a42b1050133ed492c19e77b290f69a141d91087c91a40d851716e834e70645119675b7f5cea41b7229
-  data.tar.gz: 8425229ed14a35088bb82ac68c3d4b5b910c694175ae03f4bdef963106745e06fb9e5597f6423e3b5233368670a086a80d46b1a62ba7bbb5737206b4d9ed0cff
+  metadata.gz: 2db50fbc8aebbee44415db4494e1257d2eb069fbd2e2a5ddd38d2173d9c31361d850a943ed4dea91629680e3fe7feef336942d31d535c15812b67ed070f5ec2a
+  data.tar.gz: 4528503dd4e5f27dc89aca3ffbac10cbcf06b242d9352d9b06f80abb38364f8966efe3649751789f40fd4da5d851e4ff7b1d3f1c868841708a7137e8be6c61d7

data/CHANGELOG.rdoc

@@ -1,3 +1,19 @@
+== 1.4.2 (2013-07-12)
+* Added Mongoid Support
+* Support Rails > 3.1 < 4.0
+* Fixed #93
+* Fixed travis failing
+* Added two new entities
+* Added MiniTest, testing against impressionist ( RSpec still testing test_app, will be removed soon)
+* Clean up
+* Moved all tests into tests dir
+
+== 1.4.1 (2013-07-07)
+* Added test support
+* fix trailing space
+* Created individually rspec files
+* (@nbit001)
+
 == 1.4.0 (2013-07-06)
 * Fixed #92
 * Pass option to unique for updatind counter_cache

data/lib/generators/active_record/impressionist_generator.rb

@@ -4,6 +4,7 @@ module ActiveRecord
       include Rails::Generators::Migration
       source_root File.join(File.dirname(__FILE__), 'templates')
 
+      # FIX, why is this implementing rails behaviour?
       def self.next_migration_number(dirname)
         sleep 1
         if ActiveRecord::Base.timestamped_migrations

data/lib/generators/templates/impression.rb

@@ -1,5 +1,6 @@
 # Use this hook to configure impressionist parameters
-Impressionist.setup do |config|
+#Impressionist.setup do |config|
   # Define ORM. Could be :active_record (default), :mongo_mapper or :mongoid
   # config.orm = :active_record
-end
+#end
+Impressionist.orm = :<%= options.orm if options.orm %>

data/lib/impressionist/version.rb

@@ -1,3 +1,3 @@
 module Impressionist
-  VERSION = "1.4.2"
+  VERSION = "1.4.3"
 end

data/tests/README

@@ -1 +1,11 @@
 Impressionist uses MiniTest
+
+tests/test_app still uses rspec. However it is going to be changed.
+
+to run tests one shoud:
+  * bundle install
+  * rails g impressionist
+  * rake db:migrate && rake db:test:prepare
+  * rake      # runs both code base tests and rails tests
+  * rake test # impressionist's tests
+  * rake spec # rails test api

data/tests/test_app/config/initializers/impression.rb

@@ -1,2 +1,5 @@
-# Define ORM. Could be :active_record (default) and :mongo_mapper
-#Impressionist.config.orm = :mongoid
+# Use this hook to configure impressionist parameters
+Impressionist.setup do |config|
+  # Define ORM. Could be :active_record (default), :mongo_mapper or :mongoid
+  # config.orm = :active_record
+end

data/tests/test_app/spec/rails_generators/rails_generators_spec.rb

@@ -2,8 +2,8 @@ require 'spec_helper'
 require 'systemu'
 
 # FIXME this test might break the others if run before them
-#
-describe Impressionist do
+# started fixing @nbit001
+describe Impressionist, :migration do
   fixtures :articles,:impressions,:posts
   it "should delete existing migration and generate the migration file" do
     pending

data/tests/test_app/spec/spec_helper.rb

@@ -17,12 +17,24 @@ Dir[Rails.root.join("spec/support/**/*.rb")].each {|f|
 }
 
 RSpec.configure do |config|
+
+  # in order to pass tags(symbols) as true values
+  # you need to tell rspec to do so by
+  config.treat_symbols_as_metadata_keys_with_true_values = true
+
   config.mock_with :rspec
 
   config.fixture_path = "#{::Rails.root}/spec/fixtures"
 
   config.use_transactional_fixtures = true
 
+  # excludes migration tag while running app base tests
+  config.filter_run_excluding :migration => true
+
+  # self explanatory
+  # runs everything
+  config.run_all_when_everything_filtered = true
+
   # make the rails logger usable in the tests as logger.xxx "..."
   def logger
     Rails.logger

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: impressionist
 version: !ruby/object:Gem::Version
-  version: 1.4.2
+  version: 1.4.3
 platform: ruby
 authors:
 - johnmcaliley
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-07-12 00:00:00.000000000 Z
+date: 2013-07-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: httpclient