impala 0.1.3 → 0.1.4

data/impala.gemspec

@@ -13,12 +13,14 @@ Gem::Specification.new do |gem|
   gem.homepage      = "https://github.com/colinmarc/impala-ruby"
 
   gem.add_dependency('thrift', '~> 0.9')
+  gem.add_dependency('ripl', '~> 0.7')
+  gem.add_dependency('hirb', '~> 0.7')
 
   gem.add_development_dependency('rake')
   gem.add_development_dependency('eden')
   gem.add_development_dependency('pry')
 
-  gem.add_development_dependency('minitest', '~> 4.5')
+  gem.add_development_dependency('minitest')
   gem.add_development_dependency('mocha')
 
   gem.add_development_dependency('yard')

data/lib/impala.rb

@@ -8,6 +8,7 @@ $LOAD_PATH.push(gen_dir) unless $LOAD_PATH.include?(gen_dir)
 require 'impala/version'
 
 require 'thrift'
+require 'time'
 require 'impala/protocol'
 require 'impala/cursor'
 require 'impala/connection'
@@ -22,7 +23,7 @@ module Impala
   class ParsingError < StandardError; end
 
   # Connect to an Impala server. If a block is given, it will close the
-  # connection after calling the block with the collection.
+  # connection after yielding the connection to the block.
   # @param [String] host the hostname or IP address of the Impala server
   # @param [int] port the port that the Impala server is listening on
   # @yieldparam [Connection] conn the open connection. Will be closed once the block

data/lib/impala/cursor.rb

@@ -8,7 +8,6 @@ module Impala
     def initialize(handle, service, buffer_length=1024)
       @handle = handle
       @service = service
-      @metadata = @service.get_results_metadata(@handle)
 
       @buffer_length = buffer_length
       @row_buffer = []
@@ -71,6 +70,10 @@ module Impala
 
     private
 
+    def metadata
+      @metadata ||= @service.get_results_metadata(@handle)
+    end
+
     def fetch_more
       return if @done
 
@@ -88,9 +91,9 @@ module Impala
 
     def parse_row(raw)
       row = {}
-      fields = raw.split(@metadata.delim)
+      fields = raw.split(metadata.delim)
 
-      fields.zip(@metadata.schema.fieldSchemas).each do |raw_value, schema|
+      fields.zip(metadata.schema.fieldSchemas).each do |raw_value, schema|
         value = convert_raw_value(raw_value, schema)
         row[schema.name.to_sym] = value
       end
@@ -114,11 +117,13 @@ module Impala
         end
       when 'tinyint', 'int', 'bigint'
         value.to_i
-      when 'double'
+      when 'double', 'float'
         value.to_f
+      when "timestamp"
+        Time.parse(value)
       else
         raise ParsingError.new("Unknown type: #{schema.type}")
       end
     end
   end
-end
+end

data/lib/impala/version.rb

@@ -1,3 +1,3 @@
 module Impala
-  VERSION = "0.1.3"
+  VERSION = "0.1.4"
 end

data/test/test_impala_connected.rb

@@ -28,8 +28,28 @@ describe 'connected tests' do
   end
 
   it 'can run a basic query' do
-    ret = @connection.query('SELECT 1 AS a')
-    assert_equal([{:a=>1}], ret, "the result should be a list of hashes")
+    ret = @connection.query('SELECT "foo" AS foo')
+    assert_equal([{:foo=>'foo'}], ret, "the result should be a list of hashes")
+  end
+
+  it 'can handle boolean values' do
+    ret = @connection.query('SELECT TRUE AS foo')
+    assert_equal([{:foo=>true}], ret, "the result should be a bool")
+  end
+
+  it 'can handle double values' do
+    ret = @connection.query("SELECT 1.23 AS foo")
+    assert_equal([{:foo=>1.23}], ret, "the result should be a float")
+  end
+
+  it 'can handle float values' do
+    ret = @connection.query("SELECT CAST(1.23 AS float) as foo")
+    assert_instance_of(Float, ret.first[:foo], "the result should be a float")
+  end
+
+  it 'can handle timestamp values' do
+    ret = @connection.query("SELECT NOW() AS foo")
+    assert_instance_of(Time, ret.first[:foo])
   end
 
   # TODO: this test sucks because there's no way to get multiple records
@@ -44,4 +64,8 @@ describe 'connected tests' do
     assert_equal(false, cursor.has_more?, "has_more? should be false")
     assert_nil(cursor.fetch_row, "subsequent calls to fetch_row should be nil")
   end
+
+  it 'can successfully run a "use" query' do
+    @connection.query('USE foo')
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: impala
 version: !ruby/object:Gem::Version
-  version: 0.1.3
+  version: 0.1.4
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-01-26 00:00:00.000000000 Z
+date: 2013-03-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: thrift
@@ -27,6 +27,38 @@ dependencies:
     - - ~>
       - !ruby/object:Gem::Version
         version: '0.9'
+- !ruby/object:Gem::Dependency
+  name: ripl
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '0.7'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '0.7'
+- !ruby/object:Gem::Dependency
+  name: hirb
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '0.7'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '0.7'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -80,17 +112,17 @@ dependencies:
   requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
-    - - ~>
+    - - ! '>='
       - !ruby/object:Gem::Version
-        version: '4.5'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     none: false
     requirements:
-    - - ~>
+    - - ! '>='
       - !ruby/object:Gem::Version
-        version: '4.5'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: mocha
   requirement: !ruby/object:Gem::Requirement