immutable-struct 2.2.3 → 2.3.0.rc1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: dfa246553af45d507992e2fbdc6ba2e5306159cc
-  data.tar.gz: 03989eeb4d23aeb1a0fd1c38745191b9275af538
+  metadata.gz: 3f2631b67a9155ff0938074129f5dca8570498bc
+  data.tar.gz: 145dc0eb0472fc9673d9cf9cf73c3d558d656b10
 SHA512:
-  metadata.gz: 15e9a7c7a40de80ca4b5204b1e3e37e7c60916af8138ed48fd532deb03924d5f50307f39f7cc0f681e13484fa5c077d307faaa506f9949f78d56680a529f824f
-  data.tar.gz: 239e4695f40c61705bdff234e3eeabe1ad6ad98278dd5542ddc157f2e70b4870c90ccd1f70b7c9a95783195eec5964677f818760e53947bbe566bc7280421295
+  metadata.gz: d1ae7330e2a5e9ee80abd47c48ac0bea78f3a3bb4dda6bcc9803261f1682a1806f3875a5aee19cb702f8c923895c1e3cf05c6209a60e8d3fbdfcc71c9b76b846
+  data.tar.gz: 314253075188993c13621ddcf0ca1b7e980884611a4ac3cd5170fde9ed96a907f6d1e05f151797685f83868dd0e65ba1212803d188b0f40a89331fb27f012793

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    immutable-struct (2.2.3)
+    immutable-struct (2.3.0.rc1)
 
 GEM
   remote: https://rubygems.org/

data/README.rdoc

@@ -57,7 +57,16 @@ If not using bundler, just use RubyGems:
     new_person.age     # => 41
     new_person.active? # => true
     
-You can also treat the interior as a normal class definition.  
+You can treat the interior of the block as a normal class definition with the exception of setting constants.
+Use +const_set+ to scope constants as-expected.
+
+    Point = ImmutableStruct.new(:x, :y) do
+      const_set(:ZERO, 0)
+      ONE_HUNDRED = 100
+    end
+    Point::ZERO # => 0
+    ::ONE_HUNDRED # => 100
+    ::ZERO # => NameError: uninitialized constant ZERO    
 
 
 == Links

data/lib/immutable-struct.rb

@@ -6,7 +6,7 @@
 # will be evaluated as if it were inside a class definition, allowing you
 # to add methods, include or extend modules, or do whatever else you want.
 class ImmutableStruct
-  VERSION='2.2.3' #:nodoc:
+  VERSION='2.3.0.rc1' #:nodoc:
   # Create a new class with the given read-only attributes.
   #
   # attributes:: list of symbols or strings that can be used to create attributes.
@@ -47,7 +47,7 @@ class ImmutableStruct
   #     Person = ImmutableStruct.new(:name, :location, :minor?, [:aliases])
   #     p = Person.new(name: 'Dave', minor: "yup", aliases: [ "davetron", "davetron5000" ])
   #     p.to_h # => { name: "Dave", minor: "yup", minor?: true, aliases: ["davetron", "davetron5000" ] }
-  # 
+  #
   # This has two subtle side-effects:
   #
   # * Methods that take no args, but are not 'attributes' will get called by `to_h`.  This shouldn't be a
@@ -124,10 +124,17 @@ class ImmutableStruct
     klass.class_exec(imethods) do |imethods|
       define_method(:to_h) do
         imethods.inject({}) do |hash, method|
-          next hash if [:==, :eql?, :merge, :hash].include?(method)
+          next hash if [:to_json, :==, :eql?, :merge, :hash].include?(method)
           hash.merge(method.to_sym => self.send(method))
         end
       end
+
+      define_method(:to_json) do |*args|
+        imethods.inject({}) do |hash, method|
+          next hash if [:to_json, :to_hash, :to_h, :==, :eql?, :merge, :hash].include?(method)
+          hash.merge(method.to_sym => self.send(method))
+        end.to_json(*args)
+      end
     end
     klass
   end

data/spec/immutable_struct_spec.rb

@@ -159,18 +159,76 @@ describe ImmutableStruct do
           def nick_name
             'bob'
           end
-          def to_json
-            to_h.to_json
+          def to_s
+            to_h.to_s
           end
         end
         instance = klass.new(name: "Rudy", minor: "ayup", aliases: [ "Rudyard", "Roozoola" ])
         expect {
-          instance.to_json.should == instance.to_h.to_json
+          instance.to_s.should == instance.to_h.to_s
         }.to raise_error(SystemStackError)
       end
     end
   end
 
+
+  describe "to_json" do
+    it 'recursively handles to_json' do
+      klass = ImmutableStruct.new(:name, :subclass)
+
+      subklass = ImmutableStruct.new(:number) do
+        def triple
+          3 * number
+        end
+      end
+
+      instance = klass.new(
+        name: 'Rudy',
+        subclass: subklass.new(
+          number: 1,
+        )
+      )
+      instance.to_json.should ==
+        "{\"name\":\"Rudy\",\"subclass\":{\"number\":1,\"triple\":3}}"
+    end
+
+    it 'handles arrays gracefully' do
+      klass = ImmutableStruct.new(:name, [:aliases] )
+
+      instance = klass.new(
+        name: 'Rudy',
+        aliases: ['Jones', 'Silly']
+      )
+      instance.to_json.should ==
+        "{\"name\":\"Rudy\",\"aliases\":[\"Jones\",\"Silly\"]}"
+    end
+
+    it 'recursively handles arrays to_json' do
+      klass = ImmutableStruct.new(:name, [:subclasses])
+
+      subklass = ImmutableStruct.new(:number) do
+        def triple
+          3 * number
+        end
+      end
+
+      instance = klass.new(
+        name: 'Rudy',
+        subclasses:
+         [
+           subklass.new(
+             number: 2
+           ),
+           subklass.new(
+             number: 3,
+           )
+        ]
+      )
+      instance.to_json.should ==
+        "{\"name\":\"Rudy\",\"subclasses\":[{\"number\":2,\"triple\":6},{\"number\":3,\"triple\":9}]}"
+    end
+  end
+
   describe "merge" do
     it "returns a new object as a result of merging attributes" do
       klass = ImmutableStruct.new(:food, :snacks, :butter)
@@ -280,5 +338,6 @@ describe ImmutableStruct do
 
     end
 
+
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: immutable-struct
 version: !ruby/object:Gem::Version
-  version: 2.2.3
+  version: 2.3.0.rc1
 platform: ruby
 authors:
 - Stitch Fix Engineering
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-05-01 00:00:00.000000000 Z
+date: 2017-08-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -94,12 +94,12 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - ">"
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.3.1
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.8
+rubygems_version: 2.4.5
 signing_key: 
 specification_version: 4
 summary: Easily create value objects without the pain of Ruby's Struct (or its setters)