immutable-struct 2.3.0.rc1 → 2.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 3f2631b67a9155ff0938074129f5dca8570498bc
-  data.tar.gz: 145dc0eb0472fc9673d9cf9cf73c3d558d656b10
+  metadata.gz: 90315cc7aa75a487cf037aefed966ae52c2a1826
+  data.tar.gz: 6f6c1750a942a9ab4ec45fa015fb0f75c03d3036
 SHA512:
-  metadata.gz: d1ae7330e2a5e9ee80abd47c48ac0bea78f3a3bb4dda6bcc9803261f1682a1806f3875a5aee19cb702f8c923895c1e3cf05c6209a60e8d3fbdfcc71c9b76b846
-  data.tar.gz: 314253075188993c13621ddcf0ca1b7e980884611a4ac3cd5170fde9ed96a907f6d1e05f151797685f83868dd0e65ba1212803d188b0f40a89331fb27f012793
+  metadata.gz: bf5c63f1f22ccd08744d02ae6afa583bbd901df66fdb8f68798d7b689bb3c54f487f7279f877f9525c03e98eec824d667d27769e37a828b87f279a4421a2e602
+  data.tar.gz: 22507c2b9558426d29574c7aa8d1206894a1b9d00d5c89f679765b5ac89c42f9b40425967afe831b71362f6c684db5c14b7eea3657d10296594cf07cc6553cd1

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    immutable-struct (2.3.0.rc1)
+    immutable-struct (2.3.0)
 
 GEM
   remote: https://rubygems.org/

data/lib/immutable-struct.rb

@@ -6,7 +6,7 @@
 # will be evaluated as if it were inside a class definition, allowing you
 # to add methods, include or extend modules, or do whatever else you want.
 class ImmutableStruct
-  VERSION='2.3.0.rc1' #:nodoc:
+  VERSION='2.3.0' #:nodoc:
   # Create a new class with the given read-only attributes.
   #
   # attributes:: list of symbols or strings that can be used to create attributes.
@@ -124,17 +124,11 @@ class ImmutableStruct
     klass.class_exec(imethods) do |imethods|
       define_method(:to_h) do
         imethods.inject({}) do |hash, method|
-          next hash if [:to_json, :==, :eql?, :merge, :hash].include?(method)
+          next hash if [:==, :eql?, :merge, :hash].include?(method)
           hash.merge(method.to_sym => self.send(method))
         end
       end
-
-      define_method(:to_json) do |*args|
-        imethods.inject({}) do |hash, method|
-          next hash if [:to_json, :to_hash, :to_h, :==, :eql?, :merge, :hash].include?(method)
-          hash.merge(method.to_sym => self.send(method))
-        end.to_json(*args)
-      end
+      alias_method :to_hash, :to_h
     end
     klass
   end

data/spec/immutable_struct_spec.rb

@@ -152,6 +152,20 @@ describe ImmutableStruct do
         }
       end
     end
+    context "to_hash is its alias" do
+      it "is identical" do
+        klass = ImmutableStruct.new(:name, :minor?, :location, [:aliases]) do
+          def nick_name
+            'bob'
+          end
+          def location_near?(other_location)
+            false
+          end
+        end
+        instance = klass.new(name: "Rudy", minor: "ayup", aliases: [ "Rudyard", "Roozoola" ])
+        instance.to_h.should == instance.to_hash
+      end
+    end
 
     context "no-arg method that uses to_h" do
       it "blows up" do
@@ -159,76 +173,18 @@ describe ImmutableStruct do
           def nick_name
             'bob'
           end
-          def to_s
-            to_h.to_s
+          def to_json
+            to_h.to_json
           end
         end
         instance = klass.new(name: "Rudy", minor: "ayup", aliases: [ "Rudyard", "Roozoola" ])
         expect {
-          instance.to_s.should == instance.to_h.to_s
+          instance.to_json.should == instance.to_h.to_json
         }.to raise_error(SystemStackError)
       end
     end
   end
 
-
-  describe "to_json" do
-    it 'recursively handles to_json' do
-      klass = ImmutableStruct.new(:name, :subclass)
-
-      subklass = ImmutableStruct.new(:number) do
-        def triple
-          3 * number
-        end
-      end
-
-      instance = klass.new(
-        name: 'Rudy',
-        subclass: subklass.new(
-          number: 1,
-        )
-      )
-      instance.to_json.should ==
-        "{\"name\":\"Rudy\",\"subclass\":{\"number\":1,\"triple\":3}}"
-    end
-
-    it 'handles arrays gracefully' do
-      klass = ImmutableStruct.new(:name, [:aliases] )
-
-      instance = klass.new(
-        name: 'Rudy',
-        aliases: ['Jones', 'Silly']
-      )
-      instance.to_json.should ==
-        "{\"name\":\"Rudy\",\"aliases\":[\"Jones\",\"Silly\"]}"
-    end
-
-    it 'recursively handles arrays to_json' do
-      klass = ImmutableStruct.new(:name, [:subclasses])
-
-      subklass = ImmutableStruct.new(:number) do
-        def triple
-          3 * number
-        end
-      end
-
-      instance = klass.new(
-        name: 'Rudy',
-        subclasses:
-         [
-           subklass.new(
-             number: 2
-           ),
-           subklass.new(
-             number: 3,
-           )
-        ]
-      )
-      instance.to_json.should ==
-        "{\"name\":\"Rudy\",\"subclasses\":[{\"number\":2,\"triple\":6},{\"number\":3,\"triple\":9}]}"
-    end
-  end
-
   describe "merge" do
     it "returns a new object as a result of merging attributes" do
       klass = ImmutableStruct.new(:food, :snacks, :butter)
@@ -338,6 +294,5 @@ describe ImmutableStruct do
 
     end
 
-
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: immutable-struct
 version: !ruby/object:Gem::Version
-  version: 2.3.0.rc1
+  version: 2.3.0
 platform: ruby
 authors:
 - Stitch Fix Engineering
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-08-08 00:00:00.000000000 Z
+date: 2017-08-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -94,9 +94,9 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">"
+  - - ">="
     - !ruby/object:Gem::Version
-      version: 1.3.1
+      version: '0'
 requirements: []
 rubyforge_project: 
 rubygems_version: 2.4.5