immosquare-cleaner 0.1.108 → 0.1.109

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3a413bdb4ca65fd168c69d440ecc430e69fb4906557bb608b78de5012c15b163
-  data.tar.gz: d51d4e83187b0822638b8b682ce7153d853adffe955e805f7374f3d5b6fb9772
+  metadata.gz: fd38a7439f9f3972620d9b1bd626dbdda59ea57c4b44b4c3358fae765d4ee25a
+  data.tar.gz: 13127c3a36e4b00c3b29de218df8f0c974f82b056f1c5ad2846cea09d69a610c
 SHA512:
-  metadata.gz: 1603c7f8f815bbdc32a518dbf6b6edb6dfe69d93e4540091bba8391591530aa6ac0849fef18d83d842c2b784740bc53833b3d69a9d295c2a078b6f179eb2a38d
-  data.tar.gz: 383fc4bf784457aaae1530a9aeb63654bc35218ad121f48feff13560ce8720e286a135b30ce5bdda36e86e71c7430452c07e9cbc5a89e2b7f906e9722c670546
+  metadata.gz: 3a27177e3c628cc6db2ad30fb6225111cd54e4dae8d0da0a94abec69bab21cd68fe99dc2357b0f15b3c7decd7648d719d0ed24f87b8960f78fef3147d885965b
+  data.tar.gz: 7f89548fc37bc0801b9609114ddfd752e59cbeab3ee35f12fb416ed32857cc5e87c8b506666631887112cca3aa8a9873a8547c938a68200ac55d3922a88e3793

data/lib/immosquare-cleaner/processors/javascript.rb

@@ -6,15 +6,30 @@ module ImmosquareCleaner
   module Processors
     class Javascript < Base
 
-      EXTENSIONS = [
+      ##============================================================##
+      ## ERB templates whose host language is JS/TS (not HTML).
+      ## erb_lint's HTML-context linters must not run on these —
+      ## they would corrupt HTML literals embedded inside JS string
+      ## literals. Routed to the JS-specific erb_lint config.
+      ##============================================================##
+      JS_ERB_EXTENSIONS = [
+        ".js.erb",
+        ".jsx.erb",
+        ".ts.erb",
+        ".tsx.erb",
+        ".mjs.erb",
+        ".cjs.erb",
+        ".coffee.erb"
+      ].freeze
+
+      EXTENSIONS = ([
         ".js",
         ".mjs",
+        ".cjs",
         ".jsx",
         ".ts",
-        ".tsx",
-        "js.erb",
-        ".ts.erb"
-      ].freeze
+        ".tsx"
+      ] + JS_ERB_EXTENSIONS).freeze
 
       def self.match?(file_path)
         file_path.end_with?(*EXTENSIONS)
@@ -50,7 +65,12 @@ module ImmosquareCleaner
           ## copy was taken before erb_lint ran).
           ##============================================================##
           if file_path.end_with?(".erb")
-            erblint_config  = "#{ImmosquareCleaner.gem_root}/linters/erb-lint-#{RUBY_VERSION}.yml"
+            ##============================================================##
+            ## JS/TS templates use the JS-specific erb_lint config to keep
+            ## HTML-context linters off the host string literals.
+            ##============================================================##
+            config_basename = file_path.downcase.end_with?(*JS_ERB_EXTENSIONS) ? "js-erb-lint" : "erb-lint"
+            erblint_config  = "#{ImmosquareCleaner.gem_root}/linters/#{config_basename}-#{RUBY_VERSION}.yml"
             erblint_options = ImmosquareCleaner.configuration.erblint_options || "--autocorrect"
             cmds << "bundle exec erb_lint --config #{erblint_config} #{escaped_temp} #{erblint_options}"
           else

data/lib/immosquare-cleaner/version.rb

@@ -1,3 +1,3 @@
 module ImmosquareCleaner
-  VERSION = "0.1.108".freeze
+  VERSION = "0.1.109".freeze
 end

data/lib/immosquare-cleaner.rb

@@ -124,7 +124,6 @@ module ImmosquareCleaner
     def setup_linter_configs!
       @setup_linter_configs ||= begin
         rubocop_config_with_version_path = "#{gem_root}/linters/rubocop-#{RUBY_VERSION}.yml"
-        erblint_config_with_version_path = "#{gem_root}/linters/erb-lint-#{RUBY_VERSION}.yml"
 
         if !File.exist?(rubocop_config_with_version_path)
           rubocop_config                                  = YAML.load_file("#{gem_root}/linters/rubocop.yml")
@@ -133,11 +132,20 @@ module ImmosquareCleaner
           File.write(rubocop_config_with_version_path, rubocop_config.to_yaml)
         end
 
-        if !File.exist?(erblint_config_with_version_path)
-          erblint_config                                                         = YAML.load_file("#{gem_root}/linters/erb-lint.yml")
-          erblint_config["linters"]["Rubocop"]["rubocop_config"]["inherit_from"] = ["linters/rubocop-#{RUBY_VERSION}.yml"]
-          File.write(erblint_config_with_version_path, erblint_config.to_yaml)
+        ##============================================================##
+        ## erb_lint configs that inherit the versioned rubocop config.
+        ## - erb-lint     : default config for .html.erb
+        ## - js-erb-lint  : JS-specific config for .js.erb / .ts.erb / etc.
+        ##============================================================##
+        ["erb-lint", "js-erb-lint"].each do |basename|
+          versioned_path = "#{gem_root}/linters/#{basename}-#{RUBY_VERSION}.yml"
+          next if File.exist?(versioned_path)
+
+          config                                                         = YAML.load_file("#{gem_root}/linters/#{basename}.yml")
+          config["linters"]["Rubocop"]["rubocop_config"]["inherit_from"] = ["linters/rubocop-#{RUBY_VERSION}.yml"]
+          File.write(versioned_path, config.to_yaml)
         end
+
         true
       end
     end

data/linters/erb_lint/custom_html_to_content_tag.rb

@@ -131,7 +131,28 @@ module ERBLint
         "full_error"
       ].freeze
 
+      ##============================================================##
+      ## File extensions that hold JS/TS source with embedded ERB.
+      ## Inside these files HTML literals live inside JS string
+      ## contexts ("..."/'...'/`...`). Promoting them to content_tag
+      ## breaks the surrounding string two ways: the helper's output
+      ## attributes are always double-quoted and would terminate a
+      ## double-quoted JS literal early, and any `j()` JS-escape
+      ## around the ERB output would no longer wrap the full HTML.
+      ##============================================================##
+      JS_TEMPLATE_EXTENSIONS = [
+        ".js.erb",
+        ".jsx.erb",
+        ".ts.erb",
+        ".tsx.erb",
+        ".mjs.erb",
+        ".cjs.erb",
+        ".coffee.erb"
+      ].freeze
+
       def run(processed_source)
+        return if javascript_template?(processed_source.filename)
+
         document = processed_source.ast
         children = document.children.to_a
 
@@ -195,6 +216,13 @@ module ERBLint
 
       private
 
+      def javascript_template?(filename)
+        return false if filename.nil?
+
+        downcased = filename.downcase
+        JS_TEMPLATE_EXTENSIONS.any? {|ext| downcased.end_with?(ext) }
+      end
+
       ##============================================================##
       ## Check if tag is a closing tag (has solidus as first child)
       ##============================================================##

data/linters/js-erb-lint-4.0.3.yml

@@ -0,0 +1,26 @@
+---
+EnableDefaultLinters: true
+linters:
+  NoJavascriptTagHelper:
+    enabled: false
+  SpaceInHtmlTag:
+    enabled: false
+  SelfClosingTag:
+    enabled: false
+  RequireInputAutocomplete:
+    enabled: false
+  DeprecatedClassesInline:
+    enabled: false
+  HardCodedString:
+    enabled: false
+  CustomHtmlToContentTag:
+    enabled: false
+  CustomSingleLineIfModifier:
+    enabled: true
+  Rubocop:
+    enabled: true
+    rubocop_config:
+      inherit_from:
+      - linters/rubocop-4.0.3.yml
+      Layout/TrailingWhitespace:
+        Enabled: false

data/linters/js-erb-lint.yml

@@ -0,0 +1,56 @@
+##============================================================##
+## erb_lint config for JS/TS templates (.js.erb, .ts.erb,
+## .jsx.erb, .tsx.erb, .mjs.erb, .cjs.erb, .coffee.erb).
+##
+## In these files HTML literals live inside JS string contexts
+## ("..."/'...'/`...`). erb_lint's default linters and our custom
+## ones assume HTML-document context and rewrite that HTML in
+## ways that corrupt the surrounding JS string (quote balance,
+## tag self-closing, content_tag promotion, etc.). This config
+## disables every HTML-context linter and keeps only:
+##   - Rubocop (lints Ruby code inside <% %>/<%= %>)
+##   - CustomSingleLineIfModifier (ERB structural, JS-safe)
+##   - ParserErrors / formatting linters that operate on ERB
+##     tokens, not HTML semantics
+##============================================================##
+EnableDefaultLinters: true
+linters:
+  ##============================================================##
+  ## HTML-context default linters — disabled for JS templates.
+  ##============================================================##
+  NoJavascriptTagHelper:
+    enabled: false
+  SpaceInHtmlTag:
+    enabled: false
+  SelfClosingTag:
+    enabled: false # Would rewrite `<br/>` -> `<br>` inside a JS string literal
+  RequireInputAutocomplete:
+    enabled: false # Flags `<input>` literals inside JS strings as missing autocomplete
+  DeprecatedClassesInline:
+    enabled: false # Inspects HTML class attributes — false positives in JS templates
+  HardCodedString:
+    enabled: false # i18n check — irrelevant for JS code (the JS lines themselves are not user-facing strings)
+
+  ##============================================================##
+  ## Custom HTML-context linters — disabled for JS templates.
+  ##============================================================##
+  CustomHtmlToContentTag:
+    enabled: false # Would promote HTML literals to content_tag(...) — breaks the host JS string
+
+  ##============================================================##
+  ## ERB-structural linters — safe in any context.
+  ##============================================================##
+  CustomSingleLineIfModifier:
+    enabled: true
+
+  ##============================================================##
+  ## Ruby code inside <% %>/<%= %> is linted by Rubocop with
+  ## the same config as .html.erb.
+  ##============================================================##
+  Rubocop:
+    enabled: true
+    rubocop_config:
+      inherit_from:
+        - linters/rubocop.yml
+      Layout/TrailingWhitespace:
+        Enabled: false

data/linters/rubocop-4.0.3.yml

@@ -20,6 +20,8 @@ Lint/RescueException:
   Enabled: false
 Lint/UnusedMethodArgument:
   Enabled: false
+Lint/UselessOr:
+  Enabled: false
 Naming/VariableNumber:
   Enabled: false
 Naming/FileName:
@@ -96,6 +98,8 @@ Style/SymbolArray:
   EnforcedStyle: brackets
 Style/RescueModifier:
   Enabled: false
+Style/NestedParenthesizedCalls:
+  Enabled: false
 Style/MethodCallWithArgsParentheses:
   Enabled: true
   EnforcedStyle: require_parentheses

data/linters/rubocop.yml

@@ -23,6 +23,8 @@ Lint/RescueException:
   Enabled: false # Allow `rescue Exception => e` without forcing StandardError
 Lint/UnusedMethodArgument:
   Enabled: false # Allow defining methods with unused parameters (otherwise the cop renames the param with a leading _ on save while still writing the method)
+Lint/UselessOr:
+  Enabled: false # The cop strips defensive `expr || :default` fallbacks (e.g. `foo.to_sym || :default`) when the LHS technically can't return nil. Ruby raises rather than returning nil there, so the `||` is dead by the cop's logic — but the dev wrote it as a guard against the LHS itself being nil. erb_lint also bypasses `SafeAutoCorrect: false` so the strip happens silently on save. Keep the guard.
 
 #################### Naming ###########################
 Naming/VariableNumber:
@@ -106,6 +108,8 @@ Style/SymbolArray:
   EnforcedStyle: brackets # Format arrays as [:a, :b, :c], not %i[a b c]
 Style/RescueModifier:
   Enabled: false # Allow inline rescue modifier (some_method rescue SomeException)
+Style/NestedParenthesizedCalls:
+  Enabled: false # Redundant with Style/MethodCallWithArgsParentheses (require_parentheses) — both flag `outer(inner arg)`. RuboCop dedupes the inserted `(` but not the matching `)`, and erb_lint's integration ships both corrections independently → output gets an extra `)` (e.g. `j(render :partial => "x")` becomes `j(render(:partial => "x")))`, breaking the ERB at render time).
 
 #################### OVERWRITE ###########################
 Style/MethodCallWithArgsParentheses:

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: immosquare-cleaner
 version: !ruby/object:Gem::Version
-  version: 0.1.108
+  version: 0.1.109
 platform: ruby
 authors:
 - immosquare
@@ -182,6 +182,8 @@ files:
 - linters/erb_lint/custom_single_line_if_modifier.rb
 - linters/eslint-plugins/eslint10-compat.mjs
 - linters/eslint.config.mjs
+- linters/js-erb-lint-4.0.3.yml
+- linters/js-erb-lint.yml
 - linters/normalize-comments.mjs
 - linters/prettier.yml
 - linters/rubocop-4.0.3.yml