imdb 0.4.0 → 0.4.1

data/History.txt

@@ -1,23 +1,29 @@
+== 0.4.1 2009-06-14
+
+* Added support for FakeWeb so specs run faster. [mguterl]
+* Cache the search query i Imdb::Search.query. [mguterl]
+* Added a convenience method Imdb::Search.search. [mguterl]
+
 == 0.4.0 2009-06-14
 
-* Updates to the console 'imdb' utility
+* Updates to the console 'imdb' utility [ariejan]
   * Show the IMDB ID
   * Show the full IMDB URL
 
 == 0.3.0 2009-06-07
 
-* Fixed typo in CLI field name 'Cast by'
-* Fixed retrieval of multiple directors. (#1)
+* Fixed typo in CLI field name 'Cast by' [ariejan]
+* Fixed retrieval of multiple directors. (#1) [ariejan]
 
 == 0.2.0 2009-06-04
 
-* Added console tool 'imdb' for searching and getting movie info.
-* Fixed issue #2
+* Added console tool 'imdb' for searching and getting movie info. [ariejan]
+* Fixed issue #2 [ariejan]
 
 == 0.1.0 2009-06-03
 
-* Added Imdb::Search that allows search IMDB for a specific movie.
+* Added Imdb::Search that allows search IMDB for a specific movie. [ariejan]
 
 == 0.0.1 2009-06-03
 
-* First release of the IMDB gem.
+* First release of the IMDB gem. [ariejan]

data/lib/imdb.rb

@@ -10,5 +10,5 @@ require 'imdb/search'
 require 'imdb/string_extensions'
 
 module Imdb
-  VERSION = '0.4.0'
+  VERSION = '0.4.1'
 end

data/lib/imdb/movie.rb

@@ -17,7 +17,7 @@ module Imdb
     def initialize(imdb_id, title = nil)
       @id = imdb_id
       @url = "http://www.imdb.com/title/tt#{imdb_id}/"
-      @title = title.nil? ? nil : title.gsub(/"/, "")
+      @title = title.gsub(/"/, "") if title
     end
     
     # Returns an array with cast members
@@ -87,6 +87,11 @@ module Imdb
       get("http://www.imdb.com/title/tt#{imdb_id}/")
     end
     
+    # Convenience method for search
+    def self.search(query)
+      Imdb::Search.new(query)
+    end
+    
   end # Movie
   
-end # Imdb
+end # Imdb

data/lib/imdb/search.rb

@@ -4,6 +4,8 @@ module Imdb
   class Search
     include HTTParty
     
+    attr_reader :query
+
     # Initialize a new IMDB search with the specified query
     #
     #   search = Imdb::Search.new("Star Trek")
@@ -65,4 +67,4 @@ module Imdb
     end
     
   end # Search
-end # Imdb
+end # Imdb

data/spec/imdb_movie_spec.rb

@@ -1,12 +1,5 @@
 require File.dirname(__FILE__) + '/spec_helper.rb'
 
-### WARNING: This spec uses live data!
-#
-# Many may object to testing against a live website, and for good reason. 
-# However, the IMDB interface changes over time, and to guarantee the parser
-# works with the currently available IMDB website, tests are run against
-# IMDB.com instead.
-#
 # This test uses "Die hard (1988)" as a testing sample:
 #   
 #     http://www.imdb.com/title/tt0095016/
@@ -84,5 +77,13 @@ describe "Imdb::Movie" do
       movie.director.should include("Andy Wachowski")
     end
   end
+
+  describe "search" do
+    it "should provide a convenience method to search" do
+      search = Imdb::Movie.search("Star Trek")
+      search.should respond_to(:movies)
+      search.query.should == "Star Trek"
+    end
+  end
   
-end
+end

data/spec/imdb_search_spec.rb

@@ -1,20 +1,14 @@
 require File.dirname(__FILE__) + '/spec_helper.rb'
 
-### WARNING: This spec uses live data!
-#
-# Many may object to testing against a live website, and for good reason. 
-# However, the IMDB interface changes over time, and to guarantee the parser
-# works with the currently available IMDB website, tests are run against
-# IMDB.com instead.
-#
-# This test searches for "Star Trek"
-#
 describe "Imdb::Search with multiple search results" do
   
   before(:each) do
-    # Search for "Star Trek"
     @search = Imdb::Search.new("Star Trek")
   end
+
+  it "should remember the query" do
+    @search.query.should == "Star Trek"
+  end
   
   it "should find > 10 results" do
     @search.movies.size.should > 10
@@ -33,7 +27,6 @@ end
 describe "Imdb::Search with an exact match" do
   
   before(:each) do
-    # Search for "Star Trek"
     @search = Imdb::Search.new("Matrix Revolutions")
   end
   
@@ -44,4 +37,4 @@ describe "Imdb::Search with an exact match" do
   it "should have the corrected title" do
     @search.movies.first.title.should =~ /The Matrix Revolutions/i
   end
-end
+end

data/spec/spec_helper.rb

@@ -1,3 +1,13 @@
+# By default if you have the FakeWeb gem installed when the specs are
+# run they will hit recorded responses.  However, if you don't have
+# the FakeWeb gem installed or you set the environment variable
+# LIVE_TEST then the tests will hit the live site IMDB.com.
+###
+# Having both methods available for testing allows you to quickly
+# refactor and add features, while also being able to make sure that
+# no changes to the IMDB.com interface have affected the parser.
+###
+
 begin
   require 'spec'
 rescue LoadError
@@ -8,3 +18,28 @@ end
 
 $:.unshift(File.dirname(__FILE__) + '/../lib')
 require 'imdb'
+
+def read_fixture(path)
+  File.read(File.expand_path(File.join(File.dirname(__FILE__), "fixtures", path)))
+end
+
+unless ENV['LIVE_TEST']
+  begin
+    require 'rubygems'
+    require 'fakeweb'
+    
+    FakeWeb.allow_net_connect = false
+    { "http://www.imdb.com:80/find?q=Matrix+Revolutions;s=tt" => "search_matrix_revolutions",
+      "http://www.imdb.com:80/find?q=Star+Trek;s=tt" => "search_star_trek",
+      "http://www.imdb.com:80/title/tt0117731/" => "tt0117731",
+      "http://www.imdb.com:80/title/tt0095016/" => "tt0095016",
+      "http://www.imdb.com:80/title/tt0242653/" => "tt0242653",
+      "http://www.imdb.com:80/title/tt0242653/?fr=c2M9MXxsbT01MDB8ZmI9dXx0dD0xfG14PTIwfHFzPU1hdHJpeCBSZXZvbHV0aW9uc3xodG1sPTF8c2l0ZT1kZnxxPU1hdHJpeCBSZXZvbHV0aW9uc3xwbj0w;fc=1;ft=20" => "tt0242653",
+    }.each do |url, response|
+      FakeWeb.register_uri(:get, url, :response => read_fixture(response))
+    end
+  rescue LoadError
+    puts "Could not load FakeWeb, these tests will hit IMDB.com"
+    puts "You can run `gem install fakeweb` to stub out the responses."
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: imdb
 version: !ruby/object:Gem::Version 
-  version: 0.4.0
+  version: 0.4.1
 platform: ruby
 authors: 
 - Ariejan de Vroom