imdb 0.2.0 → 0.3.0

data/History.txt

@@ -1,3 +1,8 @@
+== 0.3.0
+
+* Fixed typo in CLI field name 'Cast by'
+* Fixed retrieval of multiple directors. (#1)
+
 == 0.2.0 2009-06-04
 
 * Added console tool 'imdb' for searching and getting movie info.

data/lib/imdb.rb

@@ -10,5 +10,5 @@ require 'imdb/search'
 require 'imdb/string_extensions'
 
 module Imdb
-  VERSION = '0.2.0'
+  VERSION = '0.3.0'
 end

data/lib/imdb/cli.rb

@@ -80,9 +80,9 @@ module Imdb
       @stdout.puts "=" * 72
       @stdout.puts "Rating: #{movie.rating}"
       @stdout.puts "Duration: #{movie.length} minutes"
-      @stdout.puts "Directed by: #{movie.director}"
-      @stdout.puts "Cast by: #{movie.cast_members[0..4].join(", ")}"
-      @stdout.puts "Genres: #{movie.genres.join(", ")}"
+      @stdout.puts "Directed by: #{movie.director.join(", ")}"
+      @stdout.puts "Cast: #{movie.cast_members[0..4].join(", ")}"
+      @stdout.puts "Genre: #{movie.genres.join(", ")}"
       @stdout.puts "#{movie.plot}"
       @stdout.puts "=" * 72
       @stdout.puts

data/lib/imdb/movie.rb

@@ -17,7 +17,7 @@ module Imdb
     def initialize(imdb_id, title = nil)
       @id = imdb_id
       @url = "http://www.imdb.com/title/tt#{imdb_id}/"
-      @title = title.gsub(/"/, "")
+      @title = title.nil? ? nil : title.gsub(/"/, "")
     end
     
     # Returns an array with cast members
@@ -27,7 +27,8 @@ module Imdb
     
     # Returns the name of the director
     def director
-      document.at("h5[text()='Director:'] ~ a").innerHTML.strip.imdb_unescape_html rescue nil
+      # document.at("h5[text()='Director:'] ~ a").innerHTML.strip.imdb_unescape_html rescue nil
+      document.search("h5[text()^='Director'] ~ a").map { |link| link.innerHTML.strip.imdb_unescape_html } rescue []
     end
     
     # Returns an array of genres (as strings)

data/spec/imdb_movie_spec.rb

@@ -29,7 +29,9 @@ describe "Imdb::Movie" do
   end
   
   it "should find the director" do
-    @movie.director.should =~ /John McTiernan/
+    @movie.director.should be_an(Array)
+    @movie.director.size.should eql(1)
+    @movie.director.first.should =~ /John McTiernan/
   end
   
   it "should find the genres" do
@@ -70,4 +72,17 @@ describe "Imdb::Movie" do
     @movie.year.should eql(1988)
   end
   
+  describe "special scenarios" do
+    
+    it "should find multiple directors" do
+      # The Matrix Revolutions (2003)
+      movie = Imdb::Movie.new("0242653")
+      
+      movie.director.should be_an(Array)
+      movie.director.size.should eql(2)
+      movie.director.should include("Larry Wachowski")
+      movie.director.should include("Andy Wachowski")
+    end
+  end
+  
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: imdb
 version: !ruby/object:Gem::Version 
-  version: 0.2.0
+  version: 0.3.0
 platform: ruby
 authors: 
 - Ariejan de Vroom