image_voodoo 0.9.0 → 0.9.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e110e54c634bb3970622f8b0e4fb180fa570e15c53b0ccf830d3ccaf1efed822
-  data.tar.gz: 34d6555550532df09c08f48d15c79d2b749573c85dc8e726bae1757b0249a189
+  metadata.gz: 5028b379cc34f48eb0851549a5f49a9ebd2495385d5fdbfe09d6b9fb0bdd006c
+  data.tar.gz: 873525e43dbfb68a86b664b19d19fa49d522e5312945f86d1939386d17369f94
 SHA512:
-  metadata.gz: 5e4cf9fbf2a7d8045dd3a5be081ae2c1410cc71e327386f779b3f774d95fc4a1d174221e62cfc94c441e738e41e6e572e033f2c47da8e0c9759ca10cf4fcdd46
-  data.tar.gz: 50608dbcde4b2abc26877b0bafa91223e5a26f818dd398ad8b245dd630cc1ccd9fd8974cbaca0c0db63f493066fde7ba3d224464363fe4adbc9f44bb4b65ace7
+  metadata.gz: ee3af809b508d7cf1e4d880e155e487c19ce9579298d132b02d494edf2e63c681b0deed07b891b8d430f75fc6e3058c12fe7ad98fee47f704acdf4bc5abf8087
+  data.tar.gz: 50fd50f6ba4d34afc4b6585dfdeaeb2077a380ef1073522641253f89f7b2e5aa956174019e8275ee674a7cbad8287d22e42cd50fe2af5a576624bd0b577ce4e6

data/.gitignore

@@ -3,3 +3,4 @@
 Gemfile.lock
 lib/image_voodoo_jars.rb
 lib/com
+.idea

data/.rubocop.yml

@@ -38,12 +38,12 @@ Metrics/AbcSize:
 # in a table and then execute lambdas for each orientation but this is much
 # more clear.
 Metrics/CyclomaticComplexity:
-  Max: 9
+  Max: 10
 
 # A bunch of fields in a hash are basically generated data. Correcting them
 # for column seems much too pedantic.  I guess exclude is the right thing for
 # an unusual file?
-Metrics/LineLength:
+Layout/LineLength:
   Max: 132
   Exclude:
     - 'lib/image_voodoo/metadata.rb'
@@ -87,14 +87,6 @@ Metrics/BlockLength:
   Exclude:
     - 'bin/image_voodoo'
 
-# casecmp for this case seems like it is much less readable in a place where
-# performance could never matter (a 3-4 char downcase before processing an
-# image :) ).  This could end up being important somewhere but as a default
-# on it feels weird since I find it less readable.
-Performance/Casecmp:
-  Exclude:
-    - 'lib/image_voodoo/awt.rb'
-
 # Hash rocket looks much more natural in a rakefile for its deps.
 Style/HashSyntax:
   Exclude:
@@ -120,7 +112,7 @@ Metrics/ParameterLists:
 # w for width.  Those probably could be written out but they are so common
 # I am basically opting for short-hand.  This is something I rarely do except
 # domain-driven code like this (x,y,h,w).
-Naming/UncommunicativeMethodParamName:
+Naming/MethodParameterName:
   Enabled: false
 
 # This represents one of those frustrating dogmatic rules where if I followed

data/Gemfile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 source 'https://rubygems.org'
 
 gemspec

data/Rakefile

@@ -1,10 +1,12 @@
+# frozen_string_literal: true
+
 require 'bundler'
 require 'rake/testtask'
 require 'jars/installer'
 Bundler::GemHelper.install_tasks
 Bundler.setup
 
-task :default => [:vendor_jars, :test]
+task :default => %i[vendor_jars test]
 
 desc 'Vendor Jars'
 task :vendor_jars do

data/bin/image_voodoo

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 #!/usr/bin/env ruby
 
 require 'optparse'

data/image_voodoo.gemspec

@@ -1,4 +1,5 @@
 # -*- encoding: utf-8 -*-
+# frozen_string_literal: true
 
 $LOAD_PATH.push File.expand_path('lib', __dir__)
 require 'image_voodoo/version'
@@ -13,16 +14,14 @@ Gem::Specification.new do |s|
   s.summary     = 'Image manipulation in JRuby with ImageScience compatible API'
   s.description = 'Image manipulation in JRuby with ImageScience compatible API'
 
-  s.rubyforge_project = 'image_voodoo'
-
   s.files         = `git ls-files`.split("\n")
   s.test_files    = `git ls-files -- {test,spec,features}/*`.split("\n")
   s.executables   = `git ls-files -- bin/*`.split("\n").map { |f| File.basename(f) }
   s.require_paths = %w[lib vendor]
-  s.has_rdoc      = true
 
   s.add_development_dependency 'jar-dependencies'
   s.add_development_dependency 'rake'
+  s.add_development_dependency 'rubocop'
   s.add_development_dependency 'ruby-maven'
   s.add_development_dependency 'test-unit'
 

data/lib/image_science.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'image_voodoo'
 # HA HA...let the pin-pricking begin
 ImageScience = ImageVoodoo

data/lib/image_voodoo/awt/core_ext/buffered_image.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'java'
 
 # Hide in ImageVoodoo so awt.rb can see this and we will not polute global

data/lib/image_voodoo/awt/core_ext/graphics2d.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'java'
 
 # Hide in ImageVoodoo so awt.rb can see this and we will not polute global

data/lib/image_voodoo/awt/shapes.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class ImageVoodoo
   # (Experimental) An attempt at some primitive drawing in images.
   module Shapes
@@ -14,7 +16,7 @@ class ImageVoodoo
       border_width = options[:width].to_i || 2
       new_width, new_height = width + 2*border_width, height + 2*border_width
       target = paint(BufferedImage.new(new_width, new_height, color_type)) do |g|
-        paint_border(g, new_width, new_height, options[:color])
+        paint_border(g, new_width, new_height, options)
         g.draw_image(@src, nil, border_width, border_width)
       end
       block_given? ? yield(target) : target

data/lib/image_voodoo/awt.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'image_voodoo/awt/core_ext/buffered_image'
 require 'image_voodoo/awt/core_ext/graphics2d'
 require 'image_voodoo/awt/shapes'
@@ -132,7 +134,9 @@ class ImageVoodoo
 
     def determine_format_from_file_name(file_name)
       ext = file_name.split('.')[-1]
+
       raise ArgumentError, "no extension in file name #{file_name}" unless ext
+
       ext
     end
 
@@ -182,7 +186,9 @@ class ImageVoodoo
   # with an ArgumentError.
   def hex_to_color(rgb='000000')
     rgb ||= '000000'
+
     raise ArgumentError, 'hex rrggbb needed' if rgb !~ /[[:xdigit:]]{6,6}/
+
     Color.new(rgb[0, 2].to_i(16), rgb[2, 2].to_i(16), rgb[4, 2].to_i(16))
   end
 

data/lib/image_voodoo/gae.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Google App Engine implementation (does this work?)
 class ImageVoodoo
   java_import com.google.appengine.api.images.Image

data/lib/image_voodoo/metadata.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'image_voodoo_jars'
 require 'stringio'
 
@@ -19,7 +21,9 @@ class ImageVoodoo
     #
     def [](dirname)
       dirclass = DIRECTORY_MAP[dirname.to_s]
+
       raise ArgumentError, "Uknown metadata group: #{dirname}" unless dirclass
+
       dirclass.new @metadata
     end
 
@@ -81,10 +85,15 @@ class ImageVoodoo
     # defined.
     def [](tag_name)
       return nil unless @directory
+
       (tag_type, tag_method) = self.class::TAGS[tag_name.to_s]
+
       raise ArgumentError, "Unkown tag_name: #{tag_name}" unless tag_type
+
       java_tag_type = self.class.directory_class.const_get tag_type
+
       return nil unless @directory.contains_tag java_tag_type
+
       @directory.__send__ tag_method, java_tag_type
     end
   end

data/lib/image_voodoo/needs_head.rb

@@ -1 +1,3 @@
+# frozen_string_literal: true
+
 class ImageVoodoo; NEEDS_HEAD = true; end

data/lib/image_voodoo/version.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class ImageVoodoo
-  VERSION = '0.9.0'.freeze
+  VERSION = '0.9.1'
 end

data/lib/image_voodoo.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Before we load image_voodoo we can specify whether we want it to load full
 # AWT ala http://www.oracle.com/technetwork/articles/javase/headless-136834.html
 # Most users are using image_voodoo as a library for manipulation and do not
@@ -156,8 +158,8 @@ class ImageVoodoo
   def resize(width, height)
     target = guard { resize_impl(width, height) }
     block_given? ? yield(target) : target
-  rescue java.lang.Exception => ne # figure out why this is here at all?
-    raise ArgumentError, ne.message
+  rescue java.lang.Exception => e # figure out why this is here at all?
+    raise ArgumentError, e.message
   end
 
   # Rotates the image by angle (specified in degrees).
@@ -171,6 +173,7 @@ class ImageVoodoo
   def save(file)
     format = File.extname(file)
     return false if format == ''
+
     format = format[1..-1].downcase
     guard { save_impl(format, JFile.new(file)) }
     true
@@ -207,6 +210,7 @@ class ImageVoodoo
   # A top-level image loader opens path and then yields/returns the image.
   def self.with_image(path)
     raise ArgumentError, "file does not exist: #{path}" unless File.file?(path)
+
     image = guard { with_image_impl(JFile.new(path)) }
     image && block_given? ? yield(image) : image
   end

data/samples/bench.rb

@@ -1,4 +1,5 @@
 #!/usr/local/bin/ruby -w
+# frozen_string_literal: true
 
 require 'benchmark'
 require 'rbconfig'

data/samples/file_greyscale.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'image_voodoo'
 
 # reads in the file specified by ARGV[0], transforming to greyscale and

data/samples/file_thumbnail.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'image_science'
 
 # reads in the file specified by ARGV[0], transforms it into a 32-pixel thumbnail,

data/samples/file_view.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'image_voodoo/needs_head'
 require 'image_voodoo'
 

data/samples/in_memory.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'image_voodoo'
 
 # reads in the image at ARGV[0], transforms it into a 32-pixel thumbnail in-memory,

data/samples/lossy.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'image_voodoo'
 
 ImageVoodoo.with_image(ARGV[0]) do |img|

data/test/test_image_science.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test/unit/testcase'
 require 'test/unit' if $PROGRAM_NAME == __FILE__
 require 'image_science'

data/test/test_image_voodoo.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test/unit/testcase'
 require 'test/unit' if $PROGRAM_NAME == __FILE__
 require 'image_voodoo'

data/test/test_metadata.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test/unit/testcase'
 require 'test/unit' if $PROGRAM_NAME == __FILE__
 require 'image_voodoo'

data/test/test_shapes.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test/unit/testcase'
 require 'test/unit' if $PROGRAM_NAME == __FILE__
 require 'image_voodoo'

data/tools/gen.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Used to generate part of metadata.rb.  Unfortunately, I am unable to fill
 # in appropriate access methods so I generate with get_string and then manually
 # update.  In future versions I will just run this twice with old and new src
@@ -30,6 +32,7 @@ directories = {}
 io.readlines.each do |line|
   #  .../IptcDirectory.java: public static final int TAG_BY_LINE = 80;
   next if %r{Source/[/]?(?<dir_name>.*).java:.*TAG_(?<tag_name>[\S]+)} !~ line
+
   directory_name = normalize_directory_name dir_name
   directories[directory_name] ||= []
   directories[directory_name] << normalize_tag_name(tag_name)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: image_voodoo
 version: !ruby/object:Gem::Version
-  version: 0.9.0
+  version: 0.9.1
 platform: ruby
 authors:
 - Thomas E. Enebo, Charles Nutter, Nick Sieger
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2019-02-26 00:00:00.000000000 Z
+date: 2021-10-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   requirement: !ruby/object:Gem::Requirement
@@ -38,6 +38,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  name: rubocop
+  prerelease: false
+  type: :development
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   requirement: !ruby/object:Gem::Requirement
     requirements:
@@ -134,8 +148,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements:
 - jar com.drewnoakes, metadata-extractor, 2.11.0
-rubyforge_project: image_voodoo
-rubygems_version: 2.7.6
+rubygems_version: 3.2.14
 signing_key:
 specification_version: 4
 summary: Image manipulation in JRuby with ImageScience compatible API