image_vise 0.0.16 → 0.0.17

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a1fd49220c9d775bba0d8f8a5646b2e78a4412c5
-  data.tar.gz: 8b0033eed381e0c135bf8b109cc9013f63e58bdd
+  metadata.gz: 6b6177fda88bf4453fffa272bf1f824865827fb0
+  data.tar.gz: a2c9d53049369496b9dd1ec781bda29ca809397b
 SHA512:
-  metadata.gz: a46027f576b9237097f7813d76399b9bfddd23e6c2d948416cee63e758236d56791ec1b33cef0a3ab9322e1817424c5ac4b167216cd210bfeba2cf54b6fde4da
-  data.tar.gz: 376b9f9efe967201740f83f4778df4eff720dc8525c7a62d2d36e326acc16d18e5c2e10cf85c974bcc5db956dcb063d4a33b8536a74d33c88f888da3be734f15
+  metadata.gz: 585a4c85b023af887d0e4d508956a864addef958d634baaebf6d84a7639e4d423a16b30f1c59e12e2fd4cb03017118fbb5721af0be7b04a366e6114bc7924fbb
+  data.tar.gz: 049f638ebf0f16a6c8f70df0df0e6ed55392c347e5467ada234b09962f164841f8bfda4741c4e5c767f7b70f2c1a6b0d55de7439783269d3c7140eb9bbdcdde5

data/LICENSE.txt

@@ -19,3 +19,11 @@ LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
 OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
 WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
 
+To anyone who acknowledges that the file "sRGB_v4_ICC_preference_displayclass" is
+provided "AS IS" WITH NO EXPRESS OR IMPLIED WARRANTY, permission to use,
+copy and distribute this file for any purpose is hereby granted without
+fee, provided that the file is not changed including the ICC copyright
+notice tag, and that the name of ICC shall not be used in advertising or
+publicity pertaining to distribution of the software without specific,
+written prior permission. ICC makes no representations about the
+suitability of this software for any purpose.

data/README.md

@@ -8,8 +8,9 @@ framework. The main uses are:
 
 It is implemented as a Rack application that responds to any URL and accepts the following query string parameters:
 
-* `q` - Bese-64 encoded JSON object with `src_url` and `pipeline` properties
-* `sig` - the HMAC signature of the hash with `url`, `w` and `h` computed on a query-string encode of them
+* `q` - Base64 encoded JSON object with `src_url` and `pipeline` properties
+    (the source URL of the image and processing steps to apply)
+* `sig` - the HMAC signature, computed over the JSON in `q` before it gets Base64-encoded
 
 A request to `ImageVise` might look like this:
 
@@ -132,7 +133,7 @@ same protocol (a signed JSON-encodded waybill of HTTP(S) source-URL + pipeline i
 
 ## Using forked child processes for RMagick tasks
 
-You can optionally set the `IMAGE_VISE_ENABLE_FORK` environment variable to any value to enable forking. When this
+You can optionally set the `IMAGE_VISE_ENABLE_FORK` environment variable to `yes` to enable forking. When this
 variable is set, ImageVise will fork a child process and perform the image processing task within that process,
 killing it afterwards and deallocating all the memory. This can be extremely efficient for dealing with potential
 memory bloat issues in ImageMagick/RMagick. However, loading images into RMagick may hang in a forked child. This
@@ -159,9 +160,6 @@ multiple applications all using different keys for their signatures. Every reque
 each key and if at least one key generates the same signature for the same given parameters, it is going to be
 accepted and the request will be allowed to go through.
 
-When running `ImageVise` as a standalone application you can add set the `VISE_SECRET_KEYS` environment 
-variable to a comma-separated list of keys you are willing to accept (no spaces after the commas).
-
 ## Hostname validation
 
 By default, `ImageVise` will refuse to process images from URLs on "unknown" hosts. To mark a host as "known"
@@ -201,3 +199,6 @@ The gem version is specified in `image_vise.rb`. When contributing, please follo
 
 Copyright (c) 2016 WeTransfer. See LICENSE.txt for further details.
 The licensing terms also apply to the `waterside_magic_hour.jpg` test image.
+
+The sRGB color profiles are [downloaded from the ICC](http://www.color.org/srgbprofiles.xalter) and it's
+use is governed by the terms present in the LICENSE.txt

data/image_vise.gemspec

@@ -2,16 +2,16 @@
 # DO NOT EDIT THIS FILE DIRECTLY
 # Instead, edit Jeweler::Tasks in Rakefile, and run 'rake gemspec'
 # -*- encoding: utf-8 -*-
-# stub: image_vise 0.0.16 ruby lib
+# stub: image_vise 0.0.17 ruby lib
 
 Gem::Specification.new do |s|
   s.name = "image_vise"
-  s.version = "0.0.16"
+  s.version = "0.0.17"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.require_paths = ["lib"]
   s.authors = ["Julik Tarkhanov"]
-  s.date = "2016-10-15"
+  s.date = "2016-10-16"
   s.description = "Image processing via URLs"
   s.email = "me@julik.nl"
   s.extra_rdoc_files = [
@@ -35,7 +35,9 @@ Gem::Specification.new do |s|
     "lib/image_vise/image_request.rb",
     "lib/image_vise/pipeline.rb",
     "lib/image_vise/render_engine.rb",
+    "lib/image_vise/sRGB_v4_ICC_preference_displayclass.icc",
     "lib/image_vise/sharpen.rb",
+    "lib/image_vise/srgb.rb",
     "spec/image_vise/auto_orient_spec.rb",
     "spec/image_vise/crop_spec.rb",
     "spec/image_vise/ellipse_stencil_spec.rb",
@@ -46,10 +48,12 @@ Gem::Specification.new do |s|
     "spec/image_vise/pipeline_spec.rb",
     "spec/image_vise/render_engine_spec.rb",
     "spec/image_vise/sharpen_spec.rb",
+    "spec/image_vise/srgb_spec.rb",
     "spec/image_vise_spec.rb",
     "spec/spec_helper.rb",
     "spec/test_server.rb",
-    "spec/waterside_magic_hour.jpg"
+    "spec/waterside_magic_hour.jpg",
+    "spec/waterside_magic_hour_adobergb.jpg"
   ]
   s.homepage = "https://github.com/WeTransfer/image_vise"
   s.licenses = ["MIT"]

data/lib/image_vise/render_engine.rb

@@ -189,7 +189,7 @@ class ImageVise::RenderEngine
   end
   
   def enable_forking?
-    ENV.key? 'IMAGE_VISE_ENABLE_FORK'
+    ENV['IMAGE_VISE_ENABLE_FORK'] == 'yes'
   end
   
   def apply_pipeline(source_file_path, pipeline, source_file_type, render_to_path)

data/lib/image_vise/srgb.rb

@@ -0,0 +1,30 @@
+# Applies the sRGB profile to the image.
+# For this to work, your ImageMagick must be built
+# witl LCMS support. On OSX, you need to use the brew install
+# command with the following options:
+#
+#    $brew install imagemagick --with-little-cms --with-little-cms2
+#
+# You can verify if you do have LittleCMS support by checking the
+# delegates list that `$convert --version` outputs:
+#
+# For instance, if you do not have it, the list will look like this:
+#
+#    $ convert --version
+#    ...
+#    Delegates (built-in): bzlib freetype jng jpeg ltdl lzma png tiff xml zlib
+#
+# whereas if you do, the list will include the "lcms" delegate:
+#
+#    $ convert --version
+#    ...
+#    Delegates (built-in): bzlib freetype jng jpeg lcms ltdl lzma png tiff xml zlib
+#
+# The corresponding Pipeline method is `srgb`.
+class ImageVise::SRGB
+  PROFILE_PATH = File.expand_path(__dir__ + '/sRGB_v4_ICC_preference_displayclass.icc')
+  def apply!(magick_image)
+    magick_image.add_profile(PROFILE_PATH)
+  end
+  ImageVise.add_operator 'srgb', self
+end

data/lib/image_vise.rb

@@ -5,7 +5,7 @@ require 'rmagick'
 require 'magic_bytes'
 
 class ImageVise
-  VERSION = '0.0.16'
+  VERSION = '0.0.17'
 
   @allowed_hosts = Set.new
   @keys = Set.new

data/spec/image_vise/srgb_spec.rb

@@ -0,0 +1,28 @@
+require 'spec_helper'
+
+describe ImageVise::SRGB do
+  it 'applies the profile, creating a perceptible difference with the original' do
+    opset = ImageVise::Pipeline.new([
+      ImageVise::FitCrop.new(width: 512, height: 512, gravity: 'c'),
+      described_class.new,
+    ])
+
+    # This test will function only if you have RMagick with LCMS2 support
+    # built-in. If you do, the two images will look _very_ much like one
+    # another.
+    #
+    # If you don't, the images will look remarkably different
+    # (the AdobeRGB version has color values that match AdobeRGB
+    # primaries, and will render diffrently in pretty much any
+    # viewer).
+    image = Magick::Image.read(test_image_adobergb_path).first
+    opset.apply!(image)
+    image.strip!
+    examine_image(image, "from-adobergb")
+
+    image = Magick::Image.read(test_image_path).first
+    opset.apply!(image)
+    image.strip!
+    examine_image(image, "from-srgb")
+  end
+end

data/spec/spec_helper.rb

@@ -64,6 +64,10 @@ RSpec.configure do | config |
     File.expand_path(__dir__ + '/waterside_magic_hour.jpg')
   end
 
+  def test_image_adobergb_path
+    File.expand_path(__dir__ + '/waterside_magic_hour_adobergb.jpg')
+  end
+
   def public_url
     'http://localhost:9001/waterside_magic_hour.jpg'
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: image_vise
 version: !ruby/object:Gem::Version
-  version: 0.0.16
+  version: 0.0.17
 platform: ruby
 authors:
 - Julik Tarkhanov
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-10-15 00:00:00.000000000 Z
+date: 2016-10-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -264,7 +264,9 @@ files:
 - lib/image_vise/image_request.rb
 - lib/image_vise/pipeline.rb
 - lib/image_vise/render_engine.rb
+- lib/image_vise/sRGB_v4_ICC_preference_displayclass.icc
 - lib/image_vise/sharpen.rb
+- lib/image_vise/srgb.rb
 - spec/image_vise/auto_orient_spec.rb
 - spec/image_vise/crop_spec.rb
 - spec/image_vise/ellipse_stencil_spec.rb
@@ -275,10 +277,12 @@ files:
 - spec/image_vise/pipeline_spec.rb
 - spec/image_vise/render_engine_spec.rb
 - spec/image_vise/sharpen_spec.rb
+- spec/image_vise/srgb_spec.rb
 - spec/image_vise_spec.rb
 - spec/spec_helper.rb
 - spec/test_server.rb
 - spec/waterside_magic_hour.jpg
+- spec/waterside_magic_hour_adobergb.jpg
 homepage: https://github.com/WeTransfer/image_vise
 licenses:
 - MIT