image_optimizer 1.7.2 → 1.8.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 969a4901be9795c5603fe6da08a149216663c2ec
-  data.tar.gz: 47b0be6953e9d2fe6a58c5ae3c0aa7403b6c5b98
+  metadata.gz: 45e5f6d43275a961ce4361e16e74964a0997fb0f
+  data.tar.gz: 20825e379182211fd1d91a3d3bdc7e770156a87f
 SHA512:
-  metadata.gz: 4685d83bd013a3aa95e58a0abe28c916f8b71c12b737be3bfa9e8fa362265b158c6220c2905fff8fdeaf4591a4b2cd3f158b144b59088cca1f6b99643f340cb7
-  data.tar.gz: '002002468cc274240a6a40c9db842a729ca761b7a830c661b954bd451aadcbbe8d28f808ff6ec02a873f9da833f651d6126f932eaeb36f7607bb6ffe75ac2f4c'
+  metadata.gz: 58805ec57ebd31008f53900573f3bdb1e5486b068ba0f11295180aaf216ca88cb8bc6fcb2552c5cc8e4fd42c3dbf1e6b960441f8ef0ca491bea172158c790b47
+  data.tar.gz: 99c6b7a0eb7661048a83462996ea59afda918b3116bc26a9225a8215ab538576faa0af7f8c5117573bc19b839973e329f4edfb210bd83c8e33133c2cff3714ad

data/CHANGELOG.md

@@ -1,3 +1,6 @@
+## [1.8.0](https://github.com/jtescher/image_optimizer/releases/tag/v1.7.3) 2018-07-30
+* Fix: space in file name will break PNGQuantOptimizer - https://github.com/jtescher/image_optimizer/pull/21
+
 ## [1.7.2](https://github.com/jtescher/image_optimizer/releases/tag/v1.7.2) 2018-01-10
 * Added quiet option support for pngquant optimizer - https://github.com/jtescher/image_optimizer/pull/19
 

data/README.md

@@ -58,7 +58,7 @@ Pngquant is a command-line utility and a library for lossy compression of PNG im
 The conversion reduces file sizes significantly (often as much as 70%) and preserves full alpha transparency. Generated images are compatible with all modern web browsers, and have better fallback in IE6 than 24-bit PNGs.
 
 ```ruby
-PNGQuantOptimizer.new('path/to/file.png').optimize
+ImageOptimizer::PNGQuantOptimizer.new('path/to/file.png').optimize
 ```
 
 #### Optimize JPEG formats:

data/checksum/image_optimizer-1.8.0.gem.sha512

@@ -0,0 +1 @@
+a060c2b8101654118102bbced353085a17155363cd283bf2365f8ade16fa621b83076a06cf1c0635c44ce8ef465fad4a675bcebae616cb86b83e871db67e6e44

data/lib/image_optimizer/pngquant_optimizer.rb

@@ -3,22 +3,18 @@ class ImageOptimizer
 
   private
 
-    def perform_optimizations
-      system("#{optimizer_bin} #{command_options.join(' ')}")
-    end
-
     def command_options
-      flags = ['--skip-if-larger', '--speed 1',
-               '--force', '--verbose', '--ext .png']
+      flags = ['--skip-if-larger', '--speed=1',
+               '--force', '--verbose', '--ext=.png']
 
       flags -= ['--verbose'] if quiet?
-      flags << quantity
+      flags << quality
       flags << path
     end
 
-    def quantity
-      return "--quality 100" unless (0..100).include?(options[:quality])
-      "--quality #{options[:quality]}"
+    def quality
+      return "--quality=100" unless (0..100).include?(options[:quality])
+      "--quality=#{options[:quality]}"
     end
 
     def extensions

data/lib/image_optimizer/version.rb

@@ -1,3 +1,3 @@
 class ImageOptimizer
-  VERSION = '1.7.2'
+  VERSION = '1.8.0'
 end

data/spec/image_optimizer/pngquant_optimizer_spec.rb

@@ -3,7 +3,8 @@ require 'spec_helper'
 describe ImageOptimizer::PNGQuantOptimizer do
   describe '#optimize' do
     let(:options) { {} }
-    let(:pngquant_optimizer) { ImageOptimizer::PNGQuantOptimizer.new('/path/to/file.png', options) }
+    let(:path) { '/path/to/file.png' }
+    let(:pngquant_optimizer) { ImageOptimizer::PNGQuantOptimizer.new(path, options) }
     after { ImageOptimizer::PNGQuantOptimizer.instance_variable_set(:@bin, nil) }
     subject { pngquant_optimizer.optimize }
 
@@ -13,8 +14,8 @@ describe ImageOptimizer::PNGQuantOptimizer do
       end
 
       it 'optimizes the png' do
-        expected_cmd = "/usr/local/bin/pngquant --skip-if-larger --speed\ 1 --force --verbose --ext\ .png --quality\ 100 /path/to/file.png"
-        expect(pngquant_optimizer).to receive(:system).with(expected_cmd)
+        expected_cmd = %w[/usr/local/bin/pngquant --skip-if-larger --speed=1 --force --verbose --ext=.png --quality=100 /path/to/file.png]
+        expect(pngquant_optimizer).to receive(:system).with(*expected_cmd)
         subject
       end
 
@@ -28,8 +29,8 @@ describe ImageOptimizer::PNGQuantOptimizer do
         end
 
         it 'should optimize using the given path' do
-          expected_cmd = "#{image_pngquant_bin_path} --skip-if-larger --speed\ 1 --force --verbose --ext\ .png --quality\ 100 /path/to/file.png"
-          expect(pngquant_optimizer).to receive(:system).with(expected_cmd)
+          expected_cmd = %w[--skip-if-larger --speed=1 --force --verbose --ext=.png --quality=100 /path/to/file.png]
+          expect(pngquant_optimizer).to receive(:system).with(image_pngquant_bin_path, *expected_cmd)
           subject
         end
       end
@@ -38,8 +39,8 @@ describe ImageOptimizer::PNGQuantOptimizer do
         let(:options) { { :quality => 99 } }
 
         it 'optimizes the png with the quality' do
-          expected_cmd = "/usr/local/bin/pngquant --skip-if-larger --speed\ 1 --force --verbose --ext\ .png --quality\ 99 /path/to/file.png"
-          expect(pngquant_optimizer).to receive(:system).with(expected_cmd)
+          expected_cmd = %w[/usr/local/bin/pngquant --skip-if-larger --speed=1 --force --verbose --ext=.png --quality=99 /path/to/file.png]
+          expect(pngquant_optimizer).to receive(:system).with(*expected_cmd)
           subject
         end
       end
@@ -48,8 +49,18 @@ describe ImageOptimizer::PNGQuantOptimizer do
         let(:options) { { :quiet => true } }
 
         it 'optimizes the png with the quality' do
-          expected_cmd = "/usr/local/bin/pngquant --skip-if-larger --speed\ 1 --force --ext\ .png --quality\ 100 /path/to/file.png"
-          expect(pngquant_optimizer).to receive(:system).with(expected_cmd)
+          expected_cmd = %w[/usr/local/bin/pngquant --skip-if-larger --speed=1 --force --ext=.png --quality=100 /path/to/file.png]
+          expect(pngquant_optimizer).to receive(:system).with(*expected_cmd)
+          subject
+        end
+      end
+
+      context 'with space in file name' do
+        let(:path) { '/path/to/file 2.png' }
+
+        it do
+          expected_cmd = %w[/usr/local/bin/pngquant --skip-if-larger --speed=1 --force --verbose --ext=.png --quality=100]
+          expect(pngquant_optimizer).to receive(:system).with(*expected_cmd, path)
           subject
         end
       end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: image_optimizer
 version: !ruby/object:Gem::Version
-  version: 1.7.2
+  version: 1.8.0
 platform: ruby
 authors:
 - Julian Tescher
@@ -30,7 +30,7 @@ cert_chain:
   QwZpjX6ObAC8UUVzMUl9zs9rGj05QmK5Se0ZfFZYzfO71Z8Kx7vpePbGco/fzPvk
   15Xsz7dTwTgNTPwj2HLuCxQjiUskbdzv
   -----END CERTIFICATE-----
-date: 2018-01-11 00:00:00.000000000 Z
+date: 2018-07-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
@@ -131,6 +131,7 @@ files:
 - checksum/image_optimizer-1.7.0.gem.sha512
 - checksum/image_optimizer-1.7.1.gem.sha512
 - checksum/image_optimizer-1.7.2.gem.sha512
+- checksum/image_optimizer-1.8.0.gem.sha512
 - image_optimizer.gemspec
 - lib/image_optimizer.rb
 - lib/image_optimizer/gif_optimizer.rb