image_optim 0.17.0 → 0.17.1

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    NDA2ZGQwMGNiYTI1OTgxN2IyYWY1MmEyNDg0OTgwYzQ1YmY2ODk2MQ==
+    ZTM0NDFkYmE3MDIyOTgyMGNkMzEzNDk4NTk1NWI3MjM0ODU1NTJkYQ==
   data.tar.gz: !binary |-
-    ZTdmNTAzMDYwMzRmM2ZlZmM5YTg4MDk5ZTgzNWJjZTUxZjY4OTA2YQ==
+    N2FlNDFjZmNhMDRhOTliOTdkYzA3MjcxMTE0Y2NiMjNiNTdiYWUxYQ==
 SHA512:
   metadata.gz: !binary |-
-    NjM2NTMyODYxNDU2ZjNiOWQxYTE3NmY0NjgyMDY3ZGRmYjEzZDQzMTUwNmYy
-    N2IyZTdhODAxYmI0YjRjMmM5YWY5MWFlNGI0MGU3M2FmZjMzYTc1ZWQzMzhl
-    OWNjNGFlNzEyY2NjNDY1ODhmZTU1Mzk5MWQ5OTM4ZDQ0MmM3MWU=
+    OTBlZDI2NjQwMTkyMjNlYzg3YWUwNjI0NzgxMjgzY2M5ZjI1ZjdjZTg1MDlk
+    NjQ0MWExMzI1MGM2YjNkYjkwMDVmMjNhNTc5NWQ3MTk5YzY4ZGU5YTM0YTUy
+    YjhmOWUzMjg1Yzg0YWIxZGJjMzcxODY5NWYyMDRhMDQ2YzFiN2Y=
   data.tar.gz: !binary |-
-    Y2NmZjlmODI1NDAyODk0NjAwYzRmYjUzNDU0ZTllMTNhYmM4NWRkYjQ3YmMz
-    NDFkNDc2ZTIwNTBhOWZlNmQyYTQ2YTc0NDViYmY3NDg4Yzc0ZGNlN2JjMDA2
-    MjRmOGNlNjdiNTE2YWQxMGE5Mjc5NDdkYTk1YTkzNWNlZDI0MjI=
+    OGI2OWRiNzAxZjhjMzM4N2QyZGFkMDc2N2U1NDM1N2YwNGM2NGJjYTE1MDg4
+    YmNkMTE1MGNlZTk3ODk5MWMwODVlY2UyYWUwYWIyNzllOTViMDA2NWYxNjI2
+    MjIxMDUzNmVlZTg4YTQxYWE1MWQ2NGMwNjYwMGQ5NDU5NzM3YmE=

data/CHANGELOG.markdown

@@ -2,6 +2,10 @@
 
 ## unreleased
 
+## v0.17.1 (2014-10-06)
+
+* Fix bin path resolving method missing vendor directory [@toy](https://github.com/toy)
+
 ## v0.17.0 (2014-10-04)
 
 * Use pure ruby detection of bin path [@toy](https://github.com/toy)

data/image_optim.gemspec

@@ -2,7 +2,7 @@
 
 Gem::Specification.new do |s|
   s.name        = 'image_optim'
-  s.version     = '0.17.0'
+  s.version     = '0.17.1'
   s.summary     = %q{Optimize (lossless compress) images (jpeg, png, gif, svg) using external utilities (advpng, gifsicle, jpegoptim, jpegtran, optipng, pngcrush, pngout, pngquant, svgo)}
   s.homepage    = "http://github.com/toy/#{s.name}"
   s.authors     = ['Ivan Kuchin']

data/lib/image_optim/bin_resolver.rb

@@ -49,7 +49,7 @@ class ImageOptim
 
     # Prepand `dir` and append `VENDOR_PATH` to `PATH` from environment
     def env_path
-      [dir, ENV['PATH'], VENDOR_PATH].compact.join(':')
+      [dir, ENV['PATH'], VENDOR_PATH].compact.join(File::PATH_SEPARATOR)
     end
 
     # Collect resolving errors when running block over items of enumerable
@@ -103,7 +103,7 @@ class ImageOptim
     def full_path(name)
       # PATHEXT is needed only for windows
       exts = ENV['PATHEXT'] ? ENV['PATHEXT'].split(';') : ['']
-      ENV['PATH'].to_s.split(File::PATH_SEPARATOR).each do |dir|
+      env_path.split(File::PATH_SEPARATOR).each do |dir|
         exts.each do |ext|
           path = File.expand_path("#{name}#{ext}", dir)
           return path if File.file?(path) && File.executable?(path)

data/spec/image_optim/bin_resolver_spec.rb

@@ -34,6 +34,21 @@ describe ImageOptim::BinResolver do
       end
     end
 
+    it 'should find bin in vendor' do
+      with_env 'PATH', nil do
+        expect(full_path('jpegrescan')).
+          to eq(File.expand_path('vendor/jpegrescan'))
+      end
+    end
+
+    it 'should work with different path separator' do
+      stub_const('File::PATH_SEPARATOR', 'O_o')
+      with_env 'PATH', 'bin' do
+        expect(full_path('image_optim')).
+          to eq(File.expand_path('bin/image_optim'))
+      end
+    end
+
     it 'should return nil on failure' do
       with_env 'PATH', 'lib' do
         expect(full_path('image_optim')).to be_nil

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: image_optim
 version: !ruby/object:Gem::Version
-  version: 0.17.0
+  version: 0.17.1
 platform: ruby
 authors:
 - Ivan Kuchin
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-10-04 00:00:00.000000000 Z
+date: 2014-10-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: fspath