iknow_view_models 3.7.5 → 3.7.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 93c994829498ed19d7214cca326ef7c361de788b5d88fb00e4927208aca9f21a
-  data.tar.gz: 75019085c70b0feed81316211922e3cb87b6dfee0485a3c6424070db028a68cd
+  metadata.gz: f4e2ce83aca25f76c562927351a4c3061566428bd6d599f8d1efd3a0fe67b953
+  data.tar.gz: e6f11b57045e611fd9e3133f28fbfe7e9ee42c82edafdaa4a7be9a0c25311080
 SHA512:
-  metadata.gz: 90ac0ba33c195e22e1d3f51e9be84cdccb0fe5646d8f2ee93deba2eb5aff865a6a37dd1bf0f115a0c00fc6e33b64a086a5519b1acd90a107cede3d54c018f0c2
-  data.tar.gz: 949f86898a69d142dd5f1576054d18675785fcaae9d30c64344f1e3681f18aabae82c61cddd08a6ca3523796380cfb62e1ccb1ceee6d8d5c92753b59837c51a9
+  metadata.gz: 628bebb67d57d5036640357c5cc9429ada7d84b5fd70d57d9aa1a35244bf1bd50f0d6851d56c7949ef46d54db6c066810f3e7206833419cee16b7b1e9ee1c030
+  data.tar.gz: 497c85d6648b089bb6cac073684cf070becf37b2505b977d13ce2115eaaa7eef68da985713304548241a69b88dba3d2729925ec87ef384792cf721fdcf73b4a7

data/lib/iknow_view_models/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module IknowViewModels
-  VERSION = '3.7.5'
+  VERSION = '3.7.6'
 end

data/lib/view_model/active_record/update_operation.rb

@@ -81,15 +81,15 @@ class ViewModel::ActiveRecord
             viewmodel._list_attribute = reposition_to
           end
 
+          # Visit attributes and associations as much as possible in the order
+          # that they're declared in the view.
+          member_ordering = viewmodel.class._members.keys.each_with_index.to_h
+
           # update user-specified attributes
-          valid_members = viewmodel.class._members.keys.map(&:to_s).to_set
-          bad_keys = attributes.keys.reject { |k| valid_members.include?(k) }
-          if bad_keys.present?
-            causes = bad_keys.map { |k| ViewModel::DeserializationError::UnknownAttribute.new(k, blame_reference) }
-            raise ViewModel::DeserializationError::Collection.for_errors(causes)
-          end
+          attribute_keys = attributes.keys.sort_by { |k| member_ordering[k] }
+          attribute_keys.each do |attr_name|
+            serialized_value = attributes[attr_name]
 
-          attributes.each do |attr_name, serialized_value|
             # Note that the VM::AR deserialization tree asserts ownership over any
             # references it's provided, and so they're intentionally not passed on
             # to attribute deserialization for use by their `using:` viewmodels. A
@@ -101,7 +101,13 @@ class ViewModel::ActiveRecord
           end
 
           # Update points-to associations before save
-          points_to.each do |association_data, child_operation|
+          points_to_keys = points_to.keys.sort_by do |association_data|
+            member_ordering[association_data.association_name]
+          end
+
+          points_to_keys.each do |association_data|
+            child_operation = points_to[association_data]
+
             reflection = association_data.direct_reflection
             debug "-> #{debug_name}: Updating points-to association '#{reflection.name}'"
 
@@ -138,7 +144,12 @@ class ViewModel::ActiveRecord
 
           # Update association cache of pointed-from associations after save: the
           # child update will have saved the pointer.
-          pointed_to.each do |association_data, child_operation|
+          pointed_to_keys = pointed_to.keys.sort_by do |association_data|
+            member_ordering[association_data.association_name]
+          end
+
+          pointed_to_keys.each do |association_data|
+            child_operation = pointed_to[association_data]
             reflection = association_data.direct_reflection
 
             debug "-> #{debug_name}: Updating pointed-to association '#{reflection.name}'"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: iknow_view_models
 version: !ruby/object:Gem::Version
-  version: 3.7.5
+  version: 3.7.6
 platform: ruby
 authors:
 - iKnow Team
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2023-08-31 00:00:00.000000000 Z
+date: 2023-12-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: actionpack