iknow_view_models 3.5.0 → 3.5.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 0cb094f674e990ef9a67bbcb7b0ee260065356cdb6a56ee6e1b19582c320e96c
-  data.tar.gz: 5bb5c175e7fd30442794c2ff87687eb5dec132fa7da0d0128a1b012bd50131d6
+  metadata.gz: 1b538a2d547114ecfbb76bfc790daea11b2185abdbad54d5da82723bb7fa1bef
+  data.tar.gz: 97b7e6d1d66cae14d56fe53931d06a4079e5c9b4b61e60bf56027d539fd41224
 SHA512:
-  metadata.gz: f196d4af404bcb91d88519e04ed2afcd7d73c590af4838e16b32b4f73171d20500a4a092cb76d693d7a683bf4ca6ad337d5e79a10a5233870f9c244acfffe969
-  data.tar.gz: bfdd726357dc50f72732498d112274301089ab82719e46d7c5d7bfc5414a6bcf3dc12459bb9dee6ffa9c174dea1c81e2a0499649d9bbe1d1618702bfad18ef04
+  metadata.gz: 4f70185a7ba12a222eee6a1549f724c08754f7213a1c1594d5b2ea0060baac04fce839cb480615e02741adcc82cd2d910e8d82e519127da15efd6e14dbdf3b0b
+  data.tar.gz: 82a343d49bf61a6e351653c8a3e3855344b5dd017acc7722cc526e41af8915d6aedb028995f859354df23de82f55b2c342b2fa1a572af76b1690345fb120ae02

data/lib/iknow_view_models/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module IknowViewModels
-  VERSION = '3.5.0'
+  VERSION = '3.5.1'
 end

data/lib/view_model/migrator.rb

@@ -75,6 +75,32 @@ class ViewModel
   class UpMigrator < Migrator
     private
 
+    def migrate_tree!(node, references:)
+      if node.is_a?(Hash) && node[ViewModel::TYPE_ATTRIBUTE] == ViewModel::ActiveRecord::FUNCTIONAL_UPDATE_TYPE
+        migrate_functional_update!(node, references: references)
+      else
+        super
+      end
+    end
+
+    NESTED_FUPDATE_TYPES = ['append', 'update'].freeze
+
+    # The functional update structure uses `_type` internally with a
+    # context-dependent meaning. Retrospectively this was a poor choice, but we
+    # need to account for it here.
+    def migrate_functional_update!(node, references:)
+      actions = node[ViewModel::ActiveRecord::ACTIONS_ATTRIBUTE]
+      actions&.each do |action|
+        action_type = action[ViewModel::TYPE_ATTRIBUTE]
+        next unless NESTED_FUPDATE_TYPES.include?(action_type)
+
+        values = action[ViewModel::ActiveRecord::VALUES_ATTRIBUTE]
+        values&.each do |value|
+          migrate_tree!(value, references: references)
+        end
+      end
+    end
+
     def migrate_viewmodel!(view_name, source_version, view_hash, references)
       path = @paths[view_name]
       return false unless path

data/test/unit/view_model/active_record/migration_test.rb

@@ -178,6 +178,35 @@ class ViewModel::ActiveRecord::Migration < ActiveSupport::TestCase
           end
         end
       end
+
+      describe 'with a functional update' do
+        # note that this wouldn't actually be deserializable as child is not a collection
+        def subject_data
+          data = super()
+          data['child'] = wrap_with_fupdate(data['child'])
+          data
+        end
+
+        def expected_result
+          data = super()
+          data['data']['child'] = wrap_with_fupdate(data['data']['child'])
+          data
+        end
+
+        def wrap_with_fupdate(child)
+          # The 'after' and remove shouldn't get changed in migration, even though it has _type: Child
+          build_fupdate do
+            append([child], after: { '_type' => 'Child', 'id' => 9999 })
+            update([child.deep_merge('id' => 8888)])
+            remove([{ '_type' => 'Child', 'id' => 7777 }])
+          end
+        end
+
+        it 'migrates' do
+          migrate!
+          assert_equal(expected_result, subject)
+        end
+      end
     end
   end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: iknow_view_models
 version: !ruby/object:Gem::Version
-  version: 3.5.0
+  version: 3.5.1
 platform: ruby
 authors:
 - iKnow Team
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-08-17 00:00:00.000000000 Z
+date: 2021-10-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord