iknow_view_models 3.13.0 → 3.14.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: cf46376eaf22e04e38fb4b841c10ee273422c4927a1402b4cd2ca4d53f548cb7
-  data.tar.gz: eb83782759ccdc0259c25bf15eca93469272a947b0177c03cb739f478be0733b
+  metadata.gz: b6b63efe5e196fe293c68497b57f53356366632e08f3b2ed97b2240ceb1e2f96
+  data.tar.gz: e8c8d932be65e4f811ac1f80b45338a66681ad6c9b3e5e2957ce123ccff4b70c
 SHA512:
-  metadata.gz: 6edef87440a300016dd2044330e25d1927d161a7706abb4fab86cfd1cffde93e980ef978097006364f7fa4330c4b669342c04f3c3768645832faa0b7f8742f99
-  data.tar.gz: a44050a5c1aebc470ab8c96e027935463b6dd05f3f796f828be33b40ad3af9cd9148fcddbc69aeadb00b1466b802b049c51378f05e63af2c67143838c74a8308
+  metadata.gz: 7e050339a0ac0d06d70e55edc30a2f7a8afe2a58d64f933cc48de18de9c7f98a1fc21b0fe50666b459cf3971cc89b32c75b72fb76c30e6cf3c3f9294e7a864b4
+  data.tar.gz: 8c7fb549e253196df7ab6ca2e56f0659cff104e0e3e9c58806d3681b67ef8c69ecfdae8a781110768249f738ff69e81a0b86360c66f45fb7536ef9bf9ac3fced

data/.github/workflows/test.yml

@@ -26,12 +26,8 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        ruby-version: ['2.7', '3.0', '3.1', '3.2', '3.3']
+        ruby-version: ['3.1', '3.2', '3.3']
         include:
-          - ruby-version: '2.7'
-            bundle-gemfile: gemfiles/rails_5_2.gemfile
-          - ruby-version: '3.0'
-            bundle-gemfile: gemfiles/rails_6_0.gemfile
           - ruby-version: '3.1'
             bundle-gemfile: gemfiles/rails_6_1.gemfile
           - ruby-version: '3.2'
@@ -53,7 +49,7 @@ jobs:
     - name: Run tests
       run: bundle exec rake test
     - name: Upload result
-      uses: actions/upload-artifact@v3
+      uses: actions/upload-artifact@v4
       if: always()
       with:
         path: test/reports/

data/iknow_view_models.gemspec

@@ -21,9 +21,9 @@ Gem::Specification.new do |spec|
 
   spec.required_ruby_version = '>= 2.7.3'
 
-  spec.add_dependency 'actionpack', '>= 5.0'
-  spec.add_dependency 'activerecord', '>= 5.0'
-  spec.add_dependency 'activesupport', '>= 5.0'
+  spec.add_dependency 'actionpack', '>= 6.1'
+  spec.add_dependency 'activerecord', '>= 6.1'
+  spec.add_dependency 'activesupport', '>= 6.1'
 
   spec.add_dependency 'acts_as_manual_list'
   spec.add_dependency 'deep_preloader', '>= 1.0.2'

data/lib/iknow_view_models/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module IknowViewModels
-  VERSION = '3.13.0'
+  VERSION = '3.14.0'
 end

data/lib/view_model/active_record/update_context.rb

@@ -5,6 +5,8 @@
 # the mechanism by which it is applied to models.
 class ViewModel::ActiveRecord
   class UpdateContext
+    include ViewModel::ErrorWrapping
+
     ReleaseEntry = Struct.new(:viewmodel, :association_data) do
       def initialize(*)
         super
@@ -276,10 +278,10 @@ class ViewModel::ActiveRecord
     # human-readable error details.
     def check_deferred_constraints!(model_class)
       if model_class.connection.adapter_name == 'PostgreSQL'
-        model_class.connection.execute('SET CONSTRAINTS ALL IMMEDIATE')
+        wrap_active_record_errors([]) do
+          model_class.connection.execute('SET CONSTRAINTS ALL IMMEDIATE')
+        end
       end
-    rescue ::ActiveRecord::StatementInvalid => ex
-      raise ViewModel::DeserializationError::DatabaseConstraint.from_exception(ex)
     end
   end
 end

data/lib/view_model/active_record/update_operation.rb

@@ -9,6 +9,7 @@ class ViewModel::ActiveRecord
   class UpdateOperation
     # inverse association and record to update a change in parent from a child
     ParentData = Struct.new(:association_reflection, :viewmodel)
+    include ViewModel::ErrorWrapping
 
     enum :RunState, [:Pending, :Running, :Run]
 
@@ -68,152 +69,148 @@ class ViewModel::ActiveRecord
 
       model.class.transaction do
         # Run context and viewmodel hooks
-        ViewModel::Callbacks.wrap_deserialize(viewmodel, deserialize_context: deserialize_context) do |hook_control|
-          # update parent association
-          if reparent_to.present?
-            debug "-> #{debug_name}: Updating parent pointer to '#{reparent_to.viewmodel.class.view_name}:#{reparent_to.viewmodel.id}'"
-            association = model.association(reparent_to.association_reflection.name)
-            association.writer(reparent_to.viewmodel.model)
-            debug "<- #{debug_name}: Updated parent pointer"
-          end
-
-          # update position
-          if reposition_to.present?
-            debug "-> #{debug_name}: Updating position to #{reposition_to}"
-            viewmodel._list_attribute = reposition_to
-          end
-
-          # Visit attributes and associations as much as possible in the order
-          # that they're declared in the view. We can visit attributes and
-          # points-to associations before save, but points-from associations
-          # must be visited after save.
-          pre_save_members, post_save_members = viewmodel.class._members.values.partition do |member_data|
-            !member_data.association? || member_data.pointer_location == :local
-          end
-
-          pre_save_members.each do |member_data|
-            if member_data.association?
-              next unless association_updates.include?(member_data)
-
-              child_operation = association_updates[member_data]
+        wrap_active_record_errors(self.blame_reference) do
+          ViewModel::Callbacks.wrap_deserialize(viewmodel, deserialize_context: deserialize_context) do |hook_control|
+            # update parent association
+            if reparent_to.present?
+              debug "-> #{debug_name}: Updating parent pointer to '#{reparent_to.viewmodel.class.view_name}:#{reparent_to.viewmodel.id}'"
+              association = model.association(reparent_to.association_reflection.name)
+              association.writer(reparent_to.viewmodel.model)
+              debug "<- #{debug_name}: Updated parent pointer"
+            end
 
-              reflection = member_data.direct_reflection
-              debug "-> #{debug_name}: Updating points-to association '#{reflection.name}'"
+            # update position
+            if reposition_to.present?
+              debug "-> #{debug_name}: Updating position to #{reposition_to}"
+              viewmodel._list_attribute = reposition_to
+            end
 
-              association = model.association(reflection.name)
-              new_target =
-                if child_operation
-                  child_ctx = viewmodel.context_for_child(member_data.association_name, context: deserialize_context)
-                  child_viewmodel = child_operation.run!(deserialize_context: child_ctx)
-                  propagate_tree_changes(member_data, child_viewmodel.previous_changes)
+            # Visit attributes and associations as much as possible in the order
+            # that they're declared in the view. We can visit attributes and
+            # points-to associations before save, but points-from associations
+            # must be visited after save.
+            pre_save_members, post_save_members = viewmodel.class._members.values.partition do |member_data|
+              !member_data.association? || member_data.pointer_location == :local
+            end
 
-                  child_viewmodel.model
-                end
-              association.writer(new_target)
-              debug "<- #{debug_name}: Updated points-to association '#{reflection.name}'"
-            else
-              attr_name = member_data.name
-              next unless attributes.include?(attr_name)
-
-              serialized_value = attributes[attr_name]
-              # Note that the VM::AR deserialization tree asserts ownership over any
-              # references it's provided, and so they're intentionally not passed on
-              # to attribute deserialization for use by their `using:` viewmodels. A
-              # (better?) alternative would be to provide them as reference-only
-              # hashes, to indicate that no modification can be permitted.
-              viewmodel.public_send("deserialize_#{attr_name}", serialized_value,
-                                    references: {},
-                                    deserialize_context: deserialize_context)
+            pre_save_members.each do |member_data|
+              if member_data.association?
+                next unless association_updates.include?(member_data)
+
+                child_operation = association_updates[member_data]
+
+                reflection = member_data.direct_reflection
+                debug "-> #{debug_name}: Updating points-to association '#{reflection.name}'"
+
+                association = model.association(reflection.name)
+                new_target =
+                  if child_operation
+                    child_ctx = viewmodel.context_for_child(member_data.association_name, context: deserialize_context)
+                    child_viewmodel = child_operation.run!(deserialize_context: child_ctx)
+                    propagate_tree_changes(member_data, child_viewmodel.previous_changes)
+
+                    child_viewmodel.model
+                  end
+                association.writer(new_target)
+                debug "<- #{debug_name}: Updated points-to association '#{reflection.name}'"
+              else
+                attr_name = member_data.name
+                next unless attributes.include?(attr_name)
+
+                serialized_value = attributes[attr_name]
+                # Note that the VM::AR deserialization tree asserts ownership over any
+                # references it's provided, and so they're intentionally not passed on
+                # to attribute deserialization for use by their `using:` viewmodels. A
+                # (better?) alternative would be to provide them as reference-only
+                # hashes, to indicate that no modification can be permitted.
+                viewmodel.public_send("deserialize_#{attr_name}", serialized_value,
+                                      references: {},
+                                      deserialize_context: deserialize_context)
+              end
             end
-          end
 
-          # If a request makes no assertions about the model, we don't demand
-          # that the current state of the model is valid. This permits making
-          # edits to other models that refer to this model when this model is
-          # invalid.
-          unless reference_only? && !viewmodel.new_model?
-            deserialize_context.run_callback(ViewModel::Callbacks::Hook::BeforeValidate, viewmodel)
-            viewmodel.validate!
-          end
+            # If a request makes no assertions about the model, we don't demand
+            # that the current state of the model is valid. This permits making
+            # edits to other models that refer to this model when this model is
+            # invalid.
+            unless reference_only? && !viewmodel.new_model?
+              deserialize_context.run_callback(ViewModel::Callbacks::Hook::BeforeValidate, viewmodel)
+              viewmodel.validate!
+            end
 
-          # Save if the model has been altered. Covers not only models with
-          # view changes but also lock version assertions.
-          if viewmodel.model.changed? || viewmodel.model.new_record?
-            debug "-> #{debug_name}: Saving"
-            begin
+            # Save if the model has been altered. Covers not only models with
+            # view changes but also lock version assertions.
+            if viewmodel.model.changed? || viewmodel.model.new_record?
+              debug "-> #{debug_name}: Saving"
               model.save!
-            rescue ::ActiveRecord::RecordInvalid => ex
-              raise ViewModel::DeserializationError::Validation.from_active_model(ex.errors, blame_reference)
-            rescue ::ActiveRecord::StaleObjectError => _ex
-              raise ViewModel::DeserializationError::LockFailure.new(blame_reference)
+              debug "<- #{debug_name}: Saved"
             end
-            debug "<- #{debug_name}: Saved"
-          end
 
-          # Update association cache of pointed-from associations after save: the
-          # child update will have saved the pointer.
-          post_save_members.each do |association_data|
-            next unless association_updates.include?(association_data)
+            # Update association cache of pointed-from associations after save: the
+            # child update will have saved the pointer.
+            post_save_members.each do |association_data|
+              next unless association_updates.include?(association_data)
 
-            child_operation = association_updates[association_data]
-            reflection = association_data.direct_reflection
+              child_operation = association_updates[association_data]
+              reflection = association_data.direct_reflection
 
-            debug "-> #{debug_name}: Updating pointed-to association '#{reflection.name}'"
+              debug "-> #{debug_name}: Updating pointed-to association '#{reflection.name}'"
 
-            association = model.association(reflection.name)
-            child_ctx = viewmodel.context_for_child(association_data.association_name, context: deserialize_context)
+              association = model.association(reflection.name)
+              child_ctx = viewmodel.context_for_child(association_data.association_name, context: deserialize_context)
 
-            new_target =
-              if child_operation
-                ViewModel::Utils.map_one_or_many(child_operation) do |op|
-                  child_viewmodel = op.run!(deserialize_context: child_ctx)
-                  propagate_tree_changes(association_data, child_viewmodel.previous_changes)
+              new_target =
+                if child_operation
+                  ViewModel::Utils.map_one_or_many(child_operation) do |op|
+                    child_viewmodel = op.run!(deserialize_context: child_ctx)
+                    propagate_tree_changes(association_data, child_viewmodel.previous_changes)
 
-                  child_viewmodel.model
+                    child_viewmodel.model
+                  end
                 end
-              end
 
-            association.target = new_target
+              association.target = new_target
 
-            debug "<- #{debug_name}: Updated pointed-to association '#{reflection.name}'"
-          end
+              debug "<- #{debug_name}: Updated pointed-to association '#{reflection.name}'"
+            end
 
-          if self.released_children.present?
-            # Released children that were not reclaimed by other parents during the
-            # build phase will be deleted: check access control.
-            debug "-> #{debug_name}: Checking released children permissions"
-            self.released_children.reject(&:claimed?).each do |released_child|
-              debug "-> #{debug_name}: Checking #{released_child.viewmodel.to_reference}"
-              child_vm = released_child.viewmodel
-              child_association_data = released_child.association_data
-              child_ctx = viewmodel.context_for_child(child_association_data.association_name, context: deserialize_context)
-
-              ViewModel::Callbacks.wrap_deserialize(child_vm, deserialize_context: child_ctx) do |child_hook_control|
-                changes = ViewModel::Changes.new(deleted: true)
-                child_ctx.run_callback(ViewModel::Callbacks::Hook::OnChange,
-                                       child_vm,
-                                       changes: changes)
-                child_hook_control.record_changes(changes)
-              end
+            if self.released_children.present?
+              # Released children that were not reclaimed by other parents during the
+              # build phase will be deleted: check access control.
+              debug "-> #{debug_name}: Checking released children permissions"
+              self.released_children.reject(&:claimed?).each do |released_child|
+                debug "-> #{debug_name}: Checking #{released_child.viewmodel.to_reference}"
+                child_vm = released_child.viewmodel
+                child_association_data = released_child.association_data
+                child_ctx = viewmodel.context_for_child(child_association_data.association_name, context: deserialize_context)
+
+                ViewModel::Callbacks.wrap_deserialize(child_vm, deserialize_context: child_ctx) do |child_hook_control|
+                  changes = ViewModel::Changes.new(deleted: true)
+                  child_ctx.run_callback(ViewModel::Callbacks::Hook::OnChange,
+                                         child_vm,
+                                         changes: changes)
+                  child_hook_control.record_changes(changes)
+                end
 
-              if child_association_data.nested?
-                viewmodel.nested_children_changed!
-              elsif child_association_data.owned?
-                viewmodel.referenced_children_changed!
+                if child_association_data.nested?
+                  viewmodel.nested_children_changed!
+                elsif child_association_data.owned?
+                  viewmodel.referenced_children_changed!
+                end
               end
+              debug "<- #{debug_name}: Finished checking released children permissions"
             end
-            debug "<- #{debug_name}: Finished checking released children permissions"
-          end
 
-          final_changes = viewmodel.clear_changes!
+            final_changes = viewmodel.clear_changes!
 
-          if final_changes.changed?
-            # Now that the change has been fully attempted, call the OnChange
-            # hook if local changes were made
-            deserialize_context.run_callback(ViewModel::Callbacks::Hook::OnChange, viewmodel, changes: final_changes)
-          end
+            if final_changes.changed?
+              # Now that the change has been fully attempted, call the OnChange
+              # hook if local changes were made
+              deserialize_context.run_callback(ViewModel::Callbacks::Hook::OnChange, viewmodel, changes: final_changes)
+            end
 
-          hook_control.record_changes(final_changes)
+            hook_control.record_changes(final_changes)
+          end
         end
       end
 
@@ -221,8 +218,6 @@ class ViewModel::ActiveRecord
 
       @run_state = RunState::Run
       viewmodel
-    rescue ::ActiveRecord::StatementInvalid, ::ActiveRecord::InvalidForeignKey, ::ActiveRecord::RecordNotSaved => ex
-      raise ViewModel::DeserializationError::DatabaseConstraint.from_exception(ex, blame_reference)
     end
 
     def propagate_tree_changes(association_data, child_changes)

data/lib/view_model/active_record.rb

@@ -20,6 +20,7 @@ class ViewModel::ActiveRecord < ViewModel::Record
   AFTER_ATTRIBUTE        = 'after'
 
   require 'view_model/utils/collections'
+  require 'view_model/error_wrapping'
   require 'view_model/active_record/association_data'
   require 'view_model/active_record/update_data'
   require 'view_model/active_record/update_context'
@@ -30,6 +31,7 @@ class ViewModel::ActiveRecord < ViewModel::Record
   require 'view_model/active_record/association_manipulation'
 
   include AssociationManipulation
+  include ViewModel::ErrorWrapping
 
   attr_reader :changed_associations
 
@@ -285,14 +287,14 @@ class ViewModel::ActiveRecord < ViewModel::Record
 
   def destroy!(deserialize_context: self.class.new_deserialize_context)
     model_class.transaction do
-      ViewModel::Callbacks.wrap_deserialize(self, deserialize_context: deserialize_context) do |hook_control|
-        changes = ViewModel::Changes.new(deleted: true)
-        deserialize_context.run_callback(ViewModel::Callbacks::Hook::OnChange, self, changes: changes)
-        hook_control.record_changes(changes)
-        model.destroy!
+      wrap_active_record_errors(self.blame_reference) do
+        ViewModel::Callbacks.wrap_deserialize(self, deserialize_context: deserialize_context) do |hook_control|
+          changes = ViewModel::Changes.new(deleted: true)
+          deserialize_context.run_callback(ViewModel::Callbacks::Hook::OnChange, self, changes: changes)
+          hook_control.record_changes(changes)
+          model.destroy!
+        end
       end
-    rescue ::ActiveRecord::StatementInvalid, ::ActiveRecord::InvalidForeignKey, ::ActiveRecord::RecordNotSaved => e
-      raise ViewModel::DeserializationError::DatabaseConstraint.from_exception(e, self.blame_reference)
     end
   end
 
@@ -371,14 +373,8 @@ class ViewModel::ActiveRecord < ViewModel::Record
     end
   end
 
-  # Rails 6.1 introduced "previously_new_record?", but this library still
-  # supports activerecord >= 5.0. This is an approximation.
   def self.model_previously_new?(model)
-    if (id_changes = model.saved_change_to_id)
-      old_id, _new_id = id_changes
-      return true if old_id.nil?
-    end
-    false
+    model.previously_new_record?
   end
 
   # Helper to return entities that were part of the last deserialization. The

data/lib/view_model/deserialization_error.rb

@@ -350,6 +350,16 @@ class ViewModel
       end
     end
 
+    class TransientDatabaseError < DeserializationError
+      status 502
+      attr_reader :detail
+
+      def initialize(detail, nodes = [])
+        @detail = detail
+        super(nodes)
+      end
+    end
+
     class DatabaseConstraint < DeserializationError
       status 400
       attr_reader :detail
@@ -359,9 +369,9 @@ class ViewModel
         super(nodes)
       end
 
-      # Database constraint errors are pretty opaque and stringly typed. We can
-      # do our best to parse out what metadata we can from the error, and fall
-      # back when we can't.
+      # Database constraint errors that come from Postgres are pretty opaque and
+      # stringly typed. We can do our best to parse out what metadata we can
+      # from the error, and fall back when we can't.
       def self.from_exception(exception, nodes = [])
         case exception.cause
         when PG::UniqueViolation, PG::ExclusionViolation
@@ -478,7 +488,7 @@ class ViewModel
         @attribute = attribute
         @reason    = reason
         @details   = details
-        super([node])
+        super(Array.wrap(node))
       end
 
       def detail

data/lib/view_model/error_wrapping.rb

@@ -0,0 +1,23 @@
+# frozen_string_literal: true
+
+class ViewModel
+  module ErrorWrapping
+    extend ActiveSupport::Concern
+
+    # Catch and translate ActiveRecord errors that map to standard ViewModel
+    # errors. Blame may be either a single VM::Reference or an array of them, or
+    # an empty array if there is no specific node that the error may be attached
+    # to.
+    def wrap_active_record_errors(blame)
+      yield
+    rescue ::ActiveRecord::RecordInvalid => e
+      raise ViewModel::DeserializationError::Validation.from_active_model(e.record.errors, Array.wrap(blame))
+    rescue ::ActiveRecord::StaleObjectError => _e
+      raise ViewModel::DeserializationError::LockFailure.new(Array.wrap(blame))
+    rescue ::ActiveRecord::QueryAborted, ::ActiveRecord::PreparedStatementCacheExpired, ::ActiveRecord::TransactionRollbackError => e
+      raise ViewModel::DeserializationError::TransientDatabaseError.new(e.message, Array.wrap(blame))
+    rescue ::ActiveRecord::StatementInvalid, ::ActiveRecord::InvalidForeignKey, ::ActiveRecord::RecordNotSaved => e
+      raise ViewModel::DeserializationError::DatabaseConstraint.from_exception(e, Array.wrap(blame))
+    end
+  end
+end

data/nix/dependencies.nix

@@ -1,5 +1,4 @@
 {pkgs}:
 {
-  ruby = pkgs.ruby_3_2;
-  postgresql = pkgs.postgresql_14;
+  ruby = pkgs.ruby_3_3;
 }

data/shell.nix

@@ -8,8 +8,6 @@ in
 (bundlerEnv {
   name = "iknow-view-models-shell";
   gemdir = ./nix/gem;
-
-  gemConfig = (defaultGemConfig.override { inherit (dependencies) postgresql; });
-
+  gemConfig = defaultGemConfig;
   inherit (dependencies) ruby;
 }).env

data/test/helpers/arvm_test_utilities.rb

@@ -1,5 +1,6 @@
 # frozen_string_literal: true
 
+require 'logger'
 require 'active_support'
 require 'minitest/hooks'
 

data/test/unit/view_model/error_wrapping_test.rb

@@ -0,0 +1,129 @@
+# frozen_string_literal: true
+
+require 'minitest/autorun'
+require 'minitest/unit'
+require 'minitest/hooks'
+require 'rspec/expectations/minitest_integration'
+
+require_relative '../../helpers/arvm_test_utilities'
+require_relative '../../helpers/arvm_test_models'
+require_relative '../../helpers/viewmodel_spec_helpers'
+
+require 'view_model'
+require 'view_model/active_record'
+
+class ViewModel::ErrorWrappingTest < ActiveSupport::TestCase
+  include ARVMTestUtilities
+  extend Minitest::Spec::DSL
+
+  class Subject
+    include ViewModel::ErrorWrapping
+  end
+
+  let(:subject) { Subject.new }
+
+  describe 'wrap_active_record_errors' do
+    include ViewModelSpecHelpers::ParentAndBelongsToChild
+
+    let(:blame) { ViewModel::Reference.new(viewmodel_class, nil) }
+
+    describe 'RecordInvalid' do
+      before do
+        model_class.send(:validates, :name, inclusion: { in: ['cat'] })
+      end
+
+      it 'wraps the error' do
+        ex = assert_raises(ViewModel::DeserializationError::Validation) do
+          subject.wrap_active_record_errors(blame) do
+            model_class.create!(name: 'a')
+          end
+        end
+
+        expect(ex.attribute).to eq('name')
+        expect(ex.reason).to match(/not included/)
+        expect(ex.details).to include(error: :inclusion)
+      end
+    end
+
+    describe 'StaleObjectError' do
+      def model_attributes
+        super.merge(
+          schema: ->(t) { t.integer :lock_version, default: 0, null: false },
+        )
+      end
+
+      it 'wraps the error' do
+        model = model_class.create!(name: 'a')
+        assert_raises(ViewModel::DeserializationError::LockFailure) do
+          subject.wrap_active_record_errors(blame) do
+            model.name = 'yes'
+            model.lock_version = 10
+            model.save!
+          end
+        end
+      end
+    end
+
+    describe 'transient' do
+      def with_timeout(timeout, conn = ActiveRecord::Base.connection, &block)
+        original_timeout = conn.select_value('SHOW statement_timeout')
+        conn.execute("SET SESSION statement_timeout = #{conn.quote(timeout)}")
+        block.call(conn)
+      ensure
+        begin
+          conn.execute("SET SESSION statement_timeout = #{conn.quote(original_timeout)}")
+        rescue ActiveRecord::StatementInvalid => e
+          raise unless e.cause.is_a?(PG::InFailedSqlTransaction)
+        end
+      end
+
+      it 'wraps the error' do
+        assert_raises(ViewModel::DeserializationError::TransientDatabaseError) do
+          subject.wrap_active_record_errors(blame) do
+            with_timeout(1) do
+              ActiveRecord::Base.connection.execute('SELECT pg_sleep(10)')
+            end
+          end
+        end
+      end
+    end
+
+    describe 'check constraint' do
+      def model_attributes
+        super.merge(
+          schema: ->(t) { t.check_constraint "name = 'cat'" },
+        )
+      end
+
+      it 'wraps the error' do
+        ex = assert_raises(ViewModel::DeserializationError::DatabaseConstraint) do
+          subject.wrap_active_record_errors(blame) do
+            model_class.create!(name: 'a')
+          end
+        end
+
+        expect(ex.message).to match(/violates check constraint/)
+      end
+    end
+
+    describe 'unique constraint' do
+      def model_attributes
+        super.merge(
+          schema: ->(t) { t.index :name, unique: true },
+        )
+      end
+
+      it 'wraps the error' do
+        model_class.create!(name: 'a')
+
+        ex = assert_raises(ViewModel::DeserializationError::UniqueViolation) do
+          subject.wrap_active_record_errors(blame) do
+            model_class.create!(name: 'a')
+          end
+        end
+
+        expect(ex.columns).to eq(['name'])
+      end
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: iknow_view_models
 version: !ruby/object:Gem::Version
-  version: 3.13.0
+  version: 3.14.0
 platform: ruby
 authors:
 - iKnow Team
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-12-17 00:00:00.000000000 Z
+date: 2025-06-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: actionpack
@@ -16,42 +16,42 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '5.0'
+        version: '6.1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '5.0'
+        version: '6.1'
 - !ruby/object:Gem::Dependency
   name: activerecord
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '5.0'
+        version: '6.1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '5.0'
+        version: '6.1'
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '5.0'
+        version: '6.1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '5.0'
+        version: '6.1'
 - !ruby/object:Gem::Dependency
   name: acts_as_manual_list
   requirement: !ruby/object:Gem::Requirement
@@ -392,8 +392,6 @@ files:
 - LICENSE.txt
 - README.md
 - Rakefile
-- gemfiles/rails_5_2.gemfile
-- gemfiles/rails_6_0.gemfile
 - gemfiles/rails_6_1.gemfile
 - gemfiles/rails_7_0.gemfile
 - gemfiles/rails_7_1.gemfile
@@ -433,6 +431,7 @@ files:
 - lib/view_model/deserialize_context.rb
 - lib/view_model/error.rb
 - lib/view_model/error_view.rb
+- lib/view_model/error_wrapping.rb
 - lib/view_model/garbage_collection.rb
 - lib/view_model/migratable_view.rb
 - lib/view_model/migration.rb
@@ -488,6 +487,7 @@ files:
 - test/unit/view_model/callbacks_test.rb
 - test/unit/view_model/controller_test.rb
 - test/unit/view_model/deserialization_error/unique_violation_test.rb
+- test/unit/view_model/error_wrapping_test.rb
 - test/unit/view_model/garbage_collection_test.rb
 - test/unit/view_model/record_test.rb
 - test/unit/view_model/registry_test.rb
@@ -497,7 +497,7 @@ homepage: https://github.com/iknow/cerego_view_models
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -513,7 +513,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubygems_version: 3.1.6
-signing_key: 
+signing_key:
 specification_version: 4
 summary: ViewModels provide a means of encapsulating a collection of related data
   and specifying its JSON serialization.
@@ -550,6 +550,7 @@ test_files:
 - test/unit/view_model/callbacks_test.rb
 - test/unit/view_model/controller_test.rb
 - test/unit/view_model/deserialization_error/unique_violation_test.rb
+- test/unit/view_model/error_wrapping_test.rb
 - test/unit/view_model/garbage_collection_test.rb
 - test/unit/view_model/record_test.rb
 - test/unit/view_model/registry_test.rb

data/gemfiles/rails_5_2.gemfile

@@ -1,10 +0,0 @@
-# This file was generated by Appraisal
-
-source 'https://rubygems.org'
-
-gem 'minitest-ci'
-gem 'activerecord', '~> 5.2.0'
-gem 'activesupport', '~> 5.2.0'
-gem 'actionpack', '~> 5.2.0'
-
-gemspec path: '../'

data/gemfiles/rails_6_0.gemfile

@@ -1,10 +0,0 @@
-# This file was generated by Appraisal
-
-source 'https://rubygems.org'
-
-gem 'minitest-ci'
-gem 'activerecord', '~> 6.0.0'
-gem 'activesupport', '~> 6.0.0'
-gem 'actionpack', '~> 6.0.0'
-
-gemspec path: '../'