iknow_view_models 2.8.10 → 2.9.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 51b9c3c09028c03ae788841cce54fd75bee5c01fa2052a50404c3ae4d65fd1e5
-  data.tar.gz: 46bbee4b8f0c18c29d204af1dd1bf2ab318b7b15ea3df062c861bf13eb7317a2
+  metadata.gz: 53525088a6e3b8f394861ea5326ee235d94eb69a7b49b346ca09f26894e62f38
+  data.tar.gz: e394ad428ee6131d5dcdf7107ca5fea22d23eb41ab6bc6c5ba96626343180f89
 SHA512:
-  metadata.gz: f2d24ad04de38a97931d0f04b7b6ed98756bd8b7c6cb33624bd165b350c138c12f5b6c8ed95ae0e8e1a980295994238056961469f807e40be1e14c0515b983bc
-  data.tar.gz: 10f420fe6acbb77a4285bb17b6598e29a22974b987dc47ea9027bbf5d657d9955439e876d52aa32e47d19342928f482ba4cf9a1ec6bdf2562d4b977d1d19a9cc
+  metadata.gz: 342baae02e08f68f1f4b624c153bb9fd00144f21aef38c5623144899a4554730fd98651411e26528e05f40b16fa51136235ae1831ebc25bb4860904de465aef8
+  data.tar.gz: af565e5b9374ce950178437a16def8cda1b50639d2e98e5c367be5af0cacaff85ddcb7f0fc57a1a4309466e3f682760ae8a213f0ac9ed740eeed4bd9b975736e

data/lib/iknow_view_models/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module IknowViewModels
-  VERSION = '2.8.10'
+  VERSION = '2.9.0'
 end

data/lib/view_model/active_record/cache/cacheable_view.rb

@@ -12,7 +12,17 @@ module ViewModel::ActiveRecord::Cache::CacheableView
   CacheClearer = Struct.new(:cache, :id) do
     include ViewModel::AfterTransactionRunner
 
-    def after_transaction
+    # It's important that we clear the cache before committing, because we rely
+    # on database locking to prevent cache race conditions. We require
+    # reading/refreshing the cache to obtain a FOR SHARE lock, which means that
+    # a reader must wait for a concurrent writer to commit before continuing to
+    # the cache. If the writer cleared the cache after commit, the reader could
+    # obtain old data before the clear, and then save the old data after it.
+    def before_commit
+      cache.delete(id)
+    end
+
+    def after_rollback
       cache.delete(id)
     end
 

data/lib/view_model/after_transaction_runner.rb

@@ -4,16 +4,31 @@
 # `add_to_transaction`, the abstract method `after_transaction` will be invoked
 # by AR's callbacks.
 module ViewModel::AfterTransactionRunner
-  def committed!; end
+  # Rails' internal API
+  def committed!(*)
+    after_commit
+  end
 
   def before_committed!
-    after_transaction
+    before_commit
   end
 
   def rolledback!(*)
-    after_transaction
+    after_rollback
+  end
+
+  def trigger_transactional_callbacks?
+    true
   end
 
+  # Our simplified API
+
+  def before_commit; end
+
+  def after_commit; end
+
+  def after_rollback; end
+
   def add_to_transaction
     if connection.transaction_open?
       connection.add_transaction_record(self)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: iknow_view_models
 version: !ruby/object:Gem::Version
-  version: 2.8.10
+  version: 2.9.0
 platform: ruby
 authors:
 - iKnow Team
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-08-29 00:00:00.000000000 Z
+date: 2019-09-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord