iex-ruby-client 0.3.1 → 0.3.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1595523ca5b890b51b9d49ac27d9def034b3ca5b
-  data.tar.gz: 602da622ca41fa7940fd1045a69d931e66b55faf
+  metadata.gz: 7baa081dbd5a61e40dc8ba2b265d15809327edf6
+  data.tar.gz: b780dbaa9f3a68d24d78b8c3974fbabcf4660295
 SHA512:
-  metadata.gz: 4a02a7bf63c7585adb5ee7a006c6984e524a05aaa23505707a7dd34312c1b2f8997c266270b281b4f00f75b8f9c1a78e4f857863ec324c4152a37829b24594b5
-  data.tar.gz: 0be37668d735d10df0234a8b204c54ff59498be73ff36c7a9147207fa6650fad0c8abac962f80f31f11502830d2d2ac04642c4d4cbb51fafb6d18cee64fc3a67
+  metadata.gz: 98b22f4e83f9f9db5298d1c224da5209b3118f9d8d49900206325fd46064617d71320bc4dc189f1309cd0bc6344adbd6ba2797904ce2414ae828dcdc85c86c31
+  data.tar.gz: 8318da35e7f2ae1fdbe2514dcdd63934238d88132dcc1c3e78decdbde71d44273309a9fcab8fce3615674397823d2552c38bb85a21283b543dad03fd10629ec4

data/.rubocop_todo.yml

@@ -1,16 +1,11 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2018-05-22 16:18:43 -0400 using RuboCop version 0.51.0.
+# on 2018-05-23 18:14:22 -0400 using RuboCop version 0.51.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
-# Offense count: 2
-Lint/AmbiguousOperator:
-  Exclude:
-    - 'spec/iex/resources/quote_spec.rb'
-
 # Offense count: 4
 # Configuration parameters: CountComments, ExcludedMethods.
 Metrics/BlockLength:
@@ -45,23 +40,6 @@ Style/DateTime:
     - 'lib/iex/resources/news.rb'
     - 'spec/iex/resources/news_spec.rb'
 
-# Offense count: 15
+# Offense count: 16
 Style/Documentation:
-  Exclude:
-    - 'spec/**/*'
-    - 'test/**/*'
-    - 'lib/iex/api.rb'
-    - 'lib/iex/api/chart.rb'
-    - 'lib/iex/api/company.rb'
-    - 'lib/iex/api/news.rb'
-    - 'lib/iex/api/price.rb'
-    - 'lib/iex/api/quote.rb'
-    - 'lib/iex/errors/symbol_not_found_error.rb'
-    - 'lib/iex/resources/chart.rb'
-    - 'lib/iex/resources/chart/base.rb'
-    - 'lib/iex/resources/chart/default.rb'
-    - 'lib/iex/resources/chart/one_day.rb'
-    - 'lib/iex/resources/company.rb'
-    - 'lib/iex/resources/news.rb'
-    - 'lib/iex/resources/price.rb'
-    - 'lib/iex/resources/quote.rb'
+  Enabled: false

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+### 0.3.2 (2018/05/26)
+
+* Fix: undefined method > for nil:NilClass error - [@dblock](https://github.com/dblock).
+
 ### 0.3.1 (2018/05/23)
 
 * [#3](https://github.com/dblock/iex-ruby-client/issues/3): Fix: do not error on undefined properties - [@dblock](https://github.com/dblock).

data/lib/iex/resources/quote.rb

@@ -16,12 +16,12 @@ module IEX
       property 'latest_source', from: 'latestSource' # the source of latestPrice - IEX real time price, 15 minute delayed price, Close or Previous close
       property 'latest_time', from: 'latestTime' # human readable time of the latestPrice
       property 'latest_update', from: 'latestUpdate' # the update time of latestPrice in milliseconds since midnight Jan 1, 1970
-      property 'latest_update_t', from: 'latestUpdate', with: ->(v) { Time.at(v / 1000) } # the update time of latestPrice
+      property 'latest_update_t', from: 'latestUpdate', with: ->(v) { v && v > 0 ? Time.at(v / 1000) : nil } # the update time of latestPrice
       property 'latest_volume', from: 'latestVolume' # the total market volume of the stock
       property 'iex_realtime_price', from: 'iexRealtimePrice' # last sale price of the stock on IEX
       property 'iex_realtime_size', from: 'iexRealtimeSize' # last sale size of the stock on IEX
       property 'iex_last_updated', from: 'iexLastUpdated' # last update time of the data in milliseconds since midnight Jan 1, 1970 UTC or -1 or 0; if the value is -1 or 0, IEX has not quoted the symbol in the trading day
-      property 'iex_last_updated_t', from: 'iexLastUpdated', with: ->(v) { v > 0 ? Time.at(v / 1000) : nil } # last update time of the data
+      property 'iex_last_updated_t', from: 'iexLastUpdated', with: ->(v) { v && v > 0 ? Time.at(v / 1000) : nil } # last update time of the data
       property 'delayed_price', from: 'delayedPrice' # 15 minute delayed market price
       property 'delayed_price_time', from: 'delayedPriceTime' # time of the delayed market price
       property 'extended_price', from: 'extendedPrice' # ?
@@ -30,11 +30,13 @@ module IEX
       property 'change' # change in value, calculated using calculation_price from previous_close
       property 'change_percent', from: 'changePercent' # change in percent, calculated using calculation_price from previous_close
       property 'change_percent_s', from: 'changePercent', with: lambda { |v|
-        [
-          v > 0 ? '+' : '',
-          format('%.2f', v * 100),
-          '%'
-        ].join
+        if v
+          [
+            v > 0 ? '+' : '',
+            format('%.2f', v * 100),
+            '%'
+          ].join
+        end
       } # change in percent as a String with a leading + or - sign
       property 'iex_market_percent', from: 'iexMarketPercent' # IEX’s percentage of the market in the stock
       property 'iex_volume', from: 'iexVolume' # shares traded in the stock on IEX

data/lib/iex/resources/resource.rb

@@ -1,6 +1,5 @@
 module IEX
   class Resource < Hashie::Trash
     include Hashie::Extensions::IgnoreUndeclared
-
   end
 end

data/lib/iex/version.rb

@@ -1,3 +1,3 @@
 module IEX
-  VERSION = '0.3.1'.freeze
+  VERSION = '0.3.2'.freeze
 end

data/spec/fixtures/iex/quote/msft.yml

@@ -21,16 +21,16 @@ http_interactions:
       Server:
       - nginx
       Date:
-      - Wed, 23 May 2018 22:04:57 GMT
+      - Sat, 26 May 2018 22:44:50 GMT
       Content-Type:
       - application/json; charset=utf-8
       Content-Length:
-      - '915'
+      - '912'
       Connection:
       - keep-alive
       Set-Cookie:
-      - ctoken=087fe43d41f94d2fa909aef7ec6b84be; Domain=.iextrading.com; Path=/; Expires=Thu,
-        24 May 2018 10:04:57 GMT; Secure
+      - ctoken=b25c6a137426493aa77de4345b947c48; Domain=.iextrading.com; Path=/; Expires=Sun,
+        27 May 2018 10:44:50 GMT; Secure
       Content-Security-Policy:
       - default-src 'self'; child-src 'none'; object-src 'none'; style-src 'self'
         'unsafe-inline'; font-src data:; frame-src 'self'; connect-src 'self' https://auth.iextrading.com
@@ -62,8 +62,8 @@ http_interactions:
     body:
       encoding: UTF-8
       string: '{"symbol":"MSFT","companyName":"Microsoft Corporation","primaryExchange":"Nasdaq
-        Global Select","sector":"Technology","calculationPrice":"close","open":96.68,"openTime":1527082200673,"close":98.66,"closeTime":1527105600450,"high":98.73,"low":96.32,"latestPrice":98.66,"latestSource":"Close","latestTime":"May
-        23, 2018","latestUpdate":1527105600450,"latestVolume":20535596,"iexRealtimePrice":98.68,"iexRealtimeSize":42,"iexLastUpdated":1527105595797,"delayedPrice":98.66,"delayedPriceTime":1527105600450,"extendedPrice":98.56,"extendedChange":-0.1,"extendedChangePercent":-0.00101,"extendedPriceTime":1527109075453,"previousClose":97.5,"change":1.16,"changePercent":0.0119,"iexMarketPercent":0.01326,"iexVolume":272302,"avgTotalVolume":25931612,"iexBidPrice":0,"iexBidSize":0,"iexAskPrice":0,"iexAskSize":0,"marketCap":758024265646,"peRatio":29.19,"week52High":98.69,"week52Low":68.02,"ytdChange":0.1446483288134399}'
+        Global Select","sector":"Technology","calculationPrice":"close","open":98.3,"openTime":1527255000372,"close":98.36,"closeTime":1527278400376,"high":null,"low":null,"latestPrice":98.36,"latestSource":"Close","latestTime":"May
+        25, 2018","latestUpdate":1527278400376,"latestVolume":17944712,"iexRealtimePrice":null,"iexRealtimeSize":null,"iexLastUpdated":null,"delayedPrice":98.36,"delayedPriceTime":1527281515371,"extendedPrice":98.48,"extendedChange":0.12,"extendedChangePercent":0.00122,"extendedPriceTime":1527281940950,"previousClose":98.31,"change":0.05,"changePercent":0.00051,"iexMarketPercent":null,"iexVolume":null,"avgTotalVolume":25656536,"iexBidPrice":null,"iexBidSize":null,"iexAskPrice":null,"iexAskSize":null,"marketCap":755719306395,"peRatio":29.1,"week52High":98.98,"week52Low":68.02,"ytdChange":0.15474471407271742}'
     http_version: 
-  recorded_at: Wed, 23 May 2018 22:04:57 GMT
+  recorded_at: Sat, 26 May 2018 22:44:50 GMT
 recorded_with: VCR 4.0.0

data/spec/iex/resources/quote_spec.rb

@@ -9,21 +9,21 @@ describe IEX::Resources::Quote do
       expect(subject.symbol).to eq 'MSFT'
       expect(subject.primary_exchange).to eq 'Nasdaq Global Select'
       expect(subject.company_name).to eq 'Microsoft Corporation'
-      expect(subject.market_cap).to eq 758_024_265_646
+      expect(subject.market_cap).to eq 755_719_306_395
     end
     it 'coerces numbers' do
-      expect(subject.latest_price).to eq 98.66
-      expect(subject.change).to eq 1.16
-      expect(subject.week_52_high).to eq 98.69
+      expect(subject.latest_price).to eq 98.36
+      expect(subject.change).to eq 0.05
+      expect(subject.week_52_high).to eq 98.98
       expect(subject.week_52_low).to eq 68.02
-      expect(subject.change_percent).to eq 0.0119
-      expect(subject.change_percent_s).to eq '+1.19%'
+      expect(subject.change_percent).to eq 0.00051
+      expect(subject.change_percent_s).to eq '+0.05%'
     end
     it 'coerces times' do
-      expect(subject.latest_update).to eq 1_527_105_600_450
-      expect(subject.latest_update_t).to eq Time.at(1_527_105_600)
-      expect(subject.iex_last_updated).to eq 1_527_105_595_797
-      expect(subject.iex_last_updated_t).to eq Time.at(1_527_105_595)
+      expect(subject.latest_update).to eq 1_527_278_400_376
+      expect(subject.latest_update_t).to eq Time.at(1_527_278_400)
+      expect(subject.iex_last_updated).to be nil
+      expect(subject.iex_last_updated_t).to be nil
     end
   end
   context 'invalid symbol', vcr: { cassette_name: 'quote/invalid' } do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: iex-ruby-client
 version: !ruby/object:Gem::Version
-  version: 0.3.1
+  version: 0.3.2
 platform: ruby
 authors:
 - Daniel Doubrovkine
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-05-23 00:00:00.000000000 Z
+date: 2018-05-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday