ids_please 1.0.0 → 1.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 7779235b8c59f4d9358aa29c286841278d15bf5d
-  data.tar.gz: 7295b6fcadf9aac2394dbd938df565b22078dcab
+  metadata.gz: 8fc61f2173fb750fec7df4b629a7ade28ea6ead0
+  data.tar.gz: a502e562bcf87f2aa198f3a0553e6fd3f07850f5
 SHA512:
-  metadata.gz: 1211b6e2d5f4c70b5d8ddf96d7cf9e94bafe85c01ee5ebd8416b4c03eca139401dc262c955ee43a5cdee9df373726ebb9b8eac40e97ab851a2dc5e352b3dce06
-  data.tar.gz: 890bbc710aabcfefaa89fb3674896f2c024c9bce2e0cc9ef57cb0a0dd9f1e8e9ec8971e271baf09dfe87cf87031a41e332235120ad15fbf8357750ebb7b28312
+  metadata.gz: 1a42ed0c14b29bae3cd13206b9e0baab7181f37d312cd6ce12d6e61e899b25c7c98f1716e718fd61da99a597ed16ddcb7bde30f7768a6d9e63064b1e66ce469a
+  data.tar.gz: 4d83ac5bac217e9f57cc4f273e37af05757e47d702f8809114eedcc0d253b28783c8ba74c37432dc6b3aa763ac6688fe7871fd067a238ca8b2e3ee99b8caf937

data/README.md

@@ -3,7 +3,7 @@
 Get social network IDs or screen names from links to social network accounts.
 
 Sometimes you need to get a social network account name from a link —
-to store a screen name in yor database instead of parsing the link every time,
+to store a screen name in your database instead of parsing the link every time,
 or maybe to work with these accounts using social network APIs (as I do).
 Would be easier to have a library that extracts this kind of information
 from all known social networks for your pleasure.
@@ -29,8 +29,8 @@ This is how you get social IDs from from links:
 ```ruby
 ids = IdsPlease.new('https://twitter.com/gazay', 'http://facebook.com/alexey.gaziev')
 ids.parse
-puts ids.parsed['Twitter']  # => ["gazay"]
-puts ids.parsed['Facebook'] # => ["alexey.gaziev"]
+puts ids.parsed[:twitter]  # => ["gazay"]
+puts ids.parsed[:facebook] # => ["alexey.gaziev"]
 
 puts ids.original           # => ["https://twitter.com/gazay", "http://facebook.com/alexey.gaziev"]
 ```
@@ -40,7 +40,7 @@ Or you can just check that the link is for a known social network:
 ```ruby
 ids = IdsPlease.new('https://twitter.com/gazay', 'http://some-unknown-network.com/gazay')
 ids.recognize
-puts ids.recognized   # => {"Twitter"=>[#<URI::HTTP:0x007fea3bba7e30 URL:http://twitter.com/gazay>]}
+puts ids.recognized   # => {:twitter=>[#<URI::HTTP:0x007fea3bba7e30 URL:http://twitter.com/gazay>]}
 puts ids.unrecognized # => ["http://some-unknown-network.com/gazay"]
 ```
 

data/lib/ids_please/facebook.rb

@@ -4,9 +4,10 @@ class IdsPlease
     MASK = /fb\.me|fb\.com|facebook/i
 
     def self.parse_link(link)
-      if link.query && !link.query.empty?
-        query = CGI.parse(link.query)
-        query['id'].first if query.keys.include?('id')
+      query = CGI.parse(link.query) if link.query && !link.query.empty?
+
+      if query && query['id']
+        query['id'].first
       elsif link.path =~ /\/pages\//
         link.path.split('/').last
       else

data/lib/ids_please/google_plus.rb

@@ -14,11 +14,10 @@ class IdsPlease
     private
 
     def self.parse_link(link)
-      if link.host == 'google.com'
-        link.path.split('/')[1]
-      else
-        matched = link.path.match(/\/(\d{2,})/)
-        matched[1] if matched
+      if matched = link.path.match(/\/\+(\w+)/)
+        matched[1]
+      elsif matched = link.path.match(/\/(\d{2,})/)
+        matched[1]
       end
     end
 

data/lib/ids_please.rb

@@ -14,7 +14,7 @@ require_relative 'ids_please/odnoklassniki'
 
 class IdsPlease
 
-  VERSION = '1.0.0'
+  VERSION = '1.0.1'
 
   attr_accessor :original, :recognized, :unrecognized, :parsed
 

data/spec/ids_please/basic_spec.rb

@@ -10,6 +10,7 @@ describe IdsPlease do
         https://twitter.com/twi_acc
         https://vimeo.com/vimeo_acc
         https://plus.google.com/12341234
+        https://plus.google.com/+VladimirBokov
         https://soundcloud.com/sc_acc
         https://youtube.com/channels/yb_acc
         http://tumblr-acc.tumblr.com
@@ -57,7 +58,7 @@ describe IdsPlease do
       end
 
       it 'get right id from google+ link' do
-        expect(@recognizer.parsed[:google_plus].first).to eq('12341234')
+        expect(@recognizer.parsed[:google_plus]).to eq(['12341234', 'VladimirBokov'])
       end
 
       it 'get right id from soundcloud link' do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ids_please
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.1
 platform: ruby
 authors:
 - gazay
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-04-22 00:00:00.000000000 Z
+date: 2014-04-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake