idrac 0.10.5 → 0.10.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9c4504dd010f1458b9705e73489d4d68ec18214ef13a5a5187dde3ed52812d1a
-  data.tar.gz: eb9ab621e77b1ad17ade9579b4286a7696f7f0bb9dc0761e8862446ee8f39963
+  metadata.gz: fae473e8260d010235ebf86c7ed40b33dae6b7a1c14c2576bce55fecc319c7be
+  data.tar.gz: 8c115aeb8c6399d2d3d167204b160ef691b64ec41570b371912df697b23d9789
 SHA512:
-  metadata.gz: af0824a2ceb96d5c89a2552277d24bdf754eb748a7644d756deb3864620130b005d3f5cefa1f0921d6617fd03aab79c31fd8d9de8b0716a2e3124a8916f1bde4
-  data.tar.gz: 3c85876b2e93b31bed8f8dd4a8ea2ab4ae851048a2767c18e319151b74748c797502971c0932b9e534150c95ce66c3bb9ff93e5194a0d6e37108714724363396
+  metadata.gz: 278b81e8955021924c44c496b0df20c34f59e3630f9df3decda96ee519cadc0445901cddbf3c78c174313c36eef558780ce444fb09f3d870039adc23e7da5056
+  data.tar.gz: c66f192778e2e32cf724b3b98ef45c2311a79ee8f0144e0f95a3106ff1d2d87f67f13c30eac4a47c2055e302bb5b2dc373cf37cfc760ff2566a8f949531db061

data/lib/idrac/firmware.rb

@@ -11,6 +11,8 @@ require_relative 'firmware_catalog'
 require 'faraday'
 require 'faraday/multipart'
 
+require "timeout"
+
 module IDRAC
   class Firmware
     attr_reader :client
@@ -440,6 +442,51 @@ module IDRAC
 
 
 
+    # An iDRAC holds ONE staged package and refuses another while any update job is outstanding
+    # ("503: A deployment operation is already in progress"). Retrying cannot clear it, because
+    # the staged package IS the operation -- the caller has to wait for the slot. Anyone updating
+    # several components in sequence needs this: a straight loop over one R6525's 15 packages
+    # submitted 6 and lost 9 to 503.
+    #
+    # Every rule here is a Dell fact rather than a caller's policy, which is why it belongs in
+    # the gem. Each was a silent stall on real hardware:
+    #
+    #   * "Available-" is a PREFIX, not a substring. The TPM ships an installed entry whose
+    #     version is the literal string "NotAvailable"
+    #     (Installed-12345-NotAvailable__TPM.Integrated.1-1); a substring test matches it and the
+    #     slot then never reads free on that machine.
+    #   * RebootCompleted is TERMINAL, as is anything at PercentComplete 100. Counting a finished
+    #     reboot as active made a drained queue look busy for 67 minutes.
+    #   * Jobs matter, not just the staging slot: triggering an install consumes the staged
+    #     package into a job, so Available empties while the install is still pending.
+    TERMINAL_JOB_STATES = %w[Completed Failed CompletedWithErrors RebootCompleted RebootFailed].freeze
+
+    def update_slot_free?
+      staged = JSON.parse(client.authenticated_request(:get, "/redfish/v1/UpdateService/FirmwareInventory").body)["Members"]
+                   .map { |m| m["@odata.id"].to_s.split("/").last }
+                   .count { |id| id.start_with?("Available-") }
+      busy = JSON.parse(client.authenticated_request(:get, "/redfish/v1/Managers/iDRAC.Embedded.1/Oem/Dell/Jobs?$expand=*($levels=1)").body)["Members"]
+                 .count { |job| !(TERMINAL_JOB_STATES.include?(job["JobState"]) || job["PercentComplete"].to_i == 100) }
+      staged.zero? && busy.zero?
+    end
+
+    # Block until the iDRAC can accept an update. Probes are bounded because a hung transport
+    # blocks without raising, so a bare rescue never fires and the wait wedges silently.
+    def wait_for_update_slot!(timeout: 2700, interval: 30, probe_timeout: 90)
+      deadline = Time.now + timeout
+      loop do
+        begin
+          return true if Timeout.timeout(probe_timeout) { update_slot_free? }
+        rescue StandardError => e
+          # Report rather than counting a probe failure as "busy": an unreachable BMC is
+          # otherwise indistinguishable from a working one, and the caller waits out the timeout.
+          puts "Update slot probe failed (#{e.class}); retrying".yellow
+        end
+        raise Error, "iDRAC update slot never freed within #{timeout}s" if Time.now > deadline
+        sleep interval
+      end
+    end
+
     private
 
     def upload_firmware(firmware_path)

data/lib/idrac/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module IDRAC
-  VERSION = "0.10.5"
+  VERSION = "0.10.6"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: idrac
 version: !ruby/object:Gem::Version
-  version: 0.10.5
+  version: 0.10.6
 platform: ruby
 authors:
 - Jonathan Siegel