idrac 0.1.28 → 0.1.29

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 180bec6c43d2aced138c9479bbbfe23cec04c6149d2cd66343b5a738c0ce479f
-  data.tar.gz: 10fae4fc88a7d1ba456e3f7dc7d2efbfb8c7500b7839e7b59a2e27d5dae53c7c
+  metadata.gz: 6c080d98bd3ca44b9cc006ba66cc443ec410dcfb6bc1b712141720cc82998884
+  data.tar.gz: fe0e09d1e3089c5d354abf6f786624d5afd7dfbcd7b2984d84a72be9936dcf9c
 SHA512:
-  metadata.gz: '0990d968c95f92c2b410b8338c88e8bff464089cc828f9bd49c2fa8bb8111aff7f059fc68d8ff958ccf9c2036af6aebcd2614b96b4ef757bbf93d59f47eecba5'
-  data.tar.gz: bfea9fe661ac565bc5ee652204a927a4c19977abef08bdd51ddf0c79027cc9f40c24d3b21522a9247d8933c22499f99b2bea73be02e0e647f81b42bf7ef2ec53
+  metadata.gz: 479b4ceb21686d4803a3f780f8fe19fcd1741f17cf3b1e24cd0039bd7758688810260dd939fe60cfe07b3b829feefcfbeee4953826f315b65707d2467121fa6c
+  data.tar.gz: 1855a7715e1267c505cc20f9dfd9a9e0665b78ac4db5b06a6984503bb88fb849e7f41b9ebeb68b6e67a70d0b663ea3a6f9b7bbecd1e4c5e194aff198ca9b5238

data/bin/idrac

@@ -12,25 +12,9 @@ require "thor"
 require "idrac"
 
 module IDRAC
-  # Standalone catalog command that doesn't require a host
-  class CatalogCommand < Thor
-    desc "download [DIRECTORY]", "Download Dell firmware catalog"
-    def download(directory = nil)
-      # Create a FirmwareCatalog instance
-      catalog = IDRAC::FirmwareCatalog.new
-      
-      begin
-        catalog_path = catalog.download(directory)
-        puts "Catalog downloaded to: #{catalog_path}"
-      rescue IDRAC::Error => e
-        puts "Error: #{e.message}"
-        exit 1
-      end
-    end
-  end
-
   class CLI < Thor
-    class_option :host, type: :string, required: true, desc: "iDRAC host address"
+    # Make host not required for all commands
+    class_option :host, type: :string, required: false, desc: "iDRAC host address"
     class_option :username, type: :string, required: false, default: "root", desc: "iDRAC username (default: root)"
     class_option :password, type: :string, required: false, default: "calvin", desc: "iDRAC password (default: calvin)"
     class_option :port, type: :numeric, default: 443, desc: "iDRAC port"
@@ -42,6 +26,9 @@ module IDRAC
     method_option :wait, type: :boolean, default: true, desc: "Wait for the update to complete"
     method_option :timeout, type: :numeric, default: 3600, desc: "Timeout in seconds when waiting"
     def firmware_update(path)
+      # Ensure host is provided for commands that need it
+      ensure_host_provided
+      
       check_ssl_verification
       client = create_client
       firmware = IDRAC::Firmware.new(client)
@@ -59,13 +46,25 @@ module IDRAC
     
     desc "firmware:catalog [DIRECTORY]", "Download Dell firmware catalog"
     def firmware_catalog(directory = nil)
-      # Forward to the catalog command
-      CatalogCommand.new.download(directory)
+      # This command doesn't require a host
+      # Create a FirmwareCatalog instance directly
+      catalog = IDRAC::FirmwareCatalog.new
+      
+      begin
+        catalog_path = catalog.download(directory)
+        puts "Catalog downloaded to: #{catalog_path}"
+      rescue IDRAC::Error => e
+        puts "Error: #{e.message}"
+        exit 1
+      end
     end
     
     desc "firmware:status", "Show current firmware status and available updates"
     method_option :catalog, type: :string, desc: "Path to existing catalog file"
     def firmware_status
+      # Ensure host is provided for commands that need it
+      ensure_host_provided
+      
       check_ssl_verification
       client = create_client
       firmware = IDRAC::Firmware.new(client)
@@ -99,7 +98,7 @@ module IDRAC
             puts "No updates available."
           end
         else
-          puts "\nTo check for updates, download the catalog first with 'idrac catalog download'"
+          puts "\nTo check for updates, download the catalog first with 'idrac firmware:catalog'"
         end
       rescue IDRAC::Error => e
         puts "Error: #{e.message}"
@@ -112,6 +111,9 @@ module IDRAC
     desc "firmware:interactive", "Interactive firmware update"
     method_option :catalog, type: :string, desc: "Path to existing catalog file"
     def firmware_interactive
+      # Ensure host is provided for commands that need it
+      ensure_host_provided
+      
       check_ssl_verification
       client = create_client
       firmware = IDRAC::Firmware.new(client)
@@ -134,8 +136,36 @@ module IDRAC
           catalog_path = catalog.download
         end
         
-        firmware.interactive_update(catalog_path)
-      rescue IDRAC::Error => e
+        puts "Starting interactive firmware update. Please note:"
+        puts "- The iDRAC can only process one firmware update at a time"
+        puts "- Updates may take several minutes to complete"
+        puts "- For BIOS updates, a server reboot will be required to apply the update"
+        puts "- If you encounter errors, check the iDRAC web interface for active jobs"
+        puts ""
+        
+        begin
+          firmware.interactive_update(catalog_path)
+        rescue ArgumentError => e
+          puts "Error: #{e.message}"
+          puts "This could be due to an issue with the interactive update process."
+          puts "If you're seeing a 'job ID not found' error, it might be because:"
+          puts "1. The firmware update job wasn't created properly"
+          puts "2. There's already an update in progress"
+          puts "3. The iDRAC needs time to process the previous request"
+          puts "\nTry again in a few minutes or check the iDRAC web interface for active jobs."
+        rescue IDRAC::Error => e
+          if e.message.include?("already in progress")
+            puts "Error: #{e.message}"
+            puts "\nTroubleshooting steps:"
+            puts "1. Check the iDRAC web interface under Maintenance > System Update for active jobs"
+            puts "2. Wait for any existing updates to complete (can take 15-30 minutes)"
+            puts "3. If no updates appear to be in progress, you may need to restart the iDRAC"
+            puts "   (iDRAC web interface > Settings > iDRAC Settings > Reset iDRAC)"
+          else
+            puts "Error: #{e.message}"
+          end
+        end
+      rescue => e
         puts "Error: #{e.message}"
         exit 1
       ensure
@@ -146,6 +176,9 @@ module IDRAC
     desc "screenshot", "Take a screenshot of the current iDRAC console"
     method_option :output, type: :string, desc: "Output filename (default: idrac_screenshot_timestamp.png)"
     def screenshot
+      # Ensure host is provided for commands that need it
+      ensure_host_provided
+      
       check_ssl_verification
       client = create_client
       
@@ -177,6 +210,13 @@ module IDRAC
 
     private
 
+    def ensure_host_provided
+      unless options[:host]
+        puts "Error: No value provided for required option '--host'"
+        exit 1
+      end
+    end
+
     def check_ssl_verification
       # If verify_ssl is not explicitly set in the command line, show a warning
       unless ARGV.include?('--verify-ssl') || ARGV.include?('--no-verify-ssl')
@@ -200,18 +240,5 @@ module IDRAC
   end
 end
 
-# Create a separate CLI class for commands that don't require a host
-module IDRAC
-  class StandaloneCLI < Thor
-    # Register the catalog command
-    desc "catalog", "Download Dell firmware catalog"
-    subcommand "catalog", CatalogCommand
-  end
-end
-
-# Check if the first argument is 'catalog'
-if ARGV[0] == 'catalog'
-  IDRAC::StandaloneCLI.start(ARGV)
-else
-  IDRAC::CLI.start(ARGV)
-end 
+# Start the CLI
+IDRAC::CLI.start(ARGV) 

data/lib/idrac/firmware.rb

@@ -5,6 +5,7 @@ require 'json'
 require 'nokogiri'
 require 'fileutils'
 require 'securerandom'
+require 'set'
 require_relative 'firmware_catalog'
 
 module IDRAC
@@ -129,7 +130,7 @@ module IDRAC
       puts "Searching for updates for model: #{system_model}"
       
       # Find system models in the catalog
-      models = catalog.find_system_models(system_model.split.first)
+      models = catalog.find_system_models(system_model)
       
       if models.empty?
         puts "No matching system model found in catalog"
@@ -150,14 +151,34 @@ module IDRAC
       # Print header for firmware comparison table
       puts "\nFirmware Version Comparison:"
       puts "=" * 100
-      puts "%-30s %-20s %-20s %-10s %-15s %-20s" % ["Component", "Current Version", "Available Version", "Updateable", "Category", "Status"]
+      puts "%-30s %-20s %-20s %-10s %-15s %s" % ["Component", "Current Version", "Available Version", "Updateable", "Category", "Status"]
       puts "-" * 100
       
-      # Process each firmware component
+      # Track components we've already displayed to avoid duplicates
+      displayed_components = Set.new
+      
+      # First show current firmware with available updates
       inventory[:firmware].each do |fw|
-        # Find matching updates in catalog
+        # Make sure firmware name is not nil
+        firmware_name = fw[:name] || ""
+        
+        # Skip if we've already displayed this component
+        next if displayed_components.include?(firmware_name.downcase)
+        displayed_components.add(firmware_name.downcase)
+        
+        # Extract key identifiers from the firmware name
+        identifiers = extract_identifiers(firmware_name)
+        
+        # Try to find a matching update
         matching_updates = catalog_updates.select do |update|
-          catalog.match_component(fw[:name], update[:name])
+          update_name = update[:name] || ""
+          
+          # Check if any of our identifiers match the update name
+          identifiers.any? { |id| update_name.downcase.include?(id.downcase) } ||
+          # Or if the update name contains the firmware name
+          update_name.downcase.include?(firmware_name.downcase) ||
+          # Or if the firmware name contains the update name
+          firmware_name.downcase.include?(update_name.downcase)
         end
         
         if matching_updates.any?
@@ -180,8 +201,8 @@ module IDRAC
             }
             
             # Print row with update available
-            puts "%-30s %-20s %-20s %-10s %-15s %-20s" % [
-              fw[:name][0..29],
+            puts "%-30s %-20s %-20s %-10s %-15s %s" % [
+              fw[:name].to_s[0..29],
               fw[:version],
               update[:version],
               fw[:updateable] ? "Yes" : "No",
@@ -189,20 +210,28 @@ module IDRAC
               "UPDATE AVAILABLE"
             ]
           else
-            # Print row with no update available
-            puts "%-30s %-20s %-20s %-10s %-15s %-20s" % [
-              fw[:name][0..29],
+            # Print row with no update needed
+            status = if !needs_update
+                       "Current"
+                     elsif !fw[:updateable]
+                       "Not updateable"
+                     else
+                       "No update needed"
+                     end
+            
+            puts "%-30s %-20s %-20s %-10s %-15s %s" % [
+              fw[:name].to_s[0..29],
               fw[:version],
               update[:version] || "N/A",
               fw[:updateable] ? "Yes" : "No",
               update[:category] || "N/A",
-              "No update available"
+              status
             ]
           end
         else
           # No matching update found
-          puts "%-30s %-20s %-20s %-10s %-15s %-20s" % [
-            fw[:name][0..29],
+          puts "%-30s %-20s %-20s %-10s %-15s %s" % [
+            fw[:name].to_s[0..29],
             fw[:version],
             "N/A",
             fw[:updateable] ? "Yes" : "No",
@@ -212,11 +241,41 @@ module IDRAC
         end
       end
       
+      # Then show available updates that don't match any current firmware
+      catalog_updates.each do |update|
+        update_name = update[:name] || ""
+        
+        # Skip if we've already displayed this component
+        next if displayed_components.include?(update_name.downcase)
+        displayed_components.add(update_name.downcase)
+        
+        # Skip if this update was already matched to a current firmware
+        next if inventory[:firmware].any? do |fw|
+          firmware_name = fw[:name] || ""
+          identifiers = extract_identifiers(firmware_name)
+          
+          identifiers.any? { |id| update_name.downcase.include?(id.downcase) } ||
+          update_name.downcase.include?(firmware_name.downcase) ||
+          firmware_name.downcase.include?(update_name.downcase)
+        end
+        
+        puts "%-30s %-20s %-20s %-10s %-15s %s" % [
+          update_name.to_s[0..29],
+          "Not Installed",
+          update[:version] || "Unknown",
+          "N/A",
+          update[:category] || "N/A",
+          "NEW COMPONENT"
+        ]
+      end
+      
+      puts "=" * 100
+      
       updates
     end
     
-    def interactive_update(catalog_path = nil)
-      updates = check_updates(catalog_path)
+    def interactive_update(catalog_path = nil, selected_updates = nil)
+      updates = selected_updates || check_updates(catalog_path)
       
       if updates.empty?
         puts "No updates available for your system."
@@ -228,24 +287,30 @@ module IDRAC
         puts "#{index + 1}. #{update[:name]}: #{update[:current_version]} -> #{update[:available_version]}"
       end
       
-      puts "\nEnter the number of the update to install (or 'all' for all updates, 'q' to quit):"
-      choice = STDIN.gets.chomp
-      
-      return if choice.downcase == 'q'
-      
-      selected_updates = if choice.downcase == 'all'
-                          updates
-                        else
-                          index = choice.to_i - 1
-                          if index >= 0 && index < updates.size
-                            [updates[index]]
-                          else
-                            puts "Invalid selection."
-                            return
-                          end
-                        end
+      # If selected_updates is provided, use those directly
+      if selected_updates
+        selected = selected_updates
+      else
+        # Otherwise prompt the user for selection
+        puts "\nEnter the number of the update to install (or 'all' for all updates, 'q' to quit):"
+        choice = STDIN.gets.chomp
+        
+        return if choice.downcase == 'q'
+        
+        selected = if choice.downcase == 'all'
+                      updates
+                    else
+                      index = choice.to_i - 1
+                      if index >= 0 && index < updates.size
+                        [updates[index]]
+                      else
+                        puts "Invalid selection."
+                        return
+                      end
+                    end
+      end
       
-      selected_updates.each do |update|
+      selected.each do |update|
         puts "Downloading #{update[:name]} version #{update[:available_version]}..."
         
         # Create temp directory
@@ -274,8 +339,28 @@ module IDRAC
           end
           
           puts "Installing #{update[:name]} version #{update[:available_version]}..."
-          job_id = update(update_path, wait: true)
-          puts "Update completed with job ID: #{job_id}"
+          
+          begin
+            job_id = update(update_path, wait: true)
+            puts "Update completed with job ID: #{job_id}"
+          rescue IDRAC::Error => e
+            if e.message.include?("already in progress")
+              puts "Error: #{e.message}"
+              puts "\nTips for resolving this issue:"
+              puts "1. Wait for any existing firmware updates to complete (check iDRAC web interface)"
+              puts "2. Restart the iDRAC if no updates appear to be in progress (Settings > iDRAC Settings > Reset iDRAC)"
+              puts "3. Try again after a few minutes"
+            elsif e.message.include?("job ID") || e.message.include?("job not found")
+              puts "Error: #{e.message}"
+              puts "\nThe job ID could not be found or monitored. This could be because:"
+              puts "1. The iDRAC is busy processing other requests"
+              puts "2. The job was created but not properly tracked"
+              puts "3. The iDRAC firmware may need to be updated first"
+              puts "\nCheck the iDRAC web interface to see if the update was actually initiated."
+            else
+              puts "Error during firmware update: #{e.message}"
+            end
+          end
           
         ensure
           # Clean up temp directory
@@ -323,28 +408,103 @@ module IDRAC
       post_body << "\r\n--#{boundary}--\r\n"
       
       # Upload the firmware
-      response = client.authenticated_request(
+      begin
+        response = client.authenticated_request(
+          :post,
+          http_push_uri,
+          {
+            headers: {
+              'Content-Type' => "multipart/form-data; boundary=#{boundary}",
+              'If-Match' => etag
+            },
+            body: post_body.join
+          }
+        )
+      rescue => e
+        # Check if the error is about a deployment already in progress
+        if e.message.include?("A deployment or update operation is already in progress")
+          raise Error, "A firmware update is already in progress on the iDRAC. Please wait for it to complete before starting another update. You can check the status in the iDRAC web interface under Maintenance > System Update."
+        else
+          # Re-raise the original error
+          raise
+        end
+      end
+      
+      if response.status < 200 || response.status >= 300
+        error_message = response.body.to_s
+        
+        # Check for specific error messages in the response
+        if error_message.include?("A deployment or update operation is already in progress")
+          raise Error, "A firmware update is already in progress on the iDRAC. Please wait for it to complete before starting another update. You can check the status in the iDRAC web interface under Maintenance > System Update."
+        elsif error_message.include?("SUP0108")
+          raise Error, "iDRAC Error SUP0108: A deployment or update operation is already in progress. Wait for the operation to conclude and then try again."
+        else
+          raise Error, "Firmware upload failed with status #{response.status}: #{response.body}"
+        end
+      end
+      
+      # Extract upload ID from response
+      response_data = JSON.parse(response.body)
+      upload_id = response_data['Id'] || response_data['TaskId']
+      
+      if upload_id.nil?
+        raise Error, "Failed to extract upload ID from firmware upload response"
+      end
+      
+      puts "Firmware file uploaded successfully with ID: #{upload_id}"
+      
+      # Step 2: Initiate the firmware update using SimpleUpdate
+      puts "Initiating firmware update using SimpleUpdate..."
+      
+      # Construct the image URI using the uploaded file
+      image_uri = "#{http_push_uri}/#{upload_id}"
+      puts "Using ImageURI: #{image_uri}"
+      
+      # Call the SimpleUpdate action
+      simple_update_response = client.authenticated_request(
         :post,
-        http_push_uri,
+        "/redfish/v1/UpdateService/Actions/UpdateService.SimpleUpdate",
         {
           headers: {
-            'Content-Type' => "multipart/form-data; boundary=#{boundary}",
-            'If-Match' => etag
+            'Content-Type' => 'application/json'
           },
-          body: post_body.join
+          body: JSON.generate({
+            'ImageURI' => image_uri,
+            '@Redfish.OperationApplyTime' => 'Immediate'
+          })
         }
       )
       
-      if response.status < 200 || response.status >= 300
-        raise Error, "Firmware upload failed with status #{response.status}: #{response.body}"
+      if simple_update_response.status < 200 || simple_update_response.status >= 300
+        raise Error, "Firmware update initiation failed with status #{simple_update_response.status}: #{simple_update_response.body}"
       end
       
       # Extract job ID from response
-      response_data = JSON.parse(response.body)
-      job_id = response_data['Id'] || response_data['TaskId']
+      job_id = nil
+      
+      # Try to get job ID from Location header
+      if simple_update_response.headers['location']
+        job_id = simple_update_response.headers['location'].split('/').last
+      end
       
+      # If not found in header, try to get from response body
+      if job_id.nil? && !simple_update_response.body.empty?
+        begin
+          update_data = JSON.parse(simple_update_response.body)
+          if update_data['@odata.id']
+            job_id = update_data['@odata.id'].split('/').last
+          elsif update_data['Id']
+            job_id = update_data['Id']
+          end
+        rescue JSON::ParserError
+          # Not JSON, ignore
+        end
+      end
+      
+      # If still no job ID, use the upload ID as a fallback
       if job_id.nil?
-        raise Error, "Failed to extract job ID from firmware upload response"
+        job_id = upload_id
+        puts "No job ID found in SimpleUpdate response, using upload ID as job ID"
       end
       
       puts "Firmware update job created with ID: #{job_id}"
@@ -392,5 +552,54 @@ module IDRAC
       response_data = JSON.parse(response.body)
       response_data['TaskState'] || 'Unknown'
     end
+
+    # Helper method to extract identifiers from component names
+    def extract_identifiers(name)
+      return [] unless name
+      
+      identifiers = []
+      
+      # Extract model numbers like X520, I350, etc.
+      model_matches = name.scan(/[IX]\d{3,4}/)
+      identifiers.concat(model_matches)
+      
+      # Extract PERC model like H730
+      perc_matches = name.scan(/[HP]\d{3,4}/)
+      identifiers.concat(perc_matches)
+      
+      # Extract other common identifiers
+      if name.include?("NIC") || name.include?("Ethernet") || name.include?("Network")
+        identifiers << "NIC"
+      end
+      
+      if name.include?("PERC") || name.include?("RAID")
+        identifiers << "PERC"
+        # Extract PERC model like H730
+        perc_match = name.match(/PERC\s+([A-Z]\d{3})/)
+        identifiers << perc_match[1] if perc_match
+      end
+      
+      if name.include?("BIOS")
+        identifiers << "BIOS"
+      end
+      
+      if name.include?("iDRAC") || name.include?("IDRAC") || name.include?("Remote Access Controller")
+        identifiers << "iDRAC"
+      end
+      
+      if name.include?("Power Supply") || name.include?("PSU")
+        identifiers << "PSU"
+      end
+      
+      if name.include?("Lifecycle Controller")
+        identifiers << "LC"
+      end
+      
+      if name.include?("CPLD")
+        identifiers << "CPLD"
+      end
+      
+      identifiers
+    end
   end
 end 

data/lib/idrac/firmware_catalog.rb

@@ -62,59 +62,130 @@ module IDRAC
       doc = parse
       models = []
       
-      # Extract just the model number for PowerEdge servers (e.g., R640 from PowerEdge R640)
+      # Extract model code from full model name (e.g., "PowerEdge R640" -> "R640")
       model_code = nil
       if model_name.include?("PowerEdge")
         model_code = model_name.split.last
+      else
+        model_code = model_name
       end
       
+      puts "Searching for model: #{model_name} (code: #{model_code})"
+      
+      # Build a mapping of model names to system IDs
+      model_to_system_id = {}
+      
       doc.xpath('//SupportedSystems/Brand/Model').each do |model|
+        system_id = model['systemID'] || model['id']
         name = model.at_xpath('Display')&.text
         code = model.at_xpath('Code')&.text
         
-        # Try to match by full name
-        if name && name.downcase.include?(model_name.downcase)
-          models << {
-            name: name,
-            code: code,
-            id: model['id']
-          }
-        # Try to match by model code (e.g., R640)
-        elsif model_code && code && code.downcase == model_code.downcase
-          models << {
+        if name && system_id
+          model_to_system_id[name] = {
             name: name,
             code: code,
-            id: model['id']
+            id: system_id
           }
+          
+          # Also map just the model number (R640, etc.)
+          if name =~ /[RT]\d+/
+            model_short = name.match(/([RT]\d+\w*)/)[1]
+            model_to_system_id[model_short] = {
+              name: name,
+              code: code,
+              id: system_id
+            }
+          end
+        end
+      end
+      
+      # Try exact match first
+      if model_to_system_id[model_name]
+        models << model_to_system_id[model_name]
+      end
+      
+      # Try model code match
+      if model_to_system_id[model_code]
+        models << model_to_system_id[model_code]
+      end
+      
+      # If we still don't have a match, try a more flexible approach
+      if models.empty?
+        model_to_system_id.each do |name, model_info|
+          if name.include?(model_code) || model_code.include?(name)
+            models << model_info
+          end
+        end
+      end
+      
+      # If still no match, try matching by systemID directly
+      if models.empty?
+        doc.xpath('//SupportedSystems/Brand/Model').each do |model|
+          system_id = model['systemID'] || model['id']
+          name = model.at_xpath('Display')&.text
+          code = model.at_xpath('Code')&.text
+          
+          if code && code.downcase == model_code.downcase
+            models << {
+              name: name,
+              code: code,
+              id: system_id
+            }
+          end
         end
       end
       
-      models
+      models.uniq { |m| m[:id] }
     end
     
     def find_updates_for_system(system_id)
       doc = parse
       updates = []
       
-      doc.xpath("//SoftwareComponent[SupportedSystems/Brand/Model[@id='#{system_id}']]").each do |component|
-        name = component.at_xpath('Name')&.text
-        version = component.at_xpath('Version')&.text
-        path = component.at_xpath('Path')&.text
-        component_type = component.at_xpath('ComponentType')&.text
-        category = component.at_xpath('Category')&.text
+      # Find all SoftwareComponents
+      doc.xpath("//SoftwareComponent").each do |component|
+        # Check if this component supports our system ID
+        supported_system_ids = component.xpath(".//SupportedSystems/Brand/Model/@systemID | .//SupportedSystems/Brand/Model/@id").map(&:value)
+        
+        next unless supported_system_ids.include?(system_id)
+        
+        # Get component details
+        name_node = component.xpath("./Name/Display[@lang='en']").first
+        name = name_node ? name_node.text.strip : ""
         
-        next unless name && version && path
+        component_type_node = component.xpath("./ComponentType/Display[@lang='en']").first
+        component_type = component_type_node ? component_type_node.text.strip : ""
         
-        updates << {
-          name: name,
-          version: version,
-          path: path,
-          component_type: component_type,
-          category: category,
-          download_url: "https://downloads.dell.com/#{path}"
-        }
+        path = component['path'] || ""
+        category_node = component.xpath("./Category/Display[@lang='en']").first
+        category = category_node ? category_node.text.strip : ""
+        
+        version = component['dellVersion'] || component['vendorVersion'] || ""
+        
+        # Skip if missing essential information
+        next if name.empty? || path.empty? || version.empty?
+        
+        # Only include firmware updates
+        if component_type.include?("Firmware") ||
+           category.include?("BIOS") ||
+           category.include?("Firmware") ||
+           category.include?("iDRAC") ||
+           name.include?("BIOS") ||
+           name.include?("Firmware") ||
+           name.include?("iDRAC")
+          
+          updates << {
+            name: name,
+            version: version,
+            path: path,
+            component_type: component_type,
+            category: category,
+            download_url: "https://downloads.dell.com/#{path}"
+          }
+        end
       end
       
+      puts "Found #{updates.size} firmware updates for system ID #{system_id}"
       updates
     end
     

data/lib/idrac/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module IDRAC
-  VERSION = "0.1.28"
+  VERSION = "0.1.29"
 end

data/test_firmware_update.rb

@@ -0,0 +1,70 @@
+#!/usr/bin/env ruby
+
+require_relative 'lib/idrac'
+
+# Create a client
+client = IDRAC::Client.new(
+  host: '127.0.0.1',
+  username: 'root',
+  password: 'calvin',
+  verify_ssl: false
+)
+
+begin
+  # Login to iDRAC
+  client.login
+  puts "Logged in successfully"
+  
+  # Create a firmware instance
+  firmware = IDRAC::Firmware.new(client)
+  
+  # Get system inventory
+  puts "Getting system inventory..."
+  inventory = firmware.get_system_inventory
+  
+  puts "System Information:"
+  puts "  Model: #{inventory[:system][:model]}"
+  puts "  Manufacturer: #{inventory[:system][:manufacturer]}"
+  puts "  Service Tag: #{inventory[:system][:service_tag]}"
+  puts "  BIOS Version: #{inventory[:system][:bios_version]}"
+  
+  puts "\nInstalled Firmware:"
+  inventory[:firmware].each do |fw|
+    puts "  #{fw[:name]}: #{fw[:version]} (#{fw[:updateable] ? 'Updateable' : 'Not Updateable'})"
+  end
+  
+  # Check for updates
+  catalog_path = File.expand_path("~/.idrac/Catalog.xml")
+  if File.exist?(catalog_path)
+    puts "\nChecking for updates using catalog: #{catalog_path}"
+    updates = firmware.check_updates(catalog_path)
+    
+    if updates.empty?
+      puts "No updates available."
+    else
+      puts "\nAvailable Updates:"
+      updates.each_with_index do |update, index|
+        puts "#{index + 1}. #{update[:name]}: #{update[:current_version]} -> #{update[:available_version]}"
+      end
+      
+      # For testing, select the first update
+      if updates.any?
+        selected_update = updates.first
+        puts "\nSelected update: #{selected_update[:name]}: #{selected_update[:current_version]} -> #{selected_update[:available_version]}"
+        
+        # Download and install the update
+        puts "Starting interactive update for selected component..."
+        firmware.interactive_update(catalog_path, [selected_update])
+      end
+    end
+  else
+    puts "\nCatalog file not found at #{catalog_path}. Please download the catalog first."
+  end
+  
+rescue IDRAC::Error => e
+  puts "Error: #{e.message}"
+ensure
+  # Logout
+  client.logout if client.instance_variable_get(:@session_id)
+  puts "Logged out"
+end 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: idrac
 version: !ruby/object:Gem::Version
-  version: 0.1.28
+  version: 0.1.29
 platform: ruby
 authors:
 - Jonathan Siegel
@@ -215,6 +215,7 @@ files:
 - lib/idrac/screenshot.rb
 - lib/idrac/version.rb
 - sig/idrac.rbs
+- test_firmware_update.rb
 homepage: http://github.com
 licenses:
 - MIT