idrac 0.1.23 → 0.1.24

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 19bd4d4dbb2b3c79b0b35e70067284d0b6c38dd548f37eabe2b1102b11dd8782
-  data.tar.gz: 0555e28ccfedbbdfe5e100c23700ae2dc8cab849b806baf739de7a1d6fbd6d66
+  metadata.gz: f2e790b22ca375a798916fdb6d908583d2fa4823e90a814c2e7c27796c7b6351
+  data.tar.gz: 0ab7103ae540892dc959d22c7fa646050fe8eeaf003f6dc538c753fc3d614452
 SHA512:
-  metadata.gz: dec9acadc7a50d101322f111b4522aa886547c92e8c8d089a7811527e4be43227c7116c62b9c2b199424427ecb95ea75604160f5d728142fe14d5c78302668f0
-  data.tar.gz: 82b726d07aa328830a9a58292542712b0075b2865de7df56a1a2f161094a50762aed2b2f3aab80e835474f729a2ebbc131b452467607cbcb2bbcb70345baf61b
+  metadata.gz: 89b75cdaf04c90368379af12884e55dcd4e5daa52ccda59143776934c871a60c039891a13194a52496532159bad0859f3b8502fe2f8beeaf433319ba1d5aa0e1
+  data.tar.gz: 6dee9f26c047f9931ea846e2eaf738f91510801fdb090c384d18fd76639ca098db11ca071acb55ab81a0c319bb42ecb781d33f71ed83c66c9dac22c58c8bf2c6

data/README.md

@@ -127,6 +127,14 @@ To install this gem onto your local machine, run `bundle exec rake install`. To
 
 ## Changelog
 
+### Version 0.1.24
+- **Improved Firmware Update Check**: Fixed issues with firmware version comparison
+- Eliminated duplicate entries in firmware update results
+- Improved matching logic between installed firmware and catalog entries
+- Added proper handling of BIOS updates
+- Fixed missing version information in update output
+- Enhanced name comparison with case-insensitive matching
+
 ### Version 0.1.23
 - **Fixed Duplicate Messages**: Removed duplicate "Retrieving system inventory..." message in firmware:status command
 - The message was appearing twice because it was being printed by both the CLI class and the Firmware class

data/lib/idrac/firmware.rb

@@ -153,7 +153,12 @@ module IDRAC
       # Get current firmware versions
       current_versions = {}
       inventory[:firmware].each do |fw|
-        current_versions[fw[:name]] = fw[:version]
+        # Use the ID as the key to avoid duplicates
+        current_versions[fw[:id]] = {
+          name: fw[:name],
+          version: fw[:version],
+          updateable: fw[:updateable]
+        }
       end
       
       # Find matching components in catalog
@@ -163,21 +168,37 @@ module IDRAC
         path = component.at_xpath('Path')&.text
         component_type = component.at_xpath('ComponentType')&.text
         
+        next unless name && version && path # Skip if missing essential data
+        
         # Check if this component matches any of our firmware
-        inventory[:firmware].each do |fw|
-          if fw[:name].include?(name) || name.include?(fw[:name])
-            current_version = fw[:version]
+        # We'll track if we found a match to avoid duplicates
+        matched = false
+        
+        current_versions.each do |id, fw_info|
+          # Normalize names for comparison
+          catalog_name = name.downcase.strip
+          firmware_name = fw_info[:name].downcase.strip
+          
+          # Check if names match or contain each other
+          if catalog_name.include?(firmware_name) || firmware_name.include?(catalog_name) ||
+             (catalog_name.include?("bios") && firmware_name.include?("bios"))
+            
+            # Skip if already matched to avoid duplicates
+            next if matched
             
-            # Simple version comparison (this could be improved)
-            if version != current_version
+            # Compare versions
+            if version != fw_info[:version] && fw_info[:updateable]
               updates << {
                 name: name,
-                current_version: current_version,
+                current_version: fw_info[:version],
                 available_version: version,
                 path: path,
                 component_type: component_type,
                 download_url: "https://downloads.dell.com/#{path}"
               }
+              
+              # Mark as matched to avoid duplicates
+              matched = true
             end
           end
         end

data/lib/idrac/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module IDRAC
-  VERSION = "0.1.23"
+  VERSION = "0.1.24"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: idrac
 version: !ruby/object:Gem::Version
-  version: 0.1.23
+  version: 0.1.24
 platform: ruby
 authors:
 - Jonathan Siegel