idnow 2.3.0 → 2.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3caa1be49888278cacbd44efe6daaccaca538b747312243f55c4b529f4b060da
-  data.tar.gz: 9fdd7352d6dc258acbc7c36e1697eee0865791146390c530bc75476933da6aec
+  metadata.gz: 6de30eb89edb8583c59fc39909c4f8e2d85038a43a52586892f7b84b13c692a9
+  data.tar.gz: 4dd0371f8e80b4a41ff3f9bda3a1132a00cd08a384c17ee92ee3b908d95a91c3
 SHA512:
-  metadata.gz: f3a64af1fd998df4db251c4ddf6d7b728e759024d4f9174fb3817c30c598234bcd0589f118d36fdf062ff86fad813dda5c1b825d0ae0f582cd3cb1acef7a5fb9
-  data.tar.gz: 9e355e9c36dbdab33c17b8715f9a36b11c3e985bc6370eada59ed034eb198d0d88f230003a668698bafc1567a6e648007f6f5b5e84f49ca06c0b0f621beb16b1
+  metadata.gz: 1c50ec5fb86201da528a5ac186519dac8dbba252b2c15672ce4293d26cb240b16a415e4e0053c5b19dcedaf7507cc89a41a78eef94bc97fa553e0d7a0065e754
+  data.tar.gz: 472f48eb394d6ba897f7cd27bdb5466a722d7e3704a8eafe82079586220ec805fd3514cec6512a6e1065e713e85a80332d6f8869a00467b7ddd620f8c47e2498

data/.github/workflows/build-release.yml

@@ -0,0 +1,93 @@
+name: Build and release gem
+
+on:
+  release:
+    types:
+      - published
+
+env:
+  GEM_NAME: idnow
+  RUBY_VERSION: 3.1.2
+  VERSION: ${{github.event.release.tag_name}}
+
+jobs:
+  validate_tag:
+    runs-on: ubuntu-latest
+    steps:
+      - name: 'Validate tag pattern: ${{ env.VERSION }}'
+        run: |
+          if [[ $VERSION =~ v[0-9]+\.[0-9]+\.[0-9]+ ]]; then
+            echo "Valid tagname, continue release"
+          else
+            echo "Invalid tagname, needs doesn't follow pattern: v<Semver>"
+            exit 1
+          fi
+        env:
+          VERSION: ${{env.VERSION}}
+
+  build:
+    name: Build gem
+    needs: validate_tag
+    runs-on: ubuntu-latest
+    permissions:
+      contents: read
+    steps:
+    - uses: actions/checkout@v2
+
+    - uses: ruby/setup-ruby@v1
+      with:
+        ruby-version: ${{env.RUBY_VERSION}}
+
+    - name: Build ${{env.VERSION}}
+      run: |
+        gem build $GEM_NAME.gemspec
+
+    - uses: actions/upload-artifact@v3
+      with:
+        name: ${{env.GEM_NAME}}-${{env.VERSION}}
+        path: '*.gem'
+
+  publish:
+    name: Publish to RubyGems.org
+    needs: build
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/download-artifact@v3
+      with:
+        name: ${{env.GEM_NAME}}-${{env.VERSION}}
+
+    - uses: ruby/setup-ruby@v1
+      with:
+        ruby-version: ${{env.RUBY_VERSION}}
+
+    - name: Publish ${{env.VERSION}}
+      run: |
+        gem push $GEM_NAME-${VERSION:1}.gem
+      env:
+        GEM_HOST_API_KEY: ${{secrets.RUBYGEMS_AUTH_TOKEN}}
+        GEM_NAME: ${{env.GEM_NAME}}
+        VERSION: ${{env.VERSION}}
+
+  publish_gpr:
+    name: Publish to GitHub Packages
+    needs: publish
+    runs-on: ubuntu-latest
+    permissions:
+      packages: write
+    steps:
+    - uses: actions/download-artifact@v3
+      with:
+        name: ${{env.GEM_NAME}}-${{env.VERSION}}
+
+    - uses: ruby/setup-ruby@v1
+      with:
+        ruby-version: ${{env.RUBY_VERSION}}
+
+    - name: Publish ${{env.VERSION}}
+      run: |
+        gem push $GEM_NAME-${VERSION:1}.gem
+      env:
+        GEM_HOST_API_KEY: Bearer ${{secrets.GITHUB_TOKEN}}
+        RUBYGEMS_HOST: https://rubygems.pkg.github.com/${{github.repository_owner}}
+        GEM_NAME: ${{env.GEM_NAME}}
+        VERSION: ${{env.VERSION}}

data/.github/workflows/lint-test-build.yml

@@ -0,0 +1,39 @@
+name: Lint, test & build gem
+
+on:
+  push:
+    branches:
+      - main
+
+  pull_request:
+
+jobs:
+  lint-test-build:
+    runs-on: ubuntu-latest
+    name: Ruby ${{ matrix.ruby }}
+    strategy:
+      matrix:
+        ruby:
+          - '2.7.6'
+          - '3.1.2'
+
+    steps:
+    - uses: actions/checkout@v2
+
+    - name: Set up Ruby
+      uses: ruby/setup-ruby@v1
+      with:
+        ruby-version: ${{ matrix.ruby }}
+        bundler-cache: true
+
+    - name: Install dependencies
+      run: bundle
+
+    - name: Run linter
+      run: bundle exec rubocop
+
+    - name: Run tests
+      run: bundle exec rspec
+
+    - name: Build gem
+      run: gem build *.gemspec

data/.gitignore

@@ -11,3 +11,4 @@
 /tmp/
 tags
 .*.sw?
+*.gem

data/.rubocop.yml

@@ -1,6 +1,6 @@
 AllCops:
   DisplayCopNames: true
-  TargetRubyVersion: 2.5
+  TargetRubyVersion: 2.7
   NewCops: enable
 
 # This configuration was generated by
@@ -14,7 +14,7 @@ AllCops:
 # Offense count: 8
 # Configuration parameters: AllowHeredoc, AllowURI, URISchemes.
 # URISchemes: http, https
-Metrics/LineLength:
+Layout/LineLength:
   Max: 140
 
 Metrics/MethodLength:

data/Dockerfile

@@ -1,9 +1,9 @@
-FROM ruby:2.5
+FROM ruby:2.7
 
 RUN mkdir /gem
 WORKDIR /gem
 
-COPY Gemfile idnow-client.gemspec /gem/
+COPY Gemfile *.lock idnow-client.gemspec /gem/
 RUN bundle install
 
 COPY . /gem/

data/LICENSE.txt

@@ -1,6 +1,6 @@
 The MIT License (MIT)
 
-Copyright (c) 2016 solarisBank AG
+Copyright (c) 2016 Solarisbank AG
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal

data/README.md

@@ -1,6 +1,8 @@
 # Idnow Client
 
-Library to consume the [IDnow API](http://www.idnow.eu/developers) in Ruby. [![Build Status](https://travis-ci.com/Solarisbank/idnow-client.svg?branch=master)](https://travis-ci.com/Solarisbank/idnow-client)
+[![Gem Version](https://badge.fury.io/rb/idnow.svg)](https://badge.fury.io/rb/idnow)
+
+Library to consume the [IDnow API](http://www.idnow.eu/developers) in Ruby.
 
 ## Installation
 
@@ -114,8 +116,11 @@ Idnow.client.list_identifications(status: 'pending')
 # keep in mind that it might take a while until the identification is completed.
 Idnow.client.get_identification(transaction_number: transaction_number)
 
-# Download identification files
+# Download identification file via SFTP
 Idnow.client.download_identification(transaction_number: transaction_number)
+
+# Get identification file via HTTP
+Idnow.client.get_identification_file(transaction_number: transaction_number)
 ```
 
 #### Esigning

data/examples/idnow_automated_testing.rb

@@ -33,5 +33,5 @@ puts "\n\n"
 puts '--- Testing video chat---'
 Idnow.client.testing_request_video_chat(transaction_number: transaction_number)
 
-puts 'It might take a while until the identification is marked as successfull,' \
-     ' wait a little bit and then run idnow_get_identification.rb script'
+puts 'It might take a while until the identification is marked as successfull, ' \
+     'wait a little bit and then run idnow_get_identification.rb script'

data/{idnow-client.gemspec → idnow.gemspec}

@@ -2,15 +2,13 @@
 
 Gem::Specification.new do |spec|
   spec.name          = 'idnow'
-  spec.version       = '2.3.0'
+  spec.version       = '2.4.0'
   spec.authors       = ['Joan Martinez, Tobias Bielohlawek']
-  spec.email         = ['joan.martinez@solarisbank.de']
+  spec.email         = ['developers@solarisbank.de']
 
   spec.summary       = 'Ruby client for the IDnow API'
   spec.description   = 'Library to consume the IDnow API in Ruby, http://www.idnow.eu/developers'
 
-  raise 'RubyGems 2.0 or newer is required to protect against public gem pushes.' unless spec.respond_to?(:metadata)
-
   spec.homepage      = 'https://github.com/solarisBank/idnow-client'
   spec.license       = 'MIT'
 
@@ -19,9 +17,9 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ['lib']
 
-  spec.add_runtime_dependency 'net-sftp', '~>2.1'
+  spec.required_ruby_version = '>= 2.7'
 
-  spec.required_ruby_version = '>= 2.5', '< 3.1'
+  spec.add_runtime_dependency 'net-sftp', '~>2.1'
 
   spec.add_development_dependency 'factory_bot'
   spec.add_development_dependency 'rspec'
@@ -29,4 +27,5 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'shoulda-matchers'
   spec.add_development_dependency 'simplecov'
   spec.add_development_dependency 'webmock'
+  spec.metadata['rubygems_mfa_required'] = 'true'
 end

data/lib/idnow/API/retrieve_identifications.rb

@@ -30,6 +30,14 @@ module Idnow
         Idnow::Identification.new(response.data)
       end
 
+      def get_identification_file(transaction_number:)
+        raise Idnow::AuthenticationException if @auth_token.nil?
+
+        path = full_path_for("identifications/#{transaction_number}.zip")
+        request = Idnow::GetRequest.new(path, '')
+        execute(request, { 'X-API-LOGIN-TOKEN' => @auth_token })
+      end
+
       def download_identification(transaction_number:)
         path = "#{transaction_number}.zip"
         @sftp_client.download(path)

data/lib/idnow/json_response.rb

@@ -6,7 +6,7 @@ module Idnow
 
     def initialize(raw_response)
       super
-      raw_response = raw_response == '' ? '{}' : raw_response
+      raw_response = '{}' if raw_response == ''
       @data = JSON.parse(raw_response)
     end
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: idnow
 version: !ruby/object:Gem::Version
-  version: 2.3.0
+  version: 2.4.0
 platform: ruby
 authors:
 - Joan Martinez, Tobias Bielohlawek
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2021-06-25 00:00:00.000000000 Z
+date: 2022-07-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: net-sftp
@@ -110,16 +110,16 @@ dependencies:
         version: '0'
 description: Library to consume the IDnow API in Ruby, http://www.idnow.eu/developers
 email:
-- joan.martinez@solarisbank.de
+- developers@solarisbank.de
 executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- ".github/workflows/gem-push.yml"
+- ".github/workflows/build-release.yml"
+- ".github/workflows/lint-test-build.yml"
 - ".gitignore"
 - ".rspec"
 - ".rubocop.yml"
-- ".travis.yml"
 - CODE_OF_CONDUCT.md
 - Dockerfile
 - Gemfile
@@ -131,7 +131,7 @@ files:
 - examples/idnow_download_identification.rb
 - examples/idnow_get_identification.rb
 - examples/idnow_upload_download_default_document.rb
-- idnow-client.gemspec
+- idnow.gemspec
 - lib/idnow.rb
 - lib/idnow/API/authentication.rb
 - lib/idnow/API/automated_testing.rb
@@ -165,7 +165,8 @@ files:
 homepage: https://github.com/solarisBank/idnow-client
 licenses:
 - MIT
-metadata: {}
+metadata:
+  rubygems_mfa_required: 'true'
 post_install_message: 
 rdoc_options: []
 require_paths:
@@ -174,17 +175,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '2.5'
-  - - "<"
-    - !ruby/object:Gem::Version
-      version: '3.1'
+      version: '2.7'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
+rubygems_version: 3.3.7
 signing_key: 
 specification_version: 4
 summary: Ruby client for the IDnow API

data/.github/workflows/gem-push.yml

@@ -1,67 +0,0 @@
-name: Ruby Gem
-
-on:
-  workflow_dispatch:
-
-jobs:
-  build:
-    name: Build
-    runs-on: ubuntu-latest
-    permissions:
-      contents: read
-      packages: write
-
-    steps:
-    - uses: actions/checkout@v2
-    - name: Set up Ruby 2.5
-      uses: actions/setup-ruby@v1
-      with:
-        ruby-version: 2.5.x
-
-    - name: Build gem
-      run: |
-        gem build *.gemspec
-    - name: Upload gem
-      uses: actions/upload-artifact@v2
-      with:
-        name: idnow-client.gem
-        path: "*.gem"
-
-  publish:
-    name: Publish RubyGems
-    needs: build
-    runs-on: ubuntu-latest
-    steps:
-    - uses: actions/download-artifact@v2
-      with:
-        name: idnow-client.gem
-    - name: Set up Ruby 2.5
-      uses: actions/setup-ruby@v1
-      with:
-        ruby-version: 2.5.x
-    - name: Publish to RubyGems
-      run: gem push *.gem
-      env:
-        GEM_HOST_API_KEY: ${{secrets.RUBYGEMS_AUTH_TOKEN}}
-
-  publish_gpr:
-    name: Publish GPR
-    needs: build
-    runs-on: ubuntu-latest
-    steps:
-    - uses: actions/download-artifact@v2
-      with:
-        name: idnow-client.gem
-    - name: Set up Ruby 2.5
-      uses: actions/setup-ruby@v1
-      with:
-        ruby-version: 2.5.x
-    - name: Publish to GPR
-      run: |
-        mv *.gem idnow-client-2.3.0.gem
-        gem push --host https://rubygems.pkg.github.com/${OWNER} idnow-client-2.3.0.gem
-      env:
-        GEM_HOST_API_KEY: "Bearer ${{secrets.GITHUB_TOKEN}}"
-        OWNER: ${{github.repository_owner}}
-
-

data/.travis.yml

@@ -1,6 +0,0 @@
-language: ruby
-rvm:
-  - 2.5.3
-
-script:
-  - make test