idnow 1.3.0 → 2.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f7636a8ddecbc36e100f54413150590a4ace73ea
-  data.tar.gz: 7457d857840d07698651ad9353a72dd8e08a9cfc
+  metadata.gz: 71c54deac5050e48ce75bb19ff81ab76ca827055
+  data.tar.gz: 5e47156913a5f7127277cb5c6ef5a1e343ecad15
 SHA512:
-  metadata.gz: cc4b30834b1f450d9c9e56e43c3fabb37f6029760f25bd0178c06dd48e7bf5358b6dbee6b4243eb1d863828adfb8724dd334bf5ebcb9b64506e28edd1d2ed09a
-  data.tar.gz: ecded6e3fc954b139141d84c88aa6fdf64aa95773aefef95cfa30b720bab12b97313d451ca503e4b1532c025577ad3f92d052e421c6f415b0b4d6fb1a1c612a1
+  metadata.gz: 303055651e8474d3f2d42f76c331f11ba45c8ca85eff341fa9b3b2fb05c5dbe31e581b854bf3fb84f9e481eea682420f82b024cc317251dc6c194703a986f4ed
+  data.tar.gz: 6de474e0a88f7e24adf051327bbd14438ae93352a0304aa3660af81f79cdddb487d8d5eec051b418fdb18bd3358af543fe925d0cc4c6668b508b099681778fd8

data/.rubocop.yml

@@ -1,6 +1,6 @@
 AllCops:
   DisplayCopNames: true
-  TargetRubyVersion: 2.2
+  TargetRubyVersion: 2.3
 
 # This configuration was generated by
 # `rubocop --auto-gen-config`
@@ -19,6 +19,9 @@ Metrics/LineLength:
 Metrics/MethodLength:
   Max: 31
 
+Metrics/BlockLength:
+  Max: 190
+
 Metrics/AbcSize:
   Enabled: false
 

data/.travis.yml

@@ -1,7 +1,6 @@
 language: ruby
 rvm:
-  - 2.2.3
-  - 2.3.1
+  - 2.3.3
 
 script:
   - make test

data/Dockerfile

@@ -0,0 +1,13 @@
+FROM ruby:2.3-alpine
+
+RUN mkdir /gem
+WORKDIR /gem
+
+RUN apk update
+RUN apk add git build-base
+RUN gem install bundler
+
+COPY Gemfile idnow-client.gemspec /gem/
+RUN bundle install
+
+COPY . /gem/

data/Gemfile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 source 'https://rubygems.org'
 
 # Specify your gem's dependencies in idnow.gemspec

data/README.md

@@ -1,6 +1,6 @@
 # Idnow Client
-Library to consume the [IDnow API](http://www.idnow.eu/developers)  in Ruby.
 
+Library to consume the [IDnow API](http://www.idnow.eu/developers)  in Ruby.
 
 ## Installation
 
@@ -18,7 +18,6 @@ Or install it yourself as:
 
     $ gem install idnow
 
-
 ## Configuration
 
 The Idnow client takes three settings:
@@ -32,6 +31,7 @@ The Idnow client takes three settings:
 
 *  **company_id**
 *  **api_key**
+*  **custom_environments** (optional)
 
 You have the option of using a global singleton client:
 
@@ -39,6 +39,18 @@ You have the option of using a global singleton client:
 Idnow.env = :test
 Idnow.company_id = "mycompany"
 Idnow.api_key = "1234api_key"
+
+# optional
+Idnow.custom_environments = {
+  test: {
+    host:        'https://gateway.test.idnow.example.com',
+    target_host: 'https://go.test.idnow.example.com'
+  },
+  live: {
+    host:        'https://gateway.idnow.example.com',
+    target_host: 'https://go.idnow.example.com'
+  }
+}
 ```
 
 Or many clients can be initialized with:
@@ -48,11 +60,15 @@ client = Idnow::Client.new(env: @env, company_id: @company_id, api_key: @api_key
 ```
 
 ## API Summary
-Please read the official IDnow documentation for details. Some examples can also be found at the examples folder.
 
-####Identifications
+Please read the official IDnow documentation for details. Some examples can also be found in the examples folder.
+
+#### Identifications
+
 ```ruby
-# Identification data, all fields are optional. If you want to use a testing robot instead of a real agent for the identification, write the robot name at the first_name, last_name or any custom field.
+# Identification data, all fields are optional.
+# If you want to use a testing robot instead of a real agent for the identification,
+# write the robot name at the first_name, last_name or any custom field.
 data = Idnow::IdentificationData.new({
    birthday: '1984-07-20',
    birthplace: 'Buxtehude',
@@ -86,22 +102,24 @@ Idnow.client.testing_start(transaction_number: transaction_number)
 # Testing video chat - Only needed for automated robot testing
 Idnow.client.testing_request_video_chat(transaction_number: transaction_number)
 
-# List successful identifications.  When using automated robots, keep in mind that it might take a while until the identification is completed.
+# List successful identifications. When using automated robots,
+# keep in mind that it might take a while until the identification is completed.
 Idnow.client.login
 Idnow.client.list_identifications
 
 # List identifications by status pending or failed
 Idnow.client.list_identifications(status: 'pending')
 
-# Get identification. When using automated robots, keep in mind that it might take a while until the identification is completed.
+# Get identification. When using automated robots,
+# keep in mind that it might take a while until the identification is completed.
 Idnow.client.get_identification(transaction_number: transaction_number)
 
 # Download identification files
 Idnow.client.download_identification(transaction_number: transaction_number)
-
 ```
 
-####Esigning
+#### Esigning
+
 ```ruby
 # Create document definition
 document_identifier = "doc_id"
@@ -132,11 +150,23 @@ Idnow.client.upload_default_document(document_identifier, file_data)
 Idnow.client.download_default_document(document_identifier)
 ```
 
-
-## Development
+## Development & testing
 
 RSpec is used for testing.
+
+### Coverage report
+
 To enable code coverage check, set COV environment variable:
 
-```COV=true bundle exec rspec```
+```sh
+COV=true make test
+```
+
+### Testing with docker
 
+To run the tests through docker, you can use the included `Dockerfile`:
+
+```sh
+docker build . -t idnow-client
+docker run -it idnow-client:latest make test
+```

data/circle.yml

@@ -1,6 +1,6 @@
 machine:
   ruby:
-    version: 2.2.3
+    version: 2.3.3
 
 test:
   override:

data/examples/idnow_automated_testing.rb

@@ -1,6 +1,8 @@
+# frozen_string_literal: true
+
 require 'idnow'
 
-fail 'please call with a transaction number' unless ARGV[0]
+raise 'please call with a transaction number' unless ARGV[0]
 
 company_id = ENV.fetch('IDNOW_COMPANY_ID')
 api_key = ENV.fetch('IDNOW_API_KEY')

data/examples/idnow_download_identification.rb

@@ -1,6 +1,8 @@
+# frozen_string_literal: true
+
 require 'idnow'
 
-fail 'please call with a transaction number' unless ARGV[0]
+raise 'please call with a transaction number' unless ARGV[0]
 
 company_id = ENV.fetch('IDNOW_COMPANY_ID')
 api_key = ENV.fetch('IDNOW_API_KEY')

data/examples/idnow_get_identification.rb

@@ -1,6 +1,8 @@
+# frozen_string_literal: true
+
 require 'idnow'
 
-fail 'please call with a transaction number' unless ARGV[0]
+raise 'please call with a transaction number' unless ARGV[0]
 
 company_id = ENV.fetch('IDNOW_COMPANY_ID')
 api_key = ENV.fetch('IDNOW_API_KEY')

data/examples/idnow_upload_download_default_document.rb

@@ -1,6 +1,8 @@
+# frozen_string_literal: true
+
 require 'idnow'
 
-fail 'please call with a document identifier (must be unique)' unless ARGV[0]
+raise 'please call with a document identifier (must be unique)' unless ARGV[0]
 
 company_id = ENV.fetch('IDNOW_COMPANY_ID')
 api_key = ENV.fetch('IDNOW_API_KEY')

data/idnow-client.gemspec

@@ -1,15 +1,15 @@
-# coding: utf-8
+# frozen_string_literal: true
 
 Gem::Specification.new do |spec|
   spec.name          = 'idnow'
-  spec.version       = '1.3.0'
+  spec.version       = '2.1.1'
   spec.authors       = ['Joan Martinez, Tobias Bielohlawek']
-  spec.email         = ['joan.martinez.ripoll@gmail.com']
+  spec.email         = ['joan.martinez@solarisbank.de']
 
   spec.summary       = 'Ruby client for the IDnow API'
   spec.description   = 'Library to consume the IDnow API in Ruby, http://www.idnow.eu/developers'
 
-  fail 'RubyGems 2.0 or newer is required to protect against public gem pushes.' unless spec.respond_to?(:metadata)
+  raise 'RubyGems 2.0 or newer is required to protect against public gem pushes.' unless spec.respond_to?(:metadata)
 
   spec.homepage      = 'https://github.com/solarisBank/idnow-client'
   spec.license       = 'MIT'
@@ -21,10 +21,12 @@ Gem::Specification.new do |spec|
 
   spec.add_runtime_dependency 'net-sftp', '~>2.1'
 
+  spec.required_ruby_version = '~> 2.3'
+
+  spec.add_development_dependency 'factory_bot', '~> 4.5'
   spec.add_development_dependency 'rspec', '~> 3.3'
-  spec.add_development_dependency 'webmock', '~> 1.22'
-  spec.add_development_dependency 'simplecov', '~> 0.10'
-  spec.add_development_dependency 'rubocop', '~> 0.36.0'
-  spec.add_development_dependency 'factory_girl', '~> 4.5'
+  spec.add_development_dependency 'rubocop', '~> 0.54.0'
   spec.add_development_dependency 'shoulda-matchers', '~>3.1'
+  spec.add_development_dependency 'simplecov', '~> 0.10'
+  spec.add_development_dependency 'webmock', '~> 1.22'
 end

data/lib/idnow.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require 'idnow/modules/jsonable'
 require 'idnow/client'
 
@@ -24,14 +25,16 @@ require 'idnow/models/login_data'
 require 'idnow/models/document_definition'
 
 module Idnow
-  module Host # Used to request an identification through the idnow API
-    TEST_SERVER = 'https://gateway.test.idnow.de'.freeze
-    LIVE_SERVER = 'https://gateway.idnow.de'.freeze
+  # Used to request an identification through the idnow API
+  module Host
+    TEST_SERVER = 'https://gateway.test.idnow.de'
+    LIVE_SERVER = 'https://gateway.idnow.de'
   end
 
-  module TargetHost # Used for redirecting the user to the identification process
-    TEST_SERVER = 'https://go.test.idnow.de'.freeze
-    LIVE_SERVER = 'https://go.idnow.de'.freeze
+  # Used for redirecting the user to the identification process
+  module TargetHost
+    TEST_SERVER = 'https://go.test.idnow.de'
+    LIVE_SERVER = 'https://go.idnow.de'
   end
 
   ENVIRONMENTS = {
@@ -46,7 +49,7 @@ module Idnow
   }.freeze
 
   def env=(env)
-    fail ArgumentError, 'Please provide a valid enviroment, :test or :live' unless ENVIRONMENTS.keys.include?(env)
+    raise ArgumentError, 'Please provide a valid enviroment, :test or :live' unless ENVIRONMENTS.keys.include?(env)
     @client = nil
     @env = env
   end
@@ -61,9 +64,18 @@ module Idnow
     @api_key = api_key
   end
 
+  def custom_environments=(custom_environments)
+    @client = nil
+    @custom_environments = custom_environments
+  end
+
+  def endpoint(env, host)
+    (@custom_environments || {}).dig(env, host) || Idnow::ENVIRONMENTS[env][host]
+  end
+
   def client
     @client ||= Idnow::Client.new(env: @env, company_id: @company_id, api_key: @api_key)
   end
 
-  module_function :env=, :company_id=, :api_key=, :client
+  module_function :env=, :company_id=, :api_key=, :custom_environments=, :endpoint, :client
 end

data/lib/idnow/API/authentication.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Idnow
   module API
     module Authentication

data/lib/idnow/API/automated_testing.rb

@@ -1,8 +1,9 @@
 # frozen_string_literal: true
+
 module Idnow
   module API
     module AutomatedTesting
-      HOST = 'https://api.test.idnow.de'.freeze
+      HOST = 'https://api.test.idnow.de'
 
       def testing_start(transaction_number:)
         path = full_path_for("identifications/#{transaction_number}/start")

data/lib/idnow/API/document_definitions.rb

@@ -1,8 +1,10 @@
+# frozen_string_literal: true
+
 module Idnow
   module API
     module DocumentDefinitions
       def create_document_definition(document_data)
-        fail Idnow::AuthenticationException if @auth_token.nil?
+        raise Idnow::AuthenticationException if @auth_token.nil?
 
         path = full_path_for('documentdefinitions')
         request = Idnow::PostJsonRequest.new(path, document_data)
@@ -10,7 +12,7 @@ module Idnow
       end
 
       def list_document_definitions
-        fail Idnow::AuthenticationException if @auth_token.nil?
+        raise Idnow::AuthenticationException if @auth_token.nil?
 
         path = full_path_for('documentdefinitions')
         request = Idnow::GetRequest.new(path)
@@ -21,8 +23,8 @@ module Idnow
       end
 
       def list_cached_document_definitions(refresh = false)
-        return @document_definitions = list_document_definitions if refresh
-        @document_definitions ||= list_document_definitions
+        return @list_cached_document_definitions = list_document_definitions if refresh
+        @list_cached_document_definitions ||= list_document_definitions
       end
     end
   end

data/lib/idnow/API/download_documents.rb

@@ -1,8 +1,10 @@
+# frozen_string_literal: true
+
 module Idnow
   module API
     module DownloadDocuments
       def download_default_document(document_definition_identifier)
-        fail Idnow::AuthenticationException if @auth_token.nil?
+        raise Idnow::AuthenticationException if @auth_token.nil?
 
         path = full_path_for("documentdefinitions/#{document_definition_identifier}/data")
         request = Idnow::GetRequest.new(path, '')

data/lib/idnow/API/request_identifications.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Idnow
   module API
     module RequestIdentifications

data/lib/idnow/API/retrieve_identifications.rb

@@ -1,13 +1,15 @@
+# frozen_string_literal: true
+
 module Idnow
   module API
     module RetrieveIdentifications
-      IDENTIFICATION_STATUSES = %w(pending failed).freeze
+      IDENTIFICATION_STATUSES = %w[pending failed].freeze
 
       def list_identifications(status: nil)
-        fail Idnow::AuthenticationException if @auth_token.nil?
+        raise Idnow::AuthenticationException if @auth_token.nil?
 
         unless status.nil? || IDENTIFICATION_STATUSES.include?(status)
-          fail Idnow::InvalidArguments, "Status #{status} not defined, possible options are: #{IDENTIFICATION_STATUSES.join(',')}"
+          raise Idnow::InvalidArguments, "Status #{status} not defined, possible options are: #{IDENTIFICATION_STATUSES.join(',')}"
         end
         partial_path = status.nil? ? 'identifications' : "identifications?#{status}=true"
         path = full_path_for(partial_path)
@@ -19,7 +21,7 @@ module Idnow
       end
 
       def get_identification(transaction_number:)
-        fail Idnow::AuthenticationException if @auth_token.nil?
+        raise Idnow::AuthenticationException if @auth_token.nil?
 
         path = full_path_for("identifications/#{transaction_number}")
         request = Idnow::GetRequest.new(path)

data/lib/idnow/API/upload_documents.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Idnow
   module API
     module UploadDocuments
@@ -14,7 +16,7 @@ module Idnow
       private
 
       def upload_document(file_data, request_path)
-        fail Idnow::AuthenticationException if @auth_token.nil?
+        raise Idnow::AuthenticationException if @auth_token.nil?
         request = Idnow::PostBinaryRequest.new(request_path, file_data)
         execute(request, 'X-API-LOGIN-TOKEN' => @auth_token)
       end

data/lib/idnow/client.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require 'idnow/API/authentication'
 require 'idnow/API/automated_testing' # shouldn't be included by default
 require 'idnow/API/request_identifications'
@@ -17,21 +18,24 @@ module Idnow
     include Idnow::API::UploadDocuments
     include Idnow::API::DownloadDocuments
 
-    API_VERSION = 'v1'.freeze
+    API_VERSION = 'v1'
 
     attr_reader :host
 
-    def initialize(env:, company_id:, api_key:)
-      fail 'Please set env to :test or :live' unless Idnow::ENVIRONMENTS.keys.include?(env)
-      fail 'Please set your company_id' if company_id.nil?
-      fail 'Please set your api_key' if api_key.nil?
-      @host        = Idnow::ENVIRONMENTS[env][:host]
-      @target_host = Idnow::ENVIRONMENTS[env][:target_host]
+    def initialize(env:, company_id:, api_key:, timeout: nil)
+      raise 'Please set env to :test or :live' unless Idnow::ENVIRONMENTS.keys.include?(env)
+      raise 'Please set your company_id' if company_id.nil?
+      raise 'Please set your api_key' if api_key.nil?
+      @host        = Idnow.endpoint(env, :host)
+      @target_host = Idnow.endpoint(env, :target_host)
       @company_id  = company_id
       @api_key     = api_key
 
       @http_client = HttpClient.new(host: @host)
-      @sftp_client = SftpClient.new(host: @host, username: @company_id, password: @api_key)
+
+      sftp_client_options = { host: @host, username: @company_id, password: @api_key }
+      sftp_client_options[:timeout] = timeout if timeout
+      @sftp_client = SftpClient.new(sftp_client_options)
     end
 
     private
@@ -46,7 +50,7 @@ module Idnow
                  end
 
       response.tap do |r|
-        fail Idnow::ResponseException, r.errors if r.errors?
+        raise Idnow::ResponseException, r.errors if r.errors?
       end
     end
 

data/lib/idnow/configuration.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Idnow
   class Configuration
     # TODO: This class is not being used right now, but its aim is to be able for the developers
@@ -15,8 +16,8 @@ module Idnow
 
     module Idnow
       module Host
-        TEST = 'https://gateway.test.idnow.de'.freeze
-        PRODUCTION = 'https://gateway.idnow.de'.freeze
+        TEST = 'https://gateway.test.idnow.de'
+        PRODUCTION = 'https://gateway.idnow.de'
       end
     end
     attr_accessor :host

data/lib/idnow/exception.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Idnow
   class Exception < StandardError
     def initialize(message)

data/lib/idnow/get_request.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'net/http'
 
 module Idnow

data/lib/idnow/helpers.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Idnow
   module Helpers
     PROJECT_ROOT = File.dirname(File.dirname(File.dirname(__FILE__)))

data/lib/idnow/http_client.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Idnow
   class HttpClient
     def initialize(host:, read_timout_sec: 30)
@@ -21,7 +23,7 @@ module Idnow
     def client
       Net::HTTP.new(@uri.host, @uri.port).tap do |http|
         http.read_timeout = @read_timeout
-        http.use_ssl      = true
+        http.use_ssl      = @uri.scheme == 'https'
       end
     end
   end

data/lib/idnow/json_response.rb

@@ -1,10 +1,12 @@
+# frozen_string_literal: true
+
 module Idnow
   class JsonResponse < RawResponse
     attr_reader :data
 
     def initialize(raw_response)
       super
-      raw_response = (raw_response == '') ? '{}' : raw_response
+      raw_response = raw_response == '' ? '{}' : raw_response
       @data = JSON.parse(raw_response)
     end
   end

data/lib/idnow/models/contact_data.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Idnow
   class ContactData
     include Idnow::Jsonable

data/lib/idnow/models/document_definition.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Idnow
   class DocumentDefinition
     include Idnow::Jsonable

data/lib/idnow/models/identification.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'forwardable'
 
 module Idnow

data/lib/idnow/models/identification_data.rb

@@ -1,20 +1,24 @@
 # frozen_string_literal: true
+
 require 'json'
 
 module Idnow
   class IdentificationData
     module Gender
-      MALE = 'MALE'.freeze
-      FEMALE = 'FEMALE'.freeze
+      MALE = 'MALE'
+      FEMALE = 'FEMALE'
     end
 
-    attr_accessor :birthplace, :birthname, :city, :country, :custom1,
-                  :custom2, :custom3, :custom4, :custom5, :trackingid, :email, :firstname, :gender,
-                  :lastname, :mobilephone, :nationality, :street, :streetnumber, :title, :zipcode
+    attr_accessor :birthplace, :birthname, :city, :custom1,
+                  :custom2, :custom3, :custom4, :custom5, :trackingid, :email, :firstname,
+                  :lastname, :mobilephone, :nationality, :street, :streetnumber, :title, :zipcode,
+                  :preferredLang
+
+    attr_reader :country, :gender
 
     def initialize(params = {})
       params.keys.each do |key|
-        fail ArgumentError, "Attribute #{key} is not supported!" unless respond_to?(key.to_sym)
+        raise ArgumentError, "Attribute #{key} is not supported!" unless respond_to?(key.to_sym)
 
         send("#{key}=", params[key])
       end
@@ -31,7 +35,7 @@ module Idnow
     ########### Getter / Setter ############
 
     def birthday
-      @birthday.strftime('%Y-%m-%d') if @birthday
+      @birthday&.strftime('%Y-%m-%d')
     end
 
     def birthday=(birthday)
@@ -43,18 +47,18 @@ module Idnow
     end
 
     def country=(country)
-      fail ArgumentError, 'Country must be ISO 3166 two letter country code' unless country.instance_of?(String) && country.size == 2
+      raise ArgumentError, 'Country must be ISO 3166 two letter country code' unless country.instance_of?(String) && country.size == 2
 
       @country = country.upcase
     end
 
     def gender=(gender)
-      if %w(M MALE).include?(gender.to_s.strip.upcase)
+      if %w[M MALE].include?(gender.to_s.strip.upcase)
         @gender = Gender::MALE
-      elsif %w(F FEMALE).include?(gender.to_s.strip.upcase)
+      elsif %w[F FEMALE].include?(gender.to_s.strip.upcase)
         @gender = Gender::FEMALE
       else
-        fail ArgumentError, 'Provide valid value for gender: MALE or FEMALE'
+        raise ArgumentError, 'Provide valid value for gender: MALE or FEMALE'
       end
     end
   end

data/lib/idnow/models/identification_document.rb

@@ -1,15 +1,19 @@
+# frozen_string_literal: true
+
 module Idnow
   class IdentificationDocument
     include Idnow::Jsonable
 
-    attr_accessor :country, :number, :issued_by, :date_issued, :type, :valid_until
+    attr_accessor :country, :number, :issued_by, :type
+    attr_writer :date_issued, :valid_until
+
     def initialize(data)
-      @country             = dig_value('country', data)
-      @number              = dig_value('number', data)
-      @issued_by           = dig_value('issuedby', data)
-      @date_issued         = dig_value('dateissued', data)
-      @type                = dig_value('type', data)
-      @valid_until         = dig_value('validuntil', data)
+      @country     = data.dig('country', 'value')
+      @number      = data.dig('number', 'value')
+      @issued_by   = data.dig('issuedby', 'value')
+      @date_issued = data.dig('dateissued', 'value')
+      @type        = data.dig('type', 'value')
+      @valid_until = data.dig('validuntil', 'value')
     end
 
     def date_issued
@@ -19,16 +23,5 @@ module Idnow
     def valid_until
       Date.parse(@valid_until) if @valid_until
     end
-
-    private
-
-    def dig_value(*keys, data)
-      # TODO: use ruby 2.3 and dig
-      result = data
-      keys.each do |key|
-        result = result.fetch(key, {})
-      end
-      result['value']
-    end
   end
 end

data/lib/idnow/models/identification_process.rb

@@ -1,8 +1,10 @@
+# frozen_string_literal: true
+
 module Idnow
   class IdentificationProcess
     include Idnow::Jsonable
 
-    SUCCESSFUL_RESPONSES = %w(SUCCESS SUCCESS_DATA_CHANGED).freeze
+    SUCCESSFUL_RESPONSES = %w[SUCCESS SUCCESS_DATA_CHANGED].freeze
     attr_accessor :result, :reason, :company_id, :filename, :agentname, :identification_time, :id, :href, :type, :transaction_number
 
     def initialize(data)

data/lib/idnow/models/identification_request.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Idnow
   class IdentificationRequest
     attr_accessor :id, :transaction_number

data/lib/idnow/models/login.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Idnow
   class Login
     attr_accessor :auth_token

data/lib/idnow/models/login_data.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'json'
 
 module Idnow

data/lib/idnow/models/user_data.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Idnow
   class UserData
     include Idnow::Jsonable

data/lib/idnow/modules/jsonable.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Idnow
   module Jsonable
     def to_h

data/lib/idnow/post_binary_request.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'net/http'
 
 module Idnow

data/lib/idnow/post_json_request.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # require 'json'
 require 'net/http'
 

data/lib/idnow/raw_response.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Idnow
   class RawResponse
     attr_reader :raw
@@ -23,9 +25,9 @@ module Idnow
 
     def valid_json?(json)
       JSON.parse(json)
-      return true
+      true
     rescue JSON::ParserError
-      return false
+      false
     end
   end
 end

data/lib/idnow/sftp_client.rb

@@ -1,17 +1,22 @@
+# frozen_string_literal: true
+
 require 'net/sftp'
 
 module Idnow
   class SftpClient
-    def initialize(host:, username:, password:)
+    def initialize(host:, username:, password:, timeout: nil)
       @host = URI.parse(host).host
       @username = username
       @password = password
+      @timeout = timeout
     end
 
     def download(file_name)
       data = nil
-      Net::SFTP.start(@host, @username, password: @password) do |sftp|
-        fail Idnow::Exception, "Invalid path. No identification file found under #{file_name}" unless file_exists(sftp, file_name)
+      options = { password: @password }
+      options[:timeout] = @timeout if @timeout
+      Net::SFTP.start(@host, @username, options) do |sftp|
+        raise Idnow::Exception, "Invalid path. No identification file found under #{file_name}" unless file_exists(sftp, file_name)
         begin
           data = sftp.download!(file_name)
         rescue Net::SFTP::Exception => e

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: idnow
 version: !ruby/object:Gem::Version
-  version: 1.3.0
+  version: 2.1.1
 platform: ruby
 authors:
 - Joan Martinez, Tobias Bielohlawek
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2016-10-12 00:00:00.000000000 Z
+date: 2018-04-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: net-sftp
@@ -25,92 +25,92 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '2.1'
 - !ruby/object:Gem::Dependency
-  name: rspec
+  name: factory_bot
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.3'
+        version: '4.5'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.3'
+        version: '4.5'
 - !ruby/object:Gem::Dependency
-  name: webmock
+  name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.22'
+        version: '3.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.22'
+        version: '3.3'
 - !ruby/object:Gem::Dependency
-  name: simplecov
+  name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.10'
+        version: 0.54.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.10'
+        version: 0.54.0
 - !ruby/object:Gem::Dependency
-  name: rubocop
+  name: shoulda-matchers
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.36.0
+        version: '3.1'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.36.0
+        version: '3.1'
 - !ruby/object:Gem::Dependency
-  name: factory_girl
+  name: simplecov
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '4.5'
+        version: '0.10'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '4.5'
+        version: '0.10'
 - !ruby/object:Gem::Dependency
-  name: shoulda-matchers
+  name: webmock
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.1'
+        version: '1.22'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.1'
+        version: '1.22'
 description: Library to consume the IDnow API in Ruby, http://www.idnow.eu/developers
 email:
-- joan.martinez.ripoll@gmail.com
+- joan.martinez@solarisbank.de
 executables: []
 extensions: []
 extra_rdoc_files: []
@@ -120,6 +120,7 @@ files:
 - ".rubocop.yml"
 - ".travis.yml"
 - CODE_OF_CONDUCT.md
+- Dockerfile
 - Gemfile
 - LICENSE.txt
 - Makefile
@@ -171,9 +172,9 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - "~>"
     - !ruby/object:Gem::Version
-      version: '0'
+      version: '2.3'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
@@ -181,7 +182,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.6
+rubygems_version: 2.6.14
 signing_key: 
 specification_version: 4
 summary: Ruby client for the IDnow API