idnow 1.1.0 → 1.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 57e72a956f1a026c9297ba8199cc07b3e943fcc1
-  data.tar.gz: 86c6851ce341282bac0092a96321d8d437f1c870
+  metadata.gz: f7636a8ddecbc36e100f54413150590a4ace73ea
+  data.tar.gz: 7457d857840d07698651ad9353a72dd8e08a9cfc
 SHA512:
-  metadata.gz: 458341cdac882f348728b17556f33f6ac6faddd3b9aeae4eb88b7e0c0706ff03cdddc6d5cc0489703b0eda9ea5225e76a1b0eb96d79addc72cd05124108d158c
-  data.tar.gz: 8ed1b3ff93ce58a1f559ff614343c6aa3022ebe50f9c9159c6e133c28291f06d9703af8ce3b15bf917f96f444fe5e6e33af8b70ffd2b1715e87ce14c4c6bfdd5
+  metadata.gz: cc4b30834b1f450d9c9e56e43c3fabb37f6029760f25bd0178c06dd48e7bf5358b6dbee6b4243eb1d863828adfb8724dd334bf5ebcb9b64506e28edd1d2ed09a
+  data.tar.gz: ecded6e3fc954b139141d84c88aa6fdf64aa95773aefef95cfa30b720bab12b97313d451ca503e4b1532c025577ad3f92d052e421c6f415b0b4d6fb1a1c612a1

data/.gitignore

@@ -10,3 +10,4 @@
 /spec/reports/
 /tmp/
 tags
+.*.sw?

data/.travis.yml

@@ -0,0 +1,7 @@
+language: ruby
+rvm:
+  - 2.2.3
+  - 2.3.1
+
+script:
+  - make test

data/Makefile

@@ -1,2 +1,7 @@
-test:
+test: rspec
+
+rspec:
 	bundle exec rspec
+
+rubocop:
+	bundle exec rubocop

data/idnow-client.gemspec

@@ -2,7 +2,7 @@
 
 Gem::Specification.new do |spec|
   spec.name          = 'idnow'
-  spec.version       = '1.1.0'
+  spec.version       = '1.3.0'
   spec.authors       = ['Joan Martinez, Tobias Bielohlawek']
   spec.email         = ['joan.martinez.ripoll@gmail.com']
 

data/lib/idnow.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'idnow/modules/jsonable'
 require 'idnow/client'
 

data/lib/idnow/API/automated_testing.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Idnow
   module API
     module AutomatedTesting

data/lib/idnow/client.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'idnow/API/authentication'
 require 'idnow/API/automated_testing' # shouldn't be included by default
 require 'idnow/API/request_identifications'

data/lib/idnow/configuration.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Idnow
   class Configuration
     # TODO: This class is not being used right now, but its aim is to be able for the developers

data/lib/idnow/http_client.rb

@@ -1,26 +1,27 @@
 module Idnow
   class HttpClient
-    def initialize(host:)
-      @uri = URI.parse(host)
+    def initialize(host:, read_timout_sec: 30)
+      @uri          = URI.parse(host)
+      @read_timeout = read_timout_sec
     end
 
     def execute(request, headers = {})
       headers.each do |k, v|
         request[k] = v
       end
-      begin
-        client.request(request)
-      rescue Timeout::Error, Errno::EINVAL, Errno::ECONNRESET, EOFError,
-             Net::HTTPBadResponse, Net::HTTPHeaderSyntaxError, Net::ProtocolError => e
-        raise Idnow::ConnectionException, e
-      end
+
+      client.request(request)
+    rescue Timeout::Error, Errno::EINVAL, Errno::ECONNRESET, EOFError,
+           Net::HTTPBadResponse, Net::HTTPHeaderSyntaxError, Net::ProtocolError => e
+      raise Idnow::ConnectionException, e
     end
 
     private
 
     def client
       Net::HTTP.new(@uri.host, @uri.port).tap do |http|
-        http.use_ssl = true
+        http.read_timeout = @read_timeout
+        http.use_ssl      = true
       end
     end
   end

data/lib/idnow/models/identification.rb

@@ -1,5 +1,5 @@
 require 'forwardable'
-require 'pry'
+
 module Idnow
   class Identification
     extend Forwardable

data/lib/idnow/models/identification_data.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'json'
 
 module Idnow

data/lib/idnow/models/identification_process.rb

@@ -23,7 +23,7 @@ module Idnow
     end
 
     def review_pending?
-      result == 'REVIEW_PENDING'
+      result == 'REVIEW_PENDING' || result == 'FRAUD_SUSPICION_PENDING'
     end
   end
 end

data/lib/idnow/models/user_data.rb

@@ -19,12 +19,17 @@ module Idnow
       @streetnumber = dig_value('address', 'streetnumber', data)
       @title        = dig_value('title', data)
       @zipcode      = dig_value('address', 'zipcode', data)
+      @raw_data     = data
     end
 
     def address
       "#{street} #{streetnumber}, #{zipcode} #{city}, #{country}"
     end
 
+    def address_changed?
+      @raw_data['address'].values.any? { |field| field['status'] == 'CHANGE' }
+    end
+
     private
 
     def dig_value(*keys, data)

data/lib/idnow/sftp_client.rb

@@ -11,7 +11,7 @@ module Idnow
     def download(file_name)
       data = nil
       Net::SFTP.start(@host, @username, password: @password) do |sftp|
-        fail Idnow::Exception, "Invalid path. No identification file found under #{file_name}" if sftp.dir['.', file_name].empty?
+        fail Idnow::Exception, "Invalid path. No identification file found under #{file_name}" unless file_exists(sftp, file_name)
         begin
           data = sftp.download!(file_name)
         rescue Net::SFTP::Exception => e
@@ -20,5 +20,12 @@ module Idnow
       end
       data
     end
+
+    private
+
+    def file_exists(sftp, file_name)
+      sftp.dir.entries('.').each { |entry| return true if file_name == entry.name }
+      false
+    end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: idnow
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 1.3.0
 platform: ruby
 authors:
 - Joan Martinez, Tobias Bielohlawek
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2016-07-04 00:00:00.000000000 Z
+date: 2016-10-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: net-sftp
@@ -118,6 +118,7 @@ files:
 - ".gitignore"
 - ".rspec"
 - ".rubocop.yml"
+- ".travis.yml"
 - CODE_OF_CONDUCT.md
 - Gemfile
 - LICENSE.txt
@@ -180,7 +181,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5.1
+rubygems_version: 2.6.6
 signing_key: 
 specification_version: 4
 summary: Ruby client for the IDnow API