idn 0.0.1 → 0.0.2

data/CHANGES

@@ -1,3 +1,13 @@
+Changes with IDN 0.0.2 (2006-02-11)
+
+* Remove excessive xfree() if a call to stringprep_profile() returns an
+  error. Fixes crash reported in PR #3088.
+
+* Add tests for invalid Stringprep strings and adjust names of already
+  existing test methods.
+
+* Improve existing tests for IDN::Idna.
+
 Changes with IDN 0.0.1 (2005-09-26)
 
 * First release.

data/README

@@ -1,6 +1,6 @@
 == LibIDN Ruby Bindings
 
-Version 0.0.1
+Version 0.0.2
 
 Ruby Bindings for the GNU LibIDN library, an implementation of the
 Stringprep, Punycode and IDNA specifications defined by the IETF
@@ -168,7 +168,7 @@ mailing list.
 
 === Copyright & License
 
-Copyright (c) 2005 Erik Abele. All rights reserved.
+Copyright (c) 2005-2006 Erik Abele. All rights reserved.
 
 This documentation and the software itself are licensed under the Apache
 License, Version 2.0 (the "License").

data/Rakefile

@@ -32,7 +32,7 @@ rescue Exception
 end
 
 PKG_NAME = 'idn'
-PKG_VERSION = '0.0.1'
+PKG_VERSION = '0.0.2'
 
 PKG_AUTHOR = 'Erik Abele'
 PKG_EMAIL = 'erikabele@rubyforge.org'

data/ext/stringprep.c

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2005 Erik Abele. All rights reserved.
+ * Copyright (c) 2005-2006 Erik Abele. All rights reserved.
  * Portions Copyright (c) 2005 Yuki Mitsui. All rights reserved.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
@@ -67,7 +67,6 @@ static VALUE stringprep_internal(VALUE str, const char *profile)
   rc = stringprep_profile(RSTRING(str)->ptr, &buf, profile, 0);
 
   if (rc != STRINGPREP_OK) {
-    xfree(buf);
     rb_raise(eStringprepError, "%s (%d)", stringprep_strerror(rc), rc);
     return Qnil;
   }

data/test/tc_Idna.rb

@@ -1,6 +1,6 @@
 # Unit tests for IDN::Idna.
 #
-# Copyright (c) 2005 Erik Abele. All rights reserved.
+# Copyright (c) 2005-2006 Erik Abele. All rights reserved.
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.
@@ -208,9 +208,8 @@ class Test_Idna < Test::Unit::TestCase
 
   def test_toASCII_UNASSIGNED_ALLOWED
     TESTCASES_UNASSIGNED.each do |key, val|
-      assert_nothing_raised("TestCase #{key} failed") do
-        Idna.toASCII(val[0], IDN::Idna::ALLOW_UNASSIGNED)
-      end
+      rc = Idna.toASCII(val[0], IDN::Idna::ALLOW_UNASSIGNED)
+      assert_equal(val[1], rc, "TestCase #{key} failed")
     end
   end
 
@@ -232,9 +231,8 @@ class Test_Idna < Test::Unit::TestCase
 
   def test_toASCII_STD3_NOT_USED
     TESTCASES_STD3.each do |key, val|
-      assert_nothing_raised("TestCase #{key} failed") do
-        Idna.toASCII(val[0])
-      end
+      rc = Idna.toASCII(val[0])
+      assert_equal(val[1], rc, "TestCase #{key} failed")
     end
   end
 

data/test/tc_Stringprep.rb

@@ -1,6 +1,6 @@
 # Unit tests for IDN::Stringprep.
 #
-# Copyright (c) 2005 Erik Abele. All rights reserved.
+# Copyright (c) 2005-2006 Erik Abele. All rights reserved.
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.
@@ -36,6 +36,13 @@ class Test_Stringprep < Test::Unit::TestCase
     'E' => [ "SASLprep", "Example\xC2\xA0Name", "Example Name" ]
   }
 
+  # STRINGPREP_INVALID test vectors: invalid input strings and their
+  # corresponding profile.
+
+  TESTCASES_STRINGPREP_INVALID = {
+    'A' => [ "Nodeprep", "toto@a/a" ]
+  }
+
   # NFKC test vectors: UTF-8 encoded strings and the corresponding
   # normalized form, according to NFKC normalization mode.
 
@@ -50,14 +57,22 @@ class Test_Stringprep < Test::Unit::TestCase
   def teardown
   end
 
-  def test_with_profile
+  def test_with_profile_STRINGPREP
     TESTCASES_STRINGPREP.each do |key, val|
       rc = Stringprep.with_profile(val[1], val[0])
       assert_equal(val[2], rc, "TestCase #{key} failed")
     end
   end
 
-  def test_nfkc_normalize
+  def test_with_profile_STRINGPREP_INVALID
+    TESTCASES_STRINGPREP_INVALID.each do |key, val|
+      assert_raise(Stringprep::StringprepError, "TestCase #{key} failed") do
+        Stringprep.with_profile(val[0], val[1])
+      end
+    end
+  end
+
+  def test_nfkc_normalize_NFKC
     TESTCASES_NFKC.each do |key, val|
       rc = Stringprep.nfkc_normalize(val[0])
       assert_equal(val[1], rc, "TestCase #{key} failed")

metadata

@@ -3,8 +3,8 @@ rubygems_version: 0.8.11
 specification_version: 1
 name: idn
 version: !ruby/object:Gem::Version 
-  version: 0.0.1
-date: 2005-09-26 00:00:00 +02:00
+  version: 0.0.2
+date: 2006-02-13 00:00:00 +01:00
 summary: LibIDN Ruby Bindings
 require_paths: 
   - lib