identity_cache 1.2.0 → 1.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 561965856845fc5d5094581d735584924eda58557edfb3831c39bce2498635aa
-  data.tar.gz: 33a85428a3b2a298076d81a79b662b742c00a25971bf453f8f57eeab7cba2681
+  metadata.gz: dedbf4998ab4c83ea5d6198af733c3165b9978bd509d9cb135aefd1c1979415d
+  data.tar.gz: 03cda95c71ef97b89d2b321cbbf8737f12cb841a7eb89bc072419e3fb06b9b9d
 SHA512:
-  metadata.gz: 6a8c691d8883acfd69f11724dfff13a3ef4858a2abd2ca658659981f1d08b36dea244100c4030b8ef5d39ac8509e639fea6cd02127e09d157be636fcc2bee77a
-  data.tar.gz: e357c3a4f02a288a5ddb3290cbd11176937821bb3c9052fb318d9139ac253650f7018a8249b2ebc9f115015a6434baf7cb1b7e76bfb0dbf1e98ee745e3e95ed7
+  metadata.gz: 9e81b1259c650b6043e890ea3cdcba24c8e27442ae1609868c82eb1ec2fc2cfb89aae26693bda3cd5489937e78ab959d2fc8c101528238ebdb02bd20832d1408
+  data.tar.gz: f5bec7a26ff5d896915c6644d475f92429934f179e5d51e8eff9cfa491c117451d542ef6c745509bfead84b631df08ff8f9c8f5dba4b6076ee5b1baf789e94c6

data/.github/workflows/ci.yml

@@ -16,14 +16,14 @@ jobs:
       matrix:
         entry:
           - name: 'Minimum supported'
-            ruby: '2.5'
+            ruby: '2.7'
             gemfile: "Gemfile.min-supported"
           - name: 'Latest released & run rubocop'
-            ruby: '3.0'
+            ruby: '3.2'
             gemfile: "Gemfile.latest-release"
             rubocop: true
           - name: 'Rails edge'
-            ruby: '3.0'
+            ruby: '3.2'
             gemfile: "Gemfile.rails-edge"
             edge: true
 

data/CHANGELOG.md

@@ -1,5 +1,16 @@
 # Identity Cache Changelog
 
+## unreleased
+
+## 1.3.0
+
+### Features
+- Return meaningful value from `expire_cache` indicating whenever it succeeded or failed in the process. (#523)
+
+### Fixes
+- Expire parents cache when when calling `expire_cache`. (#523)
+- Avoid creating too many shapes on Ruby 3.2+. (#526)
+
 ## 1.2.0
 
 ### Fixes

data/dev.yml

@@ -5,7 +5,7 @@ up:
     - mysql-client@5.7:
         or:        [mysql@5.7]
         conflicts: [mysql-connector-c, mysql, mysql-client]
-  - ruby: 2.7.2
+  - ruby: 3.2.0
   - isogun
   - bundler
 

data/lib/identity_cache/cache_key_loader.rb

@@ -44,7 +44,7 @@ module IdentityCache
       # @param db_key [Array] Reference to what to load from the database.
       # @return [Hash] A hash mapping each database key to its corresponding value
       def load_multi(cache_fetcher, db_keys)
-        load_batch(cache_fetcher => db_keys).fetch(cache_fetcher)
+        load_batch({ cache_fetcher => db_keys }).fetch(cache_fetcher)
       end
 
       # Load multiple keys for multiple cache fetchers

data/lib/identity_cache/cached/attribute.rb

@@ -35,16 +35,20 @@ module IdentityCache
       end
 
       def expire(record)
+        all_deleted = true
+
         unless record.send(:was_new_record?)
           old_key = old_cache_key(record)
-          IdentityCache.cache.delete(old_key)
+          all_deleted = IdentityCache.cache.delete(old_key)
         end
         unless record.destroyed?
           new_key = new_cache_key(record)
           if new_key != old_key
-            IdentityCache.cache.delete(new_key)
+            all_deleted = IdentityCache.cache.delete(new_key) && all_deleted
           end
         end
+
+        all_deleted
       end
 
       def cache_key(index_key)

data/lib/identity_cache/parent_model_expiration.rb

@@ -45,8 +45,9 @@ module IdentityCache
     def expire_parent_caches
       parents_to_expire = Set.new
       add_parents_to_cache_expiry_set(parents_to_expire)
-      parents_to_expire.each do |parent|
-        parent.expire_primary_index if parent.class.primary_cache_index_enabled
+      parents_to_expire.select! { |parent| parent.class.primary_cache_index_enabled }
+      parents_to_expire.reduce(true) do |all_expired, parent|
+        parent.expire_primary_index && all_expired
       end
     end
 

data/lib/identity_cache/query_api.rb

@@ -166,15 +166,17 @@ module IdentityCache
     def _run_commit_callbacks
       if destroyed? || transaction_changed_attributes.present?
         expire_cache
-        expire_parent_caches
       end
       super
     end
 
-    # Invalidate the cache data associated with the record.
+    # Invalidate the cache data associated with the record. Returns `true` on success,
+    # `false` otherwise.
     def expire_cache
-      expire_attribute_indexes
-      true
+      expired_parent_caches = expire_parent_caches
+      expired_attribute_indexes = expire_attribute_indexes
+
+      expired_parent_caches && expired_attribute_indexes
     end
 
     # @api private
@@ -185,9 +187,11 @@ module IdentityCache
 
     private
 
+    # Even if we have problems with some attributes, carry over the results and expire
+    # all possible attributes without array allocation.
     def expire_attribute_indexes # :nodoc:
-      cache_indexes.each do |cached_attribute|
-        cached_attribute.expire(self)
+      cache_indexes.reduce(true) do |all_expired, cached_attribute|
+        cached_attribute.expire(self) && all_expired
       end
     end
   end

data/lib/identity_cache/version.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
 module IdentityCache
-  VERSION = "1.2.0"
+  VERSION = "1.3.0"
   CACHE_VERSION = 8
 end

data/lib/identity_cache/with_primary_index.rb

@@ -7,8 +7,9 @@ module IdentityCache
     include WithoutPrimaryIndex
 
     def expire_cache
-      expire_primary_index
-      super
+      expired_primary_index = expire_primary_index
+
+      super && expired_primary_index
     end
 
     # @api private
@@ -158,6 +159,15 @@ module IdentityCache
       def expire_primary_key_cache_index(id)
         cached_primary_index.expire(id)
       end
+
+      private
+
+      def inherited(subclass)
+        super
+        subclass.class_eval do
+          @cached_primary_index = nil
+        end
+      end
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: identity_cache
 version: !ruby/object:Gem::Version
-  version: 1.2.0
+  version: 1.3.0
 platform: ruby
 authors:
 - Camilo Lopez
@@ -14,7 +14,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-08-15 00:00:00.000000000 Z
+date: 2023-01-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord