identity_cache 0.5.0 → 0.5.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 11bd2d6f14e2b77b00c8bd58dd0731fa2976a81a
-  data.tar.gz: 4d547e1b739ce13b443dfb9ea44416a81936ed95
+  metadata.gz: c9803848d2879cfdaad2424842b64db3684e1ca4
+  data.tar.gz: 91cd873cffd35d19d66b01c8a10165344b30483d
 SHA512:
-  metadata.gz: 63aa5192013b0d99b426e0b1cf70ea6962924a57da29beaac507b4d5dae458693822a55cd24bc743768826d7b725592b456c0ca68cc9655df5509100a0ab68b3
-  data.tar.gz: 99cab0e7c1b4d8a4a5378b408582486404182e86529d4e62926d29ab3c021a2ff9af02a4af05d0a5eae4cd6996a76f4588a4e03584645025d7c7131a122407fd
+  metadata.gz: d65519bb48cdae9d0111280e05a89cee2e99a497f31d0140f3e77ca55226865ef8c575ec9bd427e41ba9fd105e304c0a006d2fa4348ce6b06393c0ed607a8e23
+  data.tar.gz: 370c4a4d3406b95b9fe40b33406182286d9586dc07db2f2517a87bb08111fafa776dead8a5430555564aefdb385a9f5ce027c511e87c32924a8e8668af00a863

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 # IdentityCache changelog
 
+#### 0.5.1
+
+- Fix bug in prefetch_associations for cache_has_one associations that may be nil
+
 #### 0.5.0
 
 - `never_set_inverse_association` and `fetch_read_only_records` are now `true` by default (#315)

data/lib/identity_cache/query_api.rb

@@ -401,7 +401,7 @@ module IdentityCache
         when details = cached_has_ones[association]
           if details[:embed] == true
             prefetch_embedded_association(records, association, details)
-            parent_records = records.map(&details[:cached_accessor_name].to_sym)
+            parent_records = records.map(&details[:cached_accessor_name].to_sym).compact
           else
             raise ArgumentError.new("Non-embedded has_one associations do not support prefetching yet.")
           end

data/lib/identity_cache/version.rb

@@ -1,4 +1,4 @@
 module IdentityCache
-  VERSION = "0.5.0"
+  VERSION = "0.5.1"
   CACHE_VERSION = 7
 end

data/test/prefetch_associations_test.rb

@@ -124,6 +124,21 @@ class PrefetchAssociationsTest < IdentityCache::TestCase
     end
   end
 
+  def test_prefetch_associations_through_nil_cache_has_one_association
+    Item.send(:cache_has_one, :associated, embed: true)
+    AssociatedRecord.send(:cache_has_many, :deeply_associated_records, embed: :ids)
+    bob_child = @bob.create_associated!(name: "bob child")
+    bob_child.deeply_associated_records.create!(name: "deep child")
+    AssociatedRecord.fetch_multi(bob_child.id)
+    Item.fetch_multi(@bob.id, @joe.id)
+
+    assert_memcache_operations(2) do
+      cached_bob, cached_joe = Item.fetch_multi(@bob.id, @joe.id, includes: {:associated => :deeply_associated_records})
+      assert_nil cached_joe.fetch_associated
+      assert_equal 'deep child', cached_bob.fetch_associated.fetch_deeply_associated_records.first.name
+    end
+  end
+
   def test_fetch_with_includes_option
     Item.send(:cache_belongs_to, :item)
     john = Item.create!(title: 'john')

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: identity_cache
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 0.5.1
 platform: ruby
 authors:
 - Camilo Lopez
@@ -14,7 +14,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-02-07 00:00:00.000000000 Z
+date: 2017-02-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: ar_transaction_changes