identity_cache 0.3.0 → 0.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e9c2e392201ed1b9c143a6ebff82f7c7af602a89
-  data.tar.gz: 445f3ce67f61a386db9bd99939d169e03562052b
+  metadata.gz: 3aaaad2b3f7ef8cd9c4aaeb338756bfcccfcbd4c
+  data.tar.gz: 06ee79bbcc777f7903139d9eab772ddcd50ad1af
 SHA512:
-  metadata.gz: d3012a594fb51bcd37c08e322545b4cf3d9e2fe8ce3d14253df79cb423fd673f143e7dea5b8c7b13499660c56db9e266d3bc0fe6e923a6f1c37a918ba5d63fa4
-  data.tar.gz: a790523fd6989dde3669602a4ddd045032c44808f7e1f6a06f3e01fbf93e9ac137377e77fd360266a11642fdf7c6d5ef21ec1cb157a1d4ea37e2bde88dc5612c
+  metadata.gz: 0678a544ee6f53d428517c5a44409a1f93a9e690002f6c8d3efe1ee731f50aed2eef3c68b7bba5b66f4500b0fd5bdef9fc09e990a1e9a5ece1d0fac8e496ada6
+  data.tar.gz: c1313137f940b3e7c22523b9bf331416f4824288d4e45617931042641e73aabef0bc1d659384faf6be904d503164f80748c783fb5c3d216c72b1af0a6d40b2ba

data/CHANGELOG.md

@@ -1,6 +1,11 @@
 # IdentityCache changelog
 
-#### 0.2.6 (unreleased)
+#### 0.3.1
+
+- Fix cache_index for non-id primary key
+
+#### 0.3.0
+
 - Add support for includes option on cache_index and fetch_by_id
 - Use ActiveRecord instantiate
 - Add association pre-fetching support for fetch_by_id

data/lib/identity_cache/configuration_dsl.rb

@@ -51,7 +51,7 @@ module IdentityCache
         if unique
           self.instance_eval(ruby = <<-CODE, __FILE__, __LINE__ + 1)
             def fetch_by_#{field_list}(#{arg_list}, options={})
-              id = fetch_#{primary_key}_by_#{field_list}(#{arg_list})
+              id = fetch_id_by_#{field_list}(#{arg_list})
               id && fetch_by_id(id, options)
             end
 
@@ -63,7 +63,7 @@ module IdentityCache
         else
           self.instance_eval(ruby = <<-CODE, __FILE__, __LINE__ + 1)
             def fetch_by_#{field_list}(#{arg_list}, options={})
-              ids = fetch_#{primary_key}_by_#{field_list}(#{arg_list})
+              ids = fetch_id_by_#{field_list}(#{arg_list})
               ids.empty? ? ids : fetch_multi(ids, options)
             end
           CODE

data/lib/identity_cache/version.rb

@@ -1,4 +1,4 @@
 module IdentityCache
-  VERSION = "0.3.0"
+  VERSION = "0.3.1"
   CACHE_VERSION = 6
 end

data/test/index_cache_test.rb

@@ -141,6 +141,18 @@ class IndexCacheTest < IdentityCache::TestCase
     end
   end
 
+  def test_cache_index_with_non_id_primary_key
+    KeyedRecord.cache_index :value
+    fixture = KeyedRecord.create!(value: "a") { |r| r.hashed_key = 123 }
+    assert_equal [123], KeyedRecord.fetch_by_value('a').map(&:id)
+  end
+
+  def test_unique_cache_index_with_non_id_primary_key
+    KeyedRecord.cache_index :value, unique: true
+    fixture = KeyedRecord.create!(value: "a") { |r| r.hashed_key = 123 }
+    assert_equal 123, KeyedRecord.fetch_by_value('a').id
+  end
+
   private
 
   def cache_key(unique: false)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: identity_cache
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.3.1
 platform: ruby
 authors:
 - Camilo Lopez
@@ -268,7 +268,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.0
+rubygems_version: 2.2.3
 signing_key: 
 specification_version: 4
 summary: IdentityCache lets you specify how you want to cache your model objects,