ideal-mollie 0.0.4 → 0.0.5

data/.travis.yml

@@ -3,6 +3,8 @@ rvm:
   - 1.8.7
   - 1.9.2
   - 1.9.3
+  - ree
+  - jruby
 script: "bundle exec rake spec"
 notifications:
   recipients:

data/CHANGELOG.md

@@ -1,5 +1,8 @@
 # Changelog
 
+- **30 January 2012**: version 0.0.5
+    - Added support for multiple profile's
+
 - **26 January 2012**: version 0.0.4
     - Changed property `payed` to `paid`
 

data/README.md

@@ -41,6 +41,12 @@ config.ideal_mollie.return_url = "http://example.org/return"
 config.ideal_mollie.test_mode = false
 ```
 
+Optionally you can add a profile_key if you have multiple profile's
+
+```
+config.ideal_mollie.profile_key = "123abc45"
+```
+
 ## Rails Example
 
 Below you will find a simple `TransactionController` and a view to display the bank selectbox. Note that this is just a very basic example.
@@ -87,27 +93,25 @@ class TransactionsController < ApplicationController
       #   my_order.customer_city = response.customer_city
       #   my_order.save
     else
-      # canceled or re-checking?
-      if my_order.paid.nil?
-        # TODO: store the result information for the canceled payment
-        # For example:
-        #   my_order = MyOrder.find_by_transaction_id(transaction_id)
-        #   my_order.paid = false
-        #   my_order.save
-      end
+      # TODO: store the result information for the canceled payment
+      # For example:
+      #   my_order = MyOrder.find_by_transaction_id(transaction_id)
+      #   my_order.paid = false
+      #   my_order.save
     end
     render :nothing => true
   end
 
   def result
+    transaction_id = params[:transaction_id]
     # TODO show the result
     # For example:
-    #   my_order = MyOrderObject.find(id)
-    #if @my_order.paid
-      render :text => "Thank you for your payment."
-    else
-      render :text => "Transaction has been cancelled or couldn't complete"
-    end
+    #   my_order = MyOrder.find_by_transaction_id(transaction_id)
+    #   if my_order.paid
+    #     render :text => "Thank you for your payment."
+    #   else
+    #     render :text => "Transaction has been cancelled or couldn't complete"
+    #   end
   end
 end
 ```

data/ideal-mollie.gemspec

@@ -30,4 +30,5 @@ Gem::Specification.new do |s|
   s.add_dependency "faraday_middleware", "~> 0.8.1"
   s.add_dependency "multi_xml", "~> 0.4.1"
   s.add_dependency "nokogiri", "~> 1.5.0"
+  s.add_dependency "jruby-openssl" if RUBY_PLATFORM == 'java'
 end

data/lib/ideal-mollie.rb

@@ -67,7 +67,7 @@ module IdealMollie
   #   IdealMollie.check_order("4b99662febb42ce6f889d9c57f5cf3fa")
   #
   # @note Once a transaction is paid, only the next time you verify the
-  #   transaction will the value of +payed+ be +true+.
+  #   transaction will the value of +paid+ be +true+.
   #   Else it will be +false+.
   #
   # @return [IdealMollie::OrderResult] the +OrderResult+.
@@ -119,7 +119,7 @@ module IdealMollie
     # @return [Hash] the parameter +Hash+ for the new order.
     def new_order_params(amount, description, bank_id, return_url=nil)
       return_url = Config.return_url if return_url.nil?
-      {
+      params = {
         :partnerid => Config.partner_id,
         :reporturl => Config.report_url,
         :returnurl => return_url,
@@ -127,6 +127,12 @@ module IdealMollie
         :amount => amount,
         :bank_id => bank_id
       }
+
+      unless Config.profile_key.nil?
+        params.merge!({:profile_key => Config.profile_key})
+      end
+
+      params
     end
 
     private

data/lib/ideal-mollie/config.rb

@@ -3,9 +3,13 @@
 #
 module IdealMollie::Config
   class << self
-    # @return [int] You Mollie partner id.
-    # @note You can find you partner id here: https://www.mollie.nl/beheer/betaaldiensten/documentatie/ideal/
+    # @return [int] Your Mollie partner id.
+    # @note See: https://www.mollie.nl/beheer/betaaldiensten/documentatie/ideal/ for your partner id
     attr_accessor :partner_id
+    # @return [String] Your Mollie profile key
+    # @note The is a optional parameter. You only need this if you have multiple profiles
+    # @note See: https://www.mollie.nl/beheer/betaaldiensten/profielen/ for the list of profiles
+    attr_accessor :profile_key
     # @return [String] The url Mollie uses to report the status of the payment
     attr_accessor :report_url
     # @return [String] The url Mollie sends you to when a transaction is finished
@@ -18,6 +22,7 @@ module IdealMollie::Config
     def init!
       @defaults = {
         :@partner_id => nil,
+        :@profile_key => nil,
         :@report_url => nil,
         :@return_url => nil,
         :@test_mode => false

data/lib/ideal-mollie/engine.rb

@@ -3,13 +3,21 @@ module IdealMollie
   # Simpel extend on the +Rails::Engine+ to add support for a new config section within
   # the environment configs
   #
-  # @example
+  # @example default
   #   # /config/environments/development.rb
   #   config.ideal_mollie.partner_id = 123456
   #   config.ideal_mollie.report_url = "http://example.org/report"
   #   config.ideal_mollie.return_url = "http://example.org/return"
   #   config.ideal_mollie.test_mode = false
   #
+  # @example optional profile_key when having to deal with multiple profile's
+  #   # /config/environments/development.rb
+  #   config.ideal_mollie.partner_id = 123456
+  #   config.ideal_mollie.report_url = "http://example.org/report"
+  #   config.ideal_mollie.return_url = "http://example.org/return"
+  #   config.ideal_mollie.test_mode = false
+  #   config.ideal_mollie.profile_key = "123abc45"
+  #
   class Engine < Rails::Engine
     config.ideal_mollie = IdealMollie::Config
   end

data/lib/ideal-mollie/version.rb

@@ -1,4 +1,4 @@
 module IdealMollie
   # Version number of IdealMollie
-  VERSION = "0.0.4"
+  VERSION = "0.0.5"
 end

data/spec/config_spec.rb

@@ -5,6 +5,7 @@ describe IdealMollie::Config do
     @config = IdealMollie::Config
     @config.test_mode = true
     @config.partner_id = 123456
+    @config.profile_key = "321zyx12"
     @config.report_url = "http://example.org/report"
     @config.return_url = "http://example.org/return"
   end
@@ -14,6 +15,7 @@ describe IdealMollie::Config do
       @config.reset!
       @config.test_mode.should be_false
       @config.partner_id.should be_nil
+      @config.profile_key.should be_nil
       @config.report_url.should be_nil
       @config.return_url.should be_nil
     end
@@ -21,8 +23,10 @@ describe IdealMollie::Config do
 
   describe "#update!" do
     it "should update" do
+      @config.reset!
       @config.test_mode = false
       @config.partner_id = 987654
+      @config.profile_key = "123abc45"
       @config.report_url = "report"
       @config.return_url = "return"
       @config.update!
@@ -30,6 +34,7 @@ describe IdealMollie::Config do
       config = IdealMollie::Config
       config.test_mode.should be_false
       config.partner_id.should eq 987654
+      config.profile_key.should eq "123abc45"
       config.report_url.should eq "report"
       config.return_url.should eq "return"
     end

data/spec/ideal_exception_spec.rb

@@ -23,6 +23,20 @@ describe IdealMollie::IdealException do
           to raise_error(IdealMollie::IdealException, /This account does not exist or is suspended./)
       end
     end
+
+    it "should throw an exception when a unknown profile key is specified" do
+      config = IdealMollie::Config
+      config.test_mode = false
+      config.partner_id = 123456
+      config.profile_key = "00000000"
+      config.report_url = "http://example.org/report"
+      config.return_url = "http://example.org/return"
+
+      VCR.use_cassette("new_order") do
+        expect { IdealMollie.new_order(1234, "exception test", "0031") }.
+          to raise_error(IdealMollie::IdealException, /A fetch was issued for an unknown or inactive profile./)
+      end
+    end
   end
 
   context "#check_order" do

data/spec/ideal_mollie_spec.rb

@@ -2,11 +2,12 @@ require 'spec_helper'
 
 describe IdealMollie do
   before(:each) do
-    config = IdealMollie::Config
-    config.test_mode = false
-    config.partner_id = 987654
-    config.report_url = "http://example.org/report"
-    config.return_url = "http://example.org/return"
+    @config = IdealMollie::Config
+    @config.reset!
+    @config.test_mode = false
+    @config.partner_id = 987654
+    @config.report_url = "http://example.org/report"
+    @config.return_url = "http://example.org/return"
   end
 
   context "#banks" do
@@ -34,6 +35,18 @@ describe IdealMollie do
         order.message.should eq "Your iDEAL-payment has successfully been setup. Your customer should visit the given URL to make the payment"
       end
     end
+    it "should return a Order for profile_key with the correct values" do
+      @config.profile_key = "123abc45"
+      @config.update!
+      VCR.use_cassette("new_order") do
+        order = IdealMollie.new_order(1000, "test", "0031")
+        order.transaction_id.should eq "474ed7b2735cbe4d1f4fd4da23269263"
+        order.amount.should eq 1000
+        order.currency.should eq "EUR"
+        order.url.should eq "https://www.abnamro.nl/nl/ideal/identification.do?randomizedstring=6616737002&trxid=30000226032385"
+        order.message.should eq "Your iDEAL-payment has successfully been setup. Your customer should visit the given URL to make the payment"
+      end
+    end
     it "should override the return url when specified" do
       params = IdealMollie.new_order_params(1200, "test", "0031")
       params[:returnurl].should eq "http://example.org/return"
@@ -41,6 +54,17 @@ describe IdealMollie do
       params = IdealMollie.new_order_params(1200, "test", "0031", "http://another.example.org/return")
       params[:returnurl].should eq "http://another.example.org/return"
     end
+    it "should not append the profile_key this isn't specified in the config" do
+      params = IdealMollie.new_order_params(1200, "test", "0031")
+      params.has_key?(:profile_key).should be_false
+    end
+    it "should append the profile_key if specified in the config" do
+      @config.profile_key = 12345
+      @config.update!
+
+      params = IdealMollie.new_order_params(1200, "test", "0031")
+      params.has_key?(:profile_key).should be_true
+    end
   end
 
   context "#check_order" do

data/spec/vcr_cassettes/new_order.yml

@@ -55,6 +55,35 @@
     body: ! "<?xml version=\"1.0\" ?>\n<response>\n\t<item type=\"error\">\n\t\t<errorcode>-2</errorcode>\n\t\t<message>This
       account does not exist or is suspended.</message>\n\t</item>\n</response>"
     http_version: '1.1'
+- !ruby/struct:VCR::HTTPInteraction
+  request: !ruby/struct:VCR::Request
+    method: :post
+    uri: https://secure.mollie.nl:443/xml/ideal?partnerid=123456&reporturl=http%3A%2F%2Fexample.org%2Freport&returnurl=http%3A%2F%2Fexample.org%2Freturn&description=exception%20test&amount=1234&bank_id=0031&profile_key=00000000&a=fetch&testmode=false
+    body:
+    headers:
+      user-agent:
+      - Ruby-IdealMollie
+      content-length:
+      - '0'
+  response: !ruby/struct:VCR::Response
+    status: !ruby/struct:VCR::ResponseStatus
+      code: 200
+      message: OK
+    headers:
+      server:
+      - nginx/0.7.67
+      date:
+      - Mon, 30 Jan 2012 11:30:43 GMT
+      content-type:
+      - text/xml
+      x-powered-by:
+      - PHP/5.2.6-1+lenny13
+      content-length:
+      - '180'
+    body: ! "<?xml version=\"1.0\" ?>\n<response>\n\t<item type=\"error\">\n\t\t<errorcode>-16</errorcode>\n\t\t<message>A
+      fetch was issued for an unknown or inactive profile.</message>\n\t</item>\n</response>"
+    http_version: '1.1'
+
 - !ruby/struct:VCR::HTTPInteraction
   request: !ruby/struct:VCR::Request
     method: :post
@@ -84,3 +113,32 @@
       iDEAL-payment has successfully been setup. Your customer should visit the given
       URL to make the payment</message>\n\t</order>\n</response>"
     http_version: '1.1'
+- !ruby/struct:VCR::HTTPInteraction
+  request: !ruby/struct:VCR::Request
+    method: :post
+    uri: https://secure.mollie.nl:443/xml/ideal?partnerid=987654&reporturl=http%3A%2F%2Fexample.org%2Freport&returnurl=http%3A%2F%2Fexample.org%2Freturn&description=test&amount=1000&bank_id=0031&profile_key=123abc45&a=fetch&testmode=false
+    body:
+    headers:
+      user-agent:
+      - Ruby-IdealMollie
+      content-length:
+      - '0'
+  response: !ruby/struct:VCR::Response
+    status: !ruby/struct:VCR::ResponseStatus
+      code: 200
+      message: OK
+    headers:
+      server:
+      - nginx/0.7.67
+      date:
+      - Mon, 30 Jan 2012 11:27:25 GMT
+      content-type:
+      - text/xml
+      x-powered-by:
+      - PHP/5.2.6-1+lenny13
+      content-length:
+      - '429'
+    body: ! "<?xml version=\"1.0\" ?>\n<response>\n\t<order>\n\t\t<transaction_id>474ed7b2735cbe4d1f4fd4da23269263</transaction_id>\n\t\t<amount>1000</amount>\n\t\t<currency>EUR</currency>\n\t\t<URL>https://www.abnamro.nl/nl/ideal/identification.do?randomizedstring=6616737002&amp;trxid=30000226032385</URL>\n\t\t<message>Your
+      iDEAL-payment has successfully been setup. Your customer should visit the given
+      URL to make the payment</message>\n\t</order>\n</response>"
+    http_version: '1.1'

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ideal-mollie
 version: !ruby/object:Gem::Version
-  version: 0.0.4
+  version: 0.0.5
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-01-27 00:00:00.000000000 Z
+date: 2012-01-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &17571080 !ruby/object:Gem::Requirement
+  requirement: &8774100 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,10 +21,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *17571080
+  version_requirements: *8774100
 - !ruby/object:Gem::Dependency
   name: vcr
-  requirement: &17585420 !ruby/object:Gem::Requirement
+  requirement: &8788740 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -32,10 +32,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *17585420
+  version_requirements: *8788740
 - !ruby/object:Gem::Dependency
   name: fakeweb
-  requirement: &17584460 !ruby/object:Gem::Requirement
+  requirement: &8785780 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -43,10 +43,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *17584460
+  version_requirements: *8785780
 - !ruby/object:Gem::Dependency
   name: yard
-  requirement: &17583660 !ruby/object:Gem::Requirement
+  requirement: &8784680 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -54,10 +54,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *17583660
+  version_requirements: *8784680
 - !ruby/object:Gem::Dependency
   name: redcarpet
-  requirement: &17582880 !ruby/object:Gem::Requirement
+  requirement: &8783740 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -65,10 +65,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *17582880
+  version_requirements: *8783740
 - !ruby/object:Gem::Dependency
   name: simplecov
-  requirement: &17582100 !ruby/object:Gem::Requirement
+  requirement: &8782940 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -76,10 +76,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *17582100
+  version_requirements: *8782940
 - !ruby/object:Gem::Dependency
   name: rake
-  requirement: &17581020 !ruby/object:Gem::Requirement
+  requirement: &8782060 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -87,10 +87,10 @@ dependencies:
         version: 0.9.0
   type: :runtime
   prerelease: false
-  version_requirements: *17581020
+  version_requirements: *8782060
 - !ruby/object:Gem::Dependency
   name: faraday
-  requirement: &17579760 !ruby/object:Gem::Requirement
+  requirement: &8797660 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -98,10 +98,10 @@ dependencies:
         version: 0.7.6
   type: :runtime
   prerelease: false
-  version_requirements: *17579760
+  version_requirements: *8797660
 - !ruby/object:Gem::Dependency
   name: faraday_middleware
-  requirement: &17578880 !ruby/object:Gem::Requirement
+  requirement: &8796900 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -109,10 +109,10 @@ dependencies:
         version: 0.8.1
   type: :runtime
   prerelease: false
-  version_requirements: *17578880
+  version_requirements: *8796900
 - !ruby/object:Gem::Dependency
   name: multi_xml
-  requirement: &17593740 !ruby/object:Gem::Requirement
+  requirement: &8795760 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -120,10 +120,10 @@ dependencies:
         version: 0.4.1
   type: :runtime
   prerelease: false
-  version_requirements: *17593740
+  version_requirements: *8795760
 - !ruby/object:Gem::Dependency
   name: nokogiri
-  requirement: &17592060 !ruby/object:Gem::Requirement
+  requirement: &8793840 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -131,7 +131,7 @@ dependencies:
         version: 1.5.0
   type: :runtime
   prerelease: false
-  version_requirements: *17592060
+  version_requirements: *8793840
 description: A simple Ruby implementation for handeling iDeal transactions with the
   Mollie API
 email:
@@ -180,7 +180,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -2711657379205421306
+      hash: -4164822868320701030
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -189,7 +189,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -2711657379205421306
+      hash: -4164822868320701030
 requirements: []
 rubyforge_project: ideal-mollie
 rubygems_version: 1.8.11