icu_ratings 1.6.1 → 1.7.0

data/lib/icu_ratings/tournament.rb

@@ -124,6 +124,10 @@ module ICU
         update_bonuses  = true
         threshold       = 0.1
       end
+      if version >= 3
+        # See http://ratings.icu.ie/articles/18 (Part 3)
+        max_iterations = [50, 50]
+      end
 
       # Phase 1.
       players.each { |p| p.reset }

data/lib/icu_ratings/version.rb

@@ -2,6 +2,6 @@
 
 module ICU
   class Ratings
-    VERSION = "1.6.1"
+    VERSION = "1.7.0"
   end
 end

data/spec/tournament_spec.rb

@@ -2445,5 +2445,181 @@ module ICU
         post_cap_bonus.should be < 0
       end
     end
+
+    context "#rate - tournament with convergence problem" do
+      before(:each) do
+        @t = ICU::RatedTournament.new(desc: "Connaught U16 Juniors 2013")
+
+        @p01 = @t.add_player(1,   desc: "Ni Mhuireagain, Eibhia", rating: 1169, kfactor: 40)
+        @p02 = @t.add_player(2,   desc: "Kelly,Jack")
+        @p03 = @t.add_player(3,   desc: "Murray,Ellen", rating: 340, kfactor: 40)
+        @p04 = @t.add_player(4,   desc: "Hanrahan,David", rating: 613, games: 3)
+        @p05 = @t.add_player(5,   desc: "Fleming,Leah")
+        @p06 = @t.add_player(6,   desc: "Kozlovs,Andrejs")
+        @p07 = @t.add_player(7,   desc: "Fernhead,George")
+        @p08 = @t.add_player(8,   desc: "Ryan,Clodagh")
+        @p09 = @t.add_player(9,   desc: "Connolly,Sean", rating: 462, games: 6)
+        @p10 = @t.add_player(10,  desc: "Fernhead,John")
+        @p11 = @t.add_player(11,  desc: "McStay,Thomas", rating: 376, games: 12)
+        @p12 = @t.add_player(12,  desc: "Mitchell,Jack", rating: 228, games: 11)
+        @p13 = @t.add_player(13,  desc: "McDonagh,Conor")
+        @p14 = @t.add_player(14,  desc: "Arinyoy,Other")
+        @p15 = @t.add_player(15,  desc: "O'Tuathail,Eimear", rating: 370, games: 7)
+        @p16 = @t.add_player(16,  desc: "Fleming,Harry")
+        @p17 = @t.add_player(17,  desc: "Ritter,Johannes")
+        @p18 = @t.add_player(18,  desc: "Mahon,Colm")
+        @p19 = @t.add_player(19,  desc: "Connell,Kevin")
+        @p20 = @t.add_player(20,  desc: "Ryan,Aoife")
+
+        @t.add_result(1,  1, 17, "W")
+        @t.add_result(2,  1,  3, "W")
+        @t.add_result(3,  1, 12, "W")
+        @t.add_result(4,  1,  2, "W")
+        @t.add_result(5,  1,  4, "W")
+        @t.add_result(6,  1,  6, "W")
+        @t.add_result(7,  1, 10, "W")
+        @t.add_result(1,  2,  7, "W")
+        @t.add_result(2,  2,  6, "W")
+        @t.add_result(3,  2, 13, "W")
+        @t.add_result(4,  2,  1, "L")
+        @t.add_result(5,  2, 10, "W")
+        @t.add_result(6,  2,  3, "W")
+        @t.add_result(7,  2,  4, "W")
+        @t.add_result(1,  3, 11, "W")
+        @t.add_result(2,  3,  1, "L")
+        @t.add_result(3,  3,  6, "W")
+        @t.add_result(4,  3, 12, "W")
+        @t.add_result(5,  3, 15, "W")
+        @t.add_result(6,  3,  2, "L")
+        @t.add_result(7,  3,  9, "W")
+        @t.add_result(1,  4, 19, "W")
+        @t.add_result(2,  4, 16, "W")
+        @t.add_result(3,  4,  9, "W")
+        @t.add_result(4,  4, 10, "D")
+        @t.add_result(5,  4,  1, "L")
+        @t.add_result(6,  4,  5, "W")
+        @t.add_result(7,  4,  2, "L")
+        @t.add_result(1,  5, 12, "L")
+        @t.add_result(2,  5, 11, "L")
+        @t.add_result(3,  5, 20, "W")
+        @t.add_result(4,  5, 18, "W")
+        @t.add_result(5,  5, 14, "W")
+        @t.add_result(6,  5,  4, "L")
+        @t.add_result(7,  5, 15, "W")
+        @t.add_result(1,  6, 10, "W")
+        @t.add_result(2,  6,  2, "L")
+        @t.add_result(3,  6,  3, "L")
+        @t.add_result(4,  6, 17, "W")
+        @t.add_result(5,  6,  9, "W")
+        @t.add_result(6,  6,  1, "L")
+        @t.add_result(7,  6, 12, "W")
+        @t.add_result(1,  7,  2, "L")
+        @t.add_result(2,  7,  9, "L")
+        @t.add_result(3,  7, 19, "L")
+        @t.add_result(4,  7, 20, "W")
+        @t.add_result(5,  7, 18, "W")
+        @t.add_result(6,  7, 17, "W")
+        @t.add_result(7,  7, 14, "W")
+        @t.add_result(1,  8, 13, "L")
+        @t.add_result(2,  8, 20, "W")
+        @t.add_result(3,  8, 14, "W")
+        @t.add_result(4,  8, 15, "L")
+        @t.add_result(5,  8, 12, "D")
+        @t.add_result(6,  8,  9, "L")
+        @t.add_result(7,  8, 18, "W")
+        @t.add_result(1,  9, 16, "D")
+        @t.add_result(2,  9,  7, "W")
+        @t.add_result(3,  9,  4, "L")
+        @t.add_result(4,  9, 13, "W")
+        @t.add_result(5,  9,  6, "L")
+        @t.add_result(6,  9,  8, "W")
+        @t.add_result(7,  9,  3, "L")
+        @t.add_result(1, 10,  6, "L")
+        @t.add_result(2, 10, 17, "W")
+        @t.add_result(3, 10, 11, "W")
+        @t.add_result(4, 10,  4, "D")
+        @t.add_result(5, 10,  2, "L")
+        @t.add_result(6, 10, 15, "W")
+        @t.add_result(7, 10,  1, "L")
+        @t.add_result(1, 11,  3, "L")
+        @t.add_result(2, 11,  5, "W")
+        @t.add_result(3, 11, 10, "L")
+        @t.add_result(4, 11, 14, "L")
+        @t.add_result(5, 11, 17, "D")
+        @t.add_result(6, 11, 19, "W")
+        @t.add_result(7, 11, 16, "W")
+        @t.add_result(1, 12,  5, "W")
+        @t.add_result(2, 12, 14, "W")
+        @t.add_result(3, 12,  1, "L")
+        @t.add_result(4, 12,  3, "L")
+        @t.add_result(5, 12,  8, "D")
+        @t.add_result(6, 12, 16, "W")
+        @t.add_result(7, 12,  6, "L")
+        @t.add_result(1, 13,  8, "W")
+        @t.add_result(2, 13, 15, "W")
+        @t.add_result(3, 13,  2, "L")
+        @t.add_result(4, 13,  9, "L")
+        @t.add_result(5, 13, 16, "L")
+        @t.add_result(6, 13, 14, "L")
+        @t.add_result(7, 13, 19, "W")
+        @t.add_result(1, 14, 20, "W")
+        @t.add_result(2, 14, 12, "L")
+        @t.add_result(3, 14,  8, "L")
+        @t.add_result(4, 14, 11, "W")
+        @t.add_result(5, 14,  5, "L")
+        @t.add_result(6, 14, 13, "W")
+        @t.add_result(7, 14,  7, "L")
+        @t.add_result(1, 15, 18, "W")
+        @t.add_result(2, 15, 13, "L")
+        @t.add_result(3, 15, 16, "W")
+        @t.add_result(4, 15,  8, "W")
+        @t.add_result(5, 15,  3, "L")
+        @t.add_result(6, 15, 10, "L")
+        @t.add_result(7, 15,  5, "L")
+        @t.add_result(1, 16,  9, "D")
+        @t.add_result(2, 16,  4, "L")
+        @t.add_result(3, 16, 15, "L")
+        @t.add_result(4, 16, 19, "W")
+        @t.add_result(5, 16, 13, "W")
+        @t.add_result(6, 16, 12, "L")
+        @t.add_result(7, 16, 11, "L")
+        @t.add_result(1, 17,  1, "L")
+        @t.add_result(2, 17, 10, "L")
+        @t.add_result(3, 17, 18, "W")
+        @t.add_result(4, 17,  6, "L")
+        @t.add_result(5, 17, 11, "D")
+        @t.add_result(6, 17,  7, "L")
+        @t.add_result(7, 17, 20, "W")
+        @t.add_result(1, 18, 15, "L")
+        @t.add_result(2, 18, 19, "W")
+        @t.add_result(3, 18, 17, "L")
+        @t.add_result(4, 18,  5, "L")
+        @t.add_result(5, 18,  7, "L")
+        @t.add_result(6, 18, 20, "W")
+        @t.add_result(7, 18,  8, "L")
+        @t.add_result(1, 19,  4, "L")
+        @t.add_result(2, 19, 18, "L")
+        @t.add_result(3, 19,  7, "W")
+        @t.add_result(4, 19, 16, "L")
+        @t.add_result(5, 19, 20, "W")
+        @t.add_result(6, 19, 11, "L")
+        @t.add_result(7, 19, 13, "L")
+        @t.add_result(1, 20, 14, "L")
+        @t.add_result(2, 20,  8, "L")
+        @t.add_result(3, 20,  5, "L")
+        @t.add_result(4, 20,  7, "L")
+        @t.add_result(5, 20, 19, "L")
+        @t.add_result(6, 20, 18, "L")
+        @t.add_result(7, 20, 17, "L")
+      end
+
+      it "should not converge with version 2 settings" do
+        lambda { @t.rate!(version: 2) }.should raise_error(/performance rating estimation did not converge/)
+      end
+
+      it "should converge with version 3 settings (higher maximum number of iterations)" do
+        lambda { @t.rate!(version: 3) }.should_not raise_error
+      end
+    end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: icu_ratings
 version: !ruby/object:Gem::Version
-  version: 1.6.1
+  version: 1.7.0
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-07-22 00:00:00.000000000 Z
+date: 2013-08-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -112,7 +112,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 3990992801625361431
+      hash: -3613568099200182560
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -121,7 +121,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 3990992801625361431
+      hash: -3613568099200182560
 requirements: []
 rubyforge_project: icu_ratings
 rubygems_version: 1.8.23