icapps-translations 0.2.0 → 0.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 43a4c063cd284480ac0ba00710f15b9ee3dc66a0
-  data.tar.gz: 18501eeac2975dbe452748dd98d508a7d6fe1d92
+  metadata.gz: 7dd2178741324fa58e7936b8807d41bdda6ec28a
+  data.tar.gz: a86b14558053d326198c1d2dc913e810124249e2
 SHA512:
-  metadata.gz: 452909028b55b33562ddb0e126dd3cf1850a996f475c50f8066c416292c891c9ba0686d6a6e561abe069ed179c87d7fd483e6a2b95d61a09fb03a3325d6c3dd7
-  data.tar.gz: f4b52bf360483b47acff530231299d5b44be5eb62d109c7115c093df1e2a94705db959f8df80b44d2f3855690ae69eb07aaa39050832890cd293c3d05f8e6fe9
+  metadata.gz: d1df6931a9b3cad88373fd51f62108fa4e4f810d58d61ccb19116a9d7448455cb05b77babb41474abf55831b10eac69ff5dd49e82648ee33d553fe2f91ec493d
+  data.tar.gz: be7e24477c232b132b4097ff123a2997dd298c50dcee80d30ca24cf83b27bf322d996de73a3e541ddd9370362f4fb053453ea1eb4530bfb53c4fa26e9b342089

data/.rubocop.yml

@@ -0,0 +1,21 @@
+# This configuration was generated by `rubocop --auto-gen-config`
+# on 2015-10-13 11:47:22 +0200 using RuboCop version 0.29.1.
+# The point is for the user to remove these configuration records
+# one by one as the offenses are removed from the code base.
+# Note that changes in the inspected code, or installation of new
+# versions of RuboCop, may require this file to be generated again.
+
+Metrics/AbcSize:
+  Max: 21
+
+Metrics/LineLength:
+  Max: 143
+
+Metrics/MethodLength:
+  Max: 12
+
+Style/Documentation:
+  Enabled: false
+
+Style/GuardClause:
+  Enabled: false

data/README.md

@@ -39,5 +39,6 @@ Then build the gem by running the following commands:
 1. Fork it ( https://github.com/icapps/translations/fork )
 2. Create your feature branch (`git checkout -b my-new-feature`)
 3. Commit your changes (`git commit -am 'Add some feature'`)
-4. Push to the branch (`git push origin my-new-feature`)
-5. Create a new Pull Request
+4. Run `rubycop` in order to be compliant to our coding style.
+5. Push to the branch (`git push origin my-new-feature`)
+6. Create a new Pull Request

data/Rakefile

@@ -1,2 +1 @@
-require "bundler/gem_tasks"
-
+require 'bundler/gem_tasks'

data/icapps-translations.gemspec

@@ -4,21 +4,21 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'icapps/translations/version'
 
 Gem::Specification.new do |spec|
-  spec.name          = "icapps-translations"
+  spec.name          = 'icapps-translations'
   spec.version       = Icapps::Translations::VERSION
-  spec.authors       = ["Jelle Vandebeeck"]
-  spec.email         = ["jelle.vandebeeck@icapps.com"]
-  spec.summary       = %q{Import translations from the iCapps translations portal.}
+  spec.authors       = ['Jelle Vandebeeck']
+  spec.email         = ['jelle.vandebeeck@icapps.com']
+  spec.summary       = 'Import translations from the iCapps translations portal.'
   spec.homepage      = 'https://github.com/icapps/translations'
-  spec.license       = "MIT"
+  spec.license       = 'MIT'
 
   spec.files         = `git ls-files -z`.split("\x0")
-  spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
-  spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
-  spec.require_paths = ["lib"]
+  spec.executables   = spec.files.grep(/^bin/) { |f| File.basename(f) }
+  spec.test_files    = spec.files.grep(/^(test|spec|features)/)
+  spec.require_paths = ['lib']
 
-  spec.add_development_dependency "bundler", "~> 1.7"
-  spec.add_development_dependency "rake", "~> 10.0"
+  spec.add_development_dependency 'bundler', '~> 1.7'
+  spec.add_development_dependency 'rake', '~> 10.0'
 
   spec.add_dependency 'thor', '~> 0.19'
   spec.add_dependency 'colorize', '~> 0.7'

data/lib/icapps/translations/cli.rb

@@ -1,8 +1,8 @@
 require 'thor'
 require 'colorize'
 
-require "icapps/translations/configuration"
-require "icapps/translations/import/xcode"
+require 'icapps/translations/configuration'
+require 'icapps/translations/import/xcode'
 
 module Icapps
   module Translations

data/lib/icapps/translations/configuration.rb

@@ -4,9 +4,10 @@ require 'yaml'
 module Icapps
   module Translations
     class Configuration
-      attr :url
-      attr :filename
-      attr :project_key
+      attr_reader :url
+      attr_reader :filename
+      attr_reader :project_key
+      attr_reader :default_language
 
       class << self
         def create
@@ -15,12 +16,12 @@ module Icapps
             return
           end
 
-          File.open(path, "w") { |f| f.write(initial_content.to_yaml) }
+          File.open(path, 'w') { |f| f.write(initial_content.to_yaml) }
           puts "[MESSAGE] Configuration created at '#{path}'.".colorize(:green)
         end
 
         def exists?
-          File.exists?(path)
+          File.exist?(path)
         end
 
         def path
@@ -36,6 +37,15 @@ module Icapps
         end
 
         def initial_content
+          ::Icapps::Translations.android? ? android_initial_content : common_initial_content
+        end
+
+        def android_initial_content
+          common_initial_content.merge!(filename: 'strings.xml',
+                                        default_language: 'en')
+        end
+
+        def common_initial_content
           {
             url:         'http://your_url.com',
             filename:    'Localizable.strings',
@@ -59,11 +69,12 @@ module Icapps
       def read_config
         puts "[VERBOSE] Reading the config file at '#{Configuration.path}'.".colorize(:white) if Configuration.options[:verbose]
 
-        params = YAML::load File.open(Configuration.path)
+        params = YAML.load File.open(Configuration.path)
         if params
-          @filename = params[:filename]
-          @url = params[:url]
-          @project_key = params[:project_key]
+          @filename         = params[:filename]
+          @url              = params[:url]
+          @project_key      = params[:project_key]
+          @default_language = params[:default_language]
         end
       end
     end

data/lib/icapps/translations/http.rb

@@ -6,13 +6,13 @@ module Icapps
   module Translations
     class Http
       class << self
-        def authenticated_response(path, is_json=false)
+        def authenticated_response(path, is_json = false)
           uri = URI("#{config.url}/#{path}")
           puts "[VERBOSE] Connecting to url '#{uri}'.".colorize(:white) if options[:verbose]
 
           http = Net::HTTP.new(uri.host, uri.port)
           request =  Net::HTTP::Get.new(uri)
-          request.add_field "Authorization", "Token token=#{config.project_key}"
+          request.add_field 'Authorization', "Token token=#{config.project_key}"
           response = http.request(request)
           is_json ? JSON.parse(response.body) : response.body
         end

data/lib/icapps/translations/import/base.rb

@@ -1,6 +1,6 @@
 require 'colorize'
 
-require "icapps/translations/http"
+require 'icapps/translations/http'
 
 module Icapps
   module Translations
@@ -14,7 +14,7 @@ module Icapps
             puts "[VERBOSE] There are currently #{languages_json.count} language(s) for this project.".colorize(:white) if options[:verbose]
 
             languages_json.each { |language| fetch_language_file language }
-            puts "[MESSAGE] Finished importing translation.".colorize(:green)
+            puts '[MESSAGE] Finished importing translation.'.colorize(:green)
           end
 
           def options

data/lib/icapps/translations/import/gradle.rb

@@ -1,7 +1,7 @@
 require 'colorize'
 
-require "icapps/translations/http"
-require "icapps/translations/import/base"
+require 'icapps/translations/http'
+require 'icapps/translations/import/base'
 
 module Icapps
   module Translations
@@ -27,9 +27,12 @@ module Icapps
 
           private
 
+          def default_language
+            config.default_language || 'en'
+          end
+
           def values_name(short_name)
-            if short_name == 'en'
-              # Default language is English.
+            if short_name == default_language
               'values'
             else
               # Android requires the country code to be prefixed with an 'r'.

data/lib/icapps/translations/import/xcode.rb

@@ -1,7 +1,7 @@
 require 'colorize'
 
-require "icapps/translations/http"
-require "icapps/translations/import/base"
+require 'icapps/translations/http'
+require 'icapps/translations/import/base'
 
 module Icapps
   module Translations

data/lib/icapps/translations/version.rb

@@ -1,5 +1,5 @@
 module Icapps
   module Translations
-    VERSION = "0.2.0"
+    VERSION = '0.2.1'
   end
 end

data/lib/icapps/translations.rb

@@ -1,7 +1,7 @@
-require "icapps/translations/version"
-require "icapps/translations/cli"
-require "icapps/translations/import/xcode"
-require "icapps/translations/import/gradle"
+require 'icapps/translations/version'
+require 'icapps/translations/cli'
+require 'icapps/translations/import/xcode'
+require 'icapps/translations/import/gradle'
 
 module Icapps
   module Translations
@@ -17,23 +17,23 @@ module Icapps
         config.validate
 
         # Import the files.
-        if is_xcode?
-          puts "[VERBOSE] Detected an Xcode project.".colorize(:white) if options[:verbose]
+        if xcode?
+          puts '[VERBOSE] Detected an Xcode project.'.colorize(:white) if options[:verbose]
           Import::Xcode.import
-        elsif is_android?
-          puts "[VERBOSE] Detected an Android project with a .gradle file.".colorize(:white) if options[:verbose]
+        elsif android?
+          puts '[VERBOSE] Detected an Android project with a .gradle file.'.colorize(:white) if options[:verbose]
           Import::Gradle.import
         else
           abort '[ERROR] No Xcode or Android gradle file detected.'.colorize(:red) unless @project_key
         end
       end
 
-      def is_android?
-        Dir.glob("**/*.gradle").count > 0
+      def android?
+        Dir.glob('**/*.gradle').count > 0
       end
 
-      def is_xcode?
-        Dir.glob("**/*.xcodeproj").count > 0
+      def xcode?
+        Dir.glob('**/*.xcodeproj').count > 0
       end
     end
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: icapps-translations
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.2.1
 platform: ruby
 authors:
 - Jelle Vandebeeck
@@ -75,6 +75,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
+- ".rubocop.yml"
 - Gemfile
 - LICENSE.txt
 - README.md