ibandit 1.3.0 → 1.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 10a72dbe9ec29e1f07a823f20185001a7df1af4db94dd8745772f0d49dfa4db3
-  data.tar.gz: 75abab8d2b505db0c3c5632d6e3db401a587b34e7605e10db11426170a179500
+  metadata.gz: bd9995eaf5ee5234723077679edc4d0a392f2e94179f29dc3dde3957f9164ce9
+  data.tar.gz: 77487285fcfaf55c76c6ec12c7122a3c7ba33e659ab03211f8720181d0315a72
 SHA512:
-  metadata.gz: f8f17a0fbd173c6a71722ec045d0e2a16c671b987c01b354d13761eec9e1fb662deffbff58f3106da46884cea357d03d672e698d9cd1e8e790308762b388f106
-  data.tar.gz: e78e45cc32fb993c73a989b5462daa411365691f03fde13cdda5eafdc80f801c57c7c7e4f016ebc060e7bef93c795a63bbfe18332c10162fd33a45d47eb8afbb
+  metadata.gz: e99899a1576356e2580619ab63eec53ca8d83259e1de48d4b8d939468e3629724559a39dc6db2265d0e6a058295f962b16aa6294048c9afa156e299a3a269366
+  data.tar.gz: 5862d478bd2a01ed65b9fffe6df750b085a3cd027a13f9c27803d02c875be0880c9db3eb85135540f81a76de18c5fc960a331e9f64f401f9b2992216572efd0f

data/CHANGELOG.md

@@ -1,3 +1,9 @@
+## 1.4.0 - February 22, 2021
+
+- [Breaking] Correct `swift_national_id` for Canadian Psudo Ibans. Before `swift_national_id`
+  would return the institution code only. Now it returns the `{institution_code}{branch_code}` as
+  per the format for electronic transfers - `0YYYXXXXX`
+
 ## 1.3.0 - February 18, 2021
 
 - Add support for BY, EG, FO, IQ, LC, SC, UA and VA

data/data/structures.yml

@@ -997,7 +997,7 @@ CA:
   :bank_code_format: "\\d{4}"
   :branch_code_format: "\\d{5}"
   :account_number_format: "\\d{7,12}"
-  :national_id_length: 4
+  :national_id_length: 9
   :pseudo_iban_bank_code_length: 4
   :pseudo_iban_branch_code_length: 5
   :pseudo_iban_account_number_length: 12

data/lib/ibandit/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Ibandit
-  VERSION = "1.3.0"
+  VERSION = "1.4.0"
 end

data/spec/ibandit/iban_spec.rb

@@ -422,7 +422,7 @@ describe Ibandit::IBAN do
         its(:swift_bank_code) { is_expected.to eq("0036") }
         its(:swift_branch_code) { is_expected.to eq("00063") }
         its(:swift_account_number) { is_expected.to eq("000000123456") }
-        its(:swift_national_id) { is_expected.to eq("0036") }
+        its(:swift_national_id) { is_expected.to eq("003600063") }
         its(:pseudo_iban) { is_expected.to eq("CAZZ003600063000000123456") }
 
         its(:iban) { is_expected.to be_nil }
@@ -441,7 +441,7 @@ describe Ibandit::IBAN do
         its(:swift_bank_code) { is_expected.to eq("36") }
         its(:swift_branch_code) { is_expected.to eq("00063") }
         its(:swift_account_number) { is_expected.to eq("000000123456") }
-        its(:swift_national_id) { is_expected.to eq("3600") }
+        its(:swift_national_id) { is_expected.to eq("3600063") }
         its(:pseudo_iban) { is_expected.to eq("CAZZ__3600063000000123456") }
 
         its(:iban) { is_expected.to be_nil }
@@ -460,7 +460,7 @@ describe Ibandit::IBAN do
         its(:swift_bank_code) { is_expected.to eq("0036") }
         its(:swift_branch_code) { is_expected.to eq("00063") }
         its(:swift_account_number) { is_expected.to eq("000000123456") }
-        its(:swift_national_id) { is_expected.to eq("0036") }
+        its(:swift_national_id) { is_expected.to eq("003600063") }
         its(:pseudo_iban) { is_expected.to eq("CAZZ003600063000000123456") }
 
         its(:iban) { is_expected.to be_nil }
@@ -486,7 +486,7 @@ describe Ibandit::IBAN do
         its(:swift_bank_code) { is_expected.to eq("0036") }
         its(:swift_branch_code) { is_expected.to eq("00063") }
         its(:swift_account_number) { is_expected.to eq("012345678900") }
-        its(:swift_national_id) { is_expected.to eq("0036") }
+        its(:swift_national_id) { is_expected.to eq("003600063") }
         its(:pseudo_iban) { is_expected.to eq("CAZZ003600063012345678900") }
 
         its(:iban) { is_expected.to be_nil }

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ibandit
 version: !ruby/object:Gem::Version
-  version: 1.3.0
+  version: 1.4.0
 platform: ruby
 authors:
 - GoCardless
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-02-18 00:00:00.000000000 Z
+date: 2021-02-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: gc_ruboconfig