ibandit 1.36.0 → 1.37.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d8bfd630aac225e15cb3f9da75e76cdd628ab808f882b6722421f6fea17660fa
-  data.tar.gz: 345b0848da39eed06d67eddd34e89ab9f744730a3a887c92f950778a2a479be3
+  metadata.gz: b92de6a0bd5136fae90ea72a6c9ef38aa44d78adcce93829217f92aaa6e06832
+  data.tar.gz: 397a26e1d180a102c9317527c43849d6c147adc2b30394563046a7214ec292b4
 SHA512:
-  metadata.gz: 9789b4df93ee4c41d587dfc8272504af058e2b088be8027e938d3ab8bc8da364e9eb9c3e1ace667e267f828236867566c606a14237d1b1440ade115865480e65
-  data.tar.gz: 421bdbf2a1acc66ca3aae3bc0dd2b4c78f2e64b00364da6699d7732596dbeb13053b99b320ed3709d8e6c06994371421714a30ea8ce71ae4894404b4c83ea668
+  metadata.gz: 39fb99232136ee69fc5e8b1d180f952cd31b4031e3e8298325c31647212ec8ae21bb27e0ff2d951917fee0eb58c4027306c5ec306f5a3482c9336e3d1fdbedbf
+  data.tar.gz: f5565d4016415743ec141be5b8df9fa8b4e171139ee0cb9f0160a27eafea107701c0b0da07179364bbda642798aefd876fef343ec0098e5a2117fbdc82369b23

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 1.37.0 - October 29, 2026
+
+- [Breaking] Call the configured modulus checker's `valid_bank_code?` for US details, as is already done for AU, NZ and CA. US routing numbers the checker does not recognise are now invalid.
+
 ## 1.36.0 - September 29, 2026
 
 - Add Slovak translations

data/lib/ibandit/iban.rb

@@ -298,7 +298,7 @@ module Ibandit
       when "AU" then valid_australian_details?
       when "NZ" then valid_nz_details?
       when "CA" then valid_ca_details?
-      when "US" then bank_code_passes_checksum_test?
+      when "US" then valid_us_details?
       else true
       end
     end
@@ -392,6 +392,14 @@ module Ibandit
       valid_modulus_check_branch_code?
     end
 
+    def valid_us_details?
+      return true unless country_code == "US"
+      return false unless bank_code_passes_checksum_test?
+      return true unless Ibandit.modulus_checker
+
+      valid_modulus_check_bank_code?
+    end
+
     def bank_code_passes_checksum_test?
       return false unless swift_bank_code
       return false if swift_bank_code.length != 9

data/lib/ibandit/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Ibandit
-  VERSION = "1.36.0"
+  VERSION = "1.37.0"
 end

data/spec/ibandit/iban_spec.rb

@@ -1936,6 +1936,82 @@ describe Ibandit::IBAN do
     end
   end
 
+  describe "valid_us_details" do
+    subject { iban.valid_us_details? }
+
+    context "with non-US details" do
+      let(:arg) do
+        {
+          country_code: "GB",
+          bank_code: "1234",
+          branch_code: "200000",
+          account_number: "55779911",
+        }
+      end
+
+      it { is_expected.to be(true) }
+    end
+
+    context "with US details" do
+      let(:arg) do
+        {
+          country_code: "US",
+          bank_code: "026073150",
+          account_number: "2715500356",
+        }
+      end
+
+      context "without a modulus checker defined" do
+        it { is_expected.to be(true) }
+      end
+
+      context "with a modulus checker defined" do
+        before do
+          Ibandit.modulus_checker = double(
+            valid_bank_code?: valid_bank_code,
+          )
+          iban.valid_us_details?
+        end
+
+        after { Ibandit.modulus_checker = nil }
+
+        let(:valid_bank_code) { true }
+
+        it "calls valid_bank_code? with an IBAN object" do
+          expect(Ibandit.modulus_checker).
+            to receive(:valid_bank_code?).
+            with(instance_of(described_class))
+
+          iban.valid_us_details?
+        end
+
+        it { is_expected.to be(true) }
+
+        context "with a bank code that does not exist" do
+          let(:valid_bank_code) { false }
+
+          it { is_expected.to be(false) }
+
+          it "sets the errors on the IBAN" do
+            expect(iban.errors).to include(bank_code: "bank code does not exist")
+          end
+        end
+      end
+
+      context "with a bank code that fails the checksum test" do
+        let(:arg) do
+          {
+            country_code: "US",
+            bank_code: "123456789",
+            account_number: "12345678",
+          }
+        end
+
+        it { is_expected.to be(false) }
+      end
+    end
+  end
+
   describe "Pseudo IBAN #valid?" do
     let(:country_code) { "CA" }
     let(:arg) do
@@ -1988,7 +2064,7 @@ describe Ibandit::IBAN do
       context "US" do
         let(:country_code) { "US" }
 
-        specify { expect(iban).to receive(:bank_code_passes_checksum_test?).at_least(1) }
+        specify { expect(iban).to receive(:valid_us_details?).at_least(1) }
       end
     end
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ibandit
 version: !ruby/object:Gem::Version
-  version: 1.36.0
+  version: 1.37.0
 platform: ruby
 authors:
 - GoCardless