ibandit 1.0.0 → 1.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 13ca505f43dfd880ea0de62afe35c6b6a18c5036b523f7656b0cc36983af4a06
-  data.tar.gz: 913d870c4c191e184189c3872bbbdef83abe3f5074670856ef8eb2d4166988cc
+  metadata.gz: 29a9fc0b51d3da97442a468761fa927eb8912028030752acd47537b46b7fe2e1
+  data.tar.gz: 012dd0332664e89b2e95e43b0ef4888b74b1c4be673da954a7a85e6564d20c59
 SHA512:
-  metadata.gz: 429b3a3de4af3d7b1a7620e7be46594f354e963bfedda97fcfb87ee983d17ae3cf87bcd7ae3891080e90392917b7c33955c0442efe38ab7404fd09484e55d1e9
-  data.tar.gz: ac9ff959b43a974efc436dbe809784e33c6e68c8065421b9a5a194b5bf24a5e64fd469cc79223c36d70f2f8bd43a12d8af82f3fe1ec0c2ff32ce9b5d02c4261b
+  metadata.gz: 39984a7f77d2cfd7b8033869eb16ff3b27ed1e173e63ff8d31dbd8cefadeb3ed96bc3ddaa5144e5fa313c74e5979e1ecad8b7b840c4e684cf889ae212678e3ef
+  data.tar.gz: 8ca397438ee9ad97bbe3d7dbc33a1ea2950b29895f62f951a55ee92e05d5fca0599d58614a4730fc24efba39b600a5de4bb9173971473defa6002c90bd09ddd0

data/.rubocop.yml

@@ -6,24 +6,24 @@ AllCops:
   TargetRubyVersion: 2.4
 
 # Limit lines to 80 characters.
-LineLength:
+Metrics/LineLength:
   Max: 80
 
-ClassLength:
+Metrics/ClassLength:
   Max: 400
 
 # Avoid single-line methods.
-SingleLineMethods:
+Style/SingleLineMethods:
   AllowIfMethodIsEmpty: true
 
 # Wants underscores in all large numbers. Pain in the ass for things like
 # unix timestamps.
-NumericLiterals:
+Style/NumericLiterals:
   Enabled: false
 
 # Wants you to use the same argument names for every reduce. This seems kinda
 # naff compared to naming them semantically
-SingleLineBlockParams:
+Style/SingleLineBlockParams:
   Enabled: false
 
 Style/SignalException:

data/.travis.yml

@@ -7,7 +7,7 @@ rvm:
   - 2.4
   - 2.5
   - 2.6
-
+  - 2.7
 
 sudo: false
 

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 1.0.1 - January 9, 2019
+
+- Add Ruby 2.7 support and fix deprecation warnings
+
 ## 1.0.0 - October 24, 2019
 
 - Discontinued support for older Ruby versions (2.1.10, 2.2.7, 2.3.4 and 2.4.1)

data/Gemfile

@@ -5,5 +5,5 @@ source 'https://rubygems.org'
 gemspec
 
 group :development do
-  gem "gc_ruboconfig"
+  gem 'gc_ruboconfig', "~> 2.5.0"
 end

data/ibandit.gemspec

@@ -8,7 +8,7 @@ Gem::Specification.new do |gem|
   gem.add_development_dependency "pry-nav",         "~> 0.2"
   gem.add_development_dependency "rspec",           "~> 3.3"
   gem.add_development_dependency "rspec-its",       "~> 1.2"
-  gem.add_development_dependency "rubocop",         "~> 0.70.0"
+  gem.add_development_dependency "rubocop",         "~> 0.75.1"
   gem.add_development_dependency "sax-machine",     "~> 1.3"
 
   gem.add_runtime_dependency "i18n"

data/lib/ibandit.rb

@@ -36,7 +36,7 @@ module Ibandit
     end
 
     def translate(key, options = {})
-      I18n.translate(key, { scope: [:ibandit] }.merge(options))
+      I18n.translate(key, scope: [:ibandit], **options)
     end
   end
 end

data/lib/ibandit/check_digit.rb

@@ -23,7 +23,7 @@ module Ibandit
         end
       end
       remainder = digits.join.to_i % 97
-      sprintf("%02d", 98 - remainder)
+      sprintf("%<check_digit>02d", check_digit: 98 - remainder)
     end
 
     def self.italian(string)

data/lib/ibandit/german_details_converter.rb

@@ -517,7 +517,7 @@ module Ibandit
         updated_account_number =
           case unpadded_account_number.size
           when 5, 6 then unpadded_account_number + "00"
-          when 7 then
+          when 7
             if Check63.new(unpadded_account_number + "00").valid?
               unpadded_account_number + "00"
             else

data/lib/ibandit/iban.rb

@@ -460,12 +460,12 @@ module Ibandit
       @swift_branch_code    = try_dup(local_details[:swift_branch_code])
       @swift_bank_code      = try_dup(local_details[:swift_bank_code])
 
-      @iban                 = IBANAssembler.assemble(swift_details)
+      @iban = IBANAssembler.assemble(swift_details)
 
       if source == :pseudo_iban
-        @check_digits       = try_dup(local_details[:check_digits])
+        @check_digits = try_dup(local_details[:check_digits])
       else
-        @check_digits       = @iban.slice(2, 2) unless @iban.nil?
+        @check_digits = @iban.slice(2, 2) unless @iban.nil?
       end
     end
 

data/lib/ibandit/local_details_cleaner.rb

@@ -198,7 +198,7 @@ module Ibandit
         bank_code, account_number = local_details[:account_number].split("-", 2)
       elsif local_details[:account_number].gsub(/\s/, "").length == 14
         cleaned_account_number = local_details[:account_number].gsub(/\s/, "")
-        bank_code      = cleaned_account_number.slice(0, 4)
+        bank_code = cleaned_account_number.slice(0, 4)
         account_number = cleaned_account_number.slice(4, 10)
       else
         return {}
@@ -573,7 +573,7 @@ module Ibandit
       ken_1          = parts[2].nil? ? "" : parts[2].rjust(6, "0")
       ken_2          = parts[3].nil? ? "" : parts[3].rjust(4, "0")
 
-      kennitala      = ken_1.empty? ? "" : (ken_1 + ken_2).rjust(10, "0")
+      kennitala = ken_1.empty? ? "" : (ken_1 + ken_2).rjust(10, "0")
 
       hufo + reikningsnumer + kennitala
     end

data/lib/ibandit/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Ibandit
-  VERSION = "1.0.0"
+  VERSION = "1.0.1"
 end

data/spec/ibandit/pseudo_iban_assembler_spec.rb

@@ -3,7 +3,7 @@
 require "spec_helper"
 
 describe Ibandit::PseudoIBANAssembler do
-  subject(:pseudo_iban) { described_class.new(local_details).assemble }
+  subject(:pseudo_iban) { described_class.new(**local_details).assemble }
 
   context "for Sweden" do
     context "with valid parameters" do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ibandit
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.1
 platform: ruby
 authors:
 - GoCardless
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-10-24 00:00:00.000000000 Z
+date: 2020-01-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri
@@ -86,14 +86,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.70.0
+        version: 0.75.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.70.0
+        version: 0.75.1
 - !ruby/object:Gem::Dependency
   name: sax-machine
   requirement: !ruby/object:Gem::Requirement
@@ -209,7 +209,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.2
+rubygems_version: 3.1.2
 signing_key: 
 specification_version: 4
 summary: Convert national banking details into IBANs, and vice-versa.