ibandit 0.6.4 → 0.6.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 70681e650c635f6195db9716fc93ad3ddc4d6587
-  data.tar.gz: 8e3a5e7e949b8c55ab06e566a20aa509b73e8175
+  metadata.gz: 823a2e3a40462ece9f02dca4e2442017d1372b57
+  data.tar.gz: 153d927db1dc73912738f0f49396a97fb8e17024
 SHA512:
-  metadata.gz: 270c923322faa85318a8b58fa0d4cc3dc68e00111d116918b4fbc54c9fc305175873d062955bf9630c025355c812ffb34f8a542ba72eaac40b806a8061de4e2d
-  data.tar.gz: ef757fd03c27b661e0e98a9f84f3b2c871fb20ac0166d686f9d25fb55e047a354481056f423a49cd2a882769d4a7edcd9ff288870a76a5efdc0063e0d25b3274
+  metadata.gz: 14cc8a274cd0b5d41249a4d3d043a582aba730b096438d206de9aa008f88672f8f451e0ba196b1780443b13cb592af93b3706c3125ee05e6531989ff80c20239
+  data.tar.gz: 7c060ed0b1a379d0617210c8ab0e485a5c1f4ee32e66c706a27fbdd774c9c9926a8311f5ebac4aa3fb7d1d9005ce3ba9399a9b3baa4dd8c9a0a8734405a04e5a

data/CHANGELOG.md

@@ -1,3 +1,10 @@
+## Unreleased
+
+## 0.6.5 - July 30, 2015
+- Add Romania to LocalDetailsCleaner and IBANAssembler
+- Add Bulgaria to LocalDetailsCleaner and IBANAssembler
+- Add Hungary to LocalDetailsCleaner and IBANAssembler
+
 ## 0.6.4 - July 28, 2015
 
 - Add Poland to LocalDetailsCleaner and IBANAssembler

data/README.md

@@ -174,6 +174,15 @@ iban = Ibandit::IBAN.new(
 )
 iban.iban                     # => "BE62510007547061"
 
+# Bulgaria
+iban = Ibandit::IBAN.new(
+  country_code: 'BG',
+  bank_code: 'BNBG',
+  branch_code: '9661'
+  account_number: '1020345678'
+)
+iban.iban                     # => "BG80BNBG96611020345678"
+
 # Cyprus
 iban = Ibandit::IBAN.new(
   country_code: 'CY',
@@ -240,6 +249,13 @@ iban = Ibandit::IBAN.new(
 )
 iban.iban                     # => "GR16011012500000000012300695"
 
+# Hungary
+iban = Ibandit::IBAN.new(
+  country_code: 'HU',
+  account_number: '11773016-11111018'
+)
+iban.iban                     # => "HU42117730161111101800000000"
+
 # Ireland
 iban = Ibandit::IBAN.new(
   country_code: 'IE',
@@ -339,6 +355,14 @@ iban = Ibandit::IBAN.new(
 )
 iban.iban                     # => "PT50000200230023843000578"
 
+# Romania
+iban = Ibandit::IBAN.new(
+  country_code: 'RO',
+  bank_code: 'AAAA',
+  account_number: '1B31007593840000'
+)
+iban.iban                     # => "RO49AAAA1B31007593840000"
+
 # San Marino
 iban = Ibandit::IBAN.new(
   country_code: 'SM',

data/lib/ibandit/check_digit.rb

@@ -84,6 +84,24 @@ module Ibandit
       (scaled_values.inject(:+) % 10).to_s
     end
 
+    # Currently unused in this gem. This method calculates the last digit
+    # of a Hungarian account number when given the initial digits.
+    def self.hungarian(string)
+      weights = [9, 7, 3, 1]
+
+      scaled_values = string.chars.map.with_index do |char, index|
+        unless char.to_i.to_s == char
+          raise InvalidCharacterError,
+                "Unexpected non-numeric character '#{char}'"
+        end
+
+        char.to_i * weights[index % weights.size]
+      end
+
+      result = 10 - scaled_values.inject(:+) % 10
+      result < 10 ? result.to_s : '0'
+    end
+
     # Currently unused in this gem. This method calculates the penultimate digit
     # of an Icelandic kennitala (included in the account number) when given the
     # first 8 digits.

data/lib/ibandit/iban_assembler.rb

@@ -1,7 +1,8 @@
 module Ibandit
   module IBANAssembler
-    SUPPORTED_COUNTRY_CODES = %w(AT BE CY DE DK EE ES FI FR GB GR IE IS IT LT LU
-                                 LV MC MT NL NO PL PT SE SI SK SM).freeze
+    SUPPORTED_COUNTRY_CODES = %w(AT BE BG CY DE DK EE ES FI FR GB GR HU IE IS IT
+                                 LT LU LV MC MT NL NO PL PT RO SE SI SK
+                                 SM).freeze
 
     EXCEPTION_COUNTRY_CODES = %w(IT SM BE).freeze
 
@@ -84,7 +85,7 @@ module Ibandit
 
     def self.required_fields(country_code)
       case country_code
-      when *%w(AT CY DE EE FI IS LT LU LV NL NO PL SE SI SK DK)
+      when *%w(AT CY DE DK EE FI IS LT LU LV NL NO PL RO SE SI SK)
         %i(bank_code account_number)
       when 'BE'
         %i(account_number)

data/lib/ibandit/local_details_cleaner.rb

@@ -1,7 +1,8 @@
 module Ibandit
   module LocalDetailsCleaner
-    SUPPORTED_COUNTRY_CODES = %w(AT BE CY DE DK EE ES FI FR GB GR IE IS IT LT LU
-                                 LV MC MT NL NO PL PT SE SI SK SM).freeze
+    SUPPORTED_COUNTRY_CODES = %w(AT BE BG CY DE DK EE ES FI FR GB GR HU IE IS IT
+                                 LT LU LV MC MT NL NO PL PT RO SE SI SK
+                                 SM).freeze
 
     def self.clean(local_details)
       country_code = local_details[:country_code]
@@ -27,9 +28,9 @@ module Ibandit
 
     def self.required_fields(country_code)
       case country_code
-      when 'AT', 'CY', 'DE', 'FI', 'LT', 'LU', 'LV', 'NL', 'SI', 'SK'
+      when 'AT', 'CY', 'DE', 'FI', 'LT', 'LU', 'LV', 'NL', 'RO', 'SI', 'SK'
         %i(bank_code account_number)
-      when 'BE', 'DK', 'EE', 'ES', 'SE', 'NO', 'PL', 'IS'
+      when 'BE', 'DK', 'EE', 'ES', 'HU', 'IS', 'NO', 'PL', 'SE'
         %i(account_number)
       when 'GB', 'IE', 'MT'
         if Ibandit.bic_finder.nil? then %i(bank_code branch_code account_number)
@@ -63,6 +64,11 @@ module Ibandit
       }
     end
 
+    def self.clean_bg_details(local_details)
+      # Bulgarian national bank details were replaced with IBANs in 2006.
+      local_details
+    end
+
     def self.clean_cy_details(local_details)
       # Account number may be 7-16 digits long.
       # Add leading zeros to account number if < 16 digits.
@@ -227,6 +233,32 @@ module Ibandit
       local_details
     end
 
+    def self.clean_hu_details(local_details)
+      # This method supports being passed the component IBAN parts, as defined
+      # by SWIFT, or a single 16 or 24 digit string.
+      if local_details[:bank_code] || local_details[:branch_code]
+        return local_details
+      end
+
+      cleaned_acct_number = local_details[:account_number].gsub(/[-\s]/, '')
+
+      case cleaned_acct_number.length
+      when 16
+        {
+          bank_code:      cleaned_acct_number.slice(0, 3),
+          branch_code:    cleaned_acct_number.slice(3, 4),
+          account_number: cleaned_acct_number.slice(7, 9).ljust(17, '0')
+        }
+      when 24
+        {
+          bank_code:      cleaned_acct_number.slice(0, 3),
+          branch_code:    cleaned_acct_number.slice(3, 4),
+          account_number: cleaned_acct_number.slice(7, 17)
+        }
+      else local_details
+      end
+    end
+
     def self.clean_ie_details(local_details)
       # Ireland uses the same local details as the United Kingdom
       branch_code = local_details[:branch_code].gsub(/[-\s]/, '')
@@ -365,6 +397,11 @@ module Ibandit
       local_details
     end
 
+    def self.clean_ro_details(local_details)
+      # Romanian national bank details were replaced with IBANs in 2004.
+      local_details
+    end
+
     def self.clean_se_details(local_details)
       converted_details =
         SwedishDetailsConverter.convert(local_details[:account_number])

data/lib/ibandit/version.rb

@@ -1,3 +1,3 @@
 module Ibandit
-  VERSION = '0.6.4'.freeze
+  VERSION = '0.6.5'.freeze
 end

data/spec/ibandit/check_digit_spec.rb

@@ -104,6 +104,28 @@ describe Ibandit::CheckDigit do
     end
   end
 
+  describe '.hungarian' do
+    subject { described_class.hungarian(account_number) }
+
+    let(:account_number) { '1234567' }
+    it { is_expected.to eq('6') }
+
+    context 'with another account number (double checking!)' do
+      let(:account_number) { '1111101' }
+      it { is_expected.to eq('8') }
+    end
+
+    context 'with all zeros' do
+      let(:account_number) { '0000000' }
+      it { is_expected.to eq('0') }
+    end
+
+    context 'with a non-numeric character' do
+      let(:account_number) { '1BAD2014' }
+      specify { expect { subject }.to raise_error(/non-numeric character/) }
+    end
+  end
+
   describe '.icelandic' do
     subject { described_class.icelandic(kennitala) }
 

data/spec/ibandit/iban_assembler_spec.rb

@@ -68,6 +68,31 @@ describe Ibandit::IBANAssembler do
       end
     end
 
+    context 'with BG as the country_code' do
+      let(:args) do
+        {
+          country_code: 'BG',
+          account_number: '1020345678',
+          bank_code: 'BNBG',
+          branch_code: '9661'
+        }
+      end
+
+      it { is_expected.to eq('BG80BNBG96611020345678') }
+
+      it_behaves_like 'allows round trips', 'BG80 BNBG 9661 1020 3456 78'
+
+      context 'without an account_number' do
+        before { args.delete(:account_number) }
+        it { is_expected.to be_nil }
+      end
+
+      context 'without a bank_code' do
+        before { args.delete(:bank_code) }
+        it { is_expected.to be_nil }
+      end
+    end
+
     context 'with CY as the country_code' do
       let(:args) do
         {
@@ -314,6 +339,48 @@ describe Ibandit::IBANAssembler do
       end
     end
 
+    context 'with HU as the country_code' do
+      let(:args) do
+        {
+          country_code: 'HU',
+          bank_code: '117',
+          branch_code: '7301',
+          account_number: '61111101800000000'
+        }
+      end
+
+      it { is_expected.to eq('HU42117730161111101800000000') }
+
+      it_behaves_like 'allows round trips', 'HU42 1177 3016 1111 1018 0000 0000'
+
+      context 'without a bank_code or branch_code' do
+        before { args.delete(:bank_code) }
+        before { args.delete(:branch_code) }
+        before { args[:account_number] = '11773016-11111018-00000000' }
+
+        it { is_expected.to be_nil }
+      end
+
+      context 'without a bank_code' do
+        before { args.delete(:bank_code) }
+        before { args[:account_number] = '11773016-11111018-00000000' }
+
+        it { is_expected.to be_nil }
+      end
+
+      context 'without a branch_code' do
+        before { args.delete(:branch_code) }
+        before { args[:account_number] = '11773016-11111018-00000000' }
+
+        it { is_expected.to be_nil }
+      end
+
+      context 'without an account_number' do
+        before { args.delete(:account_number) }
+        it { is_expected.to be_nil }
+      end
+    end
+
     context 'with IE as the country_code' do
       let(:args) do
         { country_code: 'IE',
@@ -652,6 +719,30 @@ describe Ibandit::IBANAssembler do
       end
     end
 
+    context 'with RO as the country_code' do
+      let(:args) do
+        {
+          country_code: 'RO',
+          account_number: '1B31007593840000',
+          bank_code: 'AAAA'
+        }
+      end
+
+      it { is_expected.to eq('RO49AAAA1B31007593840000') }
+
+      it_behaves_like 'allows round trips', 'RO49 AAAA 1B31 0075 9384 0000'
+
+      context 'without an account_number' do
+        before { args.delete(:account_number) }
+        it { is_expected.to be_nil }
+      end
+
+      context 'without a bank_code' do
+        before { args.delete(:bank_code) }
+        it { is_expected.to be_nil }
+      end
+    end
+
     context 'with SE as the country_code' do
       let(:args) do
         {

data/spec/ibandit/local_details_cleaner_spec.rb

@@ -87,6 +87,30 @@ describe Ibandit::LocalDetailsCleaner do
     end
   end
 
+  context 'Bulgaria' do
+    let(:country_code) { 'BG' }
+    let(:bank_code) { 'BNBG' }
+    let(:branch_code) { '9661' }
+    let(:account_number) { '1020345678' }
+
+    it { is_expected.to eq(local_details) }
+
+    context 'without an account number' do
+      let(:account_number) { nil }
+      it { is_expected.to eq(local_details) }
+    end
+
+    context 'without a branch code' do
+      let(:branch_code) { nil }
+      it { is_expected.to eq(local_details) }
+    end
+
+    context 'without a bank code' do
+      let(:bank_code) { nil }
+      it { is_expected.to eq(local_details) }
+    end
+  end
+
   context 'Cyprus' do
     let(:country_code) { 'CY' }
     let(:account_number) { '0000001200527600' }
@@ -398,6 +422,52 @@ describe Ibandit::LocalDetailsCleaner do
     end
   end
 
+  context 'Hungary' do
+    let(:country_code) { 'HU' }
+    let(:bank_code) { '117' }
+    let(:branch_code) { '7301' }
+    let(:account_number) { '61111101800000000' }
+
+    it { is_expected.to eq(local_details) }
+
+    context 'with bank and branch codes in the account number' do
+      let(:bank_code) { nil }
+      let(:branch_code) { nil }
+
+      context 'with a full account number' do
+        let(:account_number) { '11773016-11111018-00000000' }
+
+        its([:bank_code]) { is_expected.to eq('117') }
+        its([:branch_code]) { is_expected.to eq('7301') }
+        its([:account_number]) { is_expected.to eq('61111101800000000') }
+      end
+
+      context 'with a short account number' do
+        let(:account_number) { '11773016-11111018' }
+
+        its([:bank_code]) { is_expected.to eq('117') }
+        its([:branch_code]) { is_expected.to eq('7301') }
+        its([:account_number]) { is_expected.to eq('61111101800000000') }
+      end
+
+      context 'with an invalid length account number' do
+        let(:account_number) { '11773016-1111101' }
+        it { is_expected.to eq(local_details) }
+      end
+
+      context 'with a bank code, too' do
+        let(:account_number) { '11773016-11111018' }
+        let(:bank_code) { '117' }
+        it { is_expected.to eq(local_details) }
+      end
+    end
+
+    context 'without an account number' do
+      let(:account_number) { nil }
+      it { is_expected.to eq(local_details) }
+    end
+  end
+
   context 'Ireland' do
     let(:country_code) { 'IE' }
     let(:bank_code) { 'AIBK' }
@@ -795,6 +865,24 @@ describe Ibandit::LocalDetailsCleaner do
     end
   end
 
+  context 'Romania' do
+    let(:country_code) { 'RO' }
+    let(:bank_code) { 'AAAA' }
+    let(:account_number) { '1B31007593840000' }
+
+    it { is_expected.to eq(local_details) }
+
+    context 'without an account number' do
+      let(:account_number) { nil }
+      it { is_expected.to eq(local_details) }
+    end
+
+    context 'without a bank code' do
+      let(:bank_code) { nil }
+      it { is_expected.to eq(local_details) }
+    end
+  end
+
   context 'Sweden' do
     let(:country_code) { 'SE' }
     let(:bank_code) { '501' }

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ibandit
 version: !ruby/object:Gem::Version
-  version: 0.6.4
+  version: 0.6.5
 platform: ruby
 authors:
 - Grey Baker
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-07-28 00:00:00.000000000 Z
+date: 2015-07-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec