ibandit 0.5.0 → 0.6.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: fc1eddf185fe692eb8722cb1d94f8069e21f80df
-  data.tar.gz: b9df021973596bdfa6df1f554685af30b2038059
+  metadata.gz: c1df2cf95c45aa65c6c465e6e84acf90bdbe129c
+  data.tar.gz: eb5ec39059d88313840d5d3f97fbe60a65d9612a
 SHA512:
-  metadata.gz: 20535679cd0fcdd19e0ce57398d3bc0f4fa539761edb4706a466c34b4934347559903a63612db1a19d73f264490896efa33285220354cc00298a5bf0518ca593
-  data.tar.gz: aff6275493f96d55daf9a8a840b622b8c1fa97181762b0f8ef83a2e91a2f48a0d5bd868e6ef44cf48564557041c1654555ab0636059a23e2b8930d5a747f0a47
+  metadata.gz: d8a8c4d383522ed5295cf35495d321bd5518f3e9d487033dd3a81e4eedf49d2df3f93a2f7be89d32bc93495b01cd620cf0c7fbabab70dee71c97f82fe30679ed
+  data.tar.gz: 1b2c6c34acbdf70762aaa588a6e7660895e318c76d2cf0b78ce6ac24276b9836c77924560507b05d54231e9e022cab0b517b2a6adbcccf70d407dc4178152b20

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 0.6.0 - July 20, 2015
+
+- Add support for Sweden
+
 ## 0.5.0 - July 12, 2015
 
 - Add an error for unsupported German bank details, and stop raising whilst

data/README.md

@@ -12,7 +12,8 @@ allows you to:
 Ibandit also provides helper methods for validating some countries' local
 account details.
 
-The gem is kept up to date using the IBAN structure file from SWIFT.
+The gem is kept up to date using the IBAN structure file from SWIFT and the
+Bankleitzahl file from the Deutsche Bundesbank.
 
 ## Usage
 
@@ -309,6 +310,15 @@ iban = Ibandit::IBAN.new(
 )
 iban.iban                     # => "PT50000200230023843000578"
 
+# San Marino
+iban = Ibandit::IBAN.new(
+  country_code: 'SM',
+  bank_code: '05428',
+  branch_code: '11101',
+  account_number: '000000123456'
+)
+iban.iban                     # => "SM88X0542811101000000123456"
+
 # Slovakia
 iban = Ibandit::IBAN.new(
   country_code: 'SK',
@@ -342,14 +352,12 @@ iban = Ibandit::IBAN.new(
 )
 iban.iban                     # => "ES8023100001180000012345"
 
-# San Marino
+# Sweden
 iban = Ibandit::IBAN.new(
-  country_code: 'SM',
-  bank_code: '05428',
-  branch_code: '11101',
-  account_number: '000000123456'
+  country_code: 'SE',
+  account_number: '7507-1211203'
 )
-iban.iban                     # => "SM88X0542811101000000123456"
+iban.iban                     # => "SE2680000000075071211203"
 ```
 
 ## Other libraries

data/data/raw/swedish_bank_lookup.yml

@@ -0,0 +1,377 @@
+---
+# Sources:
+# - https://sv.wikipedia.org/wiki/Lista_%C3%B6ver_clearingnummer_till_svenska_banker
+# - http://www.bgc.se/globalassets/dokument/tekniska-manualer/bankernaskontonummeruppbyggnad_tekniskmanual_sv.pdf
+# - SWIFT IBAN data
+#
+# Fields:
+# - Range:                  The range of clearing codes for this bank. Used to
+#                           find the bank information for a given account number.
+#
+# - Bank:                   The name of the bank.
+#
+# - Clearing code length:   Length of the clearing codes issued by this bank. This
+#                           is 4 in all cases except Swedbank's 8000-range.
+#
+# - Serial number length:   Length of the account number that follows the clearing
+#                           code.
+#
+# - Include clearing code:  Whether the clearing code is included in the IBAN account
+#                           number.
+#
+# - Zerofill serial number: Whether the serial number should be zerofilled if it is
+#                           shorter than the required serial_number_length.
+#
+- :range: [1100, 1199]
+  :bank: Nordea
+  :bank_code: 300
+  :clearing_code_length: 4
+  :serial_number_length: 7
+  :zerofill_serial_number: false
+  :include_clearing_code: true
+- :range: [1200, 1399]
+  :bank: Danske Bank
+  :bank_code: 120
+  :clearing_code_length: 4
+  :serial_number_length: 7
+  :zerofill_serial_number: false
+  :include_clearing_code: true
+- :range: [1400, 2099]
+  :bank: Nordea
+  :bank_code: 300
+  :clearing_code_length: 4
+  :serial_number_length: 7
+  :zerofill_serial_number: false
+  :include_clearing_code: true
+- :range: [2300, 2399]
+  :bank: Ålandsbanken Sverige AB
+  :bank_code: 230
+  :clearing_code_length: 4
+  :serial_number_length: 7
+  :zerofill_serial_number: false
+  :include_clearing_code: true
+- :range: [2400, 2499]
+  :bank: Danske Bank
+  :bank_code: 120
+  :clearing_code_length: 4
+  :serial_number_length: 7
+  :zerofill_serial_number: false
+  :include_clearing_code: true
+  # NOTE: We're ignoring Sambox bank (clearing number 2950) because the only
+  # reference I've seen is wikipedia. Sambox does have its own bank code (295)
+  # though, so we may want to revisit.
+- :range: [3000, 3299]
+  :bank: Nordea
+  :bank_code: 300
+  :clearing_code_length: 4
+  :serial_number_length: 7
+  :zerofill_serial_number: false
+  :include_clearing_code: true
+- :range: [3300, 3300]
+  :bank: Nordea Personkonto
+  # NOTE: We're routing Nordea Personkonto to the main Nordea bank code, but
+  # it may belong at one of the other Nordea codes we're not currently using.
+  :bank_code: 300
+  :clearing_code_length: 4
+  :serial_number_length: 10
+  :zerofill_serial_number: false
+  :include_clearing_code: false
+- :range: [3301, 3399]
+  :bank: Nordea
+  :bank_code: 300
+  :clearing_code_length: 4
+  :serial_number_length: 7
+  :zerofill_serial_number: false
+  :include_clearing_code: true
+- :range: [3400, 3409]
+  :bank: Länsförsäkringar Bank
+  :bank_code: 902
+  :clearing_code_length: 4
+  :serial_number_length: 7
+  :zerofill_serial_number: false
+  :include_clearing_code: true
+- :range: [3410, 3781]
+  :bank: Nordea
+  :bank_code: 300
+  :clearing_code_length: 4
+  :serial_number_length: 7
+  :zerofill_serial_number: false
+  :include_clearing_code: true
+- :range: [3782, 3782]
+  :bank: Nordea Personkonto
+  # NOTE: We're routing Nordea Personkonto to the main Nordea bank code, but
+  # it may belong at one of the other Nordea codes we're not currently using.
+  :bank_code: 300
+  :clearing_code_length: 4
+  :serial_number_length: 10
+  :zerofill_serial_number: false
+  :include_clearing_code: fase
+- :range: [3783, 3999]
+  :bank: Nordea
+  :bank_code: 300
+  :clearing_code_length: 4
+  :serial_number_length: 7
+  :zerofill_serial_number: false
+  :include_clearing_code: true
+- :range: [4000, 4999]
+  :bank: Nordea
+  :bank_code: 300
+  :clearing_code_length: 4
+  :serial_number_length: 7
+  :zerofill_serial_number: false
+  :include_clearing_code: true
+- :range: [5000, 5999]
+  :bank: SEB
+  :bank_code: 500
+  :clearing_code_length: 4
+  :serial_number_length: 7
+  :zerofill_serial_number: false
+  :include_clearing_code: true
+- :range: [6000, 6999]
+  :bank: Handelsbanken
+  :bank_code: 600
+  :clearing_code_length: 4
+  :serial_number_length: 9
+  :zerofill_serial_number: true
+  :include_clearing_code: false
+- :range: [7000, 7999]
+  :bank: Swedbank
+  :bank_code: 800
+  :clearing_code_length: 4
+  :serial_number_length: 7
+  :zerofill_serial_number: false
+  :include_clearing_code: true
+- :range: [8000, 8999]
+  # NOTE: This range also includes independent savings banks, some of which
+  # appear to have their own bank code. For now we always use the Swedbank bank
+  # code - we should revisit if we see failures as a result.
+  :bank: Swedbank
+  :bank_code: 800
+  :clearing_code_length: 5
+  :serial_number_length: 10
+  :zerofill_serial_number: true
+  :include_clearing_code: true
+- :range: [9020, 9029]
+  :bank: Länsförsäkringar Bank
+  :bank_code: 902
+  :clearing_code_length: 4
+  :serial_number_length: 7
+  :zerofill_serial_number: false
+  :include_clearing_code: true
+- :range: [9040, 9049]
+  :bank: Citibank
+  :bank_code: 904
+  :clearing_code_length: 4
+  :serial_number_length: 7
+  :zerofill_serial_number: false
+  :include_clearing_code: true
+- :range: [9060, 9069]
+  :bank: Länsförsäkringar Bank
+  :bank_code: 902
+  :clearing_code_length: 4
+  :serial_number_length: 7
+  :zerofill_serial_number: false
+  :include_clearing_code: true
+- :range: [9090, 9099]
+  :bank: ABN Amro
+  :bank_code: 909
+  :clearing_code_length: 4
+  :serial_number_length: 7
+  :zerofill_serial_number: false
+  :include_clearing_code: true
+- :range: [9100, 9109]
+  :bank: Nordnet Bank
+  :bank_code: 910
+  :clearing_code_length: 4
+  :serial_number_length: 7
+  :zerofill_serial_number: false
+  :include_clearing_code: true
+- :range: [9120, 9124]
+  :bank: SEB
+  :bank_code: 500
+  :clearing_code_length: 4
+  :serial_number_length: 7
+  :zerofill_serial_number: false
+  :include_clearing_code: true
+- :range: [9130, 9149]
+  :bank: SEB
+  :bank_code: 500
+  :clearing_code_length: 4
+  :serial_number_length: 7
+  :zerofill_serial_number: false
+  :include_clearing_code: true
+- :range: [9150, 9169]
+  :bank: Skandiabanken
+  :bank_code: 915
+  :clearing_code_length: 4
+  :serial_number_length: 7
+  :zerofill_serial_number: false
+  :include_clearing_code: true
+- :range: [9170, 9179]
+  :bank: IKANO Bank
+  :bank_code: 917
+  :clearing_code_length: 4
+  :serial_number_length: 7
+  :zerofill_serial_number: false
+  :include_clearing_code: true
+- :range: [9180, 9189]
+  :bank: Danske Bank
+  :bank_code: 120
+  :clearing_code_length: 4
+  :serial_number_length: 10
+  :zerofill_serial_number: false
+  :include_clearing_code: false
+- :range: [9190, 9199]
+  :bank: Den Norske Bank
+  :bank_code: 919
+  :clearing_code_length: 4
+  :serial_number_length: 7
+  :zerofill_serial_number: false
+  :include_clearing_code: true
+- :range: [9230, 9239]
+  :bank: Marginalen Bank
+  :bank_code: 923
+  :clearing_code_length: 4
+  :serial_number_length: 7
+  :zerofill_serial_number: false
+  :include_clearing_code: true
+- :range: [9250, 9259]
+  :bank: SBAB
+  :bank_code: 925
+  :clearing_code_length: 4
+  :serial_number_length: 7
+  :zerofill_serial_number: false
+  :include_clearing_code: true
+- :range: [9260, 9269]
+  :bank: Den Norske Bank
+  :bank_code: 919
+  :clearing_code_length: 4
+  :serial_number_length: 7
+  :zerofill_serial_number: false
+  :include_clearing_code: true
+- :range: [9270, 9279]
+  :bank: ICA Banken
+  :bank_code: 927
+  :clearing_code_length: 4
+  :serial_number_length: 7
+  :zerofill_serial_number: false
+  :include_clearing_code: true
+- :range: [9280, 9289]
+  :bank: Resurs Banken AB
+  :bank_code: 928
+  :clearing_code_length: 4
+  :serial_number_length: 7
+  :zerofill_serial_number: false
+  :include_clearing_code: true
+- :range: [9300, 9329]
+  :bank: Sparbanken Öresund
+  :bank_code: 930
+  :clearing_code_length: 4
+  :serial_number_length: 10
+  :zerofill_serial_number: false
+  :include_clearing_code: false
+- :range: [9330, 9349]
+  :bank: Sparbanken Öresund
+  :bank_code: 933
+  :clearing_code_length: 4
+  :serial_number_length: 10
+  :zerofill_serial_number: false
+  :include_clearing_code: false
+- :range: [9390, 9399]
+  :bank: Landshypotek AB
+  :bank_code: 939
+  :clearing_code_length: 4
+  :serial_number_length: 7
+  :zerofill_serial_number: false
+  :include_clearing_code: true
+- :range: [9400, 9449]
+  :bank: Forex Bank AB
+  :bank_code: 940
+  :clearing_code_length: 4
+  :serial_number_length: 7
+  :zerofill_serial_number: false
+  :include_clearing_code: true
+- :range: [9460, 9469]
+  :bank: GE Money Bank
+  :bank_code: 945
+  :clearing_code_length: 4
+  :serial_number_length: 7
+  :zerofill_serial_number: false
+  :include_clearing_code: true
+- :range: [9470, 9479]
+  :bank: BNP Paribas
+  :bank_code: 947
+  :clearing_code_length: 4
+  :serial_number_length: 7
+  :zerofill_serial_number: false
+  :include_clearing_code: true
+- :range: [9500, 9549]
+  :bank: Nordea - PlusGirot
+  :bank_code: 950
+  :clearing_code_length: 4
+  :serial_number_length: 10
+  :zerofill_serial_number: true
+  :include_clearing_code: true
+- :range: [9550, 9569]
+  :bank: Avanza Bank
+  :bank_code: 955
+  :clearing_code_length: 4
+  :serial_number_length: 7
+  :zerofill_serial_number: false
+  :include_clearing_code: true
+- :range: [9570, 9579]
+  :bank: Sparbanken Syd
+  :bank_code: 957
+  :clearing_code_length: 4
+  :serial_number_length: 10
+  :zerofill_serial_number: false
+  :include_clearing_code: false
+- :range: [9590, 9599]
+  :bank: Erik Penser AB
+  :bank_code: 959
+  :clearing_code_length: 4
+  :serial_number_length: 7
+  :zerofill_serial_number: false
+  :include_clearing_code: true
+- :range: [9630, 9639]
+  :bank: "Lån & Spar Bank"
+  :bank_code: 963
+  :clearing_code_length: 4
+  :serial_number_length: 7
+  :zerofill_serial_number: false
+  :include_clearing_code: true
+- :range: [9640, 9649]
+  :bank: Nordax Finans
+  :bank_code: 964
+  :clearing_code_length: 4
+  :serial_number_length: 7
+  :zerofill_serial_number: false
+  :include_clearing_code: true
+- :range: [9660, 9669]
+  :bank: Amfa Bank
+  :bank_code: 966
+  :clearing_code_length: 4
+  :serial_number_length: 7
+  :zerofill_serial_number: false
+  :include_clearing_code: true
+- :range: [9880, 9889]
+  :bank: Riksgälden
+  :bank_code: 988
+  :clearing_code_length: 4
+  :serial_number_length: 7
+  :zerofill_serial_number: false
+  :include_clearing_code: true
+- :range: [9890, 9899]
+  :bank: Riksgälden
+  :bank_code: 989
+  :clearing_code_length: 4
+  :serial_number_length: 10
+  :zerofill_serial_number: false
+  :include_clearing_code: false
+- :range: [9960, 9969]
+  :bank: Nordea - PlusGirot
+  :bank_code: 950
+  :clearing_code_length: 4
+  :serial_number_length: 10
+  :zerofill_serial_number: true
+  :include_clearing_code: true

data/lib/ibandit.rb

@@ -3,6 +3,7 @@ require 'ibandit/version'
 require 'ibandit/errors'
 require 'ibandit/iban'
 require 'ibandit/german_details_converter'
+require 'ibandit/swedish_details_converter'
 require 'ibandit/iban_splitter'
 require 'ibandit/iban_assembler'
 require 'ibandit/local_details_cleaner'

data/lib/ibandit/iban.rb

@@ -69,7 +69,7 @@ module Ibandit
         valid_branch_code_format?,
         valid_account_number_format?,
         valid_local_modulus_check?,
-        supports_iban_determination?
+        passes_country_specific_checks?
       ].all?
     end
 
@@ -225,6 +225,16 @@ module Ibandit
       valid_modulus_check_bank_code? && valid_modulus_check_account_number?
     end
 
+    def passes_country_specific_checks?
+      return unless valid_country_code?
+
+      case country_code
+      when 'DE' then supports_iban_determination?
+      when 'SE' then valid_swedish_details?
+      else true
+      end
+    end
+
     def supports_iban_determination?
       return unless valid_format?
       return true unless country_code == 'DE'
@@ -242,6 +252,26 @@ module Ibandit
       end
     end
 
+    def valid_swedish_details?
+      return true unless country_code == 'SE'
+
+      bank_details = { bank_code: bank_code, account_number: account_number }
+
+      unless SwedishDetailsConverter.valid_bank_code?(bank_details)
+        bank_code_field = bank_code.nil? ? :account_number : :bank_code
+        @errors[bank_code_field] = Ibandit.translate(:is_invalid)
+        @errors.delete(:bank_code) if bank_code.nil?
+        return false
+      end
+
+      unless SwedishDetailsConverter.valid_length?(bank_details)
+        @errors[:account_number] = Ibandit.translate(:is_invalid)
+        return false
+      end
+
+      true
+    end
+
     ###################
     # Private methods #
     ###################

data/lib/ibandit/iban_assembler.rb

@@ -1,7 +1,7 @@
 module Ibandit
   module IBANAssembler
     SUPPORTED_COUNTRY_CODES = %w(AT BE CY DE EE ES FI FR GB GR IE IT LT LU LV MC
-                                 MT NL PT SI SK SM).freeze
+                                 MT NL PT SE SI SK SM).freeze
 
     EXCEPTION_COUNTRY_CODES = %w(IT SM BE).freeze
 
@@ -84,7 +84,7 @@ module Ibandit
 
     def self.required_fields(country_code)
       case country_code
-      when 'AT', 'CY', 'DE', 'EE', 'FI', 'LT', 'LU', 'LV', 'NL', 'SI', 'SK'
+      when *%w(AT CY DE EE FI LT LU LV NL SE SI SK)
         %i(bank_code account_number)
       when 'BE'
         %i(account_number)

data/lib/ibandit/local_details_cleaner.rb

@@ -1,7 +1,7 @@
 module Ibandit
   module LocalDetailsCleaner
     SUPPORTED_COUNTRY_CODES = %w(AT BE CY DE EE ES FI FR GB GR IE IT LT LU LV MC
-                                 MT NL PT SI SK SM).freeze
+                                 MT NL PT SE SI SK SM).freeze
 
     def self.clean(local_details)
       country_code = local_details[:country_code]
@@ -29,7 +29,7 @@ module Ibandit
       case country_code
       when 'AT', 'CY', 'DE', 'FI', 'LT', 'LU', 'LV', 'NL', 'SI', 'SK'
         %i(bank_code account_number)
-      when 'BE', 'EE', 'ES'
+      when 'BE', 'EE', 'ES', 'SE'
         %i(account_number)
       when 'GB', 'IE', 'MT'
         if Ibandit.bic_finder.nil? then %i(bank_code branch_code account_number)
@@ -294,6 +294,18 @@ module Ibandit
       local_details
     end
 
+    def self.clean_se_details(local_details)
+      converted_details =
+        SwedishDetailsConverter.convert(local_details[:account_number])
+
+      bank_code = local_details[:bank_code] || converted_details[:bank_code]
+
+      {
+        bank_code:      bank_code,
+        account_number: converted_details[:account_number]
+      }
+    end
+
     def self.clean_si_details(local_details)
       # Add leading zeros to account number if < 10 digits.
       {

data/lib/ibandit/swedish_details_converter.rb

@@ -0,0 +1,103 @@
+module Ibandit
+  module SwedishDetailsConverter
+    def self.convert(account_number)
+      cleaned_account_number =
+        account_number.gsub(/[-.\s]/, '').gsub(/\A0+/, '')
+
+      bank_info = bank_info_for(cleaned_account_number.slice(0, 4))
+
+      if bank_info.nil?
+        return { bank_code: nil,
+                 account_number: cleaned_account_number.rjust(17, '0') }
+      end
+
+      clearing_code_length = bank_info.fetch(:clearing_code_length)
+      serial_number_length = bank_info.fetch(:serial_number_length)
+
+      clearing_code = cleaned_account_number.slice(0, clearing_code_length)
+      serial_number = cleaned_account_number[clearing_code_length..-1]
+
+      if bank_info.fetch(:zerofill_serial_number)
+        serial_number = serial_number.rjust(serial_number_length, '0')
+      end
+
+      iban_account_number =
+        if bank_info.fetch(:include_clearing_code)
+          (clearing_code + serial_number).rjust(17, '0')
+        else
+          serial_number.rjust(17, '0')
+        end
+
+      {
+        bank_code: bank_info.fetch(:bank_code).to_s,
+        account_number: iban_account_number
+      }
+    end
+
+    def self.valid_bank_code?(bank_code: bank_code,
+                              account_number: account_number)
+      possible_bank_infos = possible_bank_info_for(
+        bank_code: bank_code, account_number: account_number
+      )
+
+      possible_bank_infos.any?
+    end
+
+    def self.valid_length?(bank_code: bank_code, account_number: account_number)
+      return unless valid_bank_code?(
+        bank_code: bank_code, account_number: account_number
+      )
+
+      cleaned_account_number = account_number.gsub(/\A0+/, '')
+
+      possible_bank_infos = possible_bank_info_for(
+        bank_code: bank_code, account_number: account_number
+      )
+
+      possible_bank_infos.any? do |bank|
+        length = bank.fetch(:serial_number_length)
+        length += bank[:clearing_code_length] if bank[:include_clearing_code]
+
+        if bank[:zerofill_serial_number] && !bank[:include_clearing_code]
+          serial_number_length = bank.fetch(:serial_number_length)
+          cleaned_account_number =
+            cleaned_account_number.rjust(serial_number_length, '0')
+        end
+
+        cleaned_account_number.length == length
+      end
+    end
+
+    private
+
+    def self.bank_info_for(clearing_code)
+      bank_info_table.find { |bank| bank[:range].include?(clearing_code.to_i) }
+    end
+    private_class_method :bank_info_for
+
+    def self.possible_bank_info_for(bank_code: bank_code,
+                                    account_number: account_number)
+      clearing_number = account_number.gsub(/\A0+/, '').slice(0, 4).to_i
+
+      possible_bank_infos = bank_info_table.select do |bank|
+        bank.fetch(:bank_code).to_s == bank_code
+      end
+
+      possible_bank_infos.select do |bank|
+        !bank[:include_clearing_code] || bank[:range].include?(clearing_number)
+      end
+    end
+    private_class_method :possible_bank_info_for
+
+    def self.bank_info_table
+      @swedish_bank_lookup ||=
+        begin
+          relative_path = '../../../data/raw/swedish_bank_lookup.yml'
+          raw_info = YAML.load_file(File.expand_path(relative_path, __FILE__))
+
+          raw_info.map { |bank| bank.merge(range: Range.new(*bank[:range])) }
+        end
+    end
+    private_class_method :bank_info_table
+  end
+end

data/lib/ibandit/version.rb

@@ -1,3 +1,3 @@
 module Ibandit
-  VERSION = '0.5.0'.freeze
+  VERSION = '0.6.0'.freeze
 end

data/spec/ibandit/iban_assembler_spec.rb

@@ -554,6 +554,30 @@ describe Ibandit::IBANAssembler do
       end
     end
 
+    context 'with SE as the country_code' do
+      let(:args) do
+        {
+          country_code: 'SE',
+          bank_code: '500',
+          account_number: '00000050011045825'
+        }
+      end
+
+      it { is_expected.to eq('SE0450000000050011045825') }
+
+      it_behaves_like 'allows round trips', 'SE04 5000 0000 0500 1104 5825'
+
+      context 'without a bank_code' do
+        before { args.delete(:bank_code) }
+        it { is_expected.to be_nil }
+      end
+
+      context 'without an account_number' do
+        before { args.delete(:account_number) }
+        it { is_expected.to be_nil }
+      end
+    end
+
     context 'with SI as the country_code' do
       let(:args) do
         {

data/spec/ibandit/iban_spec.rb

@@ -1222,7 +1222,7 @@ describe Ibandit::IBAN do
     end
 
     describe 'supports_iban_determination?' do
-      subject(:valid_local_modulus_check?) { iban.supports_iban_determination? }
+      subject { iban.supports_iban_determination? }
 
       context 'with unsupported account details' do
         let(:arg) do
@@ -1292,6 +1292,68 @@ describe Ibandit::IBAN do
         end
       end
     end
+
+    describe 'valid_swedish_details?' do
+      subject { iban.valid_swedish_details? }
+
+      context 'with an account number that is too long' do
+        let(:arg) do
+          {
+            country_code: 'SE',
+            bank_code: '500',
+            account_number: '00000543910240391'
+          }
+        end
+
+        it { is_expected.to eq(false) }
+
+        context 'locale en', locale: :en do
+          specify do
+            iban.valid_swedish_details?
+            expect(iban.errors).to eq(account_number: 'is invalid')
+          end
+        end
+      end
+
+      context "with an account number that doesn't have a bank code" do
+        let(:arg) do
+          {
+            country_code: 'SE',
+            bank_code: nil,
+            account_number: '00000000000010011'
+          }
+        end
+
+        it { is_expected.to eq(false) }
+
+        context 'locale en', locale: :en do
+          specify do
+            iban.valid?
+            expect(iban.errors).to include(account_number: 'is invalid')
+            expect(iban.errors).to_not include(:bank_code)
+          end
+        end
+      end
+
+      context 'with a bad bank code' do
+        let(:arg) do
+          {
+            country_code: 'SE',
+            bank_code: '902',
+            account_number: '00000054391024039'
+          }
+        end
+
+        it { is_expected.to eq(false) }
+
+        context 'locale en', locale: :en do
+          specify do
+            iban.valid_swedish_details?
+            expect(iban.errors).to eq(bank_code: 'is invalid')
+          end
+        end
+      end
+    end
   end
 
   describe '#valid?' do
@@ -1325,6 +1387,10 @@ describe Ibandit::IBAN do
       it 'runs local modulus checks' do
         expect(iban).to receive(:valid_local_modulus_check?).at_least(1)
       end
+
+      it 'runs country specific checks' do
+        expect(iban).to receive(:passes_country_specific_checks?).at_least(1)
+      end
     end
 
     context 'for a valid Albanian IBAN' do

data/spec/ibandit/local_details_cleaner_spec.rb

@@ -682,6 +682,27 @@ describe Ibandit::LocalDetailsCleaner do
     end
   end
 
+  context 'Sweden' do
+    let(:country_code) { 'SE' }
+    let(:bank_code) { '501' }
+    let(:account_number) { '5013-1007270' }
+
+    its([:bank_code]) { is_expected.to eq('501') }
+    its([:account_number]) { is_expected.to eq('00000050131007270') }
+
+    context 'without an account number' do
+      let(:account_number) { nil }
+      it { is_expected.to eq(local_details) }
+    end
+
+    context 'without a bank code' do
+      let(:bank_code) { nil }
+
+      its([:bank_code]) { is_expected.to eq('500') }
+      its([:account_number]) { is_expected.to eq('00000050131007270') }
+    end
+  end
+
   context 'Slovenia' do
     let(:country_code) { 'SI' }
     let(:bank_code) { '19100' }

data/spec/ibandit/swedish_details_converter_spec.rb

@@ -0,0 +1,237 @@
+require 'spec_helper'
+
+describe Ibandit::SwedishDetailsConverter do
+  describe '.convert' do
+    subject { described_class.convert(account_number) }
+
+    context 'with a type-1 account number' do
+      let(:account_number) { '12810105723' }
+
+      its([:bank_code]) { is_expected.to eq('120') }
+      its([:account_number]) { is_expected.to eq('00000012810105723') }
+
+      context 'that includes hyphens' do
+        let(:account_number) { '1281-0105723' }
+
+        its([:bank_code]) { is_expected.to eq('120') }
+        its([:account_number]) { is_expected.to eq('00000012810105723') }
+      end
+
+      context 'that includes spaces' do
+        let(:account_number) { '1281 0105723' }
+
+        its([:bank_code]) { is_expected.to eq('120') }
+        its([:account_number]) { is_expected.to eq('00000012810105723') }
+      end
+
+      context 'that includes full stops' do
+        let(:account_number) { '1281.010.572.3' }
+
+        its([:bank_code]) { is_expected.to eq('120') }
+        its([:account_number]) { is_expected.to eq('00000012810105723') }
+      end
+
+      context 'that has been zero-padded' do
+        let(:account_number) { '000012810105723' }
+
+        its([:bank_code]) { is_expected.to eq('120') }
+        its([:account_number]) { is_expected.to eq('00000012810105723') }
+      end
+
+      context 'that needs the account number part to be zero-padded' do
+        let(:account_number) { '1281-1' }
+
+        its([:bank_code]) { is_expected.to eq('120') }
+        its([:account_number]) { is_expected.to eq('00000000000012811') }
+      end
+
+      context 'from SEB' do
+        let(:account_number) { '5439-10 240 39' }
+
+        its([:bank_code]) { is_expected.to eq('500') }
+        its([:account_number]) { is_expected.to eq('00000054391024039') }
+      end
+    end
+
+    context "with a clearing code that doesn't match any banks" do
+      let(:account_number) { '1001-1' }
+
+      its([:bank_code]) { is_expected.to eq(nil) }
+      its([:account_number]) { is_expected.to eq('00000000000010011') }
+    end
+
+    context 'with a Swedbank clearing code' do
+      let(:account_number) { '7507-1211203' }
+
+      its([:bank_code]) { is_expected.to eq('800') }
+      its([:account_number]) { is_expected.to eq('00000075071211203') }
+
+      context 'in the 8000s range' do
+        let(:account_number) { '8327-9 33395390-9' }
+
+        its([:bank_code]) { is_expected.to eq('800') }
+        its([:account_number]) { is_expected.to eq('00832790333953909') }
+      end
+
+      context 'another in the 8000s range' do
+        let(:account_number) { '8201-6 914357963-0' }
+
+        its([:bank_code]) { is_expected.to eq('800') }
+        its([:account_number]) { is_expected.to eq('00820169143579630') }
+      end
+    end
+
+    context 'with a Sparbanken Öresund clearing code' do
+      let(:account_number) { '9300-35299478' }
+
+      its([:bank_code]) { is_expected.to eq('930') }
+      its([:account_number]) { is_expected.to eq('00000000035299478') }
+
+      context 'with clearing number 9330 or above' do
+        let(:account_number) { '9330-5930160535' }
+
+        its([:bank_code]) { is_expected.to eq('933') }
+        its([:account_number]) { is_expected.to eq('00000005930160535') }
+      end
+    end
+
+    context 'with a Sparbanken Syd clearing code' do
+      let(:account_number) { '9570-5250093407' }
+
+      its([:bank_code]) { is_expected.to eq('957') }
+      its([:account_number]) { is_expected.to eq('00000005250093407') }
+    end
+
+    context 'with a Handelsbanken clearing code' do
+      let(:account_number) { '6000-806967498' }
+
+      its([:bank_code]) { is_expected.to eq('600') }
+      its([:account_number]) { is_expected.to eq('00000000806967498') }
+
+      context 'that has clearing code 6240' do
+        let(:account_number) { '6240-219161038' }
+
+        its([:bank_code]) { is_expected.to eq('600') }
+        its([:account_number]) { is_expected.to eq('00000000219161038') }
+      end
+
+      context 'that only has an 8 digit serial number' do
+        let(:account_number) { '6240-21916103' }
+
+        its([:bank_code]) { is_expected.to eq('600') }
+        its([:account_number]) { is_expected.to eq('00000000021916103') }
+      end
+    end
+
+    context 'with a Nordea PlusGirot clearing code' do
+      let(:account_number) { '9960-3401258276' }
+
+      its([:bank_code]) { is_expected.to eq('950') }
+      its([:account_number]) { is_expected.to eq('00099603401258276') }
+    end
+  end
+
+  describe '.valid_length?' do
+    subject do
+      described_class.valid_length?(bank_code: bank_code,
+                                    account_number: account_number)
+    end
+
+    context 'without a bank code' do
+      let(:account_number) { '12810105723' }
+      let(:bank_code) { nil }
+      it { is_expected.to eq(nil) }
+    end
+
+    context 'with an impossible bank code' do
+      let(:account_number) { '12810105723' }
+      let(:bank_code) { '500' }
+      it { is_expected.to eq(nil) }
+    end
+
+    context 'with a normal type-1 account number' do
+      let(:account_number) { '00000054391024039' }
+      let(:bank_code) { '500' }
+      it { is_expected.to eq(true) }
+
+      context 'that has a 6 digit serial number' do
+        let(:account_number) { '00000005439102403' }
+        let(:bank_code) { '500' }
+        it { is_expected.to eq(false) }
+      end
+
+      context 'that has an 8 digit serial number' do
+        let(:account_number) { '00000543910240391' }
+        let(:bank_code) { '500' }
+        it { is_expected.to eq(false) }
+      end
+    end
+
+    context 'without a Danske bank account' do
+      let(:account_number) { '12810105723' }
+      let(:bank_code) { '120' }
+      it { is_expected.to eq(true) }
+
+      context 'that has an 8 digit serial number' do
+        let(:account_number) { '00000128101057231' }
+        let(:bank_code) { '120' }
+        it { is_expected.to eq(false) }
+      end
+
+      context 'that has a 6 digit serial number' do
+        let(:account_number) { '00000001281010572' }
+        let(:bank_code) { '120' }
+        # This passes because it could be a 10 digit account number from the
+        # clearing code range 9180-9189.
+        it { is_expected.to eq(true) }
+      end
+    end
+
+    context 'with a Handelsbanken account number' do
+      let(:bank_code) { '600' }
+      let(:account_number) { '00000000219161038' }
+      it { is_expected.to eq(true) }
+
+      context 'that is only 8 characters long' do
+        let(:account_number) { '00000000021916103' }
+        it { is_expected.to eq(true) }
+      end
+
+      context 'that is 10 characters long' do
+        let(:account_number) { '00000002191610381' }
+        it { is_expected.to eq(false) }
+      end
+    end
+
+    context 'without a Nordea PlusGirot account number' do
+      let(:bank_code) { '950' }
+      let(:account_number) { '00099603401258276' }
+      it { is_expected.to eq(true) }
+    end
+  end
+
+  describe '.valid_bank_code?' do
+    subject do
+      described_class.valid_bank_code?(bank_code: bank_code,
+                                       account_number: account_number)
+    end
+
+    context 'without a bank code' do
+      let(:account_number) { '12810105723' }
+      let(:bank_code) { nil }
+      it { is_expected.to eq(false) }
+    end
+
+    context 'with an impossible bank code' do
+      let(:account_number) { '12810105723' }
+      let(:bank_code) { '500' }
+      it { is_expected.to eq(false) }
+    end
+
+    context 'with a possible bank code' do
+      let(:account_number) { '12810105723' }
+      let(:bank_code) { '120' }
+      it { is_expected.to eq(true) }
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ibandit
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 0.6.0
 platform: ruby
 authors:
 - Grey Baker
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-07-12 00:00:00.000000000 Z
+date: 2015-07-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
@@ -126,6 +126,7 @@ files:
 - data/raw/IBANSTRUCTURE.xml
 - data/raw/IBAN_Registry.txt
 - data/raw/structure_additions.yml
+- data/raw/swedish_bank_lookup.yml
 - data/structures.yml
 - ibandit.gemspec
 - lib/ibandit.rb
@@ -136,6 +137,7 @@ files:
 - lib/ibandit/iban_assembler.rb
 - lib/ibandit/iban_splitter.rb
 - lib/ibandit/local_details_cleaner.rb
+- lib/ibandit/swedish_details_converter.rb
 - lib/ibandit/version.rb
 - spec/fixtures/germany_integration_test_cases.json
 - spec/fixtures/germany_unit_test_cases.json
@@ -145,6 +147,7 @@ files:
 - spec/ibandit/iban_spec.rb
 - spec/ibandit/iban_splitter_spec.rb
 - spec/ibandit/local_details_cleaner_spec.rb
+- spec/ibandit/swedish_details_converter_spec.rb
 - spec/spec_helper.rb
 homepage: https://github.com/gocardless/ibandit
 licenses: