ibandit 0.3.2 → 0.3.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 3c7cc32ffca411662b2ec9370ec48119b19c7c29
-  data.tar.gz: efad5f26823ef1843a63351de65d3c618ff2f0ee
+  metadata.gz: 50903b48fd64a40c9178ed79eebe34291cb1d3d4
+  data.tar.gz: 974ac48d09d4d7fe1b9d2a00ae2b8ae168fa209b
 SHA512:
-  metadata.gz: 85a6244394f46b3f9513314bcdc69875a6f1d14cf4ca33a17ff9ee913de7f76746690eadc64ca66384c36cbe2536c5e8bef26745d6ddffa9cefe971bc476c26e
-  data.tar.gz: 44b6dba9272e2b9a357421a415f8269b8edf04f143b2164b3ba2b2d5930120e94c49db9920699a41503bb6c0976d33f994cccfe81745d7a06e34119a54af7871
+  metadata.gz: 28a4353847b8b4301d283867cd73d067447386925d6fd52e6dc09cb5aea083b8057ff8ca805b53e702af0cda350d63b74dfb91dc226da9b5278ed7b924c627b9
+  data.tar.gz: dfe7bb6e302680efd1c4c9921f939454974c0d0b4ad1792292435e3495ca5b1bfbe0b9ac54a72359a58ef2ac7a9af0c46ea6bf9a6a5db452d60a7f408661fe7b

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 0.3.3 - March 4, 2015
+
+- Add Greece to LocalDetailsCleaner and IBANAssembler
+
 ## 0.3.2 - February 24, 2015
 
 - Allow for injection of a modulus checker

data/README.md

@@ -71,7 +71,7 @@ module ModulusChecker
   def self.valid_bank_code?(iban_string)
     some_codes
   end
-  
+
   def self.valid_account_number?(iban_string)
     some_codes
   end
@@ -223,6 +223,15 @@ iban = Ibandit::IBAN.new(
 )
 iban.iban                     # => "GB60BARC20000055779911"
 
+# Greece
+iban = Ibandit::IBAN.new(
+  country_code: 'GR',
+  bank_code: '011',
+  branch_code: '0125',
+  account_number: '0000000012300695'
+)
+iban.iban                     # => "GR16011012500000000012300695"
+
 # Ireland
 iban = Ibandit::IBAN.new(
   country_code: 'IE',
@@ -343,8 +352,6 @@ iban = Ibandit::IBAN.new(
 iban.iban                     # => "SM88X0542811101000000123456"
 ```
 
-Support for Greece and Malta is coming soon.
-
 ## Other libraries
 
 Another gem, [iban-tools](https://github.com/alphasights/iban-tools), also

data/TODO.md

@@ -1,4 +1 @@
-- Build IBANs from national banking details for each SEPA country
-  - GREECE: TODO
-
 - Specs for IBANSTRUCTURE parser

data/lib/ibandit/iban_assembler.rb

@@ -1,7 +1,7 @@
 module Ibandit
   module IBANAssembler
-    SUPPORTED_COUNTRY_CODES = %w(AT BE CY DE EE ES FI FR GB IE IT LT LU LV MC MT
-                                 NL PT SI SK SM).freeze
+    SUPPORTED_COUNTRY_CODES = %w(AT BE CY DE EE ES FI FR GB GR IE IT LT LU LV MC
+                                 MT NL PT SI SK SM).freeze
 
     EXCEPTION_COUNTRY_CODES = %w(IT SM BE).freeze
 

data/lib/ibandit/local_details_cleaner.rb

@@ -1,7 +1,7 @@
 module Ibandit
   module LocalDetailsCleaner
-    SUPPORTED_COUNTRY_CODES = %w(AT BE CY DE EE ES FI FR GB IE IT LT LU LV MC MT
-                                 NL PT SI SK SM).freeze
+    SUPPORTED_COUNTRY_CODES = %w(AT BE CY DE EE ES FI FR GB GR IE IT LT LU LV MC
+                                 MT NL PT SI SK SM).freeze
 
     def self.clean(local_details)
       country_code = local_details[:country_code]
@@ -200,6 +200,12 @@ module Ibandit
       }
     end
 
+    def self.clean_gr_details(local_details)
+      # Greek IBANs construction is idiosyncratic to the individual banks, and
+      # no central specification is published.
+      local_details
+    end
+
     def self.clean_ie_details(local_details)
       # Ireland uses the same local details as the United Kingdom
       branch_code = local_details[:branch_code].gsub(/[-\s]/, '')

data/lib/ibandit/version.rb

@@ -1,3 +1,3 @@
 module Ibandit
-  VERSION = '0.3.2'.freeze
+  VERSION = '0.3.3'.freeze
 end

data/spec/ibandit/iban_assembler_spec.rb

@@ -262,6 +262,36 @@ describe Ibandit::IBANAssembler do
       end
     end
 
+    context 'with GR as the country_code' do
+      let(:args) do
+        {
+          country_code: 'GR',
+          bank_code: '011',
+          branch_code: '0125',
+          account_number: '0000000012300695'
+        }
+      end
+
+      it { is_expected.to eq('GR1601101250000000012300695') }
+
+      it_behaves_like 'allows round trips', 'GR16 0110 1250 0000 0001 2300 695'
+
+      context 'without an account_number' do
+        before { args.delete(:account_number) }
+        it { is_expected.to be_nil }
+      end
+
+      context 'without a bank_code' do
+        before { args.delete(:bank_code) }
+        it { is_expected.to be_nil }
+      end
+
+      context 'without a branch_code' do
+        before { args.delete(:branch_code) }
+        it { is_expected.to be_nil }
+      end
+    end
+
     context 'with IE as the country_code' do
       let(:args) do
         { country_code: 'IE',

data/spec/ibandit/local_details_cleaner_spec.rb

@@ -345,6 +345,30 @@ describe Ibandit::LocalDetailsCleaner do
     end
   end
 
+  context 'Greece' do
+    let(:country_code) { 'GR' }
+    let(:bank_code) { '011' }
+    let(:branch_code) { '0125' }
+    let(:account_number) { '0000000012300695' }
+
+    it { is_expected.to eq(local_details) }
+
+    context 'without an account number' do
+      let(:account_number) { nil }
+      it { is_expected.to eq(local_details) }
+    end
+
+    context 'without a bank code' do
+      let(:bank_code) { nil }
+      it { is_expected.to eq(local_details) }
+    end
+
+    context 'without a branch code' do
+      let(:branch_code) { nil }
+      it { is_expected.to eq(local_details) }
+    end
+  end
+
   context 'Ireland' do
     let(:country_code) { 'IE' }
     let(:bank_code) { 'AIBK' }

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ibandit
 version: !ruby/object:Gem::Version
-  version: 0.3.2
+  version: 0.3.3
 platform: ruby
 authors:
 - Grey Baker
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-02-24 00:00:00.000000000 Z
+date: 2015-03-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec