ibandit 0.3.0 → 0.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: efe0d22849b9038cd0f8ba2d2a5ca9b73af14137
-  data.tar.gz: dbf58fdc4ba8242d3676b76b01f194a5d58c4412
+  metadata.gz: 79bb8d78b071a6a3cfb74852b2f62641af34014d
+  data.tar.gz: 3868681d7108888d0259ff51f145bfefb481035f
 SHA512:
-  metadata.gz: 254642c61af11750bc56d04714521b778a34ac4f9852d65eb426ab50cd820c828a90efd180058e2c6b453a4745162ecc731aaf9e4cbcd2fccbe156017d042edb
-  data.tar.gz: 1edbf221f87f7097760555697d26ec15bc7896906b3f63fd385c845f897cefebf17fa9dd74da3dff8e422e61004f3d132739f4a5e924c5cd4d14d5035c34e9f5
+  metadata.gz: b3e0bb71e33693b7b7ad0a67a3b7aa911dd3d1ef0c0f2e1c1cfa4ca2a0815f2b4f3701cf76f6414fb674da299dc6c06cef64ad2edc98dfad990c5a9095dcff2e
+  data.tar.gz: 859b58bd96989e6bf05ab2127fb29939ad4db924bf816d97c5bfd86ee6b13d424d51ee7f6a3536def34375b17fab2bd9489f7dc1178ed4f98f06b921a294b3ad

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 0.3.1 - February 14, 2015
+
+- Add Malta to LocalDetailsCleaner and IBANAssembler
+
 ## 0.3.0 - February 6, 2015
 
 - Move IBANBuilder interface into main IBAN class by overloading its constructor
@@ -13,7 +17,6 @@
 
 - Add GermanDetailsConverter
 
-
 ## 0.1.1 - January 8, 2015
 
 - Add zero-padding to CheckDigit.spanish

data/README.md

@@ -138,7 +138,7 @@ To build an IBAN from local details:
 
 ```ruby
 # Austria
-iban = Ibandit::IBANBuilder.build(
+iban = Ibandit::IBAN.new(
   country_code: 'AT',
   account_number: '234573201',
   bank_code: '19043'
@@ -146,14 +146,14 @@ iban = Ibandit::IBANBuilder.build(
 iban.iban                     # => "AT611904300234573201"
 
 # Belgium
-iban = Ibandit::IBANBuilder.build(
+iban = Ibandit::IBAN.new(
   country_code: 'BE',
   account_number: '510-0075470-61'
 )
 iban.iban                     # => "BE62510007547061"
 
 # Cyprus
-iban = Ibandit::IBANBuilder.build(
+iban = Ibandit::IBAN.new(
   country_code: 'CY',
   account_number: '1200527600',
   bank_code: '002',
@@ -162,7 +162,7 @@ iban = Ibandit::IBANBuilder.build(
 iban.iban                     # => "CY17002001280000001200527600"
 
 # Germany
-iban = Ibandit::IBANBuilder.build(
+iban = Ibandit::IBAN.new(
   country_code: 'DE',
   bank_code: '37040044',
   account_number: '0532013000'
@@ -170,14 +170,14 @@ iban = Ibandit::IBANBuilder.build(
 iban.iban                     # => "DE89370400440532013000"
 
 # Estonia
-iban = Ibandit::IBANBuilder.build(
+iban = Ibandit::IBAN.new(
   country_code: 'EE',
   account_number: '111020145685'
 )
 iban.iban                     # => "EE412200111020145685"
 
 # Finland
-iban = Ibandit::IBANBuilder.build(
+iban = Ibandit::IBAN.new(
   country_code: 'FI',
   bank_code: '123456'
   account_number: '785'
@@ -185,7 +185,7 @@ iban = Ibandit::IBANBuilder.build(
 iban.iban                     # => "FI2112345600000785"
 
 # France
-iban = Ibandit::IBANBuilder.build(
+iban = Ibandit::IBAN.new(
   country_code: 'FR',
   bank_code: '20041',
   branch_code: '01005',
@@ -194,7 +194,7 @@ iban = Ibandit::IBANBuilder.build(
 iban.iban                     # => "FR1420041010050500013M02606"
 
 # United Kingdom
-iban = Ibandit::IBANBuilder.build(
+iban = Ibandit::IBAN.new(
   country_code: 'GB',
   bank_code: 'BARC', # optional if a BIC finder is configured
   branch_code: '200000',
@@ -203,7 +203,7 @@ iban = Ibandit::IBANBuilder.build(
 iban.iban                     # => "GB60BARC20000055779911"
 
 # Ireland
-iban = Ibandit::IBANBuilder.build(
+iban = Ibandit::IBAN.new(
   country_code: 'IE',
   bank_code: 'AIBK', # optional if a BIC finder is configured
   branch_code: '931152',
@@ -212,7 +212,7 @@ iban = Ibandit::IBANBuilder.build(
 iban.iban                     # => "IE29AIBK93115212345678"
 
 # Italy
-iban = Ibandit::IBANBuilder.build(
+iban = Ibandit::IBAN.new(
   country_code: 'IT',
   bank_code: '05428',
   branch_code: '11101',
@@ -221,7 +221,7 @@ iban = Ibandit::IBANBuilder.build(
 iban.iban                     # => "IT60X0542811101000000123456"
 
 # Latvia
-iban = Ibandit::IBANBuilder.build(
+iban = Ibandit::IBAN.new(
   country_code: 'LV',
   account_number: '1234567890123',
   bank_code: 'BANK'
@@ -229,7 +229,7 @@ iban = Ibandit::IBANBuilder.build(
 iban.iban                     # => "LV72BANK1234567890123"
 
 # Lithuania
-iban = Ibandit::IBANBuilder.build(
+iban = Ibandit::IBAN.new(
   country_code: 'LT',
   account_number: '11101001000',
   bank_code: '10000'
@@ -237,7 +237,7 @@ iban = Ibandit::IBANBuilder.build(
 iban.iban                     # => "LT1000011101001000"
 
 # Luxembourg
-iban = Ibandit::IBANBuilder.build(
+iban = Ibandit::IBAN.new(
   country_code: 'LU',
   account_number: '1234567890123',
   bank_code: 'BANK'
@@ -245,7 +245,7 @@ iban = Ibandit::IBANBuilder.build(
 iban.iban                     # => "LU75BANK1234567890123"
 
 # Monaco
-iban = Ibandit::IBANBuilder.build(
+iban = Ibandit::IBAN.new(
   country_code: 'MC',
   bank_code: '20041',
   branch_code: '01005',
@@ -253,8 +253,17 @@ iban = Ibandit::IBANBuilder.build(
 )
 iban.iban                     # => "MC9320041010050500013M02606"
 
+# Malta
+iban = Ibandit::IBAN.new(
+  country_code: 'MT',
+  bank_code: 'MMEB', # optional if a BIC finder is configured
+  branch_code: '44093',
+  account_number: '9027293051'
+)
+iban.iban                     # => "MT98MMEB44093000000009027293051"
+
 # The Netherlands
-iban = Ibandit::IBANBuilder.build(
+iban = Ibandit::IBAN.new(
   country_code: 'NL',
   account_number: '0417164300',
   bank_code: 'ABNA'
@@ -262,7 +271,7 @@ iban = Ibandit::IBANBuilder.build(
 iban.iban                     # => "NL91ABNA0417164300"
 
 # Portugal
-iban = Ibandit::IBANBuilder.build(
+iban = Ibandit::IBAN.new(
   country_code: 'PT',
   bank_code: '0002',
   branch_code: '0023',
@@ -271,7 +280,7 @@ iban = Ibandit::IBANBuilder.build(
 iban.iban                     # => "PT50000200230023843000578"
 
 # Slovakia
-iban = Ibandit::IBANBuilder.build(
+iban = Ibandit::IBAN.new(
   country_code: 'SK',
   bank_code: '1200',
   account_number_prefix: '19',
@@ -280,7 +289,7 @@ iban = Ibandit::IBANBuilder.build(
 iban.iban                     # => "SK3112000000198742637541"
 
 # Slovenia
-iban = Ibandit::IBANBuilder.build(
+iban = Ibandit::IBAN.new(
   country_code: 'SI',
   bank_code: '19100',
   account_number: '1234'
@@ -288,7 +297,7 @@ iban = Ibandit::IBANBuilder.build(
 iban.iban                     # => "SI56191000000123438"
 
 # Spain
-iban = Ibandit::IBANBuilder.build(
+iban = Ibandit::IBAN.new(
   country_code: 'ES',
   bank_code: '2310',
   branch_code: '0001',
@@ -297,14 +306,14 @@ iban = Ibandit::IBANBuilder.build(
 iban.iban                     # => "ES8023100001180000012345"
 
 # Spain with 20 digit account number
-iban = Ibandit::IBANBuilder.build(
+iban = Ibandit::IBAN.new(
   country_code: 'ES',
   account_number: '23100001180000012345'
 )
 iban.iban                     # => "ES8023100001180000012345"
 
 # San Marino
-iban = Ibandit::IBANBuilder.build(
+iban = Ibandit::IBAN.new(
   country_code: 'SM',
   bank_code: '05428',
   branch_code: '11101',

data/TODO.md

@@ -1,7 +1,4 @@
 - Build IBANs from national banking details for each SEPA country
   - GREECE: TODO
-  - MALTA: TODO (maybe - not sure if local details are still used in Malta).
-
-- Clarify Lithuanian check digits
 
 - Specs for IBANSTRUCTURE parser

data/lib/ibandit/iban_assembler.rb

@@ -1,7 +1,7 @@
 module Ibandit
   module IBANAssembler
-    SUPPORTED_COUNTRY_CODES = %w(AT BE CY DE EE ES FI FR GB IE IT LT LU LV MC NL
-                                 PT SI SK SM).freeze
+    SUPPORTED_COUNTRY_CODES = %w(AT BE CY DE EE ES FI FR GB IE IT LT LU LV MC MT
+                                 NL PT SI SK SM).freeze
 
     EXCEPTION_COUNTRY_CODES = %w(IT SM BE).freeze
 

data/lib/ibandit/local_details_cleaner.rb

@@ -1,7 +1,7 @@
 module Ibandit
   module LocalDetailsCleaner
-    SUPPORTED_COUNTRY_CODES = %w(AT BE CY DE EE ES FI FR GB IE IT LT LU LV MC NL
-                                 PT SI SK SM).freeze
+    SUPPORTED_COUNTRY_CODES = %w(AT BE CY DE EE ES FI FR GB IE IT LT LU LV MC MT
+                                 NL PT SI SK SM).freeze
 
     def self.clean(local_details)
       country_code = local_details[:country_code]
@@ -31,7 +31,7 @@ module Ibandit
         %i(bank_code account_number)
       when 'BE', 'EE', 'ES'
         %i(account_number)
-      when 'GB', 'IE'
+      when 'GB', 'IE', 'MT'
         if Ibandit.bic_finder.nil? then %i(bank_code branch_code account_number)
         else %i(branch_code account_number)
         end
@@ -200,21 +200,6 @@ module Ibandit
       }
     end
 
-    def self.clean_lt_details(local_details)
-      # Lithuanian national bank details were replaced with IBANs in 2004.
-      local_details
-    end
-
-    def self.clean_lu_details(local_details)
-      # Luxembourgian national bank details were replaced with IBANs in 2002.
-      local_details
-    end
-
-    def self.clean_lv_details(local_details)
-      # Latvian national bank details were replaced with IBANs in 2004.
-      local_details
-    end
-
     def self.clean_ie_details(local_details)
       # Ireland uses the same local details as the United Kingdom
       branch_code = local_details[:branch_code].gsub(/[-\s]/, '')
@@ -245,11 +230,47 @@ module Ibandit
       }
     end
 
+    def self.clean_lt_details(local_details)
+      # Lithuanian national bank details were replaced with IBANs in 2004.
+      local_details
+    end
+
+    def self.clean_lu_details(local_details)
+      # Luxembourgian national bank details were replaced with IBANs in 2002.
+      local_details
+    end
+
+    def self.clean_lv_details(local_details)
+      # Latvian national bank details were replaced with IBANs in 2004.
+      local_details
+    end
+
     def self.clean_mc_details(local_details)
       # Monaco uses the same local details method as France
       clean_fr_details(local_details)
     end
 
+    def self.clean_mt_details(local_details)
+      # Add leading zeros to account number if < 18 digits.
+      branch_code = local_details[:branch_code]
+
+      if local_details[:bank_code]
+        bank_code = local_details[:bank_code]
+      else
+        bic = Ibandit.find_bic('MT', branch_code)
+        bank_code = bic.nil? ? nil : bic.slice(0, 4)
+      end
+
+      account_number = local_details[:account_number].gsub(/[-\s]/, '')
+      account_number = account_number.rjust(18, '0')
+
+      {
+        bank_code:      bank_code,
+        branch_code:    branch_code,
+        account_number: account_number
+      }
+    end
+
     def self.clean_nl_details(local_details)
       # Add leading zeros to account number if < 10 digits.
       {

data/lib/ibandit/version.rb

@@ -1,3 +1,3 @@
 module Ibandit
-  VERSION = '0.3.0'.freeze
+  VERSION = '0.3.1'.freeze
 end

data/spec/ibandit/iban_assembler_spec.rb

@@ -432,6 +432,44 @@ describe Ibandit::IBANAssembler do
       end
     end
 
+    context 'with MT as the country_code' do
+      let(:args) do
+        {
+          country_code: 'MT',
+          bank_code: 'MMEB',
+          branch_code: '44093',
+          account_number: '000000009027293051'
+        }
+      end
+
+      it { is_expected.to eq('MT98MMEB44093000000009027293051') }
+
+      it_behaves_like(
+        'allows round trips',
+        'MT98 MMEB 4409 3000 0000 0902 7293 051'
+      )
+
+      context 'without a branch_code' do
+        before { args.delete(:branch_code) }
+        it { is_expected.to be_nil }
+      end
+
+      context 'without an account_number' do
+        before { args.delete(:account_number) }
+        it { is_expected.to be_nil }
+      end
+
+      context 'without a bank_code' do
+        before { args.delete(:bank_code) }
+        it { is_expected.to be_nil }
+      end
+
+      context 'with a non-numeric branch code' do
+        before { args[:branch_code] = 'abc123' }
+        it { is_expected.to be_nil }
+      end
+    end
+
     context 'with NL as the country_code' do
       let(:args) do
         {

data/spec/ibandit/local_details_cleaner_spec.rb

@@ -546,6 +546,60 @@ describe Ibandit::LocalDetailsCleaner do
     end
   end
 
+  context 'Malta' do
+    let(:country_code) { 'MT' }
+    let(:bank_code) { 'MMEB' }
+    let(:branch_code) { '44093' }
+    let(:account_number) { '000000009027293051' }
+
+    it { is_expected.to eq(local_details) }
+
+    context 'with the account number spaced' do
+      let(:account_number) { '9027 2930 51' }
+      its([:account_number]) { is_expected.to eq('000000009027293051') }
+    end
+
+    context 'with the account number hyphenated' do
+      let(:account_number) { '9027-2930-51' }
+      its([:account_number]) { is_expected.to eq('000000009027293051') }
+    end
+
+    context 'without a branch code' do
+      let(:branch_code) { nil }
+      it { is_expected.to eq(local_details) }
+    end
+
+    context 'without a bank code' do
+      let(:bank_code) { nil }
+      it { is_expected.to eq(local_details) }
+
+      context 'with a BIC finder set' do
+        let(:bic_finder) { double }
+        before do
+          allow(bic_finder).to receive(:call).with('MT', '44093').
+            and_return('MMEBMTMTXXX')
+          Ibandit.bic_finder = bic_finder
+        end
+        after { Ibandit.bic_finder = nil }
+
+        its([:bank_code]) { is_expected.to eq('MMEB') }
+      end
+    end
+
+    context 'with a bank code and BIC finder set' do
+      let(:bank_code) { 'OVERRIDE' }
+      let(:bic_finder) { double }
+      before do
+        allow(bic_finder).to receive(:call).with('MT', '44093').
+          and_return('MMEBMTMTXXX')
+        Ibandit.bic_finder = bic_finder
+      end
+      after { Ibandit.bic_finder = nil }
+
+      its([:bank_code]) { is_expected.to eq('OVERRIDE') }
+    end
+  end
+
   context 'Netherlands' do
     let(:country_code) { 'NL' }
     let(:bank_code) { 'ABNA' }

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ibandit
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.3.1
 platform: ruby
 authors:
 - Grey Baker
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-02-06 00:00:00.000000000 Z
+date: 2015-02-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec