ibandit 0.11.5 → 0.11.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f365d97d443247790fa0c8b6942be2dd5b151d2e
-  data.tar.gz: 12294a51b413f1d5f9a372d72834dd5ccb9ebecc
+  metadata.gz: 41544fc88196be92db16efd014ebef39d902edae
+  data.tar.gz: 49c61566ecd2544e39806d9ffed03b396cc26657
 SHA512:
-  metadata.gz: dd29024ac1f67cdc9b1241510328d14dd11ee1c45ab744750ee4f1ad705becab8fc5334db48c0ab1930e81d2199e156d7216582de6c86b7fda6ed7f24446519b
-  data.tar.gz: d19e80eaa7d3fc9f0d614210a36abaeeba40821e93af57708509992cc9198c34c93fbabc4952528d6769eac6623bb9b8c7b5cb71650af62ddc324dad8b9ca595
+  metadata.gz: 5db651c124eee33c8feb7d4bd6b90b11a0f994c943b17e92b724cca35ed61ee25840bfbd96d37c07e91d1bee312c5faae88bda1c22ace03bb2a897cceb3bf35e
+  data.tar.gz: a47561f912533e01a0befbc694a9ceeb94b8665c080e15244323c57dc8bbce207f728a964e654c698e09917fc03fb1bb2344627288e4e295217880e810e70d12

data/.travis.yml

@@ -4,9 +4,10 @@ matrix:
   allow_failures:
 
 rvm:
-  - 2.1
-  - 2.2
-  - 2.3.0
+  - 2.1.10
+  - 2.2.7
+  - 2.3.4
+  - 2.4.1
 
 sudo: false
 

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 0.11.6 - August 16, 2017
+
+- Handle invalid characters when computing check digits for Italy
+
 ## 0.11.5 - June 16, 2017
 
 - Fix invalid regular expression `account_number_format` for Dominican Republic IBANs.

data/lib/ibandit/check_digit.rb

@@ -1,5 +1,14 @@
 module Ibandit
   module CheckDigit
+    ITALIAN_ODD_MAPPING = {
+      'A' => 1,  'B' => 0,  'C' => 5,  'D' => 7,  'E' => 9,  'F' => 13,
+      'G' => 15, 'H' => 17, 'I' => 19, 'J' => 21, 'K' => 2,  'L' => 4,
+      'M' => 18, 'N' => 20, 'O' => 11, 'P' => 3,  'Q' => 6,  'R' => 8,
+      'S' => 12, 'T' => 14, 'U' => 16, 'V' => 10, 'W' => 22, 'X' => 25,
+      'Y' => 24, 'Z' => 23, '0' => 1,  '1' => 0,  '2' => 5,  '3' => 7,
+      '4' => 9,  '5' => 13, '6' => 15, '7' => 17, '8' => 19, '9' => 21
+    }.freeze
+
     def self.iban(country_code, bban)
       chars = bban + country_code + '00'
       digits = chars.bytes.map do |byte|
@@ -16,18 +25,14 @@ module Ibandit
     end
 
     def self.italian(string)
-      odd_mapping = {
-        'A' => 1,  'B' => 0,  'C' => 5,  'D' => 7,  'E' => 9,  'F' => 13,
-        'G' => 15, 'H' => 17, 'I' => 19, 'J' => 21, 'K' => 2,  'L' => 4,
-        'M' => 18, 'N' => 20, 'O' => 11, 'P' => 3,  'Q' => 6,  'R' => 8,
-        'S' => 12, 'T' => 14, 'U' => 16, 'V' => 10, 'W' => 22, 'X' => 25,
-        'Y' => 24, 'Z' => 23, '0' => 1,  '1' => 0,  '2' => 5,  '3' => 7,
-        '4' => 9,  '5' => 13, '6' => 15, '7' => 17, '8' => 19, '9' => 21
-      }
-
       scaled_values = string.chars.map.with_index do |char, index|
         if index.even?
-          odd_mapping[char]
+          if ITALIAN_ODD_MAPPING.include?(char)
+            ITALIAN_ODD_MAPPING[char]
+          else
+            raise InvalidCharacterError,
+                  "Unexpected character '#{char}'"
+          end
         else
           case char.ord
           when 48..57 then char.to_i         # 0..9

data/lib/ibandit/version.rb

@@ -1,3 +1,3 @@
 module Ibandit
-  VERSION = '0.11.5'.freeze
+  VERSION = '0.11.6'.freeze
 end

data/spec/ibandit/iban_assembler_spec.rb

@@ -498,8 +498,13 @@ describe Ibandit::IBANAssembler do
         it { is_expected.to eq('IT64Y0542811101000000123456') }
       end
 
-      context 'with a bad character' do
-        before { args[:account_number] = '000000123hhh' }
+      context 'with a bad character in an odd position' do
+        before { args[:account_number] = '000000123h00' }
+        it { is_expected.to be_nil }
+      end
+
+      context 'with a bad character in an even position' do
+        before { args[:account_number] = '0000001230h0' }
         it { is_expected.to be_nil }
       end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ibandit
 version: !ruby/object:Gem::Version
-  version: 0.11.5
+  version: 0.11.6
 platform: ruby
 authors:
 - Grey Baker
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-06-16 00:00:00.000000000 Z
+date: 2017-08-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
@@ -182,4 +182,3 @@ signing_key:
 specification_version: 4
 summary: Convert national banking details into IBANs, and vice-versa.
 test_files: []
-has_rdoc: