ibandit 0.11.27 → 0.11.28

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 0ef65b4d6eedd45de97dbe15a3b2b3996df05e1c
-  data.tar.gz: 9e886c94b5513ad76d1d3941f1924db6a011608b
+  metadata.gz: 31afcc0a061c33a69c2fdf4dc857603ebb91fd7c
+  data.tar.gz: 7f692e0706dc2410613e2e246349f95d9c6f938e
 SHA512:
-  metadata.gz: 7b292f452af4977a2799591335975db4cec051ad0a8ce2c686eb89de0e8439476855885ed820f021508fca1f127b0622b098320855bc71e8e957e9f099049b8f
-  data.tar.gz: d01ef104eb0fad531e3b79dbf1973e9cfc94b786de4403915bbb95ba59060ef7f4d20e2719330f44aef9dc2b70b6f0456269342859592720f362ff0a1f3c6032
+  metadata.gz: 3f41f600cbd7a54a809ebdb8d9f4b3976aa23cdace895d03f4184585ebfe615bbfd9c12920df48d438e1d0ad8c15e52ba434e1d8a3803ca588e71e573ae8ae01
+  data.tar.gz: 0d269f41269d38e134b54e83a5c559fd75e5fabbd0d86fd8b461cb6f7eab7418fbe7a2af2f662b3c0dc30f83a293c312966f9e52529761557791bbc495a3e316

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 0.11.28 - March 21, 2019
+
+- Handle bad input more gracefully (`bank_code` being nil)
+
 ## 0.11.27 - February 22, 2019
 
 - Update US account number format validation to allow digits-only

data/lib/ibandit/iban.rb

@@ -386,6 +386,7 @@ module Ibandit
 
     # rubocop:disable Metrics/AbcSize
     def bank_code_passes_checksum_test?
+      return false unless swift_bank_code
       return false if swift_bank_code.length != 9
 
       code_digits = swift_bank_code.chars.map(&:to_i)

data/lib/ibandit/version.rb

@@ -1,3 +1,3 @@
 module Ibandit
-  VERSION = "0.11.27".freeze
+  VERSION = "0.11.28".freeze
 end

data/spec/ibandit/iban_spec.rb

@@ -683,6 +683,18 @@ describe Ibandit::IBAN do
         its(:to_s) { is_expected.to eq("") }
       end
 
+      context "and bank code that is nil" do
+        let(:bank_code) { nil }
+        let(:account_number) { "01234567890123456" }
+
+        its(:iban) { is_expected.to be_nil }
+
+        it "returns an error on bank_code attribute" do
+          expect(subject.valid?).to eq(false)
+          expect(subject.errors).to eq(bank_code: "is required")
+        end
+      end
+
       context "and a 17 digit account number" do
         let(:account_number) { "01234567890123456" }
         let(:bank_code) { "965498456" }

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ibandit
 version: !ruby/object:Gem::Version
-  version: 0.11.27
+  version: 0.11.28
 platform: ruby
 authors:
 - GoCardless
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-02-22 00:00:00.000000000 Z
+date: 2019-04-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri