ibandit 0.11.24 → 0.11.25

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 668b1fb51b7cf069a3571031168991cdb97f0ea2
-  data.tar.gz: 4bfe3207906007a781617a7dbff3bbbe6bb82f25
+  metadata.gz: 25eea6c456d9782856e5600061dc8414d90f651a
+  data.tar.gz: c81156af68d0817c88dd9faad9a908a7a75bab2d
 SHA512:
-  metadata.gz: bb3d8b5054d45f508f88a686040dfc51a8a3e4bd1971fe54300c31015cc5cd34ed81a8788740574f703d59738651b49f1852db0156bd22d35c4c8afdd6f19a5c
-  data.tar.gz: fe66a3af2e980f0f40d09e4db3b99391cfa3442cd23ce14a31e780b9d6a1ee0bcbc3e0c05f112d387b820b03fb7fe4dffedc6360eca2273832d881503fd8b466
+  metadata.gz: 343b1bf9e56d78bc6ee805e75d260f20596770d3ff7b9ce6107579cad1dee21d9cbdec714fa7b7c0c4fd59f2facd8ab5e290ccfe4238cba82fca014f321b3511
+  data.tar.gz: 45ddb672d2b7db64b3c2dec6bceb6e3b87be62dda0cca036b0f55d77f9e9756e6ad454fd257ab3610d98d1de9206786fb31022816dae13fa61e2e97ad491ec95

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 0.11.25 - January 10, 2019
+
+- Prevent account numbers from being all-zero in Australia
+
 ## 0.11.24 - December 13, 2018
 
 - Add support for 3-digit financial institution numbers in Canada

data/lib/ibandit/iban.rb

@@ -373,7 +373,7 @@ module Ibandit
     def valid_australian_details?
       return true unless country_code == "AU"
 
-      bsb_check?
+      bsb_check? && account_number_not_all_zeros?
     end
 
     def bsb_check?
@@ -512,5 +512,12 @@ module Ibandit
       return false if input.nil?
       input.slice(2, 2) == Constants::PSEUDO_IBAN_CHECK_DIGITS
     end
+
+    def account_number_not_all_zeros?
+      return true if @swift_account_number.to_s.chars.uniq != ["0"]
+
+      @errors[:account_number] = Ibandit.translate(:is_invalid)
+      false
+    end
   end
 end

data/lib/ibandit/version.rb

@@ -1,3 +1,3 @@
 module Ibandit
-  VERSION = "0.11.24".freeze
+  VERSION = "0.11.25".freeze
 end

data/spec/ibandit/iban_spec.rb

@@ -273,6 +273,23 @@ describe Ibandit::IBAN do
         its(:valid?) { is_expected.to eq(true) }
         its(:to_s) { is_expected.to eq("") }
       end
+
+      context "and an account number that is all zero" do
+        let(:account_number) { "000000" }
+
+        its(:country_code) { is_expected.to eq("AU") }
+        its(:bank_code) { is_expected.to be_nil }
+        its(:branch_code) { is_expected.to eq("123456") }
+        its(:account_number) { is_expected.to eq("0000000000") }
+        its(:swift_bank_code) { is_expected.to be_nil }
+        its(:swift_branch_code) { is_expected.to eq("123456") }
+        its(:swift_account_number) { is_expected.to eq("0000000000") }
+        its(:swift_national_id) { is_expected.to eq("123456") }
+        its(:iban) { is_expected.to be_nil }
+        its(:pseudo_iban) { is_expected.to eq("AUZZ1234560000000000") }
+        its(:valid?) { is_expected.to eq(false) }
+        its(:to_s) { is_expected.to eq("") }
+      end
     end
 
     context "when the IBAN was created from an Australian pseudo-IBAN" do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ibandit
 version: !ruby/object:Gem::Version
-  version: 0.11.24
+  version: 0.11.25
 platform: ruby
 authors:
 - GoCardless
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-12-13 00:00:00.000000000 Z
+date: 2019-01-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri
@@ -210,7 +210,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.2.3
+rubygems_version: 2.6.14
 signing_key: 
 specification_version: 4
 summary: Convert national banking details into IBANs, and vice-versa.