ibandit 0.11.16 → 0.11.17

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA256:
-  metadata.gz: f9a02ead16e75d81f8b1ada11d37372b5d6f3f293baf480fedabc42bae3edc9f
-  data.tar.gz: d73bfd7838bc38ae20e351e8104113fed593fa82c4e376d9939c0969a124441e
+SHA1:
+  metadata.gz: d185a7140b320e5a5d7e46b3c42276341b61093c
+  data.tar.gz: afcd5829a0f4ef9b74fd35ee66b7045c5f985154
 SHA512:
-  metadata.gz: 2da7f3eea03bb511bc23373c38cb30e28e044e56365359aafccf17770350226a57a7a9a26cf593996a082fc185353a3ab189a671fff2d30cfe6bea3a8222190b
-  data.tar.gz: 5a1a37becef9f46fce19445aec3bec965e11fcd62db747d74437dd7b5c2c92f2935a6d964446975445d4e79063d2adf49320ce7c2957269dfedb3ff78858dac8
+  metadata.gz: b31920d1c68bb1caaf52a0c0e2b31dedcae5ec91169f57ff525639bcc0f3c2a444701096569b278c536abacf95729cdef80c546178b7f37f7cec70558081ff35
+  data.tar.gz: 26f3c276022e91fd683335d454a1e81f5b8d49b3e4ea06e3b74212135350942fec82a96772a351027dd03a35a7782dd676715b8997864fe792a08dd4968e787c

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 0.11.17 - September 17, 2018
+
+- Do not crash when given too short account numbers for New Zealand
+
 ## 0.11.16 - September 3, 2018
 
 - Loosen `i18n` dependency (thanks @glaszig!)

data/README.md

@@ -522,25 +522,25 @@ iban.iban                     # => nil
 iban = Ibandit::IBAN.new(
   country_code: 'NZ',
   bank_code: '01',
-  branch_code: '5659',
+  branch_code: '0004',
   account_number: '3333333-44' # 7 digit account number and 2/3-digit account suffix
 )
-iban.pseudo_iban            # => "NZZZ0156593333333044"
+iban.pseudo_iban            # => "NZZZ0100043333333044"
 iban.iban                   # => nil
 
 iban = Ibandit::IBAN.new(
   country_code: 'NZ',
-  account_number: '01-5659-3333333-44'
+  account_number: '01-0004-3333333-44'
 )
-iban.pseudo_iban          # => "NZZZ0156593333333044"
+iban.pseudo_iban          # => "NZZZ0100043333333044"
 iban.bank_code            # => "01"
-iban.branch_code          # => "5659"
+iban.branch_code          # => "0004"
 iban.account_number       # => "3333333044"
 
-iban = Ibandit::IBAN.new('NZZZ0156593333333044')
+iban = Ibandit::IBAN.new('NZZZ0100043333333044')
 iban.country_code         # => "NZ"
 iban.bank_code            # => "01"
-iban.branch_code          # => "5659"
+iban.branch_code          # => "0004"
 iban.account_number       # => "3333333044"
 ```
 

data/lib/ibandit/local_details_cleaner.rb

@@ -455,7 +455,7 @@ module Ibandit
         account_number = cleaned_account_number[6..-1]
       end
 
-      if account_number.length == 9
+      if account_number && account_number.length == 9
         # > Some banks (such as BNZ) include three digits of the suffix in their
         # > presentation of the account number to the end customer. Other banks
         # > only show the last two digits of the suffix to the end customer.

data/lib/ibandit/version.rb

@@ -1,3 +1,3 @@
 module Ibandit
-  VERSION = "0.11.16".freeze
+  VERSION = "0.11.17".freeze
 end

data/spec/ibandit/local_details_cleaner_spec.rb

@@ -956,6 +956,11 @@ describe Ibandit::LocalDetailsCleaner do
         its([:branch_code]) { is_expected.to eq("2222") }
         its([:account_number]) { is_expected.to eq("3333333044") }
       end
+
+      context "when the account number is shorter than 6 chars" do
+        let(:account_number) { "12345" }
+        its([:account_number]) { is_expected.to be_nil }
+      end
     end
 
     context "without an account number" do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ibandit
 version: !ruby/object:Gem::Version
-  version: 0.11.16
+  version: 0.11.17
 platform: ruby
 authors:
 - GoCardless
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-09-03 00:00:00.000000000 Z
+date: 2018-09-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri
@@ -206,7 +206,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.7.6
+rubygems_version: 2.6.14
 signing_key: 
 specification_version: 4
 summary: Convert national banking details into IBANs, and vice-versa.