ibandit 0.11.14 → 0.11.15

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 3060e96d5d67d57e9759c68bfd68b4174b65291c
-  data.tar.gz: 259f05d4b483b3fc7d96fa22c9904301063ad8fc
+  metadata.gz: a159dff483326ad700b9d6c2348be9a36b6eb9fd
+  data.tar.gz: a3ebcafd962ddad867a8d8103840dd2e6514e1bf
 SHA512:
-  metadata.gz: b9c623c432caaefd6aa60fbbf63f3c75380e7723f71164b21d3d6279b71a7416b96b7812932673b24cf09d849d3dfc2106792527e12f47836f4c14f294fbc305
-  data.tar.gz: 6244f013565d3f83c28f8d4d244a80b1fc89d8cd533607f02ac919331e1bba02ea79e5f3576274fc990bc34ee078d2cfcca53a3d973f0158ab76ae04ebc7f776
+  metadata.gz: ca3965ca8a619cf55fe945a3209d59f7c3f2381b6e3512539c21f31e8676470f2952fc1ad8a594e453518bc7498a28de6dc5b2641bb2e76c03382f4a7344b030
+  data.tar.gz: f12360f3a4cc08548b40263e16d2962f97a90d23d4a0ca4bbd3533d2c902fcb5aa267032f52dabb821ca484e5142982dcc8cf5c885fe6164a9aa06e876148653

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 0.11.15 - August 30, 2018
+
+- Validate New Zealand branch codes
+
 ## 0.11.14 - July 26, 2018
 
 - Add support for NZ pseudo-IBANs

data/lib/ibandit/iban.rb

@@ -282,6 +282,7 @@ module Ibandit
       when "DE" then supports_iban_determination?
       when "SE" then valid_swedish_details?
       when "AU" then valid_australian_details?
+      when "NZ" then valid_nz_details?
       else true
       end
     end
@@ -354,6 +355,13 @@ module Ibandit
       true
     end
 
+    def valid_nz_details?
+      return true unless country_code == "NZ"
+      return true unless Ibandit.modulus_checker
+
+      valid_modulus_check_branch_code?
+    end
+
     def valid_australian_details?
       return true unless country_code == "AU"
 

data/lib/ibandit/version.rb

@@ -1,3 +1,3 @@
 module Ibandit
-  VERSION = "0.11.14".freeze
+  VERSION = "0.11.15".freeze
 end

data/spec/ibandit/iban_spec.rb

@@ -1952,6 +1952,108 @@ describe Ibandit::IBAN do
     end
   end
 
+  describe "valid_nz_details" do
+    subject { iban.valid_nz_details? }
+
+    context "with non-NewZealand details" do
+      let(:arg) do
+        {
+          country_code: "GB",
+          bank_code: "1234",
+          branch_code: "200000",
+          account_number: "55779911",
+        }
+      end
+
+      it { is_expected.to be(true) }
+    end
+
+    context "with NewZealand details" do
+      let(:arg) do
+        {
+          country_code: "NZ",
+          bank_code: "01",
+          branch_code: "0004",
+          account_number: "123456789",
+        }
+      end
+
+      context "without a modulus checker defined" do
+        it { is_expected.to be(true) }
+      end
+
+      context "with a modulus checker defined" do
+        before do
+          Ibandit.modulus_checker = double(
+            valid_branch_code?: valid_branch_code,
+          )
+          iban.valid_nz_details?
+        end
+        after { Ibandit.modulus_checker = nil }
+
+        let(:valid_branch_code) { true }
+
+        it "calls valid_branch_code? with an IBAN object" do
+          expect(Ibandit.modulus_checker).
+            to receive(:valid_branch_code?).
+            with(instance_of(Ibandit::IBAN))
+
+          iban.valid_nz_details?
+        end
+
+        it { is_expected.to be(true) }
+
+        context "with an invalid branch code" do
+          let(:valid_branch_code) { false }
+
+          it { is_expected.to be(false) }
+
+          context "locale en", locale: :en do
+            specify do
+              expect(iban.errors).to include(branch_code: "is invalid")
+            end
+          end
+
+          context "locale fr", locale: :fr do
+            specify do
+              expect(iban.errors).to include(branch_code: "est invalide")
+            end
+          end
+
+          context "locale de", locale: :de do
+            specify do
+              expect(iban.errors).to include(branch_code: "ist nicht gültig")
+            end
+          end
+
+          context "locale pt", locale: :pt do
+            specify do
+              expect(iban.errors).to include(branch_code: "é inválido")
+            end
+          end
+
+          context "locale es", locale: :es do
+            specify do
+              expect(iban.errors).to include(branch_code: "es inválido")
+            end
+          end
+
+          context "locale it", locale: :it do
+            specify do
+              expect(iban.errors).to include(branch_code: "non è valido")
+            end
+          end
+
+          context "locale nl", locale: :nl do
+            specify do
+              expect(iban.errors).to include(branch_code: "is ongeldig")
+            end
+          end
+        end
+      end
+    end
+  end
+
   describe "#valid?" do
     describe "validations called" do
       after { iban.valid? }

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ibandit
 version: !ruby/object:Gem::Version
-  version: 0.11.14
+  version: 0.11.15
 platform: ruby
 authors:
 - GoCardless
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-07-27 00:00:00.000000000 Z
+date: 2018-08-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri