ibandit 0.11.12 → 0.11.13

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: '08d2b3f6258a3edcbfb5b2e7edcd1c44909d2476'
-  data.tar.gz: 57e642a2dff2d94ffa93fa93b6ed30ca7862c797
+  metadata.gz: 4949f38e6085a415b67480155a88e459266b0af0
+  data.tar.gz: 00fe2984c26437234b467fa3afb49b9c07aa7559
 SHA512:
-  metadata.gz: 3b54fe472f576c2ddf662794fd279df02779750493fe27608bdc07d45d9085e449e6c3cf889a7f113803a1b18972e2ecaac872e03b2b6b0e6e243e2c9103d569
-  data.tar.gz: bd9ccc9de7cd8dfb2f6bb676945046d78ed7168de51c4ad0b353b59cc4722c8018bdfd9137ab634251f09493a1c9937308175e87e273c07db028f88de7bf0f0e
+  metadata.gz: 7f8ea0e2d0d7bb0b20bd56a43ea1cd5f7dafe4d5f3279723d2aa41835ec2be2a96c31c6b22a778c21b194aa334749d1c2a6d75142b14bdc983d0e35fc479dd46
+  data.tar.gz: 1166de4ea4b36c0e7f93811cb492ea417edb480684cc5c27eb90359ed27f3e81fab6526cec1f69c756ca17f166faa3fc40d04160947e99488e41b3555ef02f6d

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 0.11.13 - May 30, 2018
+
+- Allow 5-digits Australian account numbers
+
 ## 0.11.12 - March 21, 2018
 
 - Validate Australian BSBs

data/lib/ibandit/local_details_cleaner.rb

@@ -65,8 +65,8 @@ module Ibandit
       # Account number may be up to 10 digits long.
       # Add leading zeros to account number if < 10 digits.
       #
-      # Minimum account_number length is 6
-      return {} unless local_details[:account_number].length >= 6
+      # Minimum account_number length is 5
+      return {} unless local_details[:account_number].length >= 5
 
       {
         branch_code:    local_details[:branch_code].delete("-"),

data/lib/ibandit/version.rb

@@ -1,3 +1,3 @@
 module Ibandit
-  VERSION = "0.11.12".freeze
+  VERSION = "0.11.13".freeze
 end

data/spec/ibandit/iban_spec.rb

@@ -185,6 +185,23 @@ describe Ibandit::IBAN do
         its(:to_s) { is_expected.to eq("") }
       end
 
+      context "and a 5 digit account number" do
+        let(:account_number) { "12345" }
+
+        its(:country_code) { is_expected.to eq("AU") }
+        its(:bank_code) { is_expected.to be_nil }
+        its(:branch_code) { is_expected.to eq("123456") }
+        its(:account_number) { is_expected.to eq("0000012345") }
+        its(:swift_bank_code) { is_expected.to be_nil }
+        its(:swift_branch_code) { is_expected.to eq("123456") }
+        its(:swift_account_number) { is_expected.to eq("0000012345") }
+        its(:swift_national_id) { is_expected.to eq("123456") }
+        its(:iban) { is_expected.to be_nil }
+        its(:pseudo_iban) { is_expected.to eq("AUZZ1234560000012345") }
+        its(:valid?) { is_expected.to eq(true) }
+        its(:to_s) { is_expected.to eq("") }
+      end
+
       context "and a 6 digit account number" do
         let(:account_number) { "123456" }
 
@@ -300,6 +317,25 @@ describe Ibandit::IBAN do
       end
     end
 
+    context "when the input is an account number too short for Australia" do
+      let(:arg) do
+        {
+          country_code: "AU",
+          branch_code: "123456",
+          account_number: "1234",
+        }
+      end
+
+      its(:iban) { is_expected.to be_nil }
+      its(:pseudo_iban) { is_expected.to eq("AUZZ123456______1234") }
+      it "is invalid and has the correct errors" do
+        expect(subject.valid?).to eq(false)
+        expect(subject.errors).to eq(
+          account_number: "is the wrong length (should be 10 characters)",
+        )
+      end
+    end
+
     context "when the input is invalid local details for Australia" do
       let(:arg) do
         {

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ibandit
 version: !ruby/object:Gem::Version
-  version: 0.11.12
+  version: 0.11.13
 platform: ruby
 authors:
 - GoCardless
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-03-21 00:00:00.000000000 Z
+date: 2018-05-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri