ibandit 0.11.11 → 0.11.12

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 7cf488eed67769ff39b6249be1b7689359f9eb4a
-  data.tar.gz: 0f32aaf43214999c417badf26c730a334bdd3610
+  metadata.gz: '08d2b3f6258a3edcbfb5b2e7edcd1c44909d2476'
+  data.tar.gz: 57e642a2dff2d94ffa93fa93b6ed30ca7862c797
 SHA512:
-  metadata.gz: 20202b4dd9710f4912bbef1b0c7f108c1c65aa6c1fc6c279e9b4538df4e204e1aade6dd4c2ce5b28fe8351c46d24363c75125e2c1f7c75e57ce3dce2d6a54bac
-  data.tar.gz: f918279bb0f3943d334ae6f1fbc67f38357d3902a0e09af53f8187c7879232137a54b45ae0660f82472c30411a40519a6087f00414dee02e4ca6678c8d6e4ed7
+  metadata.gz: 3b54fe472f576c2ddf662794fd279df02779750493fe27608bdc07d45d9085e449e6c3cf889a7f113803a1b18972e2ecaac872e03b2b6b0e6e243e2c9103d569
+  data.tar.gz: bd9ccc9de7cd8dfb2f6bb676945046d78ed7168de51c4ad0b353b59cc4722c8018bdfd9137ab634251f09493a1c9937308175e87e273c07db028f88de7bf0f0e

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 0.11.12 - March 21, 2018
+
+- Validate Australian BSBs
+
 ## 0.11.11 - March 1, 2018
 
 - Fix padding for Australian pseudo-IBANs

data/lib/ibandit/iban.rb

@@ -269,6 +269,7 @@ module Ibandit
       case country_code
       when "DE" then supports_iban_determination?
       when "SE" then valid_swedish_details?
+      when "AU" then valid_australian_details?
       else true
       end
     end
@@ -341,6 +342,19 @@ module Ibandit
       true
     end
 
+    def valid_australian_details?
+      return true unless country_code == "AU"
+
+      bsb_check?
+    end
+
+    def bsb_check?
+      return true unless country_code == "AU"
+      return true unless Ibandit.modulus_checker
+
+      valid_modulus_check_branch_code?
+    end
+
     ###################
     # Private methods #
     ###################

data/lib/ibandit/version.rb

@@ -1,3 +1,3 @@
 module Ibandit
-  VERSION = "0.11.11".freeze
+  VERSION = "0.11.12".freeze
 end

data/spec/ibandit/iban_spec.rb

@@ -1698,6 +1698,107 @@ describe Ibandit::IBAN do
     end
   end
 
+  describe "valid_australian_details" do
+    subject { iban.valid_australian_details? }
+
+    context "with non-Australian details" do
+      let(:arg) do
+        {
+          country_code: "GB",
+          bank_code: "1234",
+          branch_code: "200000",
+          account_number: "55779911",
+        }
+      end
+
+      it { is_expected.to be(true) }
+    end
+
+    context "with Australian details" do
+      let(:arg) do
+        {
+          country_code: "AU",
+          branch_code: "123-456",
+          account_number: "123456789",
+        }
+      end
+
+      context "without a modulus checker defined" do
+        it { is_expected.to be(true) }
+      end
+
+      context "with a modulus checker defined" do
+        before do
+          Ibandit.modulus_checker = double(
+            valid_branch_code?: valid_branch_code,
+          )
+          iban.valid_australian_details?
+        end
+        after { Ibandit.modulus_checker = nil }
+
+        let(:valid_branch_code) { true }
+
+        it "calls valid_branch_code? with an IBAN object" do
+          expect(Ibandit.modulus_checker).
+            to receive(:valid_branch_code?).
+            with(instance_of(Ibandit::IBAN))
+
+          iban.valid_australian_details?
+        end
+
+        it { is_expected.to be(true) }
+
+        context "with an invalid bsb" do
+          let(:valid_branch_code) { false }
+
+          it { is_expected.to be(false) }
+
+          context "locale en", locale: :en do
+            specify do
+              expect(iban.errors).to include(branch_code: "is invalid")
+            end
+          end
+
+          context "locale fr", locale: :fr do
+            specify do
+              expect(iban.errors).to include(branch_code: "est invalide")
+            end
+          end
+
+          context "locale de", locale: :de do
+            specify do
+              expect(iban.errors).to include(branch_code: "ist nicht gültig")
+            end
+          end
+
+          context "locale pt", locale: :pt do
+            specify do
+              expect(iban.errors).to include(branch_code: "é inválido")
+            end
+          end
+
+          context "locale es", locale: :es do
+            specify do
+              expect(iban.errors).to include(branch_code: "es inválido")
+            end
+          end
+
+          context "locale it", locale: :it do
+            specify do
+              expect(iban.errors).to include(branch_code: "non è valido")
+            end
+          end
+
+          context "locale nl", locale: :nl do
+            specify do
+              expect(iban.errors).to include(branch_code: "is ongeldig")
+            end
+          end
+        end
+      end
+    end
+  end
+
   describe "#valid?" do
     describe "validations called" do
       after { iban.valid? }

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ibandit
 version: !ruby/object:Gem::Version
-  version: 0.11.11
+  version: 0.11.12
 platform: ruby
 authors:
 - GoCardless
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-03-01 00:00:00.000000000 Z
+date: 2018-03-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri
@@ -206,7 +206,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.13
+rubygems_version: 2.6.14
 signing_key: 
 specification_version: 4
 summary: Convert national banking details into IBANs, and vice-versa.