ibandit 0.9.1 → 0.10.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e021aa97b6141c2715995c7589009188c4808050
-  data.tar.gz: 45a31d572ba532971fea7de81f5609c11a5daa8c
+  metadata.gz: d98d0e6148aa8b276eb107e70a0fa9967b0720dd
+  data.tar.gz: 8102f44a3a4dfabb24658cc5ff9e5a9efea2ec45
 SHA512:
-  metadata.gz: a04adebd2ec4e94b40d3715b2803044a7f5f524a03eacb3dbf02d86e20606fe53b10cb38649244c1cfe8b3a35ce6863244a244c76184d9bc60b738440f27c3ad
-  data.tar.gz: 350d3330f5dede452d822377b3e94c3173879f7b747c7eca06f6d6d7c9fd46a3a8598da306dac32188b00e89d37592f0e99f1e135ac039f448b8e2db4bd5b530
+  metadata.gz: b0f2f4de753002a818d09e09004708747bd80584bb4c1211d236b1ebc31d31425bc44c5d04c8fd1b8b20d5af7e1e601208129b15a34468deb2e98960b57dbea7
+  data.tar.gz: 6d663575b3d182fb4ab5ba9c2b9e78be8814445df4c3820d2fc5765a8de3bc2474b56599e9fcd6a24326c591504dca3da01be68c53c78a6e9411a060faee0848

data/CHANGELOG.md

@@ -1,3 +1,9 @@
+## 0.10.0 -  February 25, 2016
+
+- BREAKING CHANGE: Pass an `Ibandit::IBAN` object to modulus checker hooks,
+  rather than a string. See https://github.com/gocardless/ibandit/pull/68 for
+  more details.
+
 ## 0.9.1 -  January 26, 2016
 
 - Update BLZ data

data/lib/ibandit/iban.rb

@@ -385,21 +385,21 @@ module Ibandit
     end
 
     def valid_modulus_check_bank_code?
-      return true if Ibandit.modulus_checker.valid_bank_code?(iban.to_s)
+      return true if Ibandit.modulus_checker.valid_bank_code?(self)
 
       @errors[:bank_code] = Ibandit.translate(:is_invalid)
       false
     end
 
     def valid_modulus_check_branch_code?
-      return true if Ibandit.modulus_checker.valid_branch_code?(iban.to_s)
+      return true if Ibandit.modulus_checker.valid_branch_code?(self)
 
       @errors[:branch_code] = Ibandit.translate(:is_invalid)
       false
     end
 
     def valid_modulus_check_account_number?
-      return true if Ibandit.modulus_checker.valid_account_number?(iban.to_s)
+      return true if Ibandit.modulus_checker.valid_account_number?(self)
 
       @errors[:account_number] = Ibandit.translate(:is_invalid)
       false

data/lib/ibandit/version.rb

@@ -1,3 +1,3 @@
 module Ibandit
-  VERSION = '0.9.1'.freeze
+  VERSION = '0.10.0'.freeze
 end

data/spec/ibandit/iban_spec.rb

@@ -1149,7 +1149,16 @@ describe Ibandit::IBAN do
         let(:valid_branch_code) { true }
         let(:valid_account_number) { true }
 
+        it 'calls valid_bank_code? with an IBAN object' do
+          expect(Ibandit.modulus_checker).
+            to receive(:valid_bank_code?).
+            with(instance_of(Ibandit::IBAN))
+
+          iban.valid_local_modulus_check?
+        end
+
         it { is_expected.to be(false) }
+
         context 'locale en', locale: :en do
           specify { expect(iban.errors).to include(bank_code: 'is invalid') }
         end
@@ -1190,7 +1199,16 @@ describe Ibandit::IBAN do
         let(:valid_branch_code) { false }
         let(:valid_account_number) { true }
 
+        it 'calls valid_branch_code? with an IBAN object' do
+          expect(Ibandit.modulus_checker).
+            to receive(:valid_branch_code?).
+            with(instance_of(Ibandit::IBAN))
+
+          iban.valid_local_modulus_check?
+        end
+
         it { is_expected.to be(false) }
+
         context 'locale en', locale: :en do
           specify do
             expect(iban.errors).to include(branch_code: 'is invalid')
@@ -1239,7 +1257,16 @@ describe Ibandit::IBAN do
         let(:valid_branch_code) { true }
         let(:valid_account_number) { false }
 
+        it 'calls valid_account_number? with an IBAN object' do
+          expect(Ibandit.modulus_checker).
+            to receive(:valid_account_number?).
+            with(instance_of(Ibandit::IBAN))
+
+          iban.valid_local_modulus_check?
+        end
+
         it { is_expected.to be(false) }
+
         context 'locale en', locale: :en do
           specify do
             expect(iban.errors).to include(account_number: 'is invalid')

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ibandit
 version: !ruby/object:Gem::Version
-  version: 0.9.1
+  version: 0.10.0
 platform: ruby
 authors:
 - Grey Baker
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-01-26 00:00:00.000000000 Z
+date: 2016-02-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec