ibandit 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 36930d16f5443cccf34293a0cb6014b8dc33c337
-  data.tar.gz: e8201ef2d1053ed3293ac3d620e0cd494e1f66a6
+  metadata.gz: eb2005426e8eca7ec2cf398a060fe361bb699d82
+  data.tar.gz: 9340e8905dbf91ea90e83fb09c2fa14e53ccf35f
 SHA512:
-  metadata.gz: 98a90bb5ed4f7b50bf82abed4709bf919d7fad46f7695dc40e317d16c102aef3b097ef928806b0d3393a07e4d2701981727cf2c77b90427b41f485e449d5f437
-  data.tar.gz: 7c02243b084a98aac05bd911bf527667b47cf98a362795fb6f7214018f563ce8ad3726f623201a34c3e6cd883b697c8531a3c08632b7f505446b908066a55a18
+  metadata.gz: 5a4bde497c40a9ca0aad45e89edbaae721fb72e60dcd023fbf1782c4a94308dbe0bb592d2fd846dc88568b2ce65f64f701050e25397efffa990b6386bdd7527c
+  data.tar.gz: 6a0ff40c72b3db4ba8a6606994cd172792786d91bd17aca2adf708722e01ff51ce0c66151ac0739a68c8cb17e4bad9898efb9148610a4f68eb685168b830b782

data/.travis.yml

@@ -0,0 +1,17 @@
+language: ruby
+
+matrix:
+  allow_failures:
+    - rvm: jruby
+    - rvm: rbx-2
+
+rvm:
+  - 2.0
+  - 2.1
+  - 2.2
+  - jruby
+  - rbx-2
+
+script:
+  - bundle exec rubocop
+  - bundle exec rspec spec

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 0.1.1 - January 8, 2014
+
+- Add zero-padding to CheckDigit.spanish
+
 ## 0.1.0 - December 29, 2014
 
 - Initial public release

data/README.md

@@ -1,4 +1,5 @@
-# Ibandit
+Ibandit [![Build Status](https://travis-ci.org/gocardless/ibandit.svg?branch=master)](https://travis-ci.org/gocardless/ibandit)
+=======
 
 Ibandit is a Ruby library for manipulating and validating
 [IBANs](http://en.wikipedia.org/wiki/International_Bank_Account_Number). It
@@ -301,3 +302,11 @@ iban.iban                     # => "SM88X0542811101000000123456"
 ```
 
 Support for Greece and Malta is coming soon.
+
+## Other libraries
+
+Another gem, [iban-tools](https://github.com/alphasights/iban-tools), also
+exists and is an excellent choice if you only require basic IBAN validation.
+We built Ibandit because iban-tools doesn't provide a comprehensive, consistent
+interface for the construction and deconstruction of IBANs into national
+details.

data/bin/build_structure_file.rb

@@ -54,9 +54,9 @@ end
 
 def convert_swift_convention(swift_string)
   swift_string.gsub(/(\d+)!([nac])/, '\2{\1}').
-    gsub('n', '\d').
-    gsub('a', '[A-Z]').
-    gsub('c', '[A-Z0-9]')
+    tr('n', '\d').
+    tr('a', '[A-Z]').
+    tr('c', '[A-Z0-9]')
 end
 
 def merge_structures(structures, additions)

data/lib/ibandit/check_digit.rb

@@ -20,7 +20,8 @@ module Ibandit
     # digits are used in the 1st and 2nd digits of local Spanish
     # account numbers.
     def self.spanish(string)
-      scaled_values = string.chars.map.with_index do |digit, index|
+      padded_string = string.rjust(10, '0')
+      scaled_values = padded_string.chars.map.with_index do |digit, index|
         unless digit.to_i.to_s == digit
           raise InvalidCharacterError,
                 "Unexpected non-numeric character '#{digit}'"

data/lib/ibandit/iban_builder.rb

@@ -65,7 +65,7 @@ module Ibandit
       #   numbers and the IBAN structure file includes them in its definition of
       #   the account number. As a result, this method ignores all arguments
       #   other than the account number.
-      opts[:account_number].gsub('-', '')
+      opts[:account_number].tr('-', '')
     end
 
     def self.build_cy_bban(opts)
@@ -192,7 +192,7 @@ module Ibandit
           opts[:account_number]
         ].join
       else
-        opts[:account_number].gsub('-', '')
+        opts[:account_number].tr('-', '')
       end
     end
 
@@ -477,7 +477,7 @@ module Ibandit
       else
         [
           opts[:bank_code],
-          opts[:account_number].gsub('-', '').rjust(16, '0')
+          opts[:account_number].tr('-', '').rjust(16, '0')
         ].join
       end
     end

data/lib/ibandit/version.rb

@@ -1,3 +1,3 @@
 module Ibandit
-  VERSION = '0.1.0'.freeze
+  VERSION = '0.1.1'.freeze
 end

data/spec/ibandit/check_digit_spec.rb

@@ -29,6 +29,14 @@ describe Ibandit::CheckDigit do
         expect { subject }.to raise_error(Ibandit::InvalidCharacterError)
       end
     end
+
+    context 'with a string that is fewer than 10 characters' do
+      let(:account_number) { '20386010' }
+
+      it 'zero-pads the string to get the correct check digit' do
+        expect(subject).to eq('5')
+      end
+    end
   end
 
   describe '.lund' do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ibandit
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Grey Baker
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-12-29 00:00:00.000000000 Z
+date: 2015-01-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
@@ -92,13 +92,13 @@ files:
 - .gitignore
 - .rubocop.yml
 - .rubocop_todo.yml
+- .travis.yml
 - CHANGELOG.md
 - Gemfile
 - LICENSE
 - README.md
 - TODO.md
 - bin/build_structure_file.rb
-- circle.yml
 - data/IBANSTRUCTURE.xml
 - data/IBAN_Registry.txt
 - data/structure_additions.yml

data/circle.yml

@@ -1,19 +0,0 @@
-machine:
-  ruby:
-    version: 2.0.0-p353
-
-test:
-  pre:
-    - bundle exec rubocop:
-        parallel: true
-        files:
-          - config.ru
-          - Rakefile
-          - app/**/*.rb
-          - lib/**/*.rb
-          - spec/**/*.rb
-  override:
-    - bundle exec rspec:
-        parallel: true
-        files:
-          - spec/**/*_spec.rb