ianfleeton-paypal-express 0.8.3 → 0.8.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: ef80a541893e55346f5ad9b9f4f816e583506abd
-  data.tar.gz: c94857a7a632ab4d6f2386a52d4630b694f9c844
+SHA256:
+  metadata.gz: 860b0d8f5a56c23d0d48d2306949be8ab7687e93cb8c54d57c875f5d44ebb349
+  data.tar.gz: d36695184583cef8c027cfab2b150fcb9b348a5a2d8de0823b6b6b017bc59d45
 SHA512:
-  metadata.gz: 4a1123c6e08907f95c31780317541e11c744cc04787850c743a213f2557b17f612bca873c3f2970e4c9b8a882f27a9f2c8ddb1cf67d3efaad98016acb8d9aea4
-  data.tar.gz: 372e09ac614ddfd5b74e57cdddfd275d4a7d7a44c34ad6ec992a63c5dde1eb107470795b0eb9a237a07743f3e8a1e03887d6ff86dd31c061b3ede7cfc895c6c9
+  metadata.gz: c703ea1e91682f791c9adac0babfa33282a721380ebd082d65c3a0967c4c3cd3f14b5d12ea90ba2d12c7d5f5a59f6c9e189adf4ef2b6915945bd669694c7abe8
+  data.tar.gz: 3e9de3ff947c7d5fd75bfb7c21e4aa16c70d857ec64f7a6eb8172fd05b98fd209c514b5f4ca74a1c6f105344ba507201b0a02f342a0c81a357972f74b386cc31

data/.travis.yml

@@ -2,9 +2,10 @@ before_install:
   - gem install bundler
 
 rvm:
-  - 2.2.7
-  - 2.3.4
-  - 2.4.1
+  - 2.2.9
+  - 2.3.6
+  - 2.4.3
+  - 2.5.0
 
 env:
   - RAILS_VERSION="~> 4.2"

data/VERSION

@@ -1 +1 @@
-0.8.3
+0.8.4

data/lib/paypal/nvp/request.rb

@@ -50,7 +50,7 @@ module Paypal
       def handle_response
         response = yield
         response = CGI.parse(response).inject({}) do |res, (k, v)|
-          res.merge!(k.to_sym => v.first)
+          res.merge!(k.to_sym => v.first.to_s)
         end
         case response[:ACK]
         when 'Success', 'SuccessWithWarning'

data/lib/paypal/util.rb

@@ -1,15 +1,23 @@
+require "bigdecimal"
+
 module Paypal
   module Util
 
     def self.formatted_amount(x)
-      sprintf "%0.2f", BigDecimal.new((x || 0).to_s).truncate(2)
+      x = '0' if x == '' || x.nil?
+      sprintf '%0.2f', BigDecimal.new(x.to_s).round(2)
     end
 
     def self.to_numeric(x)
-      if x.to_f == x.to_i
+      string = x.to_s
+      string = "0" if string == ""  # Ruby 2.5 compatibility.
+
+      decimal = BigDecimal(string)
+
+      if decimal == x.to_i
         x.to_i
       else
-        x.to_f
+        decimal
       end
     end
 

data/spec/paypal/express/request_spec.rb

@@ -8,7 +8,8 @@ describe Paypal::Express::Request do
       self._sent_params_ = params
       post_without_logging method, params
     end
-    alias_method_chain :post, :logging
+    alias_method :post_without_logging, :post
+    alias_method :post, :post_with_logging
   end
 
   let(:return_url) { 'http://example.com/success' }
@@ -39,7 +40,7 @@ describe Paypal::Express::Request do
       items << Paypal::Payment::Request::Item.new(
         :name => "Item#{index.to_s}",
         :description => "A new Item #{index.to_s}",
-        :amount => 50.00,
+        amount: BigDecimal('50.00'),
         :quantity => 1
       )
     end
@@ -266,20 +267,20 @@ describe Paypal::Express::Request do
   describe "#capture!" do
     it 'should return Paypal::Express::Response' do
       fake_response 'DoCapture/success'
-      response = instance.capture! 'authorization_id', 181.98, :BRL
+      response = instance.capture! 'authorization_id', BigDecimal('181.98'), :BRL
       expect(response).to be_instance_of Paypal::Express::Response
     end
 
     it 'should call DoExpressCheckoutPayment' do
       expect do
-        instance.capture! 'authorization_id', 181.98, :BRL
+        instance.capture! 'authorization_id', BigDecimal('181.98'), :BRL
       end.to request_to nvp_endpoint, :post
 
       expect(instance._method_).to eq(:DoCapture)
       expect(instance._sent_params_).to eq({
         :AUTHORIZATIONID => 'authorization_id',
         :COMPLETETYPE => 'Complete',
-        :AMT => 181.98,
+        AMT: BigDecimal('181.98'),
         :CURRENCYCODE => :BRL
       })
     end

data/spec/paypal/payment/common/amount_spec.rb

@@ -29,7 +29,9 @@ describe Paypal::Payment::Common::Amount do
       end
       amount = Paypal::Payment::Common::Amount.new attributes
       keys.each do |key|
-        expect(amount.send(key)).to eq(10.25)
+        actual = amount.send(key)
+        expect(actual).to be_a(BigDecimal)
+        expect(actual).to eq BigDecimal('10.25')
       end
     end
   end

data/spec/paypal/payment/request_spec.rb

@@ -3,9 +3,9 @@ require 'spec_helper.rb'
 describe Paypal::Payment::Request do
   let :instant_request do
     Paypal::Payment::Request.new(
-      :amount => 25.7,
-      :tax_amount => 0.4,
-      :shipping_amount => 1.5,
+      amount: BigDecimal('25.7'),
+      tax_amount: BigDecimal('0.4'),
+      shipping_amount: BigDecimal('1.5'),
       :currency_code => :JPY,
       :description => 'Instant Payment Request',
       :notify_url => 'http://merchant.example.com/notify',
@@ -15,12 +15,12 @@ describe Paypal::Payment::Request do
         :quantity => 2,
         :name => 'Item1',
         :description => 'Awesome Item 1!',
-        :amount => 10.25
+        :amount => BigDecimal("10.25")
       }, {
         :quantity => 3,
         :name => 'Item2',
         :description => 'Awesome Item 2!',
-        :amount => 1.1
+        amount: BigDecimal('1.1')
       }],
       :custom_fields => {
         "l_surveychoice{n}" => 'abcd' # The '{n}' will be replaced with the index
@@ -46,9 +46,9 @@ describe Paypal::Payment::Request do
 
   describe '.new' do
     it 'should handle Instant Payment parameters' do
-      expect(instant_request.amount.total).to eq(25.7)
-      expect(instant_request.amount.tax).to eq(0.4)
-      expect(instant_request.amount.shipping).to eq(1.5)
+      expect(instant_request.amount.total).to eq(BigDecimal('25.7'))
+      expect(instant_request.amount.tax).to eq(BigDecimal('0.4'))
+      expect(instant_request.amount.shipping).to eq(BigDecimal('1.5'))
       expect(instant_request.currency_code).to eq(:JPY)
       expect(instant_request.description).to eq('Instant Payment Request')
       expect(instant_request.notify_url).to eq('http://merchant.example.com/notify')
@@ -115,22 +115,21 @@ describe Paypal::Payment::Request do
   end
 
   describe '#items_amount' do
-    context 'when BigDecimal'
     let(:instance) do
       Paypal::Payment::Request.new(
         :items => [{
           :quantity => 3,
           :name => 'Item1',
           :description => 'Awesome Item 1!',
-          :amount => 130.45
+          :amount => BigDecimal("130.45")
         }]
       )
     end
 
-    # NOTE:
+    # NOTE: with floats,
     # 130.45 * 3 => 391.34999999999997 (in ruby 1.9)
     it 'should calculate total amount correctly' do
-      expect(instance.items_amount).to eq(391.35)
+      expect(instance.items_amount).to eq(BigDecimal('391.35'))
     end
   end
 end

data/spec/paypal/payment/response/info_spec.rb

@@ -40,7 +40,7 @@ describe Paypal::Payment::Response::Info do
         end
         expect(from_symbol_uppercase.amount).to eq(Paypal::Payment::Common::Amount.new(
           :total => 14,
-          :fee => 0.85
+          fee: BigDecimal('0.85')
         ))
       end
     end

data/spec/paypal/util_spec.rb

@@ -5,28 +5,28 @@ describe Paypal::Util do
     it 'should return String in "xx.yy" format' do
       expect(Paypal::Util.formatted_amount(nil)).to eq('0.00')
       expect(Paypal::Util.formatted_amount(10)).to eq('10.00')
-      expect(Paypal::Util.formatted_amount(10.02)).to eq('10.02')
-      expect(Paypal::Util.formatted_amount(10.2)).to eq('10.20')
-      expect(Paypal::Util.formatted_amount(10.24)).to eq('10.24')
-      expect(Paypal::Util.formatted_amount(10.255)).to eq('10.25')
+      expect(Paypal::Util.formatted_amount(BigDecimal('10.02'))).to eq('10.02')
+      expect(Paypal::Util.formatted_amount(BigDecimal('10.2'))).to eq('10.20')
+      expect(Paypal::Util.formatted_amount(BigDecimal('10.24'))).to eq('10.24')
+      expect(Paypal::Util.formatted_amount(BigDecimal('10.255'))).to eq('10.26')
     end
   end
 
   describe '.to_numeric' do
-    it 'should return Numeric' do
+    it 'should return Integer or BigDecimal' do
       expect(Paypal::Util.to_numeric('10')).to be_kind_of(Integer)
-      expect(Paypal::Util.to_numeric('10.5')).to be_kind_of(Float)
-      expect(Paypal::Util.to_numeric('-1.5')).to eq(-1.5)
+      expect(Paypal::Util.to_numeric('10.5')).to be_kind_of(BigDecimal)
+      expect(Paypal::Util.to_numeric('-1.5')).to eq(BigDecimal('-1.5'))
       expect(Paypal::Util.to_numeric('-1')).to eq(-1)
       expect(Paypal::Util.to_numeric('0')).to eq(0)
       expect(Paypal::Util.to_numeric('0.00')).to eq(0)
       expect(Paypal::Util.to_numeric('10')).to eq(10)
       expect(Paypal::Util.to_numeric('10.00')).to eq(10)
-      expect(Paypal::Util.to_numeric('10.02')).to eq(10.02)
-      expect(Paypal::Util.to_numeric('10.2')).to eq(10.2)
-      expect(Paypal::Util.to_numeric('10.20')).to eq(10.2)
-      expect(Paypal::Util.to_numeric('10.24')).to eq(10.24)
-      expect(Paypal::Util.to_numeric('10.25')).to eq(10.25)
+      expect(Paypal::Util.to_numeric('10.02')).to eq(BigDecimal('10.02'))
+      expect(Paypal::Util.to_numeric('10.2')).to eq(BigDecimal('10.2'))
+      expect(Paypal::Util.to_numeric('10.20')).to eq(BigDecimal('10.2'))
+      expect(Paypal::Util.to_numeric('10.24')).to eq(BigDecimal('10.24'))
+      expect(Paypal::Util.to_numeric('10.25')).to eq(BigDecimal('10.25'))
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ianfleeton-paypal-express
 version: !ruby/object:Gem::Version
-  version: 0.8.3
+  version: 0.8.4
 platform: ruby
 authors:
 - Ian Fleeton
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-04-24 00:00:00.000000000 Z
+date: 2018-04-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -254,7 +254,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: 1.3.6
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.11
+rubygems_version: 2.7.6
 signing_key: 
 specification_version: 4
 summary: PayPal Express Checkout API Client for Instance, Recurring and Digital Goods