ianfleeton-paypal-express 0.8.2 → 0.8.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 3b3867967578bb74d22b8fc5d931c62a01fa890c
-  data.tar.gz: 97b4500f7158307eb8fb5183367cd3046bb968cf
+  metadata.gz: ef80a541893e55346f5ad9b9f4f816e583506abd
+  data.tar.gz: c94857a7a632ab4d6f2386a52d4630b694f9c844
 SHA512:
-  metadata.gz: 1959ef947bd20eb3fb27d9a439dc657e51871be138e8f1f293307170fbf63781b11483de776cf4709b7dc39d5ba9adbf13237a3b12d0d801bac6a46ad8e415e1
-  data.tar.gz: 3f8fa18f46458fcb4f1390c3d8a2fbe91cafebdb3c16dce2908e0726f89f9f43ea96721f9924f7b921574e7a5d563529d18db6b14f986a1acc007236bbb90c75
+  metadata.gz: 4a1123c6e08907f95c31780317541e11c744cc04787850c743a213f2557b17f612bca873c3f2970e4c9b8a882f27a9f2c8ddb1cf67d3efaad98016acb8d9aea4
+  data.tar.gz: 372e09ac614ddfd5b74e57cdddfd275d4a7d7a44c34ad6ec992a63c5dde1eb107470795b0eb9a237a07743f3e8a1e03887d6ff86dd31c061b3ede7cfc895c6c9

data/README.rdoc

@@ -15,17 +15,17 @@ You can use this fork which is actively maintained to ensure it is working prope
 == Installation
 
 Add to your Gemfile
-  gem 'paypal-express', github: 'ianfleeton/paypal-express'
+  gem 'ianfleeton-paypal-express', github: 'ianfleeton/paypal-express', require: 'paypal/express'
 Or
-  gem 'ianfleeton-paypal-express'
+  gem 'ianfleeton-paypal-express', require: 'paypal/express'
 
 == Usage
 
 See Wiki on Github
-https://github.com/nov/paypal-express/wiki
+https://github.com/ianfleeton/paypal-express/wiki
 
 Play with Sample Rails App
-https://github.com/nov/paypal-express-sample
+https://github.com/ianfleeton/paypal-express-sample
 https://paypal-express-sample.heroku.com
 
 == Note on Patches/Pull Requests

data/VERSION

@@ -1 +1 @@
-0.8.2
+0.8.3

data/ianfleeton-paypal-express.gemspec

@@ -16,7 +16,7 @@ Gem::Specification.new do |s|
   s.test_files = `git ls-files -- {test,spec,features}/*`.split("\n")
   s.add_dependency 'activesupport', '>= 2.3', '< 6'
   s.add_dependency 'rest-client', '~> 2.0'
-  s.add_dependency 'attr_required', '~> 0.0', '>= 0.0.5'
+  s.add_dependency 'attr_required', '~> 1.0'
   s.add_development_dependency 'rake', '~> 12.0', '>= 12.0.0'
   s.add_development_dependency 'simplecov', '~> 0'
   s.add_development_dependency 'rspec', '~> 3.5', '>= 3.5.0'

data/lib/paypal/exception/api_error.rb

@@ -32,7 +32,8 @@ module Paypal
           :PAYMENTSTATUS => :payment_status,
           :PAYMENTTYPE => :payment_type,
           :REASONCODE => :reason_code,
-          :TRANSACTIONTYPE => :transaction_type
+          :TRANSACTIONTYPE => :transaction_type,
+          REFUNDSTATUS: :refund_status
         }
         attr_accessor *@@attribute_mapping.values
         attr_accessor :raw, :details

data/spec/fake_response/RefundTransaction/failure.txt

@@ -0,0 +1 @@
+TIMESTAMP=2017%2d03%2d01T16%3a17%3a13Z&CORRELATIONID=ec17e6541628a&ACK=Failure&VERSION=204%2e0&BUILD=30763207&L_ERRORCODE0=10009&L_SHORTMESSAGE0=Transaction%20refused&L_LONGMESSAGE0=This%20transaction%20has%20already%20been%20fully%20refunded&L_SEVERITYCODE0=Error&REFUNDSTATUS=None&PENDINGREASON=None

data/spec/paypal/exception/api_error_spec.rb

@@ -88,6 +88,14 @@ describe Paypal::Exception::APIError do
     end
   end
 
+  context 'when refund failure params given' do
+    let(:params) { { REFUNDSTATUS: 'None' } }
+    describe 'error.response.refund_status' do
+      subject { error.response.refund_status }
+      it { should eq 'None' }
+    end
+  end
+
   context 'otherwise' do
     subject { error }
     let(:params) { 'Failure' }

data/spec/paypal/nvp/request_spec.rb

@@ -97,6 +97,17 @@ describe Paypal::NVP::Request do
       end
     end
 
+    context 'when API error response received from RefundTransaction' do
+      before { fake_response 'RefundTransaction/failure' }
+
+      it 'should handle all attributes while raising an API error' do
+        expect(Paypal.logger).not_to receive(:warn)
+        expect do
+          instance.request :Refund, TRANSACTIONID: 'already-refunded'
+        end.to raise_error(Paypal::Exception::APIError)
+      end
+    end
+
     context 'when got HTTP error response' do
       before do
         stub_request(:post, Paypal::NVP::Request::ENDPOINT[:production])

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ianfleeton-paypal-express
 version: !ruby/object:Gem::Version
-  version: 0.8.2
+  version: 0.8.3
 platform: ruby
 authors:
 - Ian Fleeton
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-04-19 00:00:00.000000000 Z
+date: 2017-04-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -51,20 +51,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.0'
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 0.0.5
+        version: '1.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.0'
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 0.0.5
+        version: '1.0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -211,6 +205,7 @@ files:
 - spec/fake_response/IPN/valid.txt
 - spec/fake_response/ManageRecurringPaymentsProfileStatus/failure.txt
 - spec/fake_response/ManageRecurringPaymentsProfileStatus/success.txt
+- spec/fake_response/RefundTransaction/failure.txt
 - spec/fake_response/RefundTransaction/full.txt
 - spec/fake_response/SetExpressCheckout/failure.txt
 - spec/fake_response/SetExpressCheckout/success.txt
@@ -290,6 +285,7 @@ test_files:
 - spec/fake_response/IPN/valid.txt
 - spec/fake_response/ManageRecurringPaymentsProfileStatus/failure.txt
 - spec/fake_response/ManageRecurringPaymentsProfileStatus/success.txt
+- spec/fake_response/RefundTransaction/failure.txt
 - spec/fake_response/RefundTransaction/full.txt
 - spec/fake_response/SetExpressCheckout/failure.txt
 - spec/fake_response/SetExpressCheckout/success.txt