i18n_alchemy 0.3.0 → 0.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 95fd92a5aea119177568029fbf20b3e2f309ee46e2c60950f176a59856846a53
-  data.tar.gz: 805c01033647ca546ee400f55c23e7a516d283095b5d55fc52f2d9a6946f018e
+  metadata.gz: c7ebc2bc7b34e395b62ef11905c03ab5103350a569c4bc4f5d4d429441c3af19
+  data.tar.gz: 2e1b00aa921aa7467a808a0984bf851f21d63d4e1e85a526d675d119c388d261
 SHA512:
-  metadata.gz: 9d72611c6332311f5d55438a42756620ffb2c44cd01fc77ef797022ea7500b5b84023a0791ef50ce9200eb06bebeecbfb2f765a5f65d0aec18b92d0190b2cabc
-  data.tar.gz: 3c97621b2c26f4f546e09d2d82d99f65a78149156dbea3c3bb17ac70664125ea90c958a95f63bb0c686f25300ecd60f4bce92544c1188a62428f479e93918945
+  metadata.gz: 521869a7aca148cc53a0fd64f05c7563d4065989cd0332c4ec5ec7a0ecbc36554b3acd085349385c76aebd78e701f3b07ebf76ade0682057a3faca0145420263
+  data.tar.gz: d673f02a4c9e275697021e7cb99d88829454d4fc1659c0c2369c6780ad8ac2ccb67bf2488a696df549a89539d31d84235e4cff17df0f7613711a86f5184446eb

data/CHANGELOG.md

@@ -1,3 +1,9 @@
+## v0.3.1 - 2020-02-11
+
+* Ruby 2.6 & 2.7 support (no changes required)
+* Rails 6 support ([@mayordwells](https://github.com/mayordwells))
+* Add support for `update`/`update!` Active Record methods ([@tbk303](https://github.com/tbk303))
+
 ## v0.3.0 - 2018-09-08
 
 * Update I18n dependency to require >= 0.7, allowing to install more recent versions ([@nazarhussain](https://github.com/nazarhussain))

data/lib/i18n_alchemy.rb

@@ -20,7 +20,7 @@ module I18n
 
     included do
       class_attribute :localized_methods,
-        :instance_reader => false, :instance_writer => false
+        instance_reader: false, instance_writer: false
       self.localized_methods = {}
     end
 

data/lib/i18n_alchemy/attributes_parsing.rb

@@ -17,6 +17,14 @@ module I18n
         @target.update_attributes!(parse_attributes(attributes))
       end
 
+      def update(attributes)
+        @target.update(parse_attributes(attributes))
+      end
+
+      def update!(attributes)
+        @target.update!(parse_attributes(attributes))
+      end
+
       def update_attribute(attribute, value)
         attributes = parse_attributes(attribute => value)
         @target.update_attribute(attribute, attributes.values.first)

data/lib/i18n_alchemy/date_parser.rb

@@ -28,7 +28,7 @@ module I18n
       end
 
       def i18n_format
-        I18n.t(:default, :scope => [i18n_scope, :formats])
+        I18n.t(:default, scope: [i18n_scope, :formats])
       end
 
       def i18n_scope

data/lib/i18n_alchemy/numeric_parser.rb

@@ -34,7 +34,7 @@ module I18n
       end
 
       def translate(key)
-        I18n.t(key, :scope => :"number.format")
+        I18n.t(key, scope: :"number.format")
       end
 
       def valid_for_localization?(value)

data/lib/i18n_alchemy/version.rb

@@ -1,5 +1,5 @@
 module I18n
   module Alchemy
-    VERSION = "0.3.0"
+    VERSION = "0.3.1"
   end
 end

data/test/action_view_test.rb

@@ -3,13 +3,13 @@ require "action_pack"
 
 class ActionViewTest < I18n::Alchemy::TestCase
   def setup
-    @template  = ActionView::Base.new
+    @template  = ActionView::Base.respond_to?(:empty) ? ActionView::Base.empty : ActionView::Base.new
     @product   = Product.new(
-      :name         => "Potato",
-      :quantity     => 10,
-      :price        => 1.99,
-      :released_at  => Date.new(2011, 2, 28),
-      :last_sale_at => Time.mktime(2011, 2, 28, 13, 25, 30)
+      name: "Potato",
+      quantity: 10,
+      price: 1.99,
+      released_at: Date.new(2011, 2, 28),
+      last_sale_at: Time.mktime(2011, 2, 28, 13, 25, 30)
     )
     @localized = @product.localized
 
@@ -48,7 +48,7 @@ class ActionViewTest < I18n::Alchemy::TestCase
     assert_includes [
       text_input_sorted_attributes(attribute, value),
       text_input_unsorted_attributes(attribute, value)
-    ], @template.text_field(:product, attribute, :object => @localized)
+    ], @template.text_field(:product, attribute, object: @localized)
   end
 
   def text_input_sorted_attributes(attribute_name, value)

data/test/custom_parsers/my_custom_date_parser.rb

@@ -3,12 +3,12 @@ module MyCustomDateParser
   extend self
 
   def localize(value)
-    I18n.localize value, :format => :custom
+    I18n.localize value, format: :custom
   end
 
   protected
 
   def i18n_format
-    I18n.t(:custom, :scope => [:date, :formats])
+    I18n.t(:custom, scope: [:date, :formats])
   end
 end

data/test/db/test_schema.rb

@@ -1,6 +1,6 @@
 ActiveRecord::Base.establish_connection(
-  :adapter  => "sqlite3",
-  :database => ":memory:"
+  adapter: "sqlite3",
+  database: ":memory:"
 )
 
 ActiveRecord::Schema.define do

data/test/i18n_alchemy/proxy/attributes_parsing_test.rb

@@ -4,7 +4,7 @@ class ProxyAttributesParsingTest < I18n::Alchemy::ProxyTestCase
   # Attributes
   def test_initializes_proxy_with_attributes
     @localized = @product.localized(
-      :name => "Banana", :price => "0,99", :released_at => "28/02/2011")
+      name: "Banana", price: "0,99", released_at: "28/02/2011")
 
     assert_equal 0.99, @product.price
     assert_equal "0,99", @localized.price
@@ -14,7 +14,7 @@ class ProxyAttributesParsingTest < I18n::Alchemy::ProxyTestCase
   end
 
   def test_assign_attributes
-    @localized.assign_attributes(:price => '1,99')
+    @localized.assign_attributes(price: '1,99')
     assert_equal "1,99", @localized.price
   end
 
@@ -31,7 +31,7 @@ class ProxyAttributesParsingTest < I18n::Alchemy::ProxyTestCase
   end
 
   def test_attributes_assignment
-    @localized.attributes = { :price => '1,99' }
+    @localized.attributes = { price: '1,99' }
     assert_equal "1,99", @localized.price
   end
 
@@ -41,30 +41,46 @@ class ProxyAttributesParsingTest < I18n::Alchemy::ProxyTestCase
     end
   end
 
-  def test_update_attributes
-    @localized.update_attributes(:price => '2,88')
+  def test_update
+    @localized.update(price: '2,88')
     assert_equal '2,88', @localized.price
     assert_equal 2.88, @product.reload.price
   end
 
-  def test_update_attributes_does_not_change_given_attributes_hash
+  def test_update_does_not_change_given_attributes_hash
     assert_attributes_hash_is_unchanged do |attributes|
-      @localized.update_attributes(attributes)
+      @localized.update(attributes)
     end
   end
 
-  def test_update_attributes!
-    @localized.update_attributes!(:price => '2,88')
+  def test_update_attributes
+    silence_deprecations {
+      @localized.update_attributes(price: '2,88')
+    }
+    assert_equal '2,88', @localized.price
+    assert_equal 2.88, @product.reload.price
+  end
+
+  def test_update!
+    @localized.update!(price: '2,88')
     assert_equal '2,88', @localized.price
     assert_equal 2.88, @product.reload.price
   end
 
-  def test_update_attributes_bang_does_not_change_given_attributes_hash
+  def test_update_bang_does_not_change_given_attributes_hash
     assert_attributes_hash_is_unchanged do |attributes|
-      @localized.update_attributes!(attributes)
+      @localized.update!(attributes)
     end
   end
 
+  def test_update_attributes!
+    silence_deprecations {
+      @localized.update_attributes!(price: '2,88')
+    }
+    assert_equal '2,88', @localized.price
+    assert_equal 2.88, @product.reload.price
+  end
+
   def test_update_attribute
     @localized.update_attribute(:price, '2,88')
     assert_equal '2,88', @localized.price
@@ -73,40 +89,40 @@ class ProxyAttributesParsingTest < I18n::Alchemy::ProxyTestCase
 
   # Nested Attributes
   def test_should_assign_for_nested_attributes_for_collection_association
-    @supplier_localized.assign_attributes(:products_attributes => [{:price => '1,99'}, {:price => '2,93'}])
+    @supplier_localized.assign_attributes(products_attributes: [{ price: '1,99' }, { price: '2,93' }])
     assert_equal 2, @supplier_localized.products.size
     assert_equal '1,99', @supplier_localized.products.first.localized.price
     assert_equal '2,93', @supplier_localized.products.last.localized.price
   end
 
   def test_should_assign_for_nested_attributes_passing_a_hash_for_collection_with_unique_keys
-    @supplier_localized.assign_attributes(:products_attributes => {"0" => {:price => '2,93', "_destroy"=>"false"}, "1" => {:price => '2,85', "_destroy" => "false"}})
+    @supplier_localized.assign_attributes(products_attributes: { '0' => { price: '2,93', _destroy: 'false' }, '1' => { price: '2,85', _destroy: 'false' }})
     prices = @supplier.products.map { |p| p.localized.price }.sort
     assert_equal ['2,85', '2,93'], prices
   end
 
   def test_should_assign_for_nested_attributes_for_one_to_one_association
-    @supplier_localized.assign_attributes(:account_attributes => {:account_number => 10, :total_money => '100,87'})
+    @supplier_localized.assign_attributes(account_attributes: { account_number: 10, total_money: '100,87' })
     account = @supplier_localized.account
     assert_equal '10', account.account_number.to_s
     assert_equal '100,87', account.localized.total_money
   end
 
-  def test_update_attributes_for_nested_attributes
-    @supplier_localized.update_attributes(:account_attributes => {:total_money => '99,87'})
+  def test_update_for_nested_attributes
+    @supplier_localized.update(account_attributes: { total_money: '99,87' })
     assert_equal '99,87', @supplier_localized.account.localized.total_money
   end
 
   def test_attributes_assignment_for_nested
-    @supplier_localized.attributes = {:account_attributes => {:total_money => '88,12'}}
+    @supplier_localized.attributes = { account_attributes: { total_money: '88,12' }}
     assert_equal '88,12', @supplier_localized.account.localized.total_money
   end
 
   private
 
   def assert_attributes_hash_is_unchanged
-    attributes = { :quantity => 1 }
+    attributes = { quantity: 1 }
     yield attributes
-    assert_equal({ :quantity => 1 }, attributes)
+    assert_equal({ quantity: 1 }, attributes)
   end
 end

data/test/i18n_alchemy/proxy_test.rb

@@ -3,7 +3,7 @@ require "test_helper"
 class ProxyTest < I18n::Alchemy::ProxyTestCase
   def test_delegates_orm_methods_to_target_object
     assert @product.new_record?
-    assert @localized.save!(:name => "foo", :price => 1.99)
+    assert @localized.save!(name: "foo", price: 1.99)
     assert !@product.new_record?
   end
 

data/test/models/product.rb

@@ -1,9 +1,9 @@
 class Product < ActiveRecord::Base
   include I18n::Alchemy
-  localize :total, :using => :number
-  localize :estimated_delivery_at, :using => :date
-  localize :estimated_last_comission_payment_at, :using => :timestamp
-  localize :released_month, :using => MyCustomDateParser
+  localize :total, using: :number
+  localize :estimated_delivery_at, using: :date
+  localize :estimated_last_comission_payment_at, using: :timestamp
+  localize :released_month, using: MyCustomDateParser
 
   belongs_to :supplier
 

data/test/models/supplier.rb

@@ -9,5 +9,5 @@ class Supplier < ActiveRecord::Base
 end
 
 class AnotherSupplier < Supplier
-  localize :created_at, :using => :timestamp
+  localize :created_at, using: :timestamp
 end

data/test/models/user.rb

@@ -2,5 +2,5 @@ class User
   include I18n::Alchemy
   attr_accessor :created_at
 
-  localize :created_at, :using => :date
+  localize :created_at, using: :date
 end

data/test/test_helper.rb

@@ -49,5 +49,15 @@ module I18n::Alchemy
     def teardown
       I18n.locale = :en
     end
+
+    private
+
+    def silence_deprecations
+      old_silenced = ActiveSupport::Deprecation.silenced
+      ActiveSupport::Deprecation.silenced = true
+      yield
+    ensure
+      ActiveSupport::Deprecation.silenced = old_silenced
+    end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: i18n_alchemy
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.3.1
 platform: ruby
 authors:
 - Carlos Antonio da Silva
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-09-08 00:00:00.000000000 Z
+date: 2020-02-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -19,7 +19,7 @@ dependencies:
         version: 4.0.0
     - - "<"
       - !ruby/object:Gem::Version
-        version: 5.3.0
+        version: '6.1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -29,7 +29,7 @@ dependencies:
         version: 4.0.0
     - - "<"
       - !ruby/object:Gem::Version
-        version: 5.3.0
+        version: '6.1'
 - !ruby/object:Gem::Dependency
   name: i18n
   requirement: !ruby/object:Gem::Requirement
@@ -53,7 +53,7 @@ dependencies:
         version: 4.0.0
     - - "<"
       - !ruby/object:Gem::Version
-        version: 5.3.0
+        version: '6.1'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -63,7 +63,7 @@ dependencies:
         version: 4.0.0
     - - "<"
       - !ruby/object:Gem::Version
-        version: 5.3.0
+        version: '6.1'
 - !ruby/object:Gem::Dependency
   name: activerecord
   requirement: !ruby/object:Gem::Requirement
@@ -73,7 +73,7 @@ dependencies:
         version: 4.0.0
     - - "<"
       - !ruby/object:Gem::Version
-        version: 5.3.0
+        version: '6.1'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -83,7 +83,7 @@ dependencies:
         version: 4.0.0
     - - "<"
       - !ruby/object:Gem::Version
-        version: 5.3.0
+        version: '6.1'
 - !ruby/object:Gem::Dependency
   name: minitest
   requirement: !ruby/object:Gem::Requirement
@@ -102,14 +102,14 @@ dependencies:
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '10.1'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '10.1'
 description: I18n date/number parsing/localization
@@ -167,8 +167,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: i18n_alchemy
-rubygems_version: 2.7.6
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: I18n date/number parsing/localization