i18n-spec 0.2.4 → 0.3.0

data/README.md

@@ -11,9 +11,11 @@ There are a few matchers available; the subject of the spec is always a path to
     describe "config/locales/en.yml" do
       it { should be_parseable }
       it { should have_valid_pluralization_keys }
+      it { should_not have_missing_pluralization_keys }
       it { should have_one_top_level_namespace }
       it { should be_named_like_top_level_namespace }
       it { should_not have_legacy_interpolations }
+      it { should have_a_valid_locale }
     end
 
 All of these tests can be ran in one line with a shared example :
@@ -69,4 +71,4 @@ You can check a locale file with the following taks :
 
 or again, check a whole directory :
 
-	rake i18n-spec:completeness SOURCE_FILEPATH DIRECTORY
+	rake i18n-spec:completeness SOURCE_FILEPATH DIRECTORY

data/VERSION

@@ -1 +1 @@
-0.2.4
+0.3.0

data/i18n-spec.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = %q{i18n-spec}
-  s.version = "0.2.4"
+  s.version = "0.3.0"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = [%q{Christopher Dell}]
-  s.date = %q{2012-09-15}
+  s.date = %q{2012-09-16}
   s.description = %q{Includes a number of rspec matchers to make specing your locale files easy peasy.}
   s.email = %q{chris@tigrish.com}
   s.extra_rdoc_files = [
@@ -34,6 +34,7 @@ Gem::Specification.new do |s|
     "lib/i18n-spec/matchers/be_parseable_matcher.rb",
     "lib/i18n-spec/matchers/have_a_valid_locale_matcher.rb",
     "lib/i18n-spec/matchers/have_legacy_interpolations.rb",
+    "lib/i18n-spec/matchers/have_missing_pluralization_keys_matcher.rb",
     "lib/i18n-spec/matchers/have_one_top_level_namespace_matcher.rb",
     "lib/i18n-spec/matchers/have_valid_pluralization_keys_matcher.rb",
     "lib/i18n-spec/models/locale_file.rb",
@@ -45,6 +46,7 @@ Gem::Specification.new do |s|
     "spec/fixtures/invalid_locale.yml",
     "spec/fixtures/invalid_pluralization_keys.yml",
     "spec/fixtures/legacy_interpolations.yml",
+    "spec/fixtures/missing_pluralization_keys.yml",
     "spec/fixtures/multiple_top_levels.yml",
     "spec/fixtures/not_subset.yml",
     "spec/fixtures/unparseable.yml",

data/lib/i18n-spec/matchers/have_a_valid_locale_matcher.rb

@@ -1,6 +1,6 @@
 RSpec::Matchers.define :have_a_valid_locale do
   match do |actual|
     locale_file = I18nSpec::LocaleFile.new(actual)
-    locale_file.has_a_valid_locale?
+    locale_file.locale.valid?
   end
 end

data/lib/i18n-spec/matchers/have_missing_pluralization_keys_matcher.rb

@@ -0,0 +1,18 @@
+RSpec::Matchers.define :have_missing_pluralization_keys do
+  match do |actual|
+    @locale_file = I18nSpec::LocaleFile.new(actual)
+    @locale_file.missing_pluralization_keys.any?
+  end
+
+  failure_message_for_should_not do |filepath|
+    flattened_keys = []
+
+    @locale_file.errors[:missing_pluralization_keys].each do |parent, subkeys|
+      subkeys.each do |subkey|
+        flattened_keys << [parent, subkey].join('.')
+      end
+    end
+
+    "expected #{filepath} to contain the following pluralization keys :\n- " << flattened_keys.join("\n- ")
+  end
+end

data/lib/i18n-spec/models/locale_file.rb

@@ -22,6 +22,14 @@ module I18nSpec
       @flattened_translations ||= flatten_tree(translations.values.first)
     end
 
+    def locale
+      @locale ||= ISO::Tag.new(locale_code)
+    end
+
+    def locale_code
+      translations.keys.first
+    end
+
     def pluralizations
       result = flatten_tree(translations).select do |key, value|
         value.is_a?(Hash)
@@ -45,6 +53,17 @@ module I18nSpec
       invalid
     end
 
+    def missing_pluralization_keys
+      return_data = {}
+      rule_names = locale.language.plural_rule_names
+      pluralizations.each do |parent, pluralization|
+        missing_keys = rule_names - pluralization.keys
+        return_data[parent] = missing_keys if missing_keys.any?
+      end
+      @errors[:missing_pluralization_keys] = return_data if return_data.any?
+      return_data
+    end
+
     def is_parseable?
       begin
         yaml_load_content
@@ -63,11 +82,7 @@ module I18nSpec
     end
 
     def is_named_like_top_level_namespace?
-      translations.keys.first == File.basename(@filepath, File.extname(@filepath))
-    end
-
-    def has_a_valid_locale?
-      ISO::Tag.new(translations.keys.first).valid?
+      locale_code == File.basename(@filepath, File.extname(@filepath))
     end
 
   protected

data/lib/i18n-spec/shared_examples/valid_locale_file.rb

@@ -2,6 +2,7 @@ shared_examples_for "a valid locale file" do |locale_file|
   describe locale_file do
     it { should be_parseable }
     it { should have_valid_pluralization_keys }
+    it { should_not have_missing_pluralization_keys }
     it { should have_one_top_level_namespace }
     it { should be_named_like_top_level_namespace }
     it { should_not have_legacy_interpolations }

data/spec/fixtures/missing_pluralization_keys.yml

@@ -0,0 +1,4 @@
+ru:
+  cats:
+    one: 'a cat'
+    other: '%{count} cats'

data/spec/lib/i18n-spec/matchers_spec.rb

@@ -12,6 +12,7 @@ describe "Invalid files" do
   it { 'spec/fixtures/legacy_interpolations.yml'.should have_legacy_interpolations }
   it { 'spec/fixtures/invalid_locale.yml'.should_not have_a_valid_locale }
   it { 'spec/fixtures/not_subset.yml'.should_not be_a_subset_of 'spec/fixtures/en.yml' }
+  it { 'spec/fixtures/missing_pluralization_keys.yml'.should have_missing_pluralization_keys }
 end
 
 describe "Translated files" do

data/spec/lib/i18n-spec/models/locale_file_spec.rb

@@ -11,9 +11,25 @@ end
 describe I18nSpec::LocaleFile do
   include LocaleFileHelper
 
+  describe "#locale_code" do
+    it "returns the first key of the file" do
+      locale_file = locale_file_with_content("pt-BR:\n  hello: world")
+      locale_file.locale_code.should == 'pt-BR'
+    end
+  end
+
+  describe "#locale" do
+    it "returns an ISO::Tag based on the locale_code" do
+      locale_file = locale_file_with_content("pt-BR:\n  hello: world")
+      locale_file.locale.should be_a(ISO::Tag)
+      locale_file.locale.language.code.should == 'pt'
+      locale_file.locale.region.code.should   == 'BR'
+    end
+  end
+
   describe "#is_parseable?" do
     context "when YAML is parseable" do
-      let(:locale_file) { locale_file = locale_file_with_content("en:\n  hello: world") }
+      let(:locale_file) { locale_file_with_content("en:\n  hello: world") }
 
       it "returns true" do
         locale_file.is_parseable?.should == true
@@ -88,4 +104,70 @@ describe I18nSpec::LocaleFile do
       locale_file.invalid_pluralization_keys.should_not be_include 'en.birds'
     end
   end
+
+  describe "#missing_pluralization_keys" do
+    it "returns the parents that containts missing pluralizations in with the english rules" do
+      content = "en:
+        cats:
+          one: one
+        dogs:
+          other: other
+        birds:
+          one: one
+          other: other"
+      locale_file = locale_file_with_content(content)
+      locale_file.missing_pluralization_keys.should == {
+        'en.cats' => %w(other),
+        'en.dogs' => %w(one)
+      }
+      locale_file.errors[:missing_pluralization_keys].should_not be_nil
+    end
+
+    it "returns the parents that containts missing pluralizations in with the russian rules" do
+      content = "ru:
+        cats:
+          one: one
+          few: few
+          many: many
+          other: other
+        dogs:
+          one: one
+          other: some
+        birds:
+          zero: zero
+          one: one
+          few: few
+          other: other"
+      locale_file = locale_file_with_content(content)
+      locale_file.missing_pluralization_keys.should == {
+        'ru.dogs'  => %w(few many),
+        'ru.birds' => %w(many)
+      }
+      locale_file.errors[:missing_pluralization_keys].should_not be_nil
+    end
+
+    it "returns the parents that containts missing pluralizations in with the japanese rules" do
+      content = "ja:
+        cats:
+          one: one
+        dogs:
+          other: some
+        birds: not really a pluralization"
+      locale_file = locale_file_with_content(content)
+      locale_file.missing_pluralization_keys.should == { 'ja.cats' => %w(other) }
+      locale_file.errors[:missing_pluralization_keys].should_not be_nil
+    end
+
+    it "returns an empty hash when all pluralizations are complete" do
+      content = "ja:
+        cats:
+          other: one
+        dogs:
+          other: some
+        birds: not really a pluralization"
+      locale_file = locale_file_with_content(content)
+      locale_file.missing_pluralization_keys.should == {}
+      locale_file.errors[:missing_pluralization_keys].should be_nil
+    end
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: i18n-spec
 version: !ruby/object:Gem::Version
-  version: 0.2.4
+  version: 0.3.0
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-09-15 00:00:00.000000000 Z
+date: 2012-09-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: iso
-  requirement: &70351792105000 !ruby/object:Gem::Requirement
+  requirement: &70263477376200 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,10 +21,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *70351792105000
+  version_requirements: *70263477376200
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &70351792104180 !ruby/object:Gem::Requirement
+  requirement: &70263477996860 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -32,10 +32,10 @@ dependencies:
         version: 2.4.0
   type: :development
   prerelease: false
-  version_requirements: *70351792104180
+  version_requirements: *70263477996860
 - !ruby/object:Gem::Dependency
   name: bundler
-  requirement: &70351792103440 !ruby/object:Gem::Requirement
+  requirement: &70263477996380 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -43,10 +43,10 @@ dependencies:
         version: 1.1.3
   type: :development
   prerelease: false
-  version_requirements: *70351792103440
+  version_requirements: *70263477996380
 - !ruby/object:Gem::Dependency
   name: jeweler
-  requirement: &70351792065180 !ruby/object:Gem::Requirement
+  requirement: &70263477995900 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -54,10 +54,10 @@ dependencies:
         version: 1.6.4
   type: :development
   prerelease: false
-  version_requirements: *70351792065180
+  version_requirements: *70263477995900
 - !ruby/object:Gem::Dependency
   name: rdoc
-  requirement: &70351792063300 !ruby/object:Gem::Requirement
+  requirement: &70263477995420 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -65,7 +65,7 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70351792063300
+  version_requirements: *70263477995420
 description: Includes a number of rspec matchers to make specing your locale files
   easy peasy.
 email: chris@tigrish.com
@@ -92,6 +92,7 @@ files:
 - lib/i18n-spec/matchers/be_parseable_matcher.rb
 - lib/i18n-spec/matchers/have_a_valid_locale_matcher.rb
 - lib/i18n-spec/matchers/have_legacy_interpolations.rb
+- lib/i18n-spec/matchers/have_missing_pluralization_keys_matcher.rb
 - lib/i18n-spec/matchers/have_one_top_level_namespace_matcher.rb
 - lib/i18n-spec/matchers/have_valid_pluralization_keys_matcher.rb
 - lib/i18n-spec/models/locale_file.rb
@@ -103,6 +104,7 @@ files:
 - spec/fixtures/invalid_locale.yml
 - spec/fixtures/invalid_pluralization_keys.yml
 - spec/fixtures/legacy_interpolations.yml
+- spec/fixtures/missing_pluralization_keys.yml
 - spec/fixtures/multiple_top_levels.yml
 - spec/fixtures/not_subset.yml
 - spec/fixtures/unparseable.yml
@@ -124,7 +126,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 230826068479786801
+      hash: 3033916515147713516
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements: